Re: [cmake-developers] Topic "add-opencl-imported-target" good to merge?
Thanks! Cheers, Matthäus Am 02.06.2016 um 15:44 schrieb Brad King: > On 06/01/2016 03:00 PM, Matthäus G. Chajdas wrote: >> done - I had to squash and force push once more, because I used the >> wrong author in the first commit. >> >> Everything is now in one commit here: >> https://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=e95b62110715c06fb76b57fdfb13ea493a94c0c4 >> >> Thanks for the timely feedback! > > I renamed the topic to 'FindOpenCL-imported-target', added some minor > tweaks, and merged to 'next' for testing: > > FindOpenCL: Add an imported target > https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b66d4739 > > If any fixes are needed please extend the topic and merge to 'next' > again. > > Thanks, > -Brad > -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Topic "add-opencl-imported-target" good to merge?
On 06/01/2016 03:00 PM, Matthäus G. Chajdas wrote: > done - I had to squash and force push once more, because I used the > wrong author in the first commit. > > Everything is now in one commit here: > https://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=e95b62110715c06fb76b57fdfb13ea493a94c0c4 > > Thanks for the timely feedback! I renamed the topic to 'FindOpenCL-imported-target', added some minor tweaks, and merged to 'next' for testing: FindOpenCL: Add an imported target https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=b66d4739 If any fixes are needed please extend the topic and merge to 'next' again. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Topic "add-opencl-imported-target" good to merge?
Hi Brad, done - I had to squash and force push once more, because I used the wrong author in the first commit. Everything is now in one commit here: https://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=e95b62110715c06fb76b57fdfb13ea493a94c0c4 Thanks for the timely feedback! Cheers, Matthäus Am 01.06.2016 um 20:22 schrieb Brad King: > On 06/01/2016 02:15 PM, Matthäus G. Chajdas wrote: >> Hopefully done > > The revised history looks good. The change itself looks good. > > Please also add a `Help/release/dev/FindOpenCL-imported-target.rst` > file with a release note for the feature. Look at other files > in that directory for a sample. See Help/release/*.rst for other > examples. > > As part of the modernization of find modules we're also trying > to add better testing for them. Please see Tests/FindPNG and the > CMake_TEST_FindPNG code path in Tests/CMakeLists.txt and construct > a similar test for the FindOpenCL module. > > Thanks, > -Brad > -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Topic "add-opencl-imported-target" good to merge?
On 06/01/2016 02:15 PM, Matthäus G. Chajdas wrote: > Hopefully done The revised history looks good. The change itself looks good. Please also add a `Help/release/dev/FindOpenCL-imported-target.rst` file with a release note for the feature. Look at other files in that directory for a sample. See Help/release/*.rst for other examples. As part of the modernization of find modules we're also trying to add better testing for them. Please see Tests/FindPNG and the CMake_TEST_FindPNG code path in Tests/CMakeLists.txt and construct a similar test for the FindOpenCL module. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Topic "add-opencl-imported-target" good to merge?
Hopefully done - I'm not the biggest git expert but the history looks like I'd expect it to look like :) Cheers, Matthäus Am 01.06.2016 um 19:57 schrieb Brad King: > On 06/01/2016 01:53 PM, Matthäus G. Chajdas wrote: >> updated to latest master and pushed again (I merged latest master into >> this - is that fine or does it have to be a rebase? In that case I'll redo.) > > Please rebase and force push. > > Thanks, > -Brad > -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Topic "add-opencl-imported-target" good to merge?
On 06/01/2016 01:53 PM, Matthäus G. Chajdas wrote: > updated to latest master and pushed again (I merged latest master into > this - is that fine or does it have to be a rebase? In that case I'll redo.) Please rebase and force push. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Topic "add-opencl-imported-target" good to merge?
Hi Brad, updated to latest master and pushed again (I merged latest master into this - is that fine or does it have to be a rebase? In that case I'll redo.) Cheers, Matthäus Am 01.06.2016 um 17:18 schrieb Brad King: > On 05/31/2016 03:17 PM, Matthäus G. Chajdas wrote: >> I've just pushed "add-opencl-imported-target" which adds an imported >> target to FindOpenCL. The whole change is rather small: >> >> https://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=6c53137a19e482140db3dc97b626af38348f2c71 >> >> Good to merge this to next for testing? > > Please rebase on 'master' now that post-3.6 development is open. > > Thanks, > -Brad > -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
Re: [cmake-developers] Topic "add-opencl-imported-target" good to merge?
On 05/31/2016 03:17 PM, Matthäus G. Chajdas wrote: > I've just pushed "add-opencl-imported-target" which adds an imported > target to FindOpenCL. The whole change is rather small: > > https://cmake.org/gitweb?p=stage/cmake.git;a=commitdiff;h=6c53137a19e482140db3dc97b626af38348f2c71 > > Good to merge this to next for testing? Please rebase on 'master' now that post-3.6 development is open. Thanks, -Brad -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
