Re: [Cocci] bugon.cocci: fix Options at the macro

2014-11-24 Thread Michal Marek
Dne 21.11.2014 v 19:07 Wolfram Sang napsal(a):
> On Fri, Nov 07, 2014 at 06:51:05PM +0100, Wolfram Sang wrote:
>> On Tue, Oct 28, 2014 at 03:18:24PM -0200, Mauro Carvalho Chehab wrote:
>>> The comma after --no-includes makes coccinelle to not run the script:
>>>
>>> /usr/bin/spatch -D report --very-quiet --no-show-diff --cocci-file 
>>> ./scripts/coccinelle/misc/bugon.cocci --no-includes, --include-headers 
>>> --patch . --dir drivers/media/platform/coda/ -I ./arch/x86/include -I 
>>> arch/x86/include/generated -I include -I ./arch/x86/include/uapi -I 
>>> arch/x86/include/generated/uapi -I ./include/uapi -I include/generated/uapi 
>>> -I ./include/linux/kconfig.h
>>> Usage: spatch.opt --sp-file   [-o ] [--iso-file ] 
>>> [options]
>>> Options are:
>>>   --sp-file the semantic patch file
>>>   -othe output file
>>>   --in-place   do the modification on the file directly
>>>   --backup-suffix  suffix to use when making a backup for 
>>> inplace
>>> ...
>>>
>>> At least with Fedora 20 coccinelle package:
>>> coccinelle-1.0.0-0.rc20.1.fc21.x86_64
>>>
>>> Signed-off-by: Mauro Carvalho Chehab 
>>
>> Yay, with this my patch handling scripts finally work again as they used
>> to! Please let it go into 3.18.
>>
>> Tested-by: Wolfram Sang 
> 
> Ping.

Sorry for the delay. Applied now to kbuild.git#misc.

Michal

___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci


Re: [Cocci] kernel-audit: Deletion of an unnecessary check before the function call "audit_log_end"

2014-11-24 Thread Dan Carpenter
On Sun, Nov 23, 2014 at 02:24:32PM +0100, SF Markus Elfring wrote:
> > Program analysis tools can also potentially exploit this information,
> 
> The published semantic patch scripts correspond to this desire.
> 

Sorry for that.

I have deleted the Smatch check for this so it no longer warns about:

if (foo)
kfree(foo);

regards,
dan carpenter

___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci