Re: [Cocci] [PATCH v4 0/6] x86: document and address MTRR corner cases

2015-06-03 Thread Luis R. Rodriguez 
On Wed, Apr 29, 2015 at 2:44 PM, Luis R. Rodriguez
 wrote:
> From: "Luis R. Rodriguez" 
>
> This series addresses one commend fix on the table for mtrr_add()
> effect on the PAT case when UC- is used. Other than that it is
> the same as v4.
>
> Luis R. Rodriguez (6):
>   x86: add ioremap_uc() - force strong UC, PCD=1, PWT=1
>   x86: document WC MTRR effects on PAT / non-PAT pages
>   video: fbdev: atyfb: move framebuffer length fudging to helper
>   video: fbdev: atyfb: clarify ioremap() base and length used
>   video: fbdev: atyfb: replace MTRR UC hole with strong UC
>   video: fbdev: atyfb: use arch_phys_wc_add() and ioremap_wc()

Ville,

the x86 patches are in and on their way to the next version of Linux.
Can I trouble you for your review of the atyfb driver changes?

 Luis
___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] [PATCH v4] Added tables i2c_device_id and platform_device_id for checking. Extend checking on tables containing structures which are initialized without specifying member name.

2015-06-03 Thread Julia Lawall 


On Tue, 2 Jun 2015, Daniel Granat wrote:

> Signed-off-by: Daniel Granat 
> ---
>  scripts/coccinelle/misc/of_table.cocci | 34 
> +-
>  1 file changed, 29 insertions(+), 5 deletions(-)
>
> diff --git a/scripts/coccinelle/misc/of_table.cocci 
> b/scripts/coccinelle/misc/of_table.cocci
> index 3c93404..bc3c944 100644
> --- a/scripts/coccinelle/misc/of_table.cocci
> +++ b/scripts/coccinelle/misc/of_table.cocci
> @@ -1,6 +1,6 @@
> -/// Make sure of_device_id tables are NULL terminated
> +/// Make sure (of_device_id | i2c_device_id | platform_device_id) tables are 
> NULL terminated

It would be nice for the comment to be limited to 80 characters.

>  //
> -// Keywords: of_table
> +// Keywords: of_table i2c_table platform_table
>  // Confidence: Medium
>  // Options: --include-headers
>
> @@ -13,18 +13,27 @@ virtual report
>  identifier var, arr;
>  expression E;
>  @@
> -struct of_device_id arr[] = {
> +(
> +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
>   ...,
>   {
>   .var = E,
>  *}
>  };
> +|
> +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
> + ...,
> + { ..., E, ... },
> +*{ },

This should be:

struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
...,
*   { ..., E, ... },
};

With that you get four results for the context case, like for the others.

The rest looks OK.

julia

> +};
> +)
>
>  @depends on patch@
>  identifier var, arr;
>  expression E;
>  @@
> -struct of_device_id arr[] = {
> +(
> +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
>   ...,
>   {
>   .var = E,
> @@ -32,19 +41,34 @@ struct of_device_id arr[] = {
>  +},
>  +{ }
>  };
> +|
> +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
> + ...,
> + { ..., E, ... },
> ++{ },
> +};
> +)
>
>  @r depends on org || report@
>  position p1;
>  identifier var, arr;
>  expression E;
>  @@
> -struct of_device_id arr[] = {
> +(
> +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
>   ...,
>   {
>   .var = E,
>   }
>   @p1
>  };
> +|
> +struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
> + ...,
> + { ..., E, ... }
> + @p1
> +};
> +)
>
>  @script:python depends on org@
>  p1 << r.p1;
> --
> 1.9.1
>
>
___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] [PATCH] coccinelle: simple_return: Add a blank line

2015-06-03 Thread Michal Marek 
On Tue, Jun 02, 2015 at 07:18:07AM +0200, Julia Lawall wrote:
> On Mon, 1 Jun 2015, Fabio Estevam wrote:
> 
> > From: Fabio Estevam 
> > 
> > Insert a blank line in order to improve the readability of the
> > generated patch and also make it consistent with the other
> > .cocci files.
> 
> Acked-by: Julia Lawall 

Applied to kbuild.git#misc.

Michal
___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

[Cocci] [PATCH v4] Added tables i2c_device_id and platform_device_id for

2015-06-03 Thread Daniel Granat 
Thank you for advices. I submit new patch with changes you suggested but I 
don't know why in "context" rule I get only two results instead of four.
___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

[Cocci] [PATCH v4] Added tables i2c_device_id and platform_device_id for checking. Extend checking on tables containing structures which are initialized without specifying member name.

2015-06-03 Thread Daniel Granat 
Signed-off-by: Daniel Granat 
---
 scripts/coccinelle/misc/of_table.cocci | 34 +-
 1 file changed, 29 insertions(+), 5 deletions(-)

diff --git a/scripts/coccinelle/misc/of_table.cocci 
b/scripts/coccinelle/misc/of_table.cocci
index 3c93404..bc3c944 100644
--- a/scripts/coccinelle/misc/of_table.cocci
+++ b/scripts/coccinelle/misc/of_table.cocci
@@ -1,6 +1,6 @@
-/// Make sure of_device_id tables are NULL terminated
+/// Make sure (of_device_id | i2c_device_id | platform_device_id) tables are 
NULL terminated
 //
-// Keywords: of_table
+// Keywords: of_table i2c_table platform_table
 // Confidence: Medium
 // Options: --include-headers
 
@@ -13,18 +13,27 @@ virtual report
 identifier var, arr;
 expression E;
 @@
-struct of_device_id arr[] = {
+(
+struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
...,
{
.var = E,
 *  }
 };
+|
+struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
+   ...,
+   { ..., E, ... },
+*  { }, 
+};
+)
 
 @depends on patch@
 identifier var, arr;
 expression E;
 @@
-struct of_device_id arr[] = {
+(
+struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
...,
{
.var = E,
@@ -32,19 +41,34 @@ struct of_device_id arr[] = {
 +  },
 +  { }
 };
+|
+struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
+   ...,
+   { ..., E, ... },
++  { },
+};
+)
 
 @r depends on org || report@
 position p1;
 identifier var, arr;
 expression E;
 @@
-struct of_device_id arr[] = {
+(
+struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
...,
{
.var = E,
}
@p1
 };
+|
+struct \(of_device_id \| i2c_device_id \| platform_device_id\) arr[] = {
+   ...,
+   { ..., E, ... }
+   @p1
+};
+)
 
 @script:python depends on org@
 p1 << r.p1;
-- 
1.9.1

___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci