Re: [Cocci] make install broken
The makefile issues are perhaps now resolved. julia On Tue, 3 Oct 2017, Michael Stefaniuc wrote: > Hello, > > while my Makefile patch lets make install finish a lot of stuff is missing: > spatch foo.cocci foo.c > warning: Can't find macro file: ./../lib/coccinelle/standard.h > warning: Can't find default iso file: ./../lib/coccinelle/standard.iso > Python error: No module named 'coccilib' > > Only this stuff gets installed: > find /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/ > /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/ > /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/bin > /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/bin/spatch > /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/bin/spgen > /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/lib > /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/lib/coccinelle > /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/lib/coccinelle/dllpyml_stubs.so > /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/etc > /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/etc/bash_completion.d > /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/etc/bash_completion.d/spatch > > > bye > michael > ___ > Cocci mailing list > Cocci@systeme.lip6.fr > https://systeme.lip6.fr/mailman/listinfo/cocci > ___ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
Re: [Cocci] make install broken
> The makefile issues are perhaps now resolved. How much did you check it? A few implementation details were improved. Thanks for your software corrections so far. I find that there are several aspects left over for further considerations. Examples: 1. How would you like to fix dependencies like the following? elfring@Sonne:~/Projekte/Linux/next-patched> /usr/local/bin/spatch --timeout 23 ~/Projekte/Coccinelle/janitor/safer_size_determination2.cocci -dir arch/powerpc/platforms/powermac warning: Can't find macro file: /usr/local/bin/../lib/coccinelle/standard.h warning: Can't find default iso file: /usr/local/bin/../lib/coccinelle/standard.iso … 2. Should specific commands be kept as mandatory? https://www.gnu.org/software/make/manual/html_node/Errors.html https://github.com/coccinelle/coccinelle/commit/08b0344695e27c021af1df847337bd0216f92510#diff-b67911656ef5d18c4ae36cb6741b7965R318 3. How do you think about to include additional build rules into the main make script? https://github.com/coccinelle/coccinelle/issues/110 4. Do you care for progress around the tool “automake”? https://github.com/coccinelle/coccinelle/issues/41 Regards, Markus ___ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
Re: [Cocci] [PATCH] coccinelle: api: detect duplicate chip data arrays
2017-10-01 21:42 GMT+09:00 Julia Lawall : > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA > within a single structure. It is currently specific to the file > drivers/power/supply/bq27xxx_battery.c. > > Signed-off-by: Julia Lawall > > --- Applied to linux-kbuild/misc. Thanks. -- Best Regards Masahiro Yamada ___ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
Re: [Cocci] make install broken
> 3. How do you think about to include additional build rules into >the main make script? >https://github.com/coccinelle/coccinelle/issues/110 What build rules are you asking for? I can't understand the relation between your question and the link, which is about dependencies. The comment in the link is furthermore entirely out of date, since the approach to dependencies has been completely reimplemented. julia ___ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
Re: [Cocci] make install broken
On 10/06/2017 04:04 PM, Julia Lawall wrote: > The makefile issues are perhaps now resolved. Looks better as the missing stuff is installed. But it isn't working when I have a symlink to spatch. My workflow: VERSION=`git describe` ./configure --prefix=/usr/local/packages/coccinelle-$VERSION make make install cd /usr/local/bin ln -sf ../packages/coccinelle-$VERSION/bin/* . spatch foo.cocci foo.c warning: Can't find macro file: ./../lib/coccinelle/standard.h init_defs: ./macros warning: Can't find default iso file: ./../lib/coccinelle/standard.iso Python error: No module named 'coccilib' Using an absolute symbolic link doesn't works either. Using an absolute PATH to spatch makes it work: /usr/local/packages/coccinelle-1.0.6-328-g3ba77b3/bin/spatch foo.cocci foo.c coccinelle-1.0.6-179-g058cb06 is the last version that I have compiled and works with the symlinks. No clue is there is something similar in OCaml but under perl there is the handy FindBin module (FindBin::RealBin) to find the real location of the binary. bye michael > > julia > > On Tue, 3 Oct 2017, Michael Stefaniuc wrote: > >> Hello, >> >> while my Makefile patch lets make install finish a lot of stuff is missing: >> spatch foo.cocci foo.c >> warning: Can't find macro file: ./../lib/coccinelle/standard.h >> warning: Can't find default iso file: ./../lib/coccinelle/standard.iso >> Python error: No module named 'coccilib' >> >> Only this stuff gets installed: >> find /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/ >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/ >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/bin >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/bin/spatch >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/bin/spgen >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/lib >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/lib/coccinelle >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/lib/coccinelle/dllpyml_stubs.so >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/etc >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/etc/bash_completion.d >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/etc/bash_completion.d/spatch >> >> >> bye >> michael >> ___ >> Cocci mailing list >> Cocci@systeme.lip6.fr >> https://systeme.lip6.fr/mailman/listinfo/cocci >> ___ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
Re: [Cocci] make install broken
On Fri, 6 Oct 2017, Michael Stefaniuc wrote: > On 10/06/2017 04:04 PM, Julia Lawall wrote: > > The makefile issues are perhaps now resolved. > Looks better as the missing stuff is installed. > But it isn't working when I have a symlink to spatch. > > My workflow: > > VERSION=`git describe` > ./configure --prefix=/usr/local/packages/coccinelle-$VERSION > make > make install > cd /usr/local/bin > ln -sf ../packages/coccinelle-$VERSION/bin/* . > > spatch foo.cocci foo.c > warning: Can't find macro file: ./../lib/coccinelle/standard.h > init_defs: ./macros > warning: Can't find default iso file: ./../lib/coccinelle/standard.iso > Python error: No module named 'coccilib' > > Using an absolute symbolic link doesn't works either. > Using an absolute PATH to spatch makes it work: > /usr/local/packages/coccinelle-1.0.6-328-g3ba77b3/bin/spatch foo.cocci foo.c > > coccinelle-1.0.6-179-g058cb06 is the last version that I have compiled > and works with the symlinks. > > No clue is there is something similar in OCaml but under perl there is > the handy FindBin module (FindBin::RealBin) to find the real location of > the binary. Thanks for the feedback. We will try to resolve it as soon as possible. julia > > bye > michael > > > > > julia > > > > On Tue, 3 Oct 2017, Michael Stefaniuc wrote: > > > >> Hello, > >> > >> while my Makefile patch lets make install finish a lot of stuff is missing: > >> spatch foo.cocci foo.c > >> warning: Can't find macro file: ./../lib/coccinelle/standard.h > >> warning: Can't find default iso file: ./../lib/coccinelle/standard.iso > >> Python error: No module named 'coccilib' > >> > >> Only this stuff gets installed: > >> find /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/ > >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/ > >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/bin > >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/bin/spatch > >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/bin/spgen > >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/lib > >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/lib/coccinelle > >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/lib/coccinelle/dllpyml_stubs.so > >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/etc > >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/etc/bash_completion.d > >> /usr/local/packages/coccinelle-1.0.6-318-g0bf5304/etc/bash_completion.d/spatch > >> > >> > >> bye > >> michael > >> ___ > >> Cocci mailing list > >> Cocci@systeme.lip6.fr > >> https://systeme.lip6.fr/mailman/listinfo/cocci > >> > > ___ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
