Re: [Cocci] [06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType

2020-03-17 Thread Markus Elfring
>> I got special views also around patch squashing.
>> Would you like to reduce the number of update steps
>> according to the really desired software transformation?
>
> I asked him to cut it up into small chunks.

We come along different preferences for the size of these pieces.

Regards,
Markus
___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci


Re: [Cocci] [06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType

2020-03-17 Thread Julia Lawall



On Tue, 17 Mar 2020, Markus Elfring wrote:

> >> How do you think about to combine such changes in a bigger update step?
> >
> > These are separated this way so that it's easier for Julia to review.
>
> I suggest to reconsider such an approach.
>
>
> > She will probably just squash all 26 of these together and apply them later.
>
> I got special views also around patch squashing.
> Would you like to reduce the number of update steps
> according to the really desired software transformation?

I asked him to cut it up into small chunks.

julia
___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci


Re: [Cocci] [06/26] parsing_cocci: arity: Add cases for ParenType/FunctionType

2020-03-17 Thread Markus Elfring
>> How do you think about to combine such changes in a bigger update step?
>
> These are separated this way so that it's easier for Julia to review.

I suggest to reconsider such an approach.


> She will probably just squash all 26 of these together and apply them later.

I got special views also around patch squashing.
Would you like to reduce the number of update steps
according to the really desired software transformation?

Regards,
Markus
___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci