Re: [Cocci] [PATCH] scripts/coccinelle: modernize

2016-02-19 Thread Michal Marek 
On 2016-02-18 00:47, Nishanth Menon wrote:
> On 02/17/2016 05:16 PM, Julia Lawall wrote:
>> & is no longer allowed in column 0, since Coccinelle 1.0.4.
>>
>> Signed-off-by: Julia Lawall 
[...]
> Verified with:
> spatch --version
> spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
> version 4.01.0
> 
> 
> Tested-by: Nishanth Menon 

Applied to kbuild.git#misc with Cc: stable.

Michal
___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] [PATCH] scripts/coccinelle: modernize

2016-02-19 Thread Julia Lawall 
> > diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci 
> > b/scripts/coccinelle/iterators/use_after_iter.cocci
> > index f085f59..ce8cc9c 100644
> > --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> > +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> > @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
> >  |
> >  sizeof(<+...c...+>)
> >  |
> > ->member
> > + >member
>
> The added space character is not in the first column of this SmPL script.
>
> * Can it be that the additional character will be transformed according to
>   special pretty-printing rules?
>   https://github.com/coccinelle/coccinelle/issues/37

I don't understand the question.  Spaces in the script (at least before
and after the pattern) don't impact spaces in the source code.

> * Is such a change a possible workaround for open issues around
>   the message "minus: parse error" (or software improvements
>   which were developed in the meantime)?

No idea what is referred to here.  Maybe you don't like the parse errors,
but that is the errors that the parser generator generates.  You are
welcome to write a parser generator that produces bettwe messages if you
like.

> >  |
> >  c = E
> >  |
>
>
> Does the shown tweak need any further considerations?

No idea what is referred to here.

julia
___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] [PATCH] scripts/coccinelle: modernize

2016-02-17 Thread Nishanth Menon 
On 02/17/2016 05:16 PM, Julia Lawall wrote:
> & is no longer allowed in column 0, since Coccinelle 1.0.4.
> 
> Signed-off-by: Julia Lawall 
> 
> ---
>  scripts/coccinelle/iterators/use_after_iter.cocci |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci 
> b/scripts/coccinelle/iterators/use_after_iter.cocci
> index f085f59..ce8cc9c 100644
> --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
>  |
>  sizeof(<+...c...+>)
>  |
> ->member
> + >member
>  |
>  c = E
>  |
> 


Verified with:
spatch --version
spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
version 4.01.0


Tested-by: Nishanth Menon 

-- 
Regards,
Nishanth Menon
___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] [PATCH] scripts/coccinelle: modernize

2016-02-17 Thread Julia Lawall 
On Wed, 17 Feb 2016, Nishanth Menon wrote:

> On 02/17/2016 05:16 PM, Julia Lawall wrote:
> > & is no longer allowed in column 0, since Coccinelle 1.0.4.
> >
> > Signed-off-by: Julia Lawall 
> >
> > ---
> >  scripts/coccinelle/iterators/use_after_iter.cocci |2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/coccinelle/iterators/use_after_iter.cocci 
> > b/scripts/coccinelle/iterators/use_after_iter.cocci
> > index f085f59..ce8cc9c 100644
> > --- a/scripts/coccinelle/iterators/use_after_iter.cocci
> > +++ b/scripts/coccinelle/iterators/use_after_iter.cocci
> > @@ -123,7 +123,7 @@ list_remove_head(x,c,...)
> >  |
> >  sizeof(<+...c...+>)
> >  |
> > ->member
> > + >member
> >  |
> >  c = E
> >  |
> >
>
>
> Verified with:
> spatch --version
> spatch byte-code version 1.0.4-00118-gc7cf750d1c44 compiled with OCaml
> version 4.01.0
>
>
> Tested-by: Nishanth Menon 

Thanks!

julia
___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci