Re: [Cocci] [PATCH 1/2] parsing_c: Align C AST and Cocci AST for pointers

[Jaskaran Singh]

On Wed, 2020-02-05 at 19:36 +0100, Markus Elfring wrote:
> …
> > +++ b/parsing_c/pretty_print_c.ml
> > @@ -804,11 +804,12 @@ and pp_string_format (e,ii) =
> >   (FunctionType (return=void, params=int i) *)
> >(*WRONG I THINK, use left & right function *)
> >(* bug: pp_type_with_ident_rest None t;  print_ident
> > ident *)
> > +  pp_type_left t;
> >pr_elem i;
> >iiqu +> List.iter pr_elem; (* le const est forcement
> > apres le '*' *)
> >if iiqu <> [] || get_comments_after i <> []
> >then pr_space();
> > -  pp_type_with_ident_rest ident t attrs Ast_c.noattr;
> > +  print_ident ident
> > 
> >(* ugly special case ... todo? maybe sufficient in practice
> > *)
> >| (ParenType ttop, [i1;i2]) ->
> 
> Are the source code comments still appropriate for this patch hunk?
> 

I know the "le const est forcement" comment is still appropriate.

The bug comment above probably still is.

Not so sure about the WRONG I THINK comment. I'm using pp_type_left
here, but not pp_type_right. Of course, that is if the comment is in
that context.

Cheers,
Jaskaran.

> Regards,
> Markus

___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] [PATCH 1/2] parsing_c: Align C AST and Cocci AST for pointers

[Markus Elfring]

…
> +++ b/parsing_c/pretty_print_c.ml
> @@ -804,11 +804,12 @@ and pp_string_format (e,ii) =
>   (FunctionType (return=void, params=int i) *)
>(*WRONG I THINK, use left & right function *)
>(* bug: pp_type_with_ident_rest None t;  print_ident ident *)
> +  pp_type_left t;
>pr_elem i;
>iiqu +> List.iter pr_elem; (* le const est forcement apres le '*' 
> *)
>if iiqu <> [] || get_comments_after i <> []
>then pr_space();
> -  pp_type_with_ident_rest ident t attrs Ast_c.noattr;
> +  print_ident ident
>
>(* ugly special case ... todo? maybe sufficient in practice *)
>| (ParenType ttop, [i1;i2]) ->

Are the source code comments still appropriate for this patch hunk?

Regards,
Markus
___
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci