Re: [Cocci] [PATCH 2/4] coccinelle: platform_get_irq: handle 2-statement branches
> From: Masahiro Yamada I wonder about this information. Would you like to use the tag “Suggested-by” instead? … > +++ b/scripts/coccinelle/api/platform_get_irq.cocci > @@ -31,6 +31,25 @@ if ( \( ret < 0 \| ret <= 0 \) ) … > +ret = > +( > +platform_get_irq > +| > +platform_get_irq_byname > +)(E, ...); > + > +if ( \( ret < 0 \| ret <= 0 \) ) > +-{ > +-dev_err(...); > +S > +-} How do you think about to use the following SmPL code variant? + ret = +(platform_get_irq +|platform_get_irq_byname +)(E, ...); + + if ( \( ret < 0 \| ret <= 0 \) ) +-{ +-dev_err(...); + S +-} Regards, Markus ___ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
Re: [Cocci] [PATCH 2/4] coccinelle: platform_get_irq: handle 2-statement branches
> From: Masahiro Yamada I wonder about this information. Would you like to use the tag “Suggested-by” instead? … > +++ b/scripts/coccinelle/api/platform_get_irq.cocci > @@ -31,6 +31,25 @@ if ( \( ret < 0 \| ret <= 0 \) ) … > +ret = > +( > +platform_get_irq > +| > +platform_get_irq_byname > +)(E, ...); > + > +if ( \( ret < 0 \| ret <= 0 \) ) > +-{ > +-dev_err(...); > +S > +-} How do you think about to use the following SmPL code variant? + ret = +(platform_get_irq +|platform_get_irq_byname +)(E, ...); + + if ( \( ret < 0 \| ret <= 0 \) ) +-{ +-dev_err(...); + S +-} Regards, Markus ___ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
Re: [Cocci] [PATCH 2/4] coccinelle: platform_get_irq: handle 2-statement branches
On Tue, 19 Nov 2019, Markus Elfring wrote: > > From: Masahiro Yamada > > I wonder about this information. > Would you like to use the tag “Suggested-by” instead? Sorry, I seem to have done something quite wrong on this patch. I will fix it. > > > … > > +++ b/scripts/coccinelle/api/platform_get_irq.cocci > > @@ -31,6 +31,25 @@ if ( \( ret < 0 \| ret <= 0 \) ) > … > > +ret = > > +( > > +platform_get_irq > > +| > > +platform_get_irq_byname > > +)(E, ...); > > + > > +if ( \( ret < 0 \| ret <= 0 \) ) > > +-{ > > +-dev_err(...); > > +S > > +-} > > How do you think about to use the following SmPL code variant? And the benefit is what? julia > + ret = > +(platform_get_irq > +|platform_get_irq_byname > +)(E, ...); > + > + if ( \( ret < 0 \| ret <= 0 \) ) > +-{ > +-dev_err(...); > + S > +-} > > Regards, > Markus >___ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci