Re: libSystem.B.dylib Calling Code

2009-07-01 Thread Shawn Erickson
On Wed, Jul 1, 2009 at 3:18 PM, David Blanton wrote:
> Here is code that crashes. the parms coming in are checked for validity
> before ReplaceChar is called
>
> void ReplaceChar(char *s, char oldChar, char newChar)
> {
>    if(newChar == oldChar)
>        return;
>    char *n = strchr(s, oldChar);
>    while(n)
>    {
>        *n = newChar;
>        n = strchr(n+1, oldChar);
>    }
> }

Are you sure "oldChar" cannot be '\0'? If "oldChar" is '\0' then your
n+1 will put you past the end "s". Of course replacing the null
terminator with anything other then a null terminator will break the
c-stringness of the character array.

Anyway can you post a full backtrace of a crashed thread?

-Shawn
___

Cocoa-dev mailing list (Cocoa-dev@lists.apple.com)

Please do not post admin requests or moderator comments to the list.
Contact the moderators at cocoa-dev-admins(at)lists.apple.com

Help/Unsubscribe/Update your Subscription:
http://lists.apple.com/mailman/options/cocoa-dev/archive%40mail-archive.com

This email sent to arch...@mail-archive.com


libSystem.B.dylib Calling Code

2009-07-01 Thread David Blanton
Here is code that crashes. the parms coming in are checked for  
validity before ReplaceChar is called




void ReplaceChar(char *s, char oldChar, char newChar)
{
if(newChar == oldChar)
return;
char *n = strchr(s, oldChar);
while(n)
{
*n = newChar;
n = strchr(n+1, oldChar);
}
}

___

Cocoa-dev mailing list (Cocoa-dev@lists.apple.com)

Please do not post admin requests or moderator comments to the list.
Contact the moderators at cocoa-dev-admins(at)lists.apple.com

Help/Unsubscribe/Update your Subscription:
http://lists.apple.com/mailman/options/cocoa-dev/archive%40mail-archive.com

This email sent to arch...@mail-archive.com