[GitHub] trafodion pull request #1367: [TRAFODION-2875] Fix inaccuracies in compariso...

2018-01-03 Thread DaveBirdsall
GitHub user DaveBirdsall opened a pull request:

https://github.com/apache/trafodion/pull/1367

[TRAFODION-2875] Fix inaccuracies in comparison in analyzeMessageGuide.py

Ignore trailing spaces in message text and documentation text.

Take into account multiple substitution fields in message text and 
documentation text by replacing them with '.elided.' (before they were simply 
removed).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DaveBirdsall/trafodion Trafodion2875

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1367.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1367


commit e349dea868a310679487d6b7a2244798107b35a4
Author: Dave Birdsall 
Date:   2018-01-04T01:31:39Z

[TRAFODION-2875] Fix inaccuracies in text comparison in 
analyzeMessageGuide.py




---


[GitHub] trafodion pull request #1359: [TRAFODION-2857] Web-site changes to remove in...

2018-01-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/trafodion/pull/1359


---


[GitHub] trafodion pull request #1359: [TRAFODION-2857] Web-site changes to remove in...

2018-01-03 Thread svarnau
Github user svarnau commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1359#discussion_r159534056
  
--- Diff: README.md ---
@@ -20,11 +20,11 @@ Hadoop.
   
   http://trafodion.apache.org/release-notes.html
 
-  - the latest Apache Trafodion can be downloaded from Apache incubator
+  - the latest Apache Trafodion can be downloaded from Apache
 distribution site or accessed from git:
 
 - download site:
-  https://dist.apache.org/repos/dist/release/incubator/trafodion
+  https://dist.apache.org/repos/dist/release/trafodion
--- End diff --

Infra team has taken care of moving the dist directory.


---


[GitHub] trafodion pull request #1365: TRAFODION-2873. Cleanup of LobGlobals and LobL...

2018-01-03 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1365#discussion_r159528878
  
--- Diff: core/sql/exp/exp_clause.cpp ---
@@ -574,8 +574,8 @@ ex_clause::ex_clause(clause_type type,
case ITM_LOBCONVERTHANDLE:
  setClassID(LOB_CONVERTHANDLE);
  break;
-   case ITM_LOBLOAD:
- setClassID(LOB_LOAD);
+  /*   case ITM_LOBLOAD:
--- End diff --

Maybe delete these lines (and the break after them) instead of commenting 
out?


---