[GitHub] trafodion pull request #1601: [TRAFODION-3103] Add Descriptions and Examples...

2018-06-11 Thread liuyu000
Github user liuyu000 commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1601#discussion_r194599785
  
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -5958,6 +6098,122 @@ GRANT SELECT (part_no, part_name), DELETE ON TABLE 
invent.partloc
 GRANT SELECT ON TABLE invent.partloc TO ajones;
 ```
 
+* This example explains how to grant the `SELECT` privilege to PUBLIC.
+
++
+The _testuser1_ creates the table _t1_. The _testuser2_ and _testuser3_ do 
not have the `SELECT` privilege on the table _t1_.
+
++
+_testuser2_:
+
++
+```
+SQL>SELECT * FROM t1;
+
+*** ERROR[4481] The testuser2 does not have SELECT privilege on table or 
view TRAFODION.SEABASE.T1. [2018-06-11 11:39:16]
+```
+
++
+The _testuser1_ grants the `SELECT` privilege on table _t1_ to PUBLIC, 
which means granting `SELECT` privilege to all users (_testuser2_ and 
_testuser3_). 
+
--- End diff --

Thanks @robertamarton, your comment has been incorporated :pencil2:


---


[GitHub] trafodion pull request #1601: [TRAFODION-3103] Add Descriptions and Examples...

2018-06-11 Thread liuyu000
Github user liuyu000 commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1601#discussion_r194599335
  
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -5928,19 +5970,117 @@ Specifies the list of columns to grant the 
requested privilege to.
 [[grant_authorization_and_availability_requirements]]
  Authorization and Availability Requirements
 
-To grant a privilege on an object, you must have both that privilege and 
the right to grant that privilege. Privileges can 
-be granted directly to you or to one of the roles you have been granted. 
You can grant a privilege on an object if you are 
-the owner of the object (by which you are implicitly granted all 
privileges on the object) or the owner of the schema containing 
-the object, or if you have been granted both the privilege and the WITH 
GRANT OPTION for the privilege.
+* To grant a privilege on an object, you must have both that privilege and 
the right to grant that privilege. 
 
-If granting privileges on behalf of a role, you must specify the role in 
the [GRANTED] BY clause. To grant the privileges on 
-behalf of a role, you must be a member of the role, and the role must have 
the authority to grant the privileges; that is, the 
-role must have been granted the privileges WITH GRANT OPTION.
+* Privileges can be granted directly to you or to one of the roles you 
have been granted. 
+
+* You can grant a privilege on an object if one of the following is true:
++
+** If you are the owner of the object (by which you are implicitly granted 
all privileges on the object). 
+
++
+** The owner of the schema contains the object.
+
++
+** If you have been granted both the privilege and the `WITH GRANT OPTION` 
for the privilege.
+
+* If granting privileges on behalf of a role, you must specify the role in 
the `[GRANTED] BY` clause. 
++
+To grant the privileges on behalf of a role, you must be a member of the 
role, and the role must have the authority to grant the privileges; 
+that is, the role must have been granted the privileges `WITH GRANT 
OPTION`.
+
+* If you lack authority to grant:
+
+** If you lack authority to grant one or more of the specified privileges, 
SQL returns a warning (yet does grant the specified 
+privileges for which you do have authority to grant). 
+
++
+*Example*
+
++
+The owner of the table _customer_ is the _testuser1_, who grants `DELETE`, 
`INSERT` and `REFERENCES` privileges on the table _customer_ 
+to the user _testuser2_ with `WITH GRANT OPTION`.
+
++
+_testuser1_:
 
-If you lack authority to grant one or more of the specified privileges, 
SQL returns a warning (yet does grant the specified 
-privileges for which you do have authority to grant). If you lack 
authority to grant any of the specified privileges, SQL returns 
++ 
+```
+SQL>GRANT DELETE, INSERT, REFERENCES ON customer TO testuser2 WITH GRANT 
OPTION;
+
+--- SQL operation complete.
+```
+
++
+Then the _testuser2_ tries to grant all privileges on the table _customer_ 
to the _testuser3_ but fails because of lacking `SELECT` and 
+`UPDATE` privileges, only successfully grants those privileges (`DELETE`, 
`INSERT` and `REFERENCES`) for which the _testuser2_ has 
+grant options.
+
--- End diff --

Thanks @robertamarton, your comment has been incorporated :relaxed:


---


[GitHub] trafodion pull request #1601: [TRAFODION-3103] Add Descriptions and Examples...

2018-06-11 Thread liuyu000
Github user liuyu000 commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1601#discussion_r194598325
  
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -5860,7 +5863,7 @@ column-list is:
 <<<
 === syntax description of grant
 
-* `_privilege_ [,_privilege_ ]  | all [privileges]`
+* `_privilege-name_ [,_privilege-name_ ]  | all [privileges]`
 +
--- End diff --

 is the unicode for "…" (hellip) :smiley_cat:
For more information, see 
https://www.w3schools.com/charsets/ref_html_entities_h.asp.


---


[GitHub] trafodion pull request #1600: [TRAFODION-3102] unify hostname format as what...

2018-06-11 Thread mashengchen
Github user mashengchen closed the pull request at:

https://github.com/apache/trafodion/pull/1600


---


[GitHub] trafodion pull request #1604: Trafodion 2884

2018-06-11 Thread zcorrea
GitHub user zcorrea opened a pull request:

https://github.com/apache/trafodion/pull/1604

Trafodion 2884

Implements: https://issues.apache.org/jira/browse/TRAFODION-2884



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zcorrea/trafodion TRAFODION-2884

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1604.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1604


commit f375acdc8b199d56c6c39ab13ba09a014b080f90
Author: Dave George 
Date:   2018-02-26T18:07:50Z

first nameserver commit.

commit 577c985fb1afcf0a3398065de1670f6725ab887d
Author: Dave George 
Date:   2018-02-26T19:39:50Z

commit nameserver.

commit c61d2f7a6cd352fd91ba9c6fd1a848160c4e22b4
Author: Dave George 
Date:   2018-02-26T20:27:06Z

Fix SB for nameserver changes.

commit a66a1f1e1eb9dd3fdeb1b5170bb37c3500b13d7f
Author: Dave George 
Date:   2018-02-26T22:21:22Z

Convert atomic_t to SB_Atomic_Int.

commit 13d566f72233d46e22454cd55b6540512562f8bc
Author: Dave George 
Date:   2018-03-01T14:05:07Z

update nameserver.

commit b7cf5267b13fe947b28aa951d69b3834792b7238
Author: Dave George 
Date:   2018-03-02T19:09:38Z

add missing file.

commit 611c284fcb753846e785abd540fa7ef91d73d759
Author: Dave George 
Date:   2018-03-02T19:16:11Z

Add log4cxx for ns.

commit 668bcaff56a60a3a57d050146975233cbcfac275
Author: Zalo Correa 
Date:   2018-03-02T21:18:56Z

Merge remote branch 'origin/master' into TRAFODION-2884

Conflicts:
core/sqf/monitor/linux/cluster.cxx
core/sqf/monitor/linux/cluster.h
core/sqf/monitor/linux/monitor.cxx
core/sqf/monitor/linux/monitor.h
core/sqf/monitor/linux/reqprocinfo.cxx

commit 20ef4c097f6321bbffbf67b9adaebe12a6df7eeb
Author: Zalo Correa 
Date:   2018-03-02T21:19:31Z

Merge branch 'TRAFODION-2884' of github.com:zcorrea/trafodion into 
TRAFODION-2884

commit 4b8a23630155cb8162428fcdd06747478bcac652
Author: Zalo Correa 
Date:   2018-03-02T23:30:19Z

Defaulted NameServer to disabled

commit 660b9cf22530589e3a18d2de078dc71b895f6211
Author: Dave George 
Date:   2018-03-05T21:31:24Z

nameserver configuration changes.

commit 10b30d84e2983346efa1689e1088a9e48b9f2bbd
Author: Dave George 
Date:   2018-03-05T22:09:08Z

Merge branch 'TRAFODION-2884' of github.com:zcorrea/trafodion into 
TRAFODION-2884

Conflicts:
core/sqf/monitor/linux/msgdef.h
core/sqf/monitor/linux/shell.cxx

commit f210aeacec051bf1bded690e22036d704abb4f69
Author: Dave George 
Date:   2018-03-05T22:13:29Z

add new files.

commit b6580599619ad9aef9dcbb2303d56054134456f1
Author: Dave George 
Date:   2018-03-06T16:08:34Z

Launch ns.

commit 4de52a77aefb2019e1e6d1ad38ec8891ef092bad
Author: Dave George 
Date:   2018-03-06T19:25:32Z

launch nameserver without mpirun.

commit 04c1944ccc450f2b256bc61004da96347fec688e
Author: Dave George 
Date:   2018-03-06T20:24:35Z

Fix nameserver delete.

commit 0efcb387844a24e0a113e4cb3e05ae73aeb764e1
Author: Dave George 
Date:   2018-03-07T16:27:36Z

refactor monToNameserver interface. Create NS process (currently all nodes).

commit 54e5c79cbefcac3a592d5d4b81b2245783575a0b
Author: Dave George 
Date:   2018-03-07T18:05:06Z

$ZNS->$NS, ns->trafns, 'nameserver info' reimplemented as 'ps {NS}'.

commit d15263075cedd78b30e37444a07b4be0687f4930
Author: Zalo Correa 
Date:   2018-03-09T18:09:45Z

Update environment variables used to enable AGENT mode, NAME-SERVER, and 
associated ports.

commit 4c028ea41f4ff7f49cc4362ae99ea8a9d588a0f0
Author: Zalo Correa 
Date:   2018-03-09T18:15:57Z

Merge branch 'TRAFODION-2884' of github.com:zcorrea/trafodion into 
TRAFODION-2884

commit 63d3ed1c3b0ef532193127181ff209b693358316
Author: Trina Krug 
Date:   2018-03-09T19:16:06Z

Framework for Monitor PTP

commit eeade17194b9e1997a53eb31fc5a3827eb4b0702
Author: Dave George 
Date:   2018-03-09T19:26:56Z

Update.

commit 4e00a22557ba679fd6e998613d8b26ff90629d1b
Author: Dave George 
Date:   2018-03-09T19:29:22Z

Update.

commit 64f24d2fcfccd91760d5dae65cb20ca1a4861639
Author: Zalo Correa 
Date:   2018-03-09T19:30:16Z

Merge branch 'TRAFODION-2884' of github.com:zcorrea/trafodion into 
TRAFODION-2884

commit 5c608f50cfe686ec4b52646226707c800da0272b
Author: Dave George 
Date:   2018-03-09T19:30:35Z

Update.

commit 7cc10e0a7e1811438bbcc1f571f3e42a3ebea380
Author: Dave George 
Date:   2018-03-09T19:31:12Z

Update.

commit 1ba7f5599cc468b5727aae685d321e8c22a513e8
Author: Dave George 
Date:   2018-03-09T19:31:49Z

Update.

commit 01bb72427c1906dca0d74088e7d64464a2236c97
Author: Dave George 
Date:   2018-03-09T19:47:38Z

Merge branch 'TRAFODION-2884' of github.com:zcorrea/trafodion into 
TRAFODION-2884

Conflicts:

[GitHub] trafodion pull request #1603: [TRAFODION-3089] DatabaseMetaData.getIndexInfo...

2018-06-11 Thread mashengchen
GitHub user mashengchen opened a pull request:

https://github.com/apache/trafodion/pull/1603

[TRAFODION-3089] DatabaseMetaData.getIndexInfo not work well



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mashengchen/trafodion getIndexInfo

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1603.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1603


commit 36a9b4c6c51b87cf12f1fa5f76b6d4ee4a9a9f9f
Author: mashengchen 
Date:   2018-06-11T09:49:07Z

[TRAFODION-3089] DatabaseMetaData.getIndexInfo not work well




---


[GitHub] trafodion pull request #1601: [TRAFODION-3103] Add Descriptions and Examples...

2018-06-11 Thread liuyu000
Github user liuyu000 commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1601#discussion_r194591669
  
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -5819,13 +5819,16 @@ System Version 0.9.1. Expected Version 1.0.0.
 The GRANT statement grants access privileges on an SQL object and its 
columns to specified users or roles.
 Privileges can be granted on the object, on one or more columns, or both.
 
+TIP: As the owner who creates the object has all privileges by default, 
there is no need to grant privileges to the owner.
+The owner could grant/revoke privileges to/from other users or roles for 
safety.
--- End diff --

Thanks @robertamarton, your comment has been incorporated :smile: 


---


[GitHub] trafodion pull request #1566: TRAFODION-3069

2018-06-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/trafodion/pull/1566


---


[GitHub] trafodion pull request #1602: jenkins hive regr fix

2018-06-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/trafodion/pull/1602


---


[GitHub] trafodion pull request #1601: [TRAFODION-3103] Add Descriptions and Examples...

2018-06-11 Thread robertamarton
Github user robertamarton commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1601#discussion_r194449306
  
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -5819,13 +5819,16 @@ System Version 0.9.1. Expected Version 1.0.0.
 The GRANT statement grants access privileges on an SQL object and its 
columns to specified users or roles.
 Privileges can be granted on the object, on one or more columns, or both.
 
+TIP: As the owner who creates the object has all privileges by default, 
there is no need to grant privileges to the owner.
+The owner could grant/revoke privileges to/from other users or roles for 
safety.
--- End diff --

Word smith suggestion "The user or role that creates the object becomes the 
object owner and has all privileges on the object.  There is no need to grant 
privileges to the owner.  The owner can grant. ...


---


[GitHub] trafodion pull request #1601: [TRAFODION-3103] Add Descriptions and Examples...

2018-06-11 Thread robertamarton
Github user robertamarton commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1601#discussion_r194449348
  
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -5860,7 +5863,7 @@ column-list is:
 <<<
 === syntax description of grant
 
-* `_privilege_ [,_privilege_ ]  | all [privileges]`
+* `_privilege-name_ [,_privilege-name_ ]  | all [privileges]`
 +
--- End diff --


what is ?


---


[GitHub] trafodion pull request #1601: [TRAFODION-3103] Add Descriptions and Examples...

2018-06-11 Thread robertamarton
Github user robertamarton commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1601#discussion_r194449791
  
--- Diff: docs/sql_reference/src/asciidoc/_chapters/sql_statements.adoc ---
@@ -5958,6 +6098,122 @@ GRANT SELECT (part_no, part_name), DELETE ON TABLE 
invent.partloc
 GRANT SELECT ON TABLE invent.partloc TO ajones;
 ```
 
+* This example explains how to grant the `SELECT` privilege to PUBLIC.
+
++
+The _testuser1_ creates the table _t1_. The _testuser2_ and _testuser3_ do 
not have the `SELECT` privilege on the table _t1_.
+
++
+_testuser2_:
+
++
+```
+SQL>SELECT * FROM t1;
+
+*** ERROR[4481] The testuser2 does not have SELECT privilege on table or 
view TRAFODION.SEABASE.T1. [2018-06-11 11:39:16]
+```
+
++
+The _testuser1_ grants the `SELECT` privilege on table _t1_ to PUBLIC, 
which means granting `SELECT` privilege to all users (_testuser2_ and 
_testuser3_). 
+
--- End diff --

Word smith suggestion:  The _testuser1_ grants the ... privilege to all 
current  and future users (_testuser2_ and _testuser3_).


---


[GitHub] trafodion pull request #1602: jenkins hive regr fix

2018-06-11 Thread anoopsharma00
GitHub user anoopsharma00 opened a pull request:

https://github.com/apache/trafodion/pull/1602

jenkins hive regr fix



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anoopsharma00/trafodion ansharma_hiveddl_br

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1602.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1602


commit f6ee6aee7dd991de925af3e88f847fd81d1c35b2
Author: Anoop Sharma 
Date:   2018-06-11T14:28:29Z

hive regr fix




---


[GitHub] trafodion pull request #1601: [TRAFODION-3103] Add Descriptions and Examples...

2018-06-11 Thread liuyu000
GitHub user liuyu000 opened a pull request:

https://github.com/apache/trafodion/pull/1601

[TRAFODION-3103] Add Descriptions and Examples for *GRANT Statement* in 
*Trafodion SQL Reference Manual*



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liuyu000/trafodion GrantStatement

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1601.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1601


commit dc3042a9abaa9b13887d361ce377b04a06aee92e
Author: liu.yu 
Date:   2018-06-11T11:58:13Z

[TRAFODION-3103] Add Descriptions and Examples for *GRANT Statement* in 
*Trafodion SQL Reference Manual*




---


[GitHub] trafodion pull request #1600: [TRAFODION-3102] unify hostname format as what...

2018-06-11 Thread mashengchen
GitHub user mashengchen opened a pull request:

https://github.com/apache/trafodion/pull/1600

[TRAFODION-3102] unify hostname format as what monitor does

it's hard to update statistic message each time row datas change. so 
current version does not support CARDINALITY.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mashengchen/trafodion dcs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1600.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1600


commit a2635d0cac985443f1800496fa8bf99010b18988
Author: aven 
Date:   2018-06-11T03:38:52Z

[TRAFODION-3102] unify hostname format as what monitor does




---