[GitHub] trafodion pull request #1681: [TRAFODION-3174] Add Syntax for *CREATE TABLE ...

2018-08-06 Thread liuyu000
GitHub user liuyu000 opened a pull request:

https://github.com/apache/trafodion/pull/1681

[TRAFODION-3174] Add Syntax for *CREATE TABLE Statement* and *ALTER TABLE 
Statement* and Fix Typos in *Trafodion SQL Reference Manual*



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liuyu000/trafodion 
CreateTableStatement_tinyint

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1681.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1681


commit 1ceff3712b8677bf7e53e04c517fc639ee6fe991
Author: liu.yu 
Date:   2018-08-06T11:48:01Z

[TRAFODION-3174] Add Syntax for *CREATE TABLE Statement* and *ALTER TABLE 
Statement* and Fix Typos in *Trafodion SQL Reference Manual*




---


[GitHub] trafodion pull request #1674: [TRAFODION-3171] Refactor Hive sequence file r...

2018-08-06 Thread sureshsubbiah
Github user sureshsubbiah commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1674#discussion_r207986948
  
--- Diff: core/sql/executor/ExHdfsScan.cpp ---
@@ -571,6 +569,7 @@ ExWorkProcRetcode ExHdfsScanTcb::work()
  hdfsScan_ = HdfsScan::newInstance((NAHeap *)getHeap(), 
hdfsScanBuf_, hdfsScanBufMaxSize_, 
 hdfsScanTdb().hdfsIoByteArraySizeInKB_, 
 &hdfsFileInfoListAsArray_, beginRangeNum_, 
numRanges_, hdfsScanTdb().rangeTailIOSize_, 
+isSequenceFile(), 
hdfsScanTdb().recordDelimiter_, 
--- End diff --

Thank you for explaining


---


[GitHub] trafodion pull request #1674: [TRAFODION-3171] Refactor Hive sequence file r...

2018-08-06 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/trafodion/pull/1674


---


[GitHub] trafodion pull request #1679: [TRAFODION-3163] Add script to do STFS health ...

2018-08-06 Thread DaveBirdsall
Github user DaveBirdsall commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1679#discussion_r208041994
  
--- Diff: core/sqf/src/tm/tools/dtmci.cpp ---
@@ -1801,6 +1801,20 @@ int main(int argc, char *argv[])
 << "' for status command." << endl;
 }
 }
+else if (!strcmp(lp_nextcmd, "showenv"))
+{
+   get_cmd(lp_inputstr, lp_nextcmd);
+   if (lp_nextcmd[0] == '\0')
+ cout <<"TODO: show all env var\n" << endl;
+   else
+   {
+  const char* v = ms_getenv_str((const char*)lp_nextcmd);
+  if(v == NULL)
+cout <<"*** Enviorement Var not exist" << endl;
--- End diff --

Typo. "Environment"


---


[GitHub] trafodion pull request #1679: [TRAFODION-3163] Add script to do STFS health ...

2018-08-06 Thread traflm
Github user traflm commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1679#discussion_r208065409
  
--- Diff: core/sqf/src/tm/tools/dtmci.cpp ---
@@ -1801,6 +1801,20 @@ int main(int argc, char *argv[])
 << "' for status command." << endl;
 }
 }
+else if (!strcmp(lp_nextcmd, "showenv"))
+{
+   get_cmd(lp_inputstr, lp_nextcmd);
+   if (lp_nextcmd[0] == '\0')
+ cout <<"TODO: show all env var\n" << endl;
+   else
+   {
+  const char* v = ms_getenv_str((const char*)lp_nextcmd);
+  if(v == NULL)
+cout <<"*** Enviorement Var not exist" << endl;
--- End diff --

thanks Dave, I will change this typo


---


[GitHub] trafodion pull request #1676: TRAFODION-3165 HDFS storage option not work we...

2018-08-06 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/trafodion/pull/1676


---


[GitHub] trafodion pull request #1682: [TRAFODION-3177] Error when selecting count(*)...

2018-08-06 Thread zellerh
GitHub user zellerh opened a pull request:

https://github.com/apache/trafodion/pull/1682

[TRAFODION-3177] Error when selecting count(*) from event_log_reader UDF

See the JIRA for a description of the issues.

- Removed code that required usage of a set of output columns
  to evaluate code. This check caused the error described in the
  test case, and I think it is no longer necessary. Removing it
  can speed up some cases where we now evaluate predicates in the
  UDF, for example:

```
  select count(*)
  from udf("_LIBMGR_".event_log_reader('f'))
  where log_file_node = 0;
```

- Added predicate evaluation code for MESSAGE, LOG_FILE_NODE,
  LOG_FILE_LINE, and PARSE_STATUS columns.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zellerh/trafodion bug/R23a

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1682.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1682


commit 5ecb6890cb9fc381bca7c4f5c93ea8a28ed9fd31
Author: Hans Zeller 
Date:   2018-08-07T01:20:09Z

[TRAFODION-3177] Error when selecting count(*) from event_log_reader UDF

See the JIRA for a description of the issues.

- Removed code that required usage of a set of output columns
  to evaluate code. This check caused the error described in the
  test case, and I think it is no longer necessary. Removing it
  can speed up some cases where we now evaluate predicates in the
  UDF, for example:

  select count(*)
  from udf("_LIBMGR_".event_log_reader('f'))
  where log_file_node = 0;

- Added predicate evaluation code for MESSAGE, LOG_FILE_NODE,
  LOG_FILE_LINE, and PARSE_STATUS columns.




---


[GitHub] trafodion pull request #1681: [TRAFODION-3174] Add Syntax for *CREATE TABLE ...

2018-08-06 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/trafodion/pull/1681


---