[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

[sandhyasun]

Github user sandhyasun commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1721#discussion_r225719386
  
--- Diff: core/sql/sqlcomp/CmpSeabaseDDLupgrade.cpp ---
@@ -1657,7 +1717,7 @@ short 
CmpSeabaseMDupgrade::executeSeabaseMDupgrade(CmpDDLwithStatusInfo *mdui,
{
  *CmpCommon::diags() << DgSqlCode(-20123);
 
- mdui->setStep(UPGRADE_FAILED_RESTORE_OLD_REPOS);
+ mdui->setStep(UPGRADE_FAILED_RESTORE_OLD_LIBRARIES);
--- End diff --

We ar ein the phase of rewinding the upgrade. Unless the "needsUpgrade" 
flag is set, the restore steps wont do anything. So we are ok. We just need to 
start with last step and rewind but some of the in between steps may not do any 
rewinding. 


---

[GitHub] trafodion pull request #1724: [TRAFODION-3220] Executor GUI

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/trafodion/pull/1724


---

[GitHub] trafodion pull request #1726: [TRAFODION-3222] Windows odbc build fail

[Weixin-Xu]

GitHub user Weixin-Xu opened a pull request:

https://github.com/apache/trafodion/pull/1726

[TRAFODION-3222] Windows odbc build fail

1. header file "cconnect.h" missed in "sqltocconv.h"
2. In README.txt, vs2013 is recommended to build windows odbc but now only 
the version is set vs2015 or higher.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Weixin-Xu/incubator-trafodion 
WindowsODBCBuildError

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1726.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1726


commit 470dfbc5dbdb908fb10e8d37c25ce3f3c48a540f
Author: Weixin-Xu <1013438133@...>
Date:   2018-10-16T05:36:24Z

missing header file cconnect.h in sqltocconv.h

commit 0718cc9d22ac7d611bbc29ede4a0c1476aaefd68
Author: Weixin-Xu <1013438133@...>
Date:   2018-10-16T05:38:55Z

restore the version of vs depended by windows odbc from 2015 to 2013




---