[GitHub] trafodion pull request #1753: [TRAFODION-3241]support both jdk1.7 and jdk1.8

2018-12-06 Thread svarnau
Github user svarnau commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1753#discussion_r239634533
  
--- Diff: core/conn/jdbcT4/Makefile ---
@@ -26,17 +26,20 @@ include ../../macros.gmk #top level
 all: build_all
 
 build_all: LICENSE NOTICE 
-   echo "$(MAVEN) package -DskipTests"
-   set -o pipefail && $(MAVEN) package -DskipTests | tee build_jdbct4.log 
| grep --line-buffered -E -e '^\[[^WId]' -e '^\[INFO\] B[Uu][Ii][Ll][Dd]' -e 
'to compile'
-   cp target/jdbcT4-${TRAFODION_VER}.jar ${TRAF_HOME}/export/lib
-   mkdir -p ../clients
-   mv target/jdbcT4-${TRAFODION_VER}.zip ../clients
-   #ln -sf ${TRAF_HOME}/export/lib/jdbcT4-${TRAFODION_VER}.jar 
${TRAF_HOME}/export/lib/jdbcT4.jar
-   `cd ${TRAF_HOME}/export/lib;ln -sf jdbcT4-${TRAFODION_VER}.jar 
jdbcT4.jar`
+   @if [ ! -f target/*.jar ]; then \
--- End diff --

If *.jar expands to more than one file, won't that generate a shell syntax 
error?


---


[GitHub] trafodion pull request #1738: [TRAFODION-2626] Fix DCS API for $TRAF_LOG

2018-11-06 Thread svarnau
GitHub user svarnau opened a pull request:

https://github.com/apache/trafodion/pull/1738

[TRAFODION-2626] Fix DCS API for $TRAF_LOG

Previous change allowed configuration of log location, but did not
take into account retrieving logs via DCS web interface.

Link to trafodion logs is not exposed by default, but this change was tested
with that option enabled, as well as default.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/trafodion j2626_dcs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1738.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1738


commit b558beaf428d2c2c95d32f23f04440c522be0cba
Author: Steve Varnau 
Date:   2018-11-06T23:40:23Z

[TRAFODION-2626] Fix DCS API for $TRAF_LOG

Previous change allowed configuration of log location, but did not
take into account retrieving logs via DCS web interface.

Link to trafodion logs is not exposed by default, but this change was tested
with that option enabled, as well as default.




---


[GitHub] trafodion pull request #1731: [TRAFODION-2626] Fix regressions

2018-10-21 Thread svarnau
GitHub user svarnau opened a pull request:

https://github.com/apache/trafodion/pull/1731

[TRAFODION-2626] Fix regressions

* Fix a wrong variable name in regression test code.
* Revert the original changes to monitor redirector that caused loss of 
some stdout data.
* Change monitor shell to put persistent process logs in TRAF_LOG.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/trafodion j2626

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1731.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1731


commit bd2e6f324d9bbaebc72eeda383ecc53f86ffdc1a
Author: Steve Varnau 
Date:   2018-10-21T18:55:04Z

[TRAFODION-2626] Fix regressions

* Fix a wrong variable name in regression test code.
* Revert the original changes to monitor redirector that caused loss
  of some stdout data.
* Change monitor shell to put persistent process logs in TRAF_LOG.




---


[GitHub] trafodion pull request #1728: [TRAFODION-2626] Make logs directory location ...

2018-10-16 Thread svarnau
GitHub user svarnau opened a pull request:

https://github.com/apache/trafodion/pull/1728

[TRAFODION-2626] Make logs directory location configurable

Makes path to log directory independent of TRAF_HOME. The default location
is still $TRAF_HOME/logs. The DCS and REST log directories are now
sub-directories of the main TRAF_LOG directory.

Changes were pretty straight-forward, except the monitor stdout_* files.  
Someone familiar with foundation should have a look.

Tested in local_hadoop environment, with TRAF_LOG set to alternate path and 
normal logs directory blocked.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/trafodion j2626

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1728.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1728


commit 2fc08c974766c40dc51b374f172490243cc1239f
Author: Steve Varnau 
Date:   2018-10-16T21:58:01Z

[TRAFODION-2626] Make logs directory location configurable

Makes path to log directory independent of TRAF_HOME. The default location
is still $TRAF_HOME/logs. The DCS and REST log directories are now
sub-directories of the main TRAF_LOG directory.




---


[GitHub] trafodion pull request #1709: [TRAFODION-3200] correct label and version

2018-09-08 Thread svarnau
Github user svarnau commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1709#discussion_r216133725
  
--- Diff: tools/docker/build-base-docker.sh ---
@@ -19,7 +19,7 @@ set -e -x -u
 
 BASE_SCRIPT_DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )
 
-export DOCKER_ENV_VERSION="0.1"
+export DOCKER_ENV_VERSION="2.3"
 export BASE_IMAGE_NAME="trafodion/base:${DOCKER_ENV_VERSION}"
--- End diff --

Do you want to put this in the release2.3 branch instead of master?


---


[GitHub] trafodion pull request #1604: Trafodion 2884

2018-06-13 Thread svarnau
Github user svarnau commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1604#discussion_r195160478
  
--- Diff: core/sqf/sqenvcom.sh ---
@@ -673,17 +673,31 @@ export SQ_LUNMGR_VERBOSITY=1
 # Control SQ default startup behavior (c=cold, w=warm, if removed sqstart 
will autocheck)
 export SQ_STARTUP=r
 
-# Monitor process creator:
+#
+# NOTE: in a Python installation when SQ_MON_RUN_MODE below
+#   is AGENT the SQ_MON_CREATOR must be MPIRUN
+#
 #   MPIRUN - monitor process is created by mpirun
-# Uncomment SQ_MON_CREATOR when running monitor in AGENT mode
+#(meaning that mpirun is the parent process of the monitor 
process)
+#   AGENT  - monitor process runs in agent mode versus MPI collective
+#
+# Uncomment the next four environment variables
 #export SQ_MON_CREATOR=MPIRUN
-
-# Monitor process run mode:
-#   AGENT - monitor process runs in agent mode versus MPI collective
-# Uncomment the three environment variables below
 #export SQ_MON_RUN_MODE=AGENT
-#export MONITOR_COMM_PORT=23399
-#export MONITOR_SYNC_PORT=23398
+#export MONITOR_COMM_PORT=23390
+#export MONITOR_SYNC_PORT=23380
+
+#
+#   NAME-SERVER - to disable process replication and enable the name-server
+#
+# Uncomment the next environment variable
+#export SQ_NAMESERVER_ENABLED=1
+if [[ "$SQ_NAMESERVER_ENABLED" == "1" ]]; then
+  export NS_COMM_PORT=23370
+  export NS_SYNC_PORT=23360
+  export NS_M2N_COMM_PORT=23350
+  export MON2MON_COMM_PORT=23340
+fi
--- End diff --

Yes


---


[GitHub] trafodion pull request #1604: Trafodion 2884

2018-06-12 Thread svarnau
Github user svarnau commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1604#discussion_r194808275
  
--- Diff: core/sqf/sqenvcom.sh ---
@@ -673,17 +673,31 @@ export SQ_LUNMGR_VERBOSITY=1
 # Control SQ default startup behavior (c=cold, w=warm, if removed sqstart 
will autocheck)
 export SQ_STARTUP=r
 
-# Monitor process creator:
+#
+# NOTE: in a Python installation when SQ_MON_RUN_MODE below
+#   is AGENT the SQ_MON_CREATOR must be MPIRUN
+#
 #   MPIRUN - monitor process is created by mpirun
-# Uncomment SQ_MON_CREATOR when running monitor in AGENT mode
+#(meaning that mpirun is the parent process of the monitor 
process)
+#   AGENT  - monitor process runs in agent mode versus MPI collective
+#
+# Uncomment the next four environment variables
 #export SQ_MON_CREATOR=MPIRUN
-
-# Monitor process run mode:
-#   AGENT - monitor process runs in agent mode versus MPI collective
-# Uncomment the three environment variables below
 #export SQ_MON_RUN_MODE=AGENT
-#export MONITOR_COMM_PORT=23399
-#export MONITOR_SYNC_PORT=23398
+#export MONITOR_COMM_PORT=23390
+#export MONITOR_SYNC_PORT=23380
+
+#
+#   NAME-SERVER - to disable process replication and enable the name-server
+#
+# Uncomment the next environment variable
+#export SQ_NAMESERVER_ENABLED=1
+if [[ "$SQ_NAMESERVER_ENABLED" == "1" ]]; then
+  export NS_COMM_PORT=23370
+  export NS_SYNC_PORT=23360
+  export NS_M2N_COMM_PORT=23350
+  export MON2MON_COMM_PORT=23340
+fi
--- End diff --

PORT numbers should not be hard-coded here. I think most default ports are 
coded elsewhere, but these need to at leaset be coded to allow over-ride, such 
as:
export NS_COMM_PORT=${NS_COMM_PORT:-23370}


---


[GitHub] trafodion pull request #1565: Add RH7 supported flag to build & test on addi...

2018-05-15 Thread svarnau
GitHub user svarnau opened a pull request:

https://github.com/apache/trafodion/pull/1565

Add RH7 supported flag to build & test on additional OS

Testing jenkins processing, which keys off install_features file.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/trafodion rh7_test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1565.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1565


commit c138dd08bbfb5f2d08c139962468ff1f70d353e0
Author: Steve Varnau 
Date:   2018-05-15T17:20:55Z

Add RH7 supported flag to build & test on additional OS




---


[GitHub] trafodion pull request #1535: TRAFODION-2957 one stmt support multi-queries

2018-04-24 Thread svarnau
Github user svarnau commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1535#discussion_r183804788
  
--- Diff: 
core/conn/jdbcT4/src/main/java/org/trafodion/jdbc/t4/TrafT4MultiQueriesPreparedStatement.java
 ---
@@ -0,0 +1,372 @@
+package org.trafodion.jdbc.t4;
+
+import java.math.BigDecimal;
+import java.sql.BatchUpdateException;
+import java.sql.Date;
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.sql.Time;
+import java.sql.Timestamp;
+import java.util.logging.Level;
+
+public class TrafT4MultiQueriesPreparedStatement extends 
TrafT4PreparedStatement {
+
+private String[] sqlArr = null;
+private TrafT4PreparedStatement[] pstmtArr = null;
+private int[][] paramDescs = null;
+
+private int currentSqlIndex;
+
+TrafT4MultiQueriesPreparedStatement(TrafT4Connection connection, 
String sql) throws SQLException {
+this(connection, sql, ResultSet.TYPE_FORWARD_ONLY, 
ResultSet.CONCUR_READ_ONLY,
+TrafT4ResultSet.CLOSE_CURSORS_AT_COMMIT, null);
+if (connection.props_.t4Logger_.isLoggable(Level.FINE) == true) {
+Object p[] = T4LoggingUtilities.makeParams(connection.props_, 
connection, sql);
+connection.props_.t4Logger_.logp(Level.FINE, 
"TrafT4MultiQueriesPreparedStatement", "", "", p);
+}
+}
+
+TrafT4MultiQueriesPreparedStatement(TrafT4Connection connection, 
String sql, String stmtLabel) throws SQLException {
+this(connection, sql, ResultSet.TYPE_FORWARD_ONLY, 
ResultSet.CONCUR_READ_ONLY,
+TrafT4ResultSet.CLOSE_CURSORS_AT_COMMIT, stmtLabel);
+if (connection.props_.t4Logger_.isLoggable(Level.FINE) == true) {
+Object p[] = T4LoggingUtilities.makeParams(connection.props_, 
connection, sql, stmtLabel);
+connection.props_.t4Logger_.logp(Level.FINE, 
"TrafT4MultiQueriesPreparedStatement", "", "", p);
+}
+}
+
+TrafT4MultiQueriesPreparedStatement(TrafT4Connection connection, 
String sql, int resultSetType,
+int resultSetConcurrency) throws SQLException {
+this(connection, sql, resultSetType, resultSetConcurrency, 
connection.holdability_, null);
+if (connection.props_.t4Logger_.isLoggable(Level.FINE) == true) {
+Object p[] = T4LoggingUtilities.makeParams(connection.props_, 
connection, sql, resultSetType,
+resultSetConcurrency);
+connection.props_.t4Logger_.logp(Level.FINE, 
"TrafT4MultiQueriesPreparedStatement", "", "", p);
+}
+}
+
+TrafT4MultiQueriesPreparedStatement(TrafT4Connection connection, 
String sql, int resultSetType,
+int resultSetConcurrency, int resultSetHoldability) throws 
SQLException {
+this(connection, sql, resultSetType, resultSetConcurrency, 
resultSetHoldability, null);
+if (connection.props_.t4Logger_.isLoggable(Level.FINE) == true) {
+Object p[] = T4LoggingUtilities.makeParams(connection.props_, 
connection, sql, resultSetType,
+resultSetConcurrency, resultSetHoldability);
+connection.props_.t4Logger_.logp(Level.FINE, 
"TrafT4MultiQueriesPreparedStatement", "", "", p);
+}
+
+}
+
+TrafT4MultiQueriesPreparedStatement(TrafT4Connection connection, 
String sql, int resultSetType,
+int resultSetConcurrency, int resultSetHoldability, String 
stmtLabel) throws SQLException {
+super(connection, sql, resultSetType, resultSetConcurrency, 
resultSetHoldability, stmtLabel);
+if (connection.props_.t4Logger_.isLoggable(Level.FINE) == true) {
+Object p[] = T4LoggingUtilities.makeParams(connection.props_, 
connection, sql, resultSetType,
+resultSetConcurrency, resultSetHoldability, stmtLabel);
+connection.props_.t4Logger_.logp(Level.FINE, 
"TrafT4MultiQueriesPreparedStatement", "", "", p);
+}
+
+if (resultSetType != ResultSet.TYPE_FORWARD_ONLY && resultSetType 
!= ResultSet.TYPE_SCROLL_INSENSITIVE
+&& resultSetType != ResultSet.TYPE_SCROLL_SENSITIVE) {
+throw TrafT4Messages.createSQLException(connection_.props_, 
connection_.getLocale(),
+"invalid_resultset_type", null);
+}
+if (resultSetConcurrency != ResultSet.CONCUR_READ_ONLY && 
resultSetConcurrency != ResultSet.CONCUR_UPDATABLE) {
+throw TrafT4Messages.createSQLException(connection_.props_, 
connection_.getLocale(),
   

[GitHub] trafodion pull request #1514: [TRAFODION-3022] Add web site link to Apache C...

2018-04-11 Thread svarnau
GitHub user svarnau opened a pull request:

https://github.com/apache/trafodion/pull/1514

[TRAFODION-3022] Add web site link to Apache Current Events

This adds the ApacheCon (or whatever ASF current event is next) icon on the 
top-right of the web pages, opposite of the Dragon logo.

Icon can be previewed here: 
https://www.apache.org/events/current-event-125x125.png 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/trafodion web3022

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1514.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1514


commit 40058343ca89f66a1e7b6abcef1f5329db6231f6
Author: Steve Varnau 
Date:   2018-04-11T17:55:30Z

[TRAFODION-3022] Add web site link to Apache Current Events




---


[GitHub] trafodion pull request #1477: [TRAFODION-2985] Revert 2.2.0 download links t...

2018-03-14 Thread svarnau
GitHub user svarnau opened a pull request:

https://github.com/apache/trafodion/pull/1477

[TRAFODION-2985] Revert 2.2.0 download links to mirror pointers



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/trafodion web2985

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1477.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1477


commit 47c9f7425aab9af74f57354c3ad741d25c81e68d
Author: Steve Varnau 
Date:   2018-03-15T01:17:52Z

[TRAFODION-2985] Revert 2.2.0 web links to mirror pointers




---


[GitHub] trafodion pull request #1467: [TRAFODION-2985] Update Project Web Site for A...

2018-03-09 Thread svarnau
Github user svarnau commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1467#discussion_r173606905
  
--- Diff: docs/src/site/markdown/download.md ---
@@ -37,34 +72,34 @@ To build Trafodion from source code, see the [Trafodion 
Contributor Guide](https
 * [Ambari Plugin][ap210]  -  [PGP][appgp210] [MD5][apmd5210] 
[SHA1][apsha210]
 * [Documentation](documentation.html#210_Release)
 
-[src210]: 
http://www.apache.org/dyn/closer.lua/trafodion/apache-trafodion-2.1.0-incubating/src/apache-trafodion-2.1.0-incubating-src.tar.gz
-[pgp210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/src/apache-trafodion-2.1.0-incubating-src.tar.gz.asc
-[md5210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/src/apache-trafodion-2.1.0-incubating-src.tar.gz.md5
-[sha210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/src/apache-trafodion-2.1.0-incubating-src.tar.gz.sha
-[ins210]: 
http://www.apache.org/dyn/closer.lua/trafodion/apache-trafodion-2.1.0-incubating/bin/apache-trafodion_installer-2.1.0-incubating.tar.gz
-[inpgp210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/apache-trafodion_installer-2.1.0-incubating.tar.gz.asc
-[inmd5210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/apache-trafodion_installer-2.1.0-incubating.tar.gz.md5
-[insha210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/apache-trafodion_installer-2.1.0-incubating.tar.gz.sha
-[pins210]: 
http://www.apache.org/dyn/closer.lua/trafodion/apache-trafodion-2.1.0-incubating/bin/apache-trafodion_pyinstaller-2.1.0-incubating.tar.gz
-[pinpgp210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/apache-trafodion_pyinstaller-2.1.0-incubating.tar.gz.asc
-[pinmd5210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/apache-trafodion_pyinstaller-2.1.0-incubating.tar.gz.md5
-[pinsha210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/apache-trafodion_pyinstaller-2.1.0-incubating.tar.gz.sha
-[ser210]: 
http://www.apache.org/dyn/closer.lua/trafodion/apache-trafodion-2.1.0-incubating/bin/apache-trafodion_server-2.1.0-RH6-x86_64-incubating.tar.gz
-[sepgp210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/apache-trafodion_server-2.1.0-RH6-x86_64-incubating.tar.gz.asc
-[semd5210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/apache-trafodion_server-2.1.0-RH6-x86_64-incubating.tar.gz.md5
-[sesha210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/apache-trafodion_server-2.1.0-RH6-x86_64-incubating.tar.gz.sha
-[cl210]: 
http://www.apache.org/dyn/closer.lua/trafodion/apache-trafodion-2.1.0-incubating/bin/apache-trafodion_clients-2.1.0-RH6-x86_64-incubating.tar.gz
-[clpgp210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/apache-trafodion_clients-2.1.0-RH6-x86_64-incubating.tar.gz.asc
-[clmd5210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/apache-trafodion_clients-2.1.0-RH6-x86_64-incubating.tar.gz.md5
-[clsha210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/apache-trafodion_clients-2.1.0-RH6-x86_64-incubating.tar.gz.sha
-[ar210]: 
http://www.apache.org/dyn/closer.lua/trafodion/apache-trafodion-2.1.0-incubating/bin/traf_ambari_rpms/apache-trafodion_server-2.1.0-1.x86_64.rpm
-[arpgp210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/traf_ambari_rpms/apache-trafodion_server-2.1.0-1.x86_64.rpm.asc
-[armd5210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/traf_ambari_rpms/apache-trafodion_server-2.1.0-1.x86_64.rpm.md5
-[arsha210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/traf_ambari_rpms/apache-trafodion_server-2.1.0-1.x86_64.rpm.sha
-[ap210]: 
http://www.apache.org/dyn/closer.lua/trafodion/apache-trafodion-2.1.0-incubating/bin/traf_ambari_rpms/traf_ambari-2.1.0-1.noarch.rpm
-[appgp210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/traf_ambari_rpms/traf_ambari-2.1.0-1.noarch.rpm.asc
-[apmd5210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/traf_ambari_rpms/traf_ambari-2.1.0-1.noarch.rpm.md5
-[apsha210]: 
http://www.apache.org/dist/trafodion/apache-trafodion-2.1.0-incubating/bin/traf_ambari_rpms/traf_ambari-2.1.0-1.noarch.rpm.sha
+[src210]: 
http://archive.apache.org/dyn/closer.lua/trafodion/apache-trafodion-2.1.0-incubating/src/apache-trafodion-2.1.0-incubating-src.tar.gz
--- End diff --

Good to change these to archive, but I think the URL is not quite right. 
"dyn/closer.lua" should be replaced by "dist".


---


[GitHub] trafodion pull request #1427: TRAFODION-2940 In HA env, one node lose networ...

2018-02-15 Thread svarnau
Github user svarnau commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1427#discussion_r168625988
  
--- Diff: dcs/bin/scripts/dcsunbind.sh ---
@@ -51,6 +51,31 @@ function check_node {
 done
 }
 
+function check_self_node {
+for myinterface in `/sbin/ip link show|cut -d: -f1- | cut -c1- | awk 
-F': ' '/^[0-9]+:.*/ {print $2;}'`; do
+ip_output=$(/sbin/ip addr show $myinterface | cut -d: -f1- | cut 
-c1-)
+
+myifport=`echo "$ip_output" | grep -w $gv_float_external_ip`
+status=$?
+if [ $status -eq 0 ]; then
+tempinterface=`echo $gv_float_interface:$gv_port`
+# check if another interface is bound to this virtual ip 
address
+echo "$myifport" | grep "$tempinterface"  > /dev/null
+if [ $? -eq 0 ]; then
+unbindip=`echo "$myifport" | awk '{print $2}'`
+unbindlb=`echo "$myifport"|awk '{print $NF}'`
+echo "Virtual ip $gv_float_external_ip is in use on node 
$HOSTNAME bound to interface $myinterface($unbindlb) - unbinding..."
+sudo /sbin/ip addr del $unbindip dev $myinterface
+status=$?
--- End diff --

It seems unnecessary to duplicate entire function just to change whether 
commands run locally or remotely. That can be done with a variable, so that we 
don't have two copies of this code to maintain.


---


[GitHub] trafodion pull request #1445: [TRAFODION-2959] Change download URLs for old ...

2018-02-15 Thread svarnau
GitHub user svarnau opened a pull request:

https://github.com/apache/trafodion/pull/1445

[TRAFODION-2959] Change download URLs for old releases

Old releases need to be from archives site.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/trafodion j2959

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1445.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1445


commit 59e2c8e457f14b6721a4582a629c82aa277f6d87
Author: Steve Varnau 
Date:   2018-02-15T20:00:28Z

[TRAFODION-2959] Change download URLs for old releases

Old releases need to be from archives site.




---


[GitHub] trafodion pull request #1424: [TRAFODION-2871] Add web references to securit...

2018-01-30 Thread svarnau
GitHub user svarnau opened a pull request:

https://github.com/apache/trafodion/pull/1424

[TRAFODION-2871] Add web references to security mailing list



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/trafodion j2871

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1424.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1424


commit e0b1dbc5d3ba15ac5b5b93cf7f1905be65c4b0d8
Author: Steve Varnau 
Date:   2018-01-31T00:43:41Z

[TRAFODION-2871] Add web references to security mailing list




---


[GitHub] trafodion pull request #1402: [TRAFODION-2857] Remove remaining "incubator" ...

2018-01-16 Thread svarnau
GitHub user svarnau opened a pull request:

https://github.com/apache/trafodion/pull/1402

[TRAFODION-2857] Remove remaining "incubator" path on downloads page

As Seth pointed out on the user list, I missed updating paths on the
downloads web page.  The old release names still have "incubating" in
the dir and file names, but the whole trafodion dist site has moved
out of the incubator directory.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/trafodion j2857_3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1402.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1402


commit c26bac1668723721b1f8115c8c5f7e6b334a90ff
Author: Steve Varnau 
Date:   2018-01-16T18:08:34Z

[TRAFODION-2857] Remove remaining "incubator" path on downloads page

As Seth pointed out on the user list, I missed updating paths on the
downloads web page.  The old release names still have "incubating" in
the dir and file names, but the whole trafodion dist site has moved
out of the incubator directory.




---


[GitHub] trafodion pull request #1393: [TRAFODION-2861] Backport to release2.2 branch

2018-01-11 Thread svarnau
GitHub user svarnau opened a pull request:

https://github.com/apache/trafodion/pull/1393

[TRAFODION-2861] Backport to release2.2 branch

This includes doc changes for 2.2 docs to be generated without incubating 
references. (Main website is generated from master branch.)

Also includes packaging changes to remove incubating. 2.2.0 will be first 
TLP release.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/trafodion tlp_2.2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1393.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1393


commit f077620ae434bfdc115a599a591bec1f5eb7bff6
Author: Steve Varnau 
Date:   2017-12-22T19:23:57Z

[TRAFODION-2857] Web-site changes to remove incubating status

Project status and URL changes.
Email lists and git repo name changes still to come based on infra changes.

commit 6047c512707f72fd32f4b6e7e91bd3834c272b10
Author: Steve Varnau 
Date:   2017-12-29T19:03:25Z

[TRAFODION-2857] Adding repo and email address name changes.

commit 6429a0c2839dd22eefbd6ed368236492e8f730fc
Author: Steve Varnau 
Date:   2018-01-04T20:07:47Z

[TRAFODION-2861][TRAFODION-2869] Remove incubating from release packaging

Remove disclaimer file and incubating string from packaging file names.




---


[GitHub] trafodion pull request #1371: [TRAFODION-2863] Web-page style sheets should ...

2018-01-04 Thread svarnau
GitHub user svarnau opened a pull request:

https://github.com/apache/trafodion/pull/1371

[TRAFODION-2863] Web-page style sheets should be protocol relative

To be compatible with http or https

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/trafodion j2863

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1371.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1371


commit 98a07c3f1e5843b061d197a6427400f521d793dd
Author: Steve Varnau 
Date:   2018-01-04T23:02:01Z

[TRAFODION-2863] Web-page style sheets should be protocol relative

To be compatible with http or https




---


[GitHub] trafodion pull request #1370: [TRAFODION-2861][TRAFODION-2869] Remove incuba...

2018-01-04 Thread svarnau
GitHub user svarnau opened a pull request:

https://github.com/apache/trafodion/pull/1370

[TRAFODION-2861][TRAFODION-2869] Remove incubating from release packaging

Remove disclaimer file and incubating string from packaging file names.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/trafodion pkg-tlp

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafodion/pull/1370.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1370


commit 34bf83acb40350b646b1e906445423b2c041412f
Author: Steve Varnau 
Date:   2018-01-04T20:07:47Z

[TRAFODION-2861][TRAFODION-2869] Remove incubating from release packaging

Remove disclaimer file and incubating string from packaging file names.




---


[GitHub] trafodion pull request #1359: [TRAFODION-2857] Web-site changes to remove in...

2018-01-03 Thread svarnau
Github user svarnau commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1359#discussion_r159534056
  
--- Diff: README.md ---
@@ -20,11 +20,11 @@ Hadoop.
   
   http://trafodion.apache.org/release-notes.html
 
-  - the latest Apache Trafodion can be downloaded from Apache incubator
+  - the latest Apache Trafodion can be downloaded from Apache
 distribution site or accessed from git:
 
 - download site:
-  https://dist.apache.org/repos/dist/release/incubator/trafodion
+  https://dist.apache.org/repos/dist/release/trafodion
--- End diff --

Infra team has taken care of moving the dist directory.


---


[GitHub] trafodion pull request #1359: [TRAFODION-2857] Web-site changes to remove in...

2017-12-29 Thread svarnau
Github user svarnau commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1359#discussion_r159092008
  
--- Diff: README.md ---
@@ -20,11 +20,11 @@ Hadoop.
   
   http://trafodion.apache.org/release-notes.html
 
-  - the latest Apache Trafodion can be downloaded from Apache incubator
+  - the latest Apache Trafodion can be downloaded from Apache
 distribution site or accessed from git:
 
 - download site:
-  https://dist.apache.org/repos/dist/release/incubator/trafodion
+  https://dist.apache.org/repos/dist/release/trafodion
--- End diff --

Good point. I was anticipating this change.  I thought I could move the 
dist site with a couple svn commands, but I lack permission, so I have inquired 
with infrastructure team.


---


[GitHub] trafodion pull request #1359: [TRAFODION-2857] Web-site changes to remove in...

2017-12-29 Thread svarnau
Github user svarnau commented on a diff in the pull request:

https://github.com/apache/trafodion/pull/1359#discussion_r159091858
  
--- Diff: README ---
@@ -13,16 +13,16 @@ To get started using Apache Trafodion:
 
   - documentation for this release can be viewed on the Apache Trafodion 
 wiki page: 
-  http://trafodion.incubator.apache.org/documentation.html
+  http://trafodion.apache.org/documentation.html
 
   - release notes describing changes for particular releases can be viewed:
   http://trafodion.apache.org/release-notes.html
 
-  - the latest Apache Trafodion can be downloaded from Apache incubator
+  - the latest Apache Trafodion can be downloaded from Apache
--- End diff --

Okay, I will add "the"


---


[GitHub] incubator-trafodion pull request #1359: [TRAFODION-2857] Web-site changes to...

2017-12-23 Thread svarnau
Github user svarnau commented on a diff in the pull request:


https://github.com/apache/incubator-trafodion/pull/1359#discussion_r158595694
  
--- Diff: docs/client_install/src/asciidoc/_chapters/preparation.adoc ---
@@ -220,7 +219,7 @@ $ unzip trafci.zip -d $HOME/trafodion/trafci
 .
 $ cd ..
 $ ls
-apache-trafodion_clients-2.0.1-incubating.tar.gz  clients  jdbct4  trafci
+apache-trafodion_clients-2.2.0.tar.gz  clients  jdbct4  trafci
--- End diff --

This is example in documentation on master branch, for next release. Not 
for past releases that were incubating releases.


---


[GitHub] incubator-trafodion pull request #1359: [TRAFODION-2857] Web-site changes to...

2017-12-22 Thread svarnau
GitHub user svarnau opened a pull request:

https://github.com/apache/incubator-trafodion/pull/1359

[TRAFODION-2857] Web-site changes to remove incubating status

Project status and URL changes.
Email lists and git repo name changes still to come based on infra changes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/svarnau/incubator-trafodion j2857

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafodion/pull/1359.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1359


commit 5dc33bf06451263ad0f5dde3313e959e39ac931a
Author: Steve Varnau 
Date:   2017-12-22T19:23:57Z

[TRAFODION-2857] Web-site changes to remove incubating status

Project status and URL changes.
Email lists and git repo name changes still to come based on infra changes.




---