commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2024-08-05 17:20:43 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.7232 (New) Package is "virt-manager" Mon Aug 5 17:20:43 2024 rev:260 rq:1191255 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2024-07-28 17:18:52.742439326 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.7232/virt-manager.changes 2024-08-05 17:20:45.069835657 +0200 @@ -1,0 +2,7 @@ +Mon Jul 29 15:29:29 MDT 2024 - carn...@suse.com + +- bsc#1228384 - virt-install generates unwanted libvirt storage + pools when running with --dry-run --print-xml + virtinst-dont-create-storage-pool-for-dryrun.patch + +--- New: virtinst-dont-create-storage-pool-for-dryrun.patch BETA DEBUG BEGIN: New: pools when running with --dry-run --print-xml virtinst-dont-create-storage-pool-for-dryrun.patch BETA DEBUG END: Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.5cYvSn/_old 2024-08-05 17:20:47.389930718 +0200 +++ /var/tmp/diff_new_pack.5cYvSn/_new 2024-08-05 17:20:47.389930718 +0200 @@ -154,6 +154,7 @@ Patch228: virtinst-media-detection.patch Patch229: virtinst-enable-video-virtio-for-arm.patch Patch230: virtinst-add-hyperv-performance-options.patch +Patch231: virtinst-dont-create-storage-pool-for-dryrun.patch # Bug Fixes Patch251: virtman-increase-setKeepAlive-count.patch Patch252: virtman-allow-destroy-from-shutdown-menu-of-crashed-vm.patch @@ -331,6 +332,10 @@ donttest="$donttest or testCLI0416virt_clone or testCLI0417virt_clone" donttest="$donttest or testCLI0419virt_clone or testCLI0420virt_clone" donttest="$donttest or testCLI0428virt_clone" +# bsc#1228384: --dry-run no longer creates a storage pool when used +donttest="$donttest or testCLI0007virt_install_storage_creation" +donttest="$donttest or testCLI0132virt_install_remote_storage" +donttest="$donttest or testCLI0350virt_xml_edit_clear_disk" # pytest -v -rfEs -k "not ($donttest)" %endif ++ virtinst-dont-create-storage-pool-for-dryrun.patch ++ Reference: bsc#1228384 Don't create a storage pool for a dry run Index: virt-manager-4.1.0/virtinst/cli.py === --- virt-manager-4.1.0.orig/virtinst/cli.py +++ virt-manager-4.1.0/virtinst/cli.py @@ -69,6 +69,14 @@ def _reset_global_state(): _globalstate = _GlobalState() +_dryrun = False + +def get_dryrun(): +return _dryrun +def set_dryrun(val): +global _dryrun +_dryrun = val + VIRT_PARSERS = [] @@ -646,6 +654,7 @@ def add_misc_options(grp, prompt=False, help=argparse.SUPPRESS) if dryrun: +set_dryrun(True) grp.add_argument("--dry-run", action="store_true", dest="dry", help=_("Run through install process, but do not " "create devices or define the guest.")) @@ -3615,7 +3624,7 @@ class ParserDisk(VirtCLIParser): ### def set_path_cb(self, inst, val, virtarg): -inst.set_source_path(val) +inst.set_source_path(val, get_dryrun()) def path_lookup_cb(self, inst, val, virtarg): return inst.get_source_path() == val Index: virt-manager-4.1.0/virtinst/devices/disk.py === --- virt-manager-4.1.0.orig/virtinst/devices/disk.py +++ virt-manager-4.1.0/virtinst/devices/disk.py @@ -635,7 +635,7 @@ class DeviceDisk(Device): self._resolve_storage_backend() return self._storage_backend.get_path() -def set_source_path(self, newpath): +def set_source_path(self, newpath, dryrun=False): if self._storage_backend.will_create_storage(): raise xmlutil.DevError( "Can't change disk path if storage creation info " @@ -644,7 +644,7 @@ class DeviceDisk(Device): # User explicitly changed 'path', so try to lookup its storage # object since we may need it (newpath, vol_object, parent_pool) = diskbackend.manage_path( -self.conn, newpath) +self.conn, newpath, dryrun) self._change_backend(newpath, vol_object, parent_pool) self._set_xmlpath(self.get_source_path()) Index: virt-manager-4.1.0/virtinst/diskbackend.py === --- virt-manager-4.1.0.orig/virtinst/diskbackend.py +++
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2024-07-28 17:18:49 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1882 (New) Package is "virt-manager" Sun Jul 28 17:18:49 2024 rev:259 rq:1189664 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2024-07-03 20:29:55.688247833 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1882/virt-manager.changes 2024-07-28 17:18:52.742439326 +0200 @@ -1,0 +2,7 @@ +Tue Jul 23 14:12:20 MDT 2024 - carn...@suse.com + +- bsc#1228227 - libvirt missing default hyperv options causes + windows guest performance degredation. + virtinst-add-hyperv-performance-options.patch + +--- New: virtinst-add-hyperv-performance-options.patch BETA DEBUG BEGIN: New: windows guest performance degredation. virtinst-add-hyperv-performance-options.patch BETA DEBUG END: Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.u7jRAI/_old 2024-07-28 17:18:56.582592821 +0200 +++ /var/tmp/diff_new_pack.u7jRAI/_new 2024-07-28 17:18:56.582592821 +0200 @@ -153,6 +153,7 @@ Patch227: virtinst-add-pvh-support.patch Patch228: virtinst-media-detection.patch Patch229: virtinst-enable-video-virtio-for-arm.patch +Patch230: virtinst-add-hyperv-performance-options.patch # Bug Fixes Patch251: virtman-increase-setKeepAlive-count.patch Patch252: virtman-allow-destroy-from-shutdown-menu-of-crashed-vm.patch ++ virtinst-add-hyperv-performance-options.patch ++ References: bsc#1228227 These additional options if used will improve performance for windows VMs. vpindex makes sense in conjunction with synic and stimer synic requires vpindex stimer requires vpindex and synic --- virt-manager-4.1.0/virtinst/domain/features.py.orig 2024-07-23 14:08:31.059017630 -0600 +++ virt-manager-4.1.0/virtinst/domain/features.py 2024-07-23 14:09:33.071019107 -0600 @@ -32,7 +32,9 @@ class DomainFeatures(XMLBuilder): hyperv_spinlocks = XMLProperty("./hyperv/spinlocks/@state", is_onoff=True) hyperv_spinlocks_retries = XMLProperty("./hyperv/spinlocks/@retries", is_int=True) +hyperv_vpindex = XMLProperty("./hyperv/vpindex/@state", is_onoff=True) hyperv_synic = XMLProperty("./hyperv/synic/@state", is_onoff=True) +hyperv_stimer = XMLProperty("./hyperv/stimer/@state", is_onoff=True) vmport = XMLProperty("./vmport/@state", is_onoff=True) kvm_hidden = XMLProperty("./kvm/hidden/@state", is_onoff=True) @@ -84,3 +86,9 @@ class DomainFeatures(XMLBuilder): self.hyperv_spinlocks = True if self.hyperv_spinlocks_retries is None: self.hyperv_spinlocks_retries = 8191 +if self.hyperv_vpindex is None: +self.hyperv_vpindex = True +if self.hyperv_synic is None: +self.hyperv_synic = True +if self.hyperv_stimer is None: +self.hyperv_stimer = True --- virt-manager-4.1.0/virtinst/cli.py.orig 2024-07-23 13:37:39.086973500 -0600 +++ virt-manager-4.1.0/virtinst/cli.py 2024-07-23 13:38:28.030974666 -0600 @@ -2989,7 +2989,9 @@ class ParserFeatures(VirtCLIParser): "hyperv.relaxed.state": "hyperv_relaxed", "hyperv.spinlocks.state": "hyperv_spinlocks", "hyperv.spinlocks.retries": "hyperv_spinlocks_retries", +"hyperv.vpindex.state": "hyperv_vpindex", "hyperv.synic.state": "hyperv_synic", +"hyperv.stimer.state": "hyperv_stimer", } @classmethod @@ -3010,7 +3012,9 @@ class ParserFeatures(VirtCLIParser): cls.add_arg("hyperv.relaxed.state", "hyperv_relaxed", is_onoff=True) cls.add_arg("hyperv.spinlocks.state", "hyperv_spinlocks", is_onoff=True) cls.add_arg("hyperv.spinlocks.retries", "hyperv_spinlocks_retries") +cls.add_arg("hyperv.vpindex.state", "hyperv_vpindex", is_onoff=True) cls.add_arg("hyperv.synic.state", "hyperv_synic", is_onoff=True) +cls.add_arg("hyperv.stimer.state", "hyperv_stimer", is_onoff=True) cls.add_arg("vmport.state", "vmport", is_onoff=True) cls.add_arg("kvm.hidden.state", "kvm_hidden", is_onoff=True) --- virt-manager-4.1.0/tests/test_cli.py.orig 2024-07-23 14:37:19.511058816 -0600 +++ virt-manager-4.1.0/tests/test_cli.py2024-07-23 14:38:46.819060897 -0600 @@ -554,7 +554,7 @@ memorytune0.vcpus=0-3,memorytune0.node0. --metadata
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2024-07-01 11:19:27 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.18349 (New) Package is "virt-manager" Mon Jul 1 11:19:27 2024 rev:257 rq:1184046 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2024-06-21 16:03:04.421775532 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.18349/virt-manager.changes 2024-07-01 11:19:30.097161646 +0200 @@ -1,0 +2,6 @@ +Thu Jun 20 13:40:47 UTC 2024 - Markéta Machová + +- remove dependency on /usr/bin/python3 using + %python3_fix_shebang macro, [bsc#1212476] + +--- Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.4vE2v7/_old 2024-07-01 11:19:36.209384314 +0200 +++ /var/tmp/diff_new_pack.4vE2v7/_new 2024-07-01 11:19:36.213384460 +0200 @@ -290,6 +290,8 @@ install -m 755 %SOURCE3 %{buildroot}/usr/lib/supportconfig/plugins/virt_manager chmod -x %{buildroot}%{_datadir}/virt-manager/virtManager/virtmanager.py +%python3_fix_shebang + %find_lang %{name} %endif
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2024-06-21 16:02:43 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.18349 (New) Package is "virt-manager" Fri Jun 21 16:02:43 2024 rev:256 rq:1182047 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2024-06-12 15:37:15.831800523 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.18349/virt-manager.changes 2024-06-21 16:03:04.421775532 +0200 @@ -1,0 +2,5 @@ +Wed Jun 19 02:24:29 UTC 2024 - Steve Kowalik + +- Skip some tests that fail under Pytest 8.x. + +--- Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.QNirpa/_old 2024-06-21 16:03:07.429885872 +0200 +++ /var/tmp/diff_new_pack.QNirpa/_new 2024-06-21 16:03:07.433886019 +0200 @@ -1,5 +1,5 @@ # -# spec file +# spec file for package virt-manager # # Copyright (c) 2024 SUSE LLC # @@ -321,6 +321,13 @@ donttest="$donttest or testCheckXMLBuilderProps" # "These command line arguments or aliases are not checked in the test suite" donttest="$donttest or testCheckCLISuboptions" +# These tests fail with Pytest 8.x +donttest="$donttest or testCLI0142virt_install_location_manual_kernel" +donttest="$donttest or testCLI0397virt_clone_auto_unmanaged" +donttest="$donttest or testCLI0401virt_clone or testCLI0402virt_clone" +donttest="$donttest or testCLI0416virt_clone or testCLI0417virt_clone" +donttest="$donttest or testCLI0419virt_clone or testCLI0420virt_clone" +donttest="$donttest or testCLI0428virt_clone" # pytest -v -rfEs -k "not ($donttest)" %endif
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2024-06-12 15:37:14 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.19518 (New) Package is "virt-manager" Wed Jun 12 15:37:14 2024 rev:255 rq:1180071 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2024-05-28 17:27:30.957149581 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.19518/virt-manager.changes 2024-06-12 15:37:15.831800523 +0200 @@ -1,0 +2,8 @@ +Tue Jun 11 13:24:45 MDT 2024 - carn...@suse.com + +- bsc#1226173 - virt-manager: Browse local does not work anymore + 090-db1b2fbc-Use-GtkFileChooserNative.patch + Renamed 090-uitests-Fix-with-GtkFileChooserNative.patch to + 091-uitests-Fix-with-GtkFileChooserNative.patch + +--- Old: 090-uitests-Fix-with-GtkFileChooserNative.patch New: 090-db1b2fbc-Use-GtkFileChooserNative.patch 091-uitests-Fix-with-GtkFileChooserNative.patch BETA DEBUG BEGIN: Old: 090-db1b2fbc-Use-GtkFileChooserNative.patch Renamed 090-uitests-Fix-with-GtkFileChooserNative.patch to 091-uitests-Fix-with-GtkFileChooserNative.patch BETA DEBUG END: BETA DEBUG BEGIN: New:- bsc#1226173 - virt-manager: Browse local does not work anymore 090-db1b2fbc-Use-GtkFileChooserNative.patch Renamed 090-uitests-Fix-with-GtkFileChooserNative.patch to New: Renamed 090-uitests-Fix-with-GtkFileChooserNative.patch to 091-uitests-Fix-with-GtkFileChooserNative.patch BETA DEBUG END: Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.AZ03B6/_old 2024-06-12 15:37:19.123921072 +0200 +++ /var/tmp/diff_new_pack.AZ03B6/_new 2024-06-12 15:37:19.127921218 +0200 @@ -127,7 +127,8 @@ Patch87:087-Allow-serial-console-resize-to-beyond-80-columns.patch Patch88:088-tests-Fix-host-copy-XML-with-libvirt-10.1.0.patch Patch89:089-hostdev-Fix-error-when-mdev-type_id-is-missing.patch -Patch90:090-uitests-Fix-with-GtkFileChooserNative.patch +Patch90:090-db1b2fbc-Use-GtkFileChooserNative.patch +Patch91:091-uitests-Fix-with-GtkFileChooserNative.patch Patch100: revert-363fca41-virt-install-Require-osinfo-for-non-x86-HVM-case-too.patch # SUSE Only Patch150: virtman-desktop.patch ++ 090-db1b2fbc-Use-GtkFileChooserNative.patch ++ Subject: Use GtkFileChooserNative From: Michael Weghorn m.wegh...@posteo.de Wed Mar 20 07:41:29 2024 +0100 Date: Sun Apr 7 15:54:47 2024 -0400: Git: db1b2fbce3c287e8127b3c744b2f8d49ad8ed2bc Use GtkFileChooserNative [1] instead of GtkFileChooserDialog [2] to integrate better with the platform (e.g. use the portal implementation when run with GTK_USE_PORTAL=1, resulting in the KDE Frameworks implementation being used when xdg-desktop-portal-kde is in use). Quoting from the GtkFileChooserDialog doc [2]: > If you want to integrate well with the platform you should use the > GtkFileChooserNative API, which will use a platform-specific dialog if > available and fall back to GtkFileChooserDialog otherwise. Also replace the use of GTK_STOCK_CANCEL [3] and GTK_STOCK_OPEN [4] which were deprecated in GTK 3.10: Both, the `accept_label` and `cancel_label` params of `Gtk.FileChooserNative.new` can be `None` to use the default text ("Open", "Cancel"). [5] Adjust the only caller (in `vmmVMWindow#_takeScreenshot`) that was passing an explicit label/icon name for the accept button to pass `_("_Save")` as label, rather than the also deprecated Gtk.STOCK_SAVE [6]. (GtkFileChooserDialog has special handling for Gtk.STOCK_SAVE etc., but that's not generally the case for native dialogs). Rename the method param from `choose_button` to `choose_label` to make clearer that this is a label. [1] https://docs.gtk.org/gtk3/class.FileChooserNative.html [2] https://docs.gtk.org/gtk3/class.FileChooserDialog.html [3] https://docs.gtk.org/gtk3/const.STOCK_CANCEL.html [4] https://docs.gtk.org/gtk3/const.STOCK_OPEN.html [5] http://pygobject-doc.gitee.io/pgi-docs/Gtk-3.0/classes/FileChooserNative.html#Gtk.FileChooserNative.new [6] https://docs.gtk.org/gtk3/const.STOCK_SAVE.html Fixes #315 diff --git a/virtManager/error.py b/virtManager/error.py index 593c89ca..2b3a99f5 100644 --- a/virtManager/error.py +++ b/virtManager/error.py @@ -234,7 +234,7 @@ class vmmErrorDialog(vmmGObject): def browse_local(self, dialog_name, start_folder=None, _type=None, dialog_type=None, - choose_button=None, default_name=None, + choose_label=None, default_name=None,
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2024-05-17 20:03:54 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1880 (New) Package is "virt-manager" Fri May 17 20:03:54 2024 rev:253 rq:1174664 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2024-05-09 12:07:51.305835218 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1880/virt-manager.changes 2024-05-17 20:03:58.048790865 +0200 @@ -1,0 +2,6 @@ +Thu May 9 11:52:06 MDT 2024 - carn...@suse.com + +- Enable mdev tests with the introduction of libvirt 10.3.0 + virt-manager.spec + +--- Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.vCdLNG/_old 2024-05-17 20:04:05.781070262 +0200 +++ /var/tmp/diff_new_pack.vCdLNG/_new 2024-05-17 20:04:05.781070262 +0200 @@ -286,13 +286,6 @@ donttest="$donttest or testCLI0280virt_xml_build_disk_domain" donttest="$donttest or testCLI0287virt_xml_edit_cpu_host_copy" donttest="$donttest or testCLI0288virt_xml_build_pool_logical_disk" -# Disabled tests for libvirt 10.1.0 -donttest="$donttest or testDASDMdev" -donttest="$donttest or testAPQNMdev" -donttest="$donttest or testPCIMdev" -donttest="$donttest or testPCIMdevNewFormat" -donttest="$donttest or testCLI0369virt_xml_add_hostdev_mdev" -donttest="$donttest or testCLI0377virt_xml_add_hostdev_mdev_start" # End disabled tests for libvirt 10.1.0 donttest="$donttest or testCLI0375virt_xml_add_disk_create_storage_start" # Due to the above skips:
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2024-05-09 12:07:39 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1880 (New) Package is "virt-manager" Thu May 9 12:07:39 2024 rev:252 rq:1172595 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2024-03-08 18:07:27.850303919 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1880/virt-manager.changes 2024-05-09 12:07:51.305835218 +0200 @@ -1,0 +2,7 @@ +Tue May 7 13:30:54 MDT 2024 - carn...@suse.com + +- bsc#1222738 - virt-manager shows SLE Micro 6.0 in suggested OS + version should be SL Micro 6.0 + virtinst-add-slm-detection-support.patch + +--- New: virtinst-add-slm-detection-support.patch BETA DEBUG BEGIN: New: version should be SL Micro 6.0 virtinst-add-slm-detection-support.patch BETA DEBUG END: Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.jbVtMk/_old 2024-05-09 12:07:53.221904854 +0200 +++ /var/tmp/diff_new_pack.jbVtMk/_new 2024-05-09 12:07:53.221904854 +0200 @@ -148,10 +148,11 @@ Patch181: virtinst-add-slem-detection-support.patch Patch182: virtinst-add-sle-hpc-support.patch Patch183: virtinst-add-oracle-linux-support.patch -Patch184: virtinst-windows-server-detection.patch -Patch185: virtman-fix-shared-disk-request-alignment-error.patch -Patch186: virtman-language-fixes.patch -Patch187: virtman-fix-inspection-apps-window.patch +Patch184: virtinst-add-slm-detection-support.patch +Patch185: virtinst-windows-server-detection.patch +Patch186: virtman-fix-shared-disk-request-alignment-error.patch +Patch187: virtman-language-fixes.patch +Patch188: virtman-fix-inspection-apps-window.patch BuildArch: noarch ++ virtinst-add-slm-detection-support.patch ++ Add support for detecting SUSE Linux Micro 6.0 and newer. See also the osinfo-db package for the description file. Note that starting with Micro version 6.0, the word "Enterprise" was dropped from the Micro version name. Index: virt-manager-4.1.0/virtinst/install/urldetect.py === --- virt-manager-4.1.0.orig/virtinst/install/urldetect.py +++ virt-manager-4.1.0/virtinst/install/urldetect.py @@ -271,13 +271,16 @@ class _SUSEContent(object): ",", 1)[0].strip().rsplit(":")[4] distro_version = distro_version.strip() -if "Enterprise" in self.product_name or "SLES" in self.product_name: +if "Enterprise" in self.product_name or "SLES" in self.product_name or "Micro" in self.product_name: if " SAP " in self.product_name: sle_version = self.product_name.strip().rsplit(' ')[7] if " High Performance " in self.product_name: sle_version = self.product_name.strip().rsplit(' ')[6] else: -sle_version = self.product_name.strip().rsplit(' ')[4] +if "SUSE Linux Micro" in self.product_name: +sle_version = self.product_name.strip().rsplit(' ')[3] +else: +sle_version = self.product_name.strip().rsplit(' ')[4] if len(self.product_name.strip().rsplit(' ')) > 5 and not " Micro " in self.product_name: if " SAP " in self.product_name: sle_version = (sle_version + '.' + @@ -708,6 +711,14 @@ class _MICRODistro(_SuseDistro): famregex = ".*SUSE Linux Enterprise Micro.*" +class _SLMICRODistro(_SuseDistro): +PRETTY_NAME = "SLES" +matching_distros = ["slm"] +_variant_prefix = "slm" +_suse_regex = [".*SUSE Linux Micro*", ".*SUSE Micro*"] +famregex = ".*SUSE Linux Micro.*" + + class _CAASPDistro(_SuseDistro): PRETTY_NAME = "SLES" matching_distros = ["caasp"] @@ -977,6 +988,7 @@ def _build_distro_list(osobj): _SLEDDistro, _OpensuseDistro, _MICRODistro, +_SLMICRODistro, _CAASPDistro, _OESDistro, _DebianDistro,
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2024-03-08 18:07:27 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1770 (New) Package is "virt-manager" Fri Mar 8 18:07:27 2024 rev:251 rq:1156150 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2024-02-15 20:58:47.848566100 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1770/virt-manager.changes 2024-03-08 18:07:27.850303919 +0100 @@ -1,0 +2,6 @@ +Thu Mar 7 14:59:08 MST 2024 - carn...@suse.com + +- Disable mdev tests with introduction of libvirt 10.1.0 + virt-manager.spec + +--- Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.OjhkUN/_old 2024-03-08 18:07:29.426361837 +0100 +++ /var/tmp/diff_new_pack.OjhkUN/_new 2024-03-08 18:07:29.426361837 +0100 @@ -285,6 +285,14 @@ donttest="$donttest or testCLI0280virt_xml_build_disk_domain" donttest="$donttest or testCLI0287virt_xml_edit_cpu_host_copy" donttest="$donttest or testCLI0288virt_xml_build_pool_logical_disk" +# Disabled tests for libvirt 10.1.0 +donttest="$donttest or testDASDMdev" +donttest="$donttest or testAPQNMdev" +donttest="$donttest or testPCIMdev" +donttest="$donttest or testPCIMdevNewFormat" +donttest="$donttest or testCLI0369virt_xml_add_hostdev_mdev" +donttest="$donttest or testCLI0377virt_xml_add_hostdev_mdev_start" +# End disabled tests for libvirt 10.1.0 donttest="$donttest or testCLI0375virt_xml_add_disk_create_storage_start" # Due to the above skips: # "there are XML properties that are untested in the test suite"
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2024-02-15 20:58:43 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1815 (New) Package is "virt-manager" Thu Feb 15 20:58:43 2024 rev:250 rq:1146269 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2024-02-11 15:45:13.653927285 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1815/virt-manager.changes 2024-02-15 20:58:47.848566100 +0100 @@ -1,0 +2,7 @@ +Mon Feb 12 10:50:32 MST 2024 - carn...@suse.com + +- bsc#1219791 - [virt-manager][aarch64] Error launching details: + name 'log' is not defined + virtinst-enable-video-virtio-for-arm.patch + +--- Other differences: -- ++ virt-install.rb ++ --- /var/tmp/diff_new_pack.CbiQDd/_old 2024-02-15 20:58:49.680632261 +0100 +++ /var/tmp/diff_new_pack.CbiQDd/_new 2024-02-15 20:58:49.684632405 +0100 @@ -35,7 +35,6 @@ Yast.import "Popup" Yast.import "String" Yast.import "Arch" - Yast.import "FileUtils" #=== # Start virt-install (GUI) or vm-install if Text mode (commandline) @@ -50,7 +49,7 @@ end if UI.TextMode() -if FileUtils.Exists("/usr/bin/vm-install") +if File.file?("/usr/bin/vm-install") Builtins.y2milestone("Running virt-install in text mode is not supported. Running vm-install instead in command line mode.") status = UI.RunInTerminal("/usr/bin/vm-install") else ++ virtinst-enable-video-virtio-for-arm.patch ++ --- /var/tmp/diff_new_pack.CbiQDd/_old 2024-02-15 20:58:49.732634138 +0100 +++ /var/tmp/diff_new_pack.CbiQDd/_new 2024-02-15 20:58:49.736634283 +0100 @@ -157,7 +157,15 @@ === --- virt-manager-4.1.0.orig/virtinst/devices/video.py +++ virt-manager-4.1.0/virtinst/devices/video.py -@@ -32,8 +32,11 @@ class DeviceVideo(Device): +@@ -6,6 +6,7 @@ + + from .device import Device + from ..xmlbuilder import XMLProperty ++from ..logger import log + + + class DeviceVideo(Device): +@@ -32,8 +33,11 @@ class DeviceVideo(Device): if guest.os.is_pseries(): return "vga" if guest.os.is_arm_machvirt():
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2024-02-11 15:44:57 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1815 (New) Package is "virt-manager" Sun Feb 11 15:44:57 2024 rev:249 rq:1145533 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2024-01-26 22:45:36.860623527 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1815/virt-manager.changes 2024-02-11 15:45:13.653927285 +0100 @@ -1,0 +2,7 @@ +Fri Feb 9 14:13:18 MST 2024 - carn...@suse.com + +- Handle case where vm-install no longer exists on the host. This + is related to bsc#1219133. + virt-install.rb + +--- Other differences: -- ++ virt-install.rb ++ --- /var/tmp/diff_new_pack.XRB3A9/_old 2024-02-11 15:45:16.126016191 +0100 +++ /var/tmp/diff_new_pack.XRB3A9/_new 2024-02-11 15:45:16.130016335 +0100 @@ -35,6 +35,7 @@ Yast.import "Popup" Yast.import "String" Yast.import "Arch" + Yast.import "FileUtils" #=== # Start virt-install (GUI) or vm-install if Text mode (commandline) @@ -49,8 +50,12 @@ end if UI.TextMode() -Builtins.y2milestone("Running virt-install in text mode is not supported. Running vm-install instead in command line mode.") -status = UI.RunInTerminal("/usr/bin/vm-install") +if FileUtils.Exists("/usr/bin/vm-install") + Builtins.y2milestone("Running virt-install in text mode is not supported. Running vm-install instead in command line mode.") + status = UI.RunInTerminal("/usr/bin/vm-install") +else + Popup.Error(_("Please use the command line to execute virt-install with the appropriate options for creating a VM.")) +end else Builtins.y2milestone("Launching virt-manager to run virt-install in GUI mode.") if Arch.is_xen0 == false
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2024-01-21 23:08:04 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.16006 (New) Package is "virt-manager" Sun Jan 21 23:08:04 2024 rev:247 rq:1140020 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2023-12-12 19:32:49.241768554 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.16006/virt-manager.changes 2024-01-21 23:08:17.881378042 +0100 @@ -1,0 +2,7 @@ +Fri Jan 19 14:15:14 MST 2024 - carn...@suse.com + +- bsc#1218983 - [SLE15SP6] virt-manager:test testCLI0264virt_xml + fails with libvirt 10.0.0. Disable this test for now. + virt-manager.spec + +--- Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.gP697R/_old 2024-01-21 23:08:19.573439720 +0100 +++ /var/tmp/diff_new_pack.gP697R/_new 2024-01-21 23:08:19.577439866 +0100 @@ -1,7 +1,7 @@ # # spec file # -# Copyright (c) 2023 SUSE LLC +# Copyright (c) 2024 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -306,6 +306,7 @@ # different source image format donttest="$donttest or testCLI0199virt_install_bhyve_default_f27" donttest="$donttest or testCLI0200virt_install_bhyve_default_f27" +donttest="$donttest or testCLI0264virt_xml" # Due to the above skips: # "there are XML properties that are untested in the test suite" donttest="$donttest or testCheckXMLBuilderProps"
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2023-08-02 16:48:07 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.22712 (New) Package is "virt-manager" Wed Aug 2 16:48:07 2023 rev:244 rq:1101566 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2023-06-17 22:19:54.647392837 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.22712/virt-manager.changes 2023-08-02 16:48:20.524583220 +0200 @@ -1,0 +2,7 @@ +Mon Jul 31 11:01:58 MDT 2023 - carn...@suse.com + +- bsc#1213790 - Application tab in virt-manager is collapsed, + therefore I can't read anything + virtman-fix-inspection-apps-window.patch + +--- New: virtman-fix-inspection-apps-window.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.vfhkkc/_old 2023-08-02 16:48:22.800597064 +0200 +++ /var/tmp/diff_new_pack.vfhkkc/_new 2023-08-02 16:48:22.804597089 +0200 @@ -104,6 +104,7 @@ Patch186: virtman-language-fixes.patch Patch187: virtman-check-for-libvirt-modular-daemons.patch Patch188: virtman-fix-osinfo-tests.patch +Patch189: virtman-fix-inspection-apps-window.patch BuildArch: noarch ++ virtman-fix-inspection-apps-window.patch ++ References: bsc#1213790 --- virt-manager-4.1.0/ui/details.ui.orig 2023-07-31 10:58:34.089070956 -0600 +++ virt-manager-4.1.0/ui/details.ui2023-07-31 10:59:05.625072305 -0600 @@ -808,7 +808,7 @@ -False +True True 0
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2023-06-17 22:19:49 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.15902 (New) Package is "virt-manager" Sat Jun 17 22:19:49 2023 rev:243 rq:1093153 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2023-04-27 19:57:07.708583077 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.15902/virt-manager.changes 2023-06-17 22:19:54.647392837 +0200 @@ -1,0 +2,9 @@ +Tue Jun 13 16:48:17 MDT 2023 - carn...@suse.com + +- bsc#1212195 - libvirtd crashes when virt-manager connects + virt-manager qemu:///system on a fresh installation tumbleweed + virtman-check-for-libvirt-modular-daemons.patch +- Changes to osinfo-db cause some virt-manager tests to fail. + virtman-fix-osinfo-tests.patch + +--- New: virtman-check-for-libvirt-modular-daemons.patch virtman-fix-osinfo-tests.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.QhwMEZ/_old 2023-06-17 22:19:56.015401059 +0200 +++ /var/tmp/diff_new_pack.QhwMEZ/_new 2023-06-17 22:19:56.019401083 +0200 @@ -102,6 +102,8 @@ Patch184: virtinst-windows-server-detection.patch Patch185: virtman-fix-shared-disk-request-alignment-error.patch Patch186: virtman-language-fixes.patch +Patch187: virtman-check-for-libvirt-modular-daemons.patch +Patch188: virtman-fix-osinfo-tests.patch BuildArch: noarch ++ virtman-check-for-libvirt-modular-daemons.patch ++ References: bsc#1212195 --- virt-manager-4.1.0/virtManager/lib/connectauth.py.orig 2023-06-13 16:34:55.683255450 -0600 +++ virt-manager-4.1.0/virtManager/lib/connectauth.py 2023-06-13 16:35:22.499256089 -0600 @@ -206,6 +206,11 @@ def connect_error(conn, errmsg, tb, warn def setup_first_uri(config, tryuri): # Add /usr/sbin to the path in case non-root user launches virt-manager libvirtd_installed = bool(shutil.which("libvirtd", path=os.environ['PATH'] + os.pathsep + "/usr/sbin")) +# Check for new modular libvirt daemons +if libvirtd_installed is False: +libvirtd_installed = bool(shutil.which("virtqemud", path=os.environ['PATH'] + os.pathsep + "/usr/sbin")) +if libvirtd_installed is False: +libvirtd_installed = bool(shutil.which("virtxend", path=os.environ['PATH'] + os.pathsep + "/usr/sbin")) if config.CLITestOptions.fake_no_libvirtd: libvirtd_installed = False ++ virtman-fix-osinfo-tests.patch ++ # Fix tests --- virt-manager-4.1.0/tests/data/cli/compare/virt-install-osinfo-url.xml.orig 2023-06-14 10:38:08.152804131 -0600 +++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-osinfo-url.xml 2023-06-14 10:41:32.756809007 -0600 @@ -13,7 +13,7 @@ hvm /VIRTINST-TESTSUITE/vmlinuz /VIRTINST-TESTSUITE/initrd.img - method=http://archives.fedoraproject.org/pub/archive/fedora/linux/releases/26/Server/x86_64/os/ + method=https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/26/Server/x86_64/os/ --- virt-manager-4.1.0/tests/data/cli/compare/virt-install-osinfo-url-with-disk.xml.orig 2023-06-14 10:38:14.424804281 -0600 +++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-osinfo-url-with-disk.xml 2023-06-14 10:40:27.748807458 -0600 @@ -13,7 +13,7 @@ hvm /VIRTINST-TESTSUITE/vmlinuz /VIRTINST-TESTSUITE/initrd.img - method=http://archives.fedoraproject.org/pub/archive/fedora/linux/releases/26/Server/x86_64/os/ + method=https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/26/Server/x86_64/os/ --- virt-manager-4.1.0/tests/data/cli/compare/virt-install-osinfo-url-unattended.xml.orig 2023-06-14 10:38:24.920804531 -0600 +++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-osinfo-url-unattended.xml 2023-06-14 10:40:11.028807059 -0600 @@ -13,7 +13,7 @@ hvm /VIRTINST-TESTSUITE/vmlinuz /VIRTINST-TESTSUITE/initrd.img -ks=file:/fedora.ks inst.repo=http://archives.fedoraproject.org/pub/archive/fedora/linux/releases/26/Server/x86_64/os/ +ks=file:/fedora.ks inst.repo=https://archives.fedoraproject.org/pub/archive/fedora/linux/releases/26/Server/x86_64/os/ --- virt-manager-4.1.0/tests/data/cli/compare/virt-install-osinfo-unattended-treeapis.xml.orig 2023-06-14 10:39:35.908806222 -0600 +++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-osinfo-unattended-treeapis.xml 2023-06-14 10:39:52.756806624 -0600 @@ -13,7 +13,7 @@
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2023-04-27 19:57:06 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1533 (New) Package is "virt-manager" Thu Apr 27 19:57:06 2023 rev:242 rq:1082818 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2023-04-08 17:38:22.857810733 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1533/virt-manager.changes 2023-04-27 19:57:07.708583077 +0200 @@ -1,0 +2,13 @@ +Tue Apr 25 06:14:10 MDT 2023 - carn...@suse.com + +- bsc#1201748 - virt-install --graphics vnc fails with not support + for video model 'virtio' + virtinst-enable-video-virtio-for-arm.patch + +--- +Mon Apr 17 13:24:16 MDT 2023 - carn...@suse.com + +- Drop virtman-check-for-valid-display.patch. This patch is no + longer required. + +--- Old: virtman-check-for-valid-display.patch New: virtinst-enable-video-virtio-for-arm.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.mSX8HG/_old 2023-04-27 19:57:08.708588955 +0200 +++ /var/tmp/diff_new_pack.mSX8HG/_new 2023-04-27 19:57:08.712588978 +0200 @@ -36,7 +36,7 @@ License:GPL-2.0-or-later Group: System/Monitoring URL:http://virt-manager.org/ -Source0: https://virt-manager.org/download/sources/virt-manager/virt-manager-%{version}.tar.gz +Source0: https://releases.pagure.org/virt-manager/virt-manager-%{version}.tar.gz Source1:virt-install.rb Source2:virt-install.desktop Source3:virt-manager-supportconfig @@ -74,17 +74,17 @@ Patch126: virtinst-add-sle15-detection-support.patch Patch127: virtinst-add-pvh-support.patch Patch128: virtinst-media-detection.patch +Patch129: virtinst-enable-video-virtio-for-arm.patch # Bug Fixes Patch151: virtman-increase-setKeepAlive-count.patch Patch152: virtman-allow-destroy-from-shutdown-menu-of-crashed-vm.patch -Patch153: virtman-check-for-valid-display.patch -Patch154: virtman-allow-creating-i686-vm.patch -Patch155: virtman-dont-specify-vte-version.patch -Patch156: virtman-dont-specify-gtksource-version.patch -Patch157: virtman-fix-restore-vm-menu-selection.patch -Patch158: virtman-disallow-adding-floppy-disk.patch -Patch159: virtman-register-delete-event-for-details-dialog.patch -Patch160: virtman-revert-use-of-AyatanaAppIndicator3.patch +Patch153: virtman-allow-creating-i686-vm.patch +Patch154: virtman-dont-specify-vte-version.patch +Patch155: virtman-dont-specify-gtksource-version.patch +Patch156: virtman-fix-restore-vm-menu-selection.patch +Patch157: virtman-disallow-adding-floppy-disk.patch +Patch158: virtman-register-delete-event-for-details-dialog.patch +Patch159: virtman-revert-use-of-AyatanaAppIndicator3.patch Patch170: virtinst-xen-drive-type.patch Patch171: virtinst-xenbus-disk-index-fix.patch Patch172: virtinst-refresh_before_fetch_pool.patch @@ -246,6 +246,9 @@ # Expectsion element donttest="$donttest or testCLI0168virt_install_s390x_cdrom" donttest="$donttest or testCLI0169virt_install_s390x_cdrom" +# Fedora specific +donttest="$donttest or testCLI0178virt_install_arm_defaultmach_f20" +donttest="$donttest or testCLI0179virt_install_arm_kvm_import" # missing element, extra element donttest="$donttest or testCLI0189virt_install_xen_default" donttest="$donttest or testCLI0190virt_install_xen_default" ++ virtinst-enable-video-virtio-for-arm.patch ++ References: bsc#1201748 Enable video virtio on arm if domain caps reports it is supported. Index: virt-manager-4.1.0/tests/data/cli/compare/virt-install-aarch64-cdrom.xml === --- virt-manager-4.1.0.orig/tests/data/cli/compare/virt-install-aarch64-cdrom.xml +++ virt-manager-4.1.0/tests/data/cli/compare/virt-install-aarch64-cdrom.xml @@ -63,6 +63,18 @@ + + + + + + + + + + + + /dev/urandom @@ -131,6 +143,18 @@ + + + + + + + + + + + + /dev/urandom Index: virt-manager-4.1.0/tests/data/cli/compare/virt-install-aarch64-firmware-no-override.xml === ---
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2023-04-08 17:38:21 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.19717 (New) Package is "virt-manager" Sat Apr 8 17:38:21 2023 rev:241 rq:1077929 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2023-01-29 14:21:48.022594138 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.19717/virt-manager.changes 2023-04-08 17:38:22.857810733 +0200 @@ -1,0 +2,7 @@ +Thu Apr 6 15:06:51 MDT 2023 - carn...@suse.com + +- Language file fixes + bsc#1209800, bsc#1197945, bsc#1197947, bsc#1198041 + virtman-language-fixes.patch + +--- New: virtman-language-fixes.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.sF8gr8/_old 2023-04-08 17:38:24.621820860 +0200 +++ /var/tmp/diff_new_pack.sF8gr8/_new 2023-04-08 17:38:24.625820883 +0200 @@ -101,6 +101,7 @@ Patch183: virtinst-add-oracle-linux-support.patch Patch184: virtinst-windows-server-detection.patch Patch185: virtman-fix-shared-disk-request-alignment-error.patch +Patch186: virtman-language-fixes.patch BuildArch: noarch ++ virtman-language-fixes.patch ++ 3252 lines (skipped)
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2023-01-29 14:10:11 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.32243 (New) Package is "virt-manager" Sun Jan 29 14:10:11 2023 rev:240 rq:1061650 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2022-11-29 10:52:59.728686170 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.32243/virt-manager.changes 2023-01-29 14:21:48.022594138 +0100 @@ -1,0 +2,16 @@ +Fri Jan 20 11:20:21 MST 2023 - carn...@suse.com + +- bsc#1207070 - libvirt fails to start the guest once the new + shared disk is added, with the error, "cannot get 'write' + permission without 'resize' image size is not a multiple of + request alignment" + virtman-fix-shared-disk-request-alignment-error.patch + +--- +Thu Jan 5 10:45:46 MST 2023 - carn...@suse.com + +- Replace downstream patch with upstream version (bsc#1203252) + 67832d30-addhardware-Fix-backtrace-when-controller-index-is-None.patch + Drop virtman-fix-uninitialized-controller-index.patch + +--- Old: virtman-fix-uninitialized-controller-index.patch New: 67832d30-addhardware-Fix-backtrace-when-controller-index-is-None.patch virtman-fix-shared-disk-request-alignment-error.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.xnQ2Q7/_old 2023-01-29 14:21:48.858598672 +0100 +++ /var/tmp/diff_new_pack.xnQ2Q7/_new 2023-01-29 14:21:48.866598715 +0100 @@ -1,7 +1,7 @@ # # spec file # -# Copyright (c) 2022 SUSE LLC +# Copyright (c) 2023 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -51,6 +51,7 @@ Patch8: fbdf0516-cli-cpu-Add-maxphysaddr.mode-bits-options.patch Patch9: b0d05167-cloner-Sync-uuid-and-sysinfo-system-uuid.patch Patch10:999ccb85-virt-install-unattended-and-cloud-init-conflict.patch +Patch11: 67832d30-addhardware-Fix-backtrace-when-controller-index-is-None.patch # SUSE Only Patch70:virtman-desktop.patch Patch71:virtman-kvm.patch @@ -84,7 +85,6 @@ Patch158: virtman-disallow-adding-floppy-disk.patch Patch159: virtman-register-delete-event-for-details-dialog.patch Patch160: virtman-revert-use-of-AyatanaAppIndicator3.patch -Patch161: virtman-fix-uninitialized-controller-index.patch Patch170: virtinst-xen-drive-type.patch Patch171: virtinst-xenbus-disk-index-fix.patch Patch172: virtinst-refresh_before_fetch_pool.patch @@ -100,6 +100,7 @@ Patch182: virtinst-add-sle-hpc-support.patch Patch183: virtinst-add-oracle-linux-support.patch Patch184: virtinst-windows-server-detection.patch +Patch185: virtman-fix-shared-disk-request-alignment-error.patch BuildArch: noarch ++ 67832d30-addhardware-Fix-backtrace-when-controller-index-is-None.patch ++ Subject: addhardware: Fix backtrace when controller.index is None From: Cole Robinson crobi...@redhat.com Tue Dec 13 13:49:35 2022 -0500 Date: Tue Dec 13 13:49:35 2022 -0500: Git: 67832d3097cd6451833c30452d6991896e05933c When creating a new VM, in the customize wizard we can't depend on index= value being set (virtinst doesn't do it for example). For example, this causes a backtrace when adding two virtio-scsi controllers via the Customize wizard, or adding an extra virtio-scsi controller to an aarch64 CDROM install. Reported-by: Charles Arnold Signed-off-by: Cole Robinson --- a/virtManager/addhardware.py +++ b/virtManager/addhardware.py @@ -1560,7 +1560,7 @@ class vmmAddHardware(vmmGObjectUI): controller_num = [x for x in controllers if (x.type == controller_type)] if len(controller_num) > 0: -index_new = max([x.index for x in controller_num]) + 1 +index_new = max(int(x.index or 0) for x in controller_num) + 1 dev.index = index_new dev.type = controller_type ++ virtman-fix-shared-disk-request-alignment-error.patch ++ References: bsc#1207070 When creating a raw disk that is marked as 'shared', libvirt will round the allocation amount higher to a 4k boundary. This results in the qemu error shown below passed back to libvirt. Note that only raw disks can be marked shared (not qcow2) but the rounding should not harm qcow2 disks. libvirt.libvirtError: internal error: qemu unexpectedly closed the monitor:
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2022-11-29 10:52:52 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1597 (New) Package is "virt-manager" Tue Nov 29 10:52:52 2022 rev:239 rq:1038777 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2022-11-16 15:42:36.671668109 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1597/virt-manager.changes 2022-11-29 10:52:59.728686170 +0100 @@ -1,0 +2,8 @@ +Mon Nov 28 12:28:44 MST 2022 - carn...@suse.com + +- bsc#1205675 - [Build 20221122] virt-install: Specifying --boot no + longer implies no_install=yes + 1cb0be40-virtinstall-split-no_install-conditional-apart-to-track-code-coverage.patch + e94786c0-virtinstall-fix-regression-with-boot-and-no-install-method.patch + +--- New: 1cb0be40-virtinstall-split-no_install-conditional-apart-to-track-code-coverage.patch e94786c0-virtinstall-fix-regression-with-boot-and-no-install-method.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.N0F7S5/_old 2022-11-29 10:53:00.516690310 +0100 +++ /var/tmp/diff_new_pack.N0F7S5/_new 2022-11-29 10:53:00.520690331 +0100 @@ -45,10 +45,12 @@ Patch2: 11a887ec-cli-disk-Add-driver.metadata_cache-options.patch Patch3: 7295ebfb-tests-cli-Fix-test-output-after-previous-commit.patch Patch4: 58f5e36d-fsdetails-Fix-an-error-with-source.socket-of-virtiofs.patch -Patch5: c22a876e-tests-Add-a-compat-check-for-linux2020-in-amd-sev-test-case.patch -Patch6: fbdf0516-cli-cpu-Add-maxphysaddr.mode-bits-options.patch -Patch7: b0d05167-cloner-Sync-uuid-and-sysinfo-system-uuid.patch -Patch8: 999ccb85-virt-install-unattended-and-cloud-init-conflict.patch +Patch5: 1cb0be40-virtinstall-split-no_install-conditional-apart-to-track-code-coverage.patch +Patch6: e94786c0-virtinstall-fix-regression-with-boot-and-no-install-method.patch +Patch7: c22a876e-tests-Add-a-compat-check-for-linux2020-in-amd-sev-test-case.patch +Patch8: fbdf0516-cli-cpu-Add-maxphysaddr.mode-bits-options.patch +Patch9: b0d05167-cloner-Sync-uuid-and-sysinfo-system-uuid.patch +Patch10:999ccb85-virt-install-unattended-and-cloud-init-conflict.patch # SUSE Only Patch70:virtman-desktop.patch Patch71:virtman-kvm.patch @@ -215,13 +217,24 @@ # different device names donttest="test_disk_numtotarget" donttest="$donttest or testCLI0001virt_install_many_devices" -donttest="$donttest or testCLI0110virt_install_reinstall_cdrom" -donttest="$donttest or testCLI0284virt_xml_build_pool_logical_disk" -donttest="$donttest or testCLI0285virt_xml_build_pool_logical_disk" +donttest="$donttest or testCLI0113virt_install_reinstall_cdrom" +donttest="$donttest or testCLI0165virt_install" +donttest="$donttest or testCLI0172virt_install_s390x_cdrom" +donttest="$donttest or testCLI0193virt_install_xen_default" +donttest="$donttest or testCLI0194virt_install_xen_pv" +donttest="$donttest or testCLI0195virt_install_xen_hvm" +donttest="$donttest or testCLI0196virt_install_xen_hvm" +donttest="$donttest or testCLI0203virt_install_bhyve_default_f27" donttest="$donttest or testCLI0276virt_xml_build_disk_domain" donttest="$donttest or testCLI0277virt_xml_build_disk_domain" +donttest="$donttest or testCLI0280virt_xml_build_disk_domain" +donttest="$donttest or testCLI0284virt_xml_build_pool_logical_disk" +donttest="$donttest or testCLI0285virt_xml_build_pool_logical_disk" +donttest="$donttest or testCLI0287virt_xml_edit_cpu_host_copy" +donttest="$donttest or testCLI0288virt_xml_build_pool_logical_disk" donttest="$donttest or testCLI0371virt_xml_add_disk_create_storage_start" donttest="$donttest or testCLI0372virt_xml_add_disk_create_storage_start" +donttest="$donttest or testCLI0375virt_xml_add_disk_create_storage_start" # depends on osc/obs host cpu? donttest="$donttest or testCLI0003virt_install_singleton_config_2" donttest="$donttest or testCLI0283virt_xml_edit_cpu_host_copy" ++ 1cb0be40-virtinstall-split-no_install-conditional-apart-to-track-code-coverage.patch ++ Subject: virtinstall: split no_install conditional apart to track code coverage From: Cole Robinson crobi...@redhat.com Sat Aug 20 09:42:47 2022 -0400 Date: Sat Aug 20 09:47:49 2022 -0400: Git: 1cb0be4002445e5755ead2423b5a4e9e06f0a3cb Each bit here is part of the CLI API, we need to be sure we are covering each one. Extend the test suite to hit one case we are missing Signed-off-by: Cole
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2022-11-16 15:42:30 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1597 (New) Package is "virt-manager" Wed Nov 16 15:42:30 2022 rev:238 rq:1035877 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2022-11-08 10:53:40.049497733 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1597/virt-manager.changes 2022-11-16 15:42:36.671668109 +0100 @@ -1,0 +2,7 @@ +Tue Nov 15 07:51:46 MST 2022 - carn...@suse.com + +- bsc#1203252 - virt-manager regression - cannot add second + virtio-scsi controller + virtman-fix-uninitialized-controller-index.patch + +--- New: virtman-fix-uninitialized-controller-index.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.cxGJtc/_old 2022-11-16 15:42:37.667671719 +0100 +++ /var/tmp/diff_new_pack.cxGJtc/_new 2022-11-16 15:42:37.671671733 +0100 @@ -82,6 +82,7 @@ Patch158: virtman-disallow-adding-floppy-disk.patch Patch159: virtman-register-delete-event-for-details-dialog.patch Patch160: virtman-revert-use-of-AyatanaAppIndicator3.patch +Patch161: virtman-fix-uninitialized-controller-index.patch Patch170: virtinst-xen-drive-type.patch Patch171: virtinst-xenbus-disk-index-fix.patch Patch172: virtinst-refresh_before_fetch_pool.patch ++ virtman-fix-uninitialized-controller-index.patch ++ References: bsc#1203252 --- virt-manager-4.1.0/virtManager/addhardware.py.orig 2022-11-15 07:49:08.318413181 -0700 +++ virt-manager-4.1.0/virtManager/addhardware.py 2022-11-15 07:49:48.126414130 -0700 @@ -1570,6 +1570,8 @@ class vmmAddHardware(vmmGObjectUI): if len(controller_num) > 0: index_new = max([x.index for x in controller_num]) + 1 dev.index = index_new +else: +dev.index = 0 dev.type = controller_type
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2022-11-08 10:53:34 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1597 (New) Package is "virt-manager" Tue Nov 8 10:53:34 2022 rev:237 rq:1034192 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2022-10-28 19:29:51.326729153 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1597/virt-manager.changes 2022-11-08 10:53:40.049497733 +0100 @@ -1,0 +2,19 @@ +Mon Nov 7 05:32:57 MST 2022 - carn...@suse.com + +- Refresh test skips +- Drop the very old "Obsoletes: python-virtinst <= 0.600.4" + virt-manager.spec + +--- +Fri Nov 4 11:01:28 MDT 2022 - carn...@suse.com + +- Upstream bug fixes (bsc#1027942) + 11a887ec-cli-disk-Add-driver.metadata_cache-options.patch + 7295ebfb-tests-cli-Fix-test-output-after-previous-commit.patch + 58f5e36d-fsdetails-Fix-an-error-with-source.socket-of-virtiofs.patch + c22a876e-tests-Add-a-compat-check-for-linux2020-in-amd-sev-test-case.patch + fbdf0516-cli-cpu-Add-maxphysaddr.mode-bits-options.patch + b0d05167-cloner-Sync-uuid-and-sysinfo-system-uuid.patch + 999ccb85-virt-install-unattended-and-cloud-init-conflict.patch + +--- New: 11a887ec-cli-disk-Add-driver.metadata_cache-options.patch 58f5e36d-fsdetails-Fix-an-error-with-source.socket-of-virtiofs.patch 7295ebfb-tests-cli-Fix-test-output-after-previous-commit.patch 999ccb85-virt-install-unattended-and-cloud-init-conflict.patch b0d05167-cloner-Sync-uuid-and-sysinfo-system-uuid.patch c22a876e-tests-Add-a-compat-check-for-linux2020-in-amd-sev-test-case.patch fbdf0516-cli-cpu-Add-maxphysaddr.mode-bits-options.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.xBVVfq/_old 2022-11-08 10:53:41.925508897 +0100 +++ /var/tmp/diff_new_pack.xBVVfq/_new 2022-11-08 10:53:41.929508921 +0100 @@ -42,6 +42,13 @@ Source3:virt-manager-supportconfig # Upstream Patches Patch1: revert-363fca41-virt-install-Require-osinfo-for-non-x86-HVM-case-too.patch +Patch2: 11a887ec-cli-disk-Add-driver.metadata_cache-options.patch +Patch3: 7295ebfb-tests-cli-Fix-test-output-after-previous-commit.patch +Patch4: 58f5e36d-fsdetails-Fix-an-error-with-source.socket-of-virtiofs.patch +Patch5: c22a876e-tests-Add-a-compat-check-for-linux2020-in-amd-sev-test-case.patch +Patch6: fbdf0516-cli-cpu-Add-maxphysaddr.mode-bits-options.patch +Patch7: b0d05167-cloner-Sync-uuid-and-sysinfo-system-uuid.patch +Patch8: 999ccb85-virt-install-unattended-and-cloud-init-conflict.patch # SUSE Only Patch70:virtman-desktop.patch Patch71:virtman-kvm.patch @@ -162,7 +169,6 @@ Requires: python3-requests Provides: python3-virtinst Provides: virt-clone -Obsoletes: python-virtinst <= 0.600.4 Supplements:virt-manager %description -n virt-install @@ -210,23 +216,32 @@ donttest="$donttest or testCLI0001virt_install_many_devices" donttest="$donttest or testCLI0110virt_install_reinstall_cdrom" donttest="$donttest or testCLI0284virt_xml_build_pool_logical_disk" +donttest="$donttest or testCLI0285virt_xml_build_pool_logical_disk" donttest="$donttest or testCLI0276virt_xml_build_disk_domain" +donttest="$donttest or testCLI0277virt_xml_build_disk_domain" donttest="$donttest or testCLI0371virt_xml_add_disk_create_storage_start" +donttest="$donttest or testCLI0372virt_xml_add_disk_create_storage_start" # depends on osc/obs host cpu? donttest="$donttest or testCLI0003virt_install_singleton_config_2" donttest="$donttest or testCLI0283virt_xml_edit_cpu_host_copy" +donttest="$donttest or testCLI0284virt_xml_edit_cpu_host_copy" # RuntimeError: SEV launch security requires a Q35 machine -- due to patch for bsc#1196806, jsc#SLE-18834 ? donttest="$donttest or testCLI0162virt_install" # Expectsion element donttest="$donttest or testCLI0168virt_install_s390x_cdrom" +donttest="$donttest or testCLI0169virt_install_s390x_cdrom" # missing element, extra element donttest="$donttest or testCLI0189virt_install_xen_default" +donttest="$donttest or testCLI0190virt_install_xen_default" donttest="$donttest or testCLI0190virt_install_xen_pv" +donttest="$donttest or testCLI0191virt_install_xen_pv" # different additional in donttest="$donttest or testCLI0191virt_install_xen_hvm" donttest="$donttest or testCLI0192virt_install_xen_hvm" +donttest="$donttest or
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2022-10-28 19:29:29 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.2275 (New) Package is "virt-manager" Fri Oct 28 19:29:29 2022 rev:236 rq:1031597 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2022-08-08 08:45:21.242480864 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.2275/virt-manager.changes 2022-10-28 19:29:51.326729153 +0200 @@ -1,0 +2,6 @@ +Tue Oct 4 14:00:46 MDT 2022 - carn...@suse.com + +- jsc#PED-2113 [Virt Tools] Refresh Virtualization Tools for Xen + and KVM Management + +--- Other differences: --
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2022-08-08 08:45:08 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1521 (New) Package is "virt-manager" Mon Aug 8 08:45:08 2022 rev:235 rq:993366 version:4.1.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2022-07-22 19:20:16.956563363 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1521/virt-manager.changes 2022-08-08 08:45:21.242480864 +0200 @@ -1,0 +2,55 @@ +Fri Aug 5 16:25:59 UTC 2022 - Ben Greiner + +- Update to 4.1.0 + * Fix build with setuptools-61 (Peter Alfredsen, Miro Hron??ok) + * add UI and cli support for qemu-vdagent channel (Jonathon Jongsma) + * cli: More --iothreads suboptions (Lin Ma) + * launch_security: Use SEV-ES policy=0x07 if host supports it (Charles + * Arnold) + * cli: Add support for URL query with disks (Martin Kletzander) +- Drop patches merged upstream: + * c6107419-tests-Drop-usage-of-sgio-unfiltered.patch + * 90e13549-Fix-build-with-setuptools-61+.patch + * 46dc0616-setup-add-bits-for-setuptools-61.patch + * 9ac94ef7-tests-Fix-another-sgio-filtered-case.patch + * 34662fec-tests-Fix-with-latest-argcomplete.patch + * d51541e1-Fix-UI-rename-with-firmware-efi.patch + * b8a77805-domain-cpu-Clear-migratable-when-changing-to-custom-cpu.patch + * 0d84bcfb-cli-Add-iothreadids-attributes-thread_pool_min-and-thread_pool_max.patch + * 424283ad-launch_security-Use-SEV-ES-policy-0x07-if-host-supports-it.patch +- Refresh patches + * virtman-add-tooltip-to-firmware.patch +-- changed surrounding imports + * virtinst-set-cache-mode-unsafe-for-install.patch +-- the patch changes the expected output in tests +- Refresh test skips + +--- +Wed Aug 3 14:51:34 MDT 2022 - carn...@suse.com + +- Upstream bug fixes (bsc#1027942) + c6107419-tests-Drop-usage-of-sgio-unfiltered.patch + 9ac94ef7-tests-Fix-another-sgio-filtered-case.patch + b8a77805-domain-cpu-Clear-migratable-when-changing-to-custom-cpu.patch + 0d84bcfb-cli-Add-iothreadids-attributes-thread_pool_min-and-thread_pool_max.patch + 90e13549-Fix-build-with-setuptools-61+.patch + 424283ad-launch_security-Use-SEV-ES-policy-0x07-if-host-supports-it.patch +- Modified virtman-add-sev-memory-support.patch +- Renamed upstream patches + virtman-pr381-setuptools-61.patch to +46dc0616-setup-add-bits-for-setuptools-61.patch + virtman-34662fe-argcomplete.patch to +34662fec-tests-Fix-with-latest-argcomplete.patch + +--- +Tue Jul 19 10:03:04 UTC 2022 - Ben Greiner + +- Add Source URL +- Add upstream patch virtman-pr381-setuptools-61.patch + gh#virt-manager/virt-manager#381 +- Enable tests + * No python package should go untested + * Use multibuild so that all runtime requirements are checked + * Add virtman-34662fe-argcomplete.patch + +--- Old: d51541e1-Fix-UI-rename-with-firmware-efi.patch virt-manager-4.0.0.tar.gz New: _multibuild virt-manager-4.1.0.tar.gz Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.B58K8k/_old 2022-08-08 08:45:22.554484723 +0200 +++ /var/tmp/diff_new_pack.B58K8k/_new 2022-08-08 08:45:22.558484735 +0200 @@ -1,5 +1,5 @@ # -# spec file for package virt-manager +# spec file # # Copyright (c) 2022 SUSE LLC # @@ -20,20 +20,28 @@ %global with_guestfs 0 %global default_hvs"qemu,xen,lxc" -Name: virt-manager -Version:4.0.0 +%global flavor @BUILD_FLAVOR@%{nil} +%if "%{flavor}" == "test" +%bcond_without test +%define psuffix -%{flavor} +%else +%bcond_with test +%define psuffix %{nil} +%endif + +Name: virt-manager%{psuffix} +Version:4.1.0 Release:0 Summary:Virtual Machine Manager License:GPL-2.0-or-later Group: System/Monitoring URL:http://virt-manager.org/ -Source0:%{name}-%{version}.tar.gz +Source0: https://virt-manager.org/download/sources/virt-manager/virt-manager-%{version}.tar.gz Source1:virt-install.rb Source2:virt-install.desktop Source3:virt-manager-supportconfig # Upstream Patches Patch1: revert-363fca41-virt-install-Require-osinfo-for-non-x86-HVM-case-too.patch -Patch2: d51541e1-Fix-UI-rename-with-firmware-efi.patch # SUSE Only Patch70:virtman-desktop.patch Patch71:virtman-kvm.patch @@ -84,7 +92,6 @@ Patch184:
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2022-07-22 19:20:14 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.21925 (New) Package is "virt-manager" Fri Jul 22 19:20:14 2022 rev:234 rq:990302 version:4.0.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2022-06-24 08:45:07.619126840 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.21925/virt-manager.changes 2022-07-22 19:20:16.956563363 +0200 @@ -1,0 +2,7 @@ +Tue Jul 12 14:41:21 MDT 2022 - carn...@suse.com + +- Upstream bug fix (bsc#1027942) + d51541e1-Fix-UI-rename-with-firmware-efi.patch +- Use autosetup in spec file + +--- New: d51541e1-Fix-UI-rename-with-firmware-efi.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.TLqckg/_old 2022-07-22 19:20:18.060565258 +0200 +++ /var/tmp/diff_new_pack.TLqckg/_new 2022-07-22 19:20:18.064565266 +0200 @@ -33,6 +33,7 @@ Source3:virt-manager-supportconfig # Upstream Patches Patch1: revert-363fca41-virt-install-Require-osinfo-for-non-x86-HVM-case-too.patch +Patch2: d51541e1-Fix-UI-rename-with-firmware-efi.patch # SUSE Only Patch70:virtman-desktop.patch Patch71:virtman-kvm.patch @@ -157,57 +158,7 @@ machine). %prep -%setup -q -# Upstream Patches -%patch1 -p1 -# SUSE Only -%patch70 -p1 -%patch71 -p1 -%patch72 -p1 -%patch73 -p1 -%patch74 -p1 -%patch75 -p1 -%patch76 -p1 -# Enhancements -%patch103 -p1 -%patch104 -p1 -%patch105 -p1 -%patch106 -p1 -%patch120 -p1 -%patch121 -p1 -%patch122 -p1 -%patch123 -p1 -%patch124 -p1 -%patch125 -p1 -%patch126 -p1 -%patch127 -p1 -%patch128 -p1 -# Bug Fixes -%patch151 -p1 -%patch152 -p1 -%patch153 -p1 -%patch154 -p1 -%patch155 -p1 -%patch156 -p1 -%patch157 -p1 -%patch158 -p1 -%patch159 -p1 -%patch160 -p1 -%patch170 -p1 -%patch171 -p1 -%patch172 -p1 -%patch173 -p1 -%patch174 -p1 -%patch175 -p1 -%patch176 -p1 -%patch177 -p1 -%patch178 -p1 -%patch179 -p1 -%patch180 -p1 -%patch181 -p1 -%patch182 -p1 -%patch183 -p1 -%patch184 -p1 +%autosetup -p1 %build %if %{default_hvs} ++ d51541e1-Fix-UI-rename-with-firmware-efi.patch ++ Subject: Fix UI rename with firmware='efi' From: Cole Robinson crobi...@redhat.com Sat Jun 18 16:16:38 2022 -0400 Date: Mon Jun 20 09:37:26 2022 -0400: Git: d51541e155bd29389f804425356690ea55465551 Our code to duplicate nvram wasn't expecting the XML to be devoid of an nvram path. Resolves: https://github.com/virt-manager/virt-manager/issues/372 Signed-off-by: Cole Robinson diff --git a/tests/uitests/data/live/uitests-firmware-efi.xml b/tests/uitests/data/live/uitests-firmware-efi.xml new file mode 100644 index ..b7463818 --- /dev/null +++ b/tests/uitests/data/live/uitests-firmware-efi.xml @@ -0,0 +1,14 @@ + + uitests-firmware-efi + 65536 + 65536 + 1 + +hvm + + + + + + + diff --git a/tests/uitests/test_livetests.py b/tests/uitests/test_livetests.py index 28884298..7ac2ee48 100644 --- a/tests/uitests/test_livetests.py +++ b/tests/uitests/test_livetests.py @@ -38,7 +38,7 @@ def _vm_wrapper(vmname, uri="qemu:///system", opts=None): except Exception: pass try: -dom.undefine() +dom.undefineFlags(libvirt.VIR_DOMAIN_UNDEFINE_NVRAM) dom.destroy() except Exception: pass @@ -499,3 +499,45 @@ def testLiveHotplug(app, dom): pool.undefine() except Exception: log.debug("Error cleaning up pool", exc_info=True) + + +@_vm_wrapper("uitests-firmware-efi") +def testFirmwareRename(app, dom): +from virtinst import cli, DeviceDisk +win = app.topwin +dom.destroy() + +# First we refresh the 'nvram' pool, so we can reliably +# check if nvram files are created/deleted as expected +conn = cli.getConnection(app.conn.getURI()) +origname = dom.name() +nvramdir = conn.get_libvirt_data_root_dir() + "/qemu/nvram" + +fakedisk = DeviceDisk(conn) +fakedisk.set_source_path(nvramdir + "/FAKE-UITEST-FILE") +nvram_pool = fakedisk.get_parent_pool() +nvram_pool.refresh() + +origpath = "%s/%s_VARS.fd" % (nvramdir, origname) +newname = "uitests-firmware-efi-renamed" +newpath = "%s/%s_VARS.fd" % (nvramdir, newname) +assert DeviceDisk.path_definitely_exists(app.conn, origpath) +assert not DeviceDisk.path_definitely_exists(app.conn, newpath) + +# Now do the actual UI clickage +win.find("Details",
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2022-06-24 08:44:59 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1548 (New) Package is "virt-manager" Fri Jun 24 08:44:59 2022 rev:233 rq:984601 version:4.0.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2022-05-31 15:47:49.484005846 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1548/virt-manager.changes 2022-06-24 08:45:07.619126840 +0200 @@ -1,0 +2,7 @@ +Wed Jun 22 13:54:26 MDT 2022 - carn...@suse.com + +- bsc#1200691 - SLES 15 SP4 GMC --os-variant tag shouldn't be + mandatory on s390x (see also bsc#1200422) + revert-363fca41-virt-install-Require-osinfo-for-non-x86-HVM-case-too.patch + +--- New: revert-363fca41-virt-install-Require-osinfo-for-non-x86-HVM-case-too.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.7twfTZ/_old 2022-06-24 08:45:08.643127987 +0200 +++ /var/tmp/diff_new_pack.7twfTZ/_new 2022-06-24 08:45:08.647127991 +0200 @@ -32,6 +32,7 @@ Source2:virt-install.desktop Source3:virt-manager-supportconfig # Upstream Patches +Patch1: revert-363fca41-virt-install-Require-osinfo-for-non-x86-HVM-case-too.patch # SUSE Only Patch70:virtman-desktop.patch Patch71:virtman-kvm.patch @@ -158,6 +159,7 @@ %prep %setup -q # Upstream Patches +%patch1 -p1 # SUSE Only %patch70 -p1 %patch71 -p1 ++ revert-363fca41-virt-install-Require-osinfo-for-non-x86-HVM-case-too.patch ++ References: bsc#1200691, an IBM request This patch reverts commit 363fca413cae336a0ca86cbdcbb2f65fead948ee. Only x86 will have a hard requirement for the --osinfo option. From: Cole Robinson crobi...@redhat.com Sun Feb 20 11:40:35 2022 -0500 Subject: virt-install: Require --osinfo for non-x86 HVM case too Date: Sun Feb 20 11:40:35 2022 -0500: Git: 363fca413cae336a0ca86cbdcbb2f65fead948ee It's generally not as valuable for non-x86 where we don't have the history of supporting non-virtio OSes, but as time goes on it will likely become more relevant for non-x86 arches, so let's make this change now to get ahead of it. Signed-off-by: Cole Robinson --- a/man/virt-install.rst +++ b/man/virt-install.rst @@ -1040,8 +1040,8 @@ all other settings off or unset. By default, virt-install will always attempt ``--osinfo detect=on`` for appropriate install media. If no OS is detected, we will fail -in most common cases. This fatal error was added in 2022. You can -work around this by using the fallback example +in certain common cases (x86 KVM for example). This fatal error was +added in 2022. You can work around this by using the fallback example above, or disabling the ``require`` option. If you just need to get back to the old non-fatal behavior ASAP, set the environment variable VIRTINSTALL_OSINFO_DISABLE_REQUIRE=1. --- a/tests/test_cli.py +++ b/tests/test_cli.py @@ -1162,7 +1162,6 @@ c.add_compare("--connect %(URI-KVM-ARMV7 # c.add_valid("--arch aarch64 --osinfo fedora19 --nodisks --pxe --connect " + utils.URIs.kvm_x86_nodomcaps, grep="Libvirt version does not support UEFI") # attempt to default to aarch64 UEFI, but it fails, but should only print warnings -c.add_invalid("--arch aarch64 --nodisks --pxe --connect " + utils.URIs.kvm_x86, grep="OS name is required") # catch missing osinfo for non-x86 c.add_compare("--arch aarch64 --osinfo fedora19 --machine virt --boot kernel=/f19-arm.kernel,initrd=/f19-arm.initrd,kernel_args=\"console=ttyAMA0,1234 rw root=/dev/vda3\" --disk %(EXISTIMG1)s", "aarch64-machvirt") c.add_compare("--arch aarch64 --osinfo fedora19 --boot kernel=/f19-arm.kernel,initrd=/f19-arm.initrd,kernel_args=\"console=ttyAMA0,1234 rw root=/dev/vda3\" --disk %(EXISTIMG1)s", "aarch64-machdefault") c.add_compare("--arch aarch64 --cdrom %(ISO-F26-NETINST)s --boot loader=CODE.fd,nvram.template=VARS.fd --disk %(EXISTIMG1)s --cpu none --events on_crash=preserve,on_reboot=destroy,on_poweroff=restart", "aarch64-cdrom") # cdrom test, but also --cpu none override, --events override, and headless --- a/virtinst/virtinstall.py +++ b/virtinst/virtinstall.py @@ -355,13 +355,9 @@ def _show_memory_warnings(guest): def _needs_accurate_osinfo(guest): -# HVM is really the only case where OS impacts what we set for defaults, -# so far. -# -# Historically we would only warn about missing osinfo on x86, but -# with the change to make osinfo mandatory we relaxed the arch check, -# so virt-install behavior is more
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2022-05-31 15:47:02 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1548 (New) Package is "virt-manager" Tue May 31 15:47:02 2022 rev:232 rq:979896 version:4.0.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2022-05-12 22:58:13.868625277 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1548/virt-manager.changes 2022-05-31 15:47:49.484005846 +0200 @@ -1,0 +2,6 @@ +Mon May 23 08:10:42 MDT 2022 - carn...@suse.com + +- Change dependency on package xorriso to Requires from Recommends + virt-manager.spec + +--- Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.Bpj8Fq/_old 2022-05-31 15:47:50.776006703 +0200 +++ /var/tmp/diff_new_pack.Bpj8Fq/_new 2022-05-31 15:47:50.784006709 +0200 @@ -98,7 +98,6 @@ Requires: virt-install Requires: virt-manager-common = %{verrel} Requires: typelib(GtkSource) -Recommends: xorriso %if %{with_guestfs} Requires: python3-libguestfs @@ -129,6 +128,7 @@ Requires: python3-libvirt-python >= 0.7.0 Requires: python3-libxml2-python Requires: python3-pycurl +Requires: xorriso Requires: typelib(AppIndicator3) Requires: typelib(LibvirtGLib) Suggests: python3-virt-bootstrap
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2022-05-12 22:57:51 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1538 (New) Package is "virt-manager" Thu May 12 22:57:51 2022 rev:231 rq:976118 version:4.0.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2022-03-05 14:44:32.639717981 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1538/virt-manager.changes 2022-05-12 22:58:13.868625277 +0200 @@ -1,0 +2,10 @@ +Wed Mar 30 09:06:33 MDT 2022 - carn...@suse.com + +- bsc#1196806 - [jsc#SLE-18834][virt-install] ERROR SEV launch + security requires a Q35 UEFI machine (epic: jsc#SLE-18732) + virtman-add-sev-memory-support.patch +- Add firmware features to description tooltip when mouse hovers + over the selected firmware file. + virtman-add-tooltip-to-firmware.patch + +--- New: virtman-add-sev-memory-support.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.CoNVTD/_old 2022-05-12 22:58:14.744626454 +0200 +++ /var/tmp/diff_new_pack.CoNVTD/_new 2022-05-12 22:58:14.748626459 +0200 @@ -44,6 +44,7 @@ Patch103: virtman-load-stored-uris.patch Patch104: virtman-add-tooltip-to-firmware.patch Patch105: virtman-modify-gui-defaults.patch +Patch106: virtman-add-sev-memory-support.patch Patch120: virtinst-default-xen-to-qcow2-format.patch Patch121: virtinst-detect-oes-distros.patch Patch122: virtinst-vol-default-nocow.patch @@ -86,6 +87,7 @@ %define verrel %{version}-%{release} Requires: dbus-1-x11 Requires: dconf +Requires: gstreamer-plugins-good Requires: gtk3 Requires: python3-gobject # For console widget @@ -168,6 +170,7 @@ %patch103 -p1 %patch104 -p1 %patch105 -p1 +%patch106 -p1 %patch120 -p1 %patch121 -p1 %patch122 -p1 ++ virtinst-add-pvh-support.patch ++ --- /var/tmp/diff_new_pack.CoNVTD/_old 2022-05-12 22:58:14.836626577 +0200 +++ /var/tmp/diff_new_pack.CoNVTD/_new 2022-05-12 22:58:14.840626582 +0200 @@ -45,7 +45,7 @@ === --- virt-manager-4.0.0.orig/virtManager/object/domain.py +++ virt-manager-4.0.0/virtManager/object/domain.py -@@ -1274,6 +1274,8 @@ class vmmDomain(vmmLibvirtObject): +@@ -1292,6 +1292,8 @@ class vmmDomain(vmmLibvirtObject): return self.get_xmlobj().os.is_xenpv() def is_hvm(self): return self.get_xmlobj().os.is_hvm() ++ virtinst-set-default-nic.patch ++ --- /var/tmp/diff_new_pack.CoNVTD/_old 2022-05-12 22:58:14.880626636 +0200 +++ /var/tmp/diff_new_pack.CoNVTD/_new 2022-05-12 22:58:14.880626636 +0200 @@ -1,11 +1,11 @@ References: bsc#1172356, bsc#1177620 Libvirt doesn't accept "Hypervisor default" as a model name -Index: virt-manager-3.3.0/virtinst/devices/interface.py +Index: virt-manager-4.0.0/virtinst/devices/interface.py === virt-manager-3.3.0.orig/virtinst/devices/interface.py -+++ virt-manager-3.3.0/virtinst/devices/interface.py -@@ -302,6 +302,9 @@ class DeviceInterface(Device): +--- virt-manager-4.0.0.orig/virtinst/devices/interface.py virt-manager-4.0.0/virtinst/devices/interface.py +@@ -305,6 +305,9 @@ class DeviceInterface(Device): return "e1000e" if not guest.os.is_x86(): return None ++ virtman-add-sev-memory-support.patch ++ References: bsc#1196806, jsc#SLE-18834 Index: virt-manager-4.0.0/ui/details.ui === --- virt-manager-4.0.0.orig/ui/details.ui +++ virt-manager-4.0.0/ui/details.ui @@ -1925,7 +1925,20 @@ - + +Enable launch security +True +True +False +start +True +True + + + +1 +4 + Index:
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2022-03-05 14:43:52 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1958 (New) Package is "virt-manager" Sat Mar 5 14:43:52 2022 rev:230 rq:959256 version:4.0.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2022-01-23 12:16:47.900022679 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1958/virt-manager.changes 2022-03-05 14:44:32.639717981 +0100 @@ -1,0 +2,43 @@ +Wed Mar 2 21:11:58 MST 2022 - carn...@suse.com + +- bsc#1196202 - virt-install crashes on a time-of-check time-of-use + (TOCTOU) race condition + Resolved by upgrade to version 4.0.0 (jsc#SLE-18261) + virt-manager-4.0.0.tar.gz +- Other features and bug fixes (bsc#1027942) + virt-install ???os-variant/???osinfo is now a hard requirement for most cases + Add ???Enable shared memory??? UI checkbox (Lin Ma) + add UI preference to default to UEFI for new VMs (Charles Arnold) + Add virtiofs filesystem driver UI option + Fill in all ???cputune, ???cpu, ???shmem, ???input, and ???boot suboptions (Hugues Fafard) + virt-* mdev improvements (Shalini Chellathurai Saroja) + bhyve improvments (Roman Bogorodskiy) + Revive network portgroup UI + enable a TPM by default when UEFI is used (Daniel P. Berrang??) + Use cpu host-passthrough by default on qemu x86 + use virtio-gpu video for most modern distros + Default to extra pcie root ports for q35 + set discard=unmap by default for sparse disks and block devices + We now require xorissofs for ???location ISO + We now use setuptools rather than just plain distutils +- Add virtman-revert-use-of-AyatanaAppIndicator3.patch +- Drop the following patches + 0e15cd51-virt-manager-enable-MDEV-support.patch + 143c6bef-virtinst-fix-error-message-format-string.patch + 4d0e3232-virtinst-Fix-TOCTOU-in-domain-enumeration.patch + 8bb64ad5-console-Dont-block-console-reconnect-for-non-error.patch + 9363e1e6-virt-xml-add-support-for-mediated-devices.patch + 965480e8-virt-install-add-mediated-device.patch + 9d4002ee-tests-verify-MDEV-support.patch + cf93e2db-console-fix-error-with-old-pygobject.patch + d3c627f1-volumeupload-Use-1MiB-read-size.patch + d9b5090e-Fix-forgetting-password-from-keyring.patch + e7222b50-addstorage-Dont-pass-None-to-widget.set_active.patch + f87e96d3-hostdev-use-method-get_mdev_uuid.patch + fe8722e7-createnet-Remove-some-unnecessary-max_length-annotations.patch + virtinst-graphics-add-check-for-qemu-modules-in-spice-graphic.patch + virtman-add-firmware-preferences.patch + virtman-legacy-bios-support.patch + virtman-show-no-firmware-for-xenpv.patch + +--- Old: 0e15cd51-virt-manager-enable-MDEV-support.patch 143c6bef-virtinst-fix-error-message-format-string.patch 4d0e3232-virtinst-Fix-TOCTOU-in-domain-enumeration.patch 8bb64ad5-console-Dont-block-console-reconnect-for-non-error.patch 9363e1e6-virt-xml-add-support-for-mediated-devices.patch 965480e8-virt-install-add-mediated-device.patch 9d4002ee-tests-verify-MDEV-support.patch cf93e2db-console-fix-error-with-old-pygobject.patch d3c627f1-volumeupload-Use-1MiB-read-size.patch d9b5090e-Fix-forgetting-password-from-keyring.patch e7222b50-addstorage-Dont-pass-None-to-widget.set_active.patch f87e96d3-hostdev-use-method-get_mdev_uuid.patch fe8722e7-createnet-Remove-some-unnecessary-max_length-annotations.patch virt-manager-3.2.0.tar.bz2 virtinst-graphics-add-check-for-qemu-modules-in-spice-graphic.patch virtman-add-firmware-preferences.patch virtman-legacy-bios-support.patch virtman-show-no-firmware-for-xenpv.patch New: virt-manager-4.0.0.tar.gz virtman-revert-use-of-AyatanaAppIndicator3.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.tloGb4/_old 2022-03-05 14:44:33.939718309 +0100 +++ /var/tmp/diff_new_pack.tloGb4/_new 2022-03-05 14:44:33.943718311 +0100 @@ -21,30 +21,17 @@ %global default_hvs"qemu,xen,lxc" Name: virt-manager -Version:3.2.0 +Version:4.0.0 Release:0 Summary:Virtual Machine Manager License:GPL-2.0-or-later Group: System/Monitoring URL:http://virt-manager.org/ -Source0:%{name}-%{version}.tar.bz2 +Source0:%{name}-%{version}.tar.gz Source1:virt-install.rb Source2:virt-install.desktop Source3:virt-manager-supportconfig # Upstream Patches -Patch1: e7222b50-addstorage-Dont-pass-None-to-widget.set_active.patch -Patch2:
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2022-01-23 12:15:34 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1938 (New) Package is "virt-manager" Sun Jan 23 12:15:34 2022 rev:229 rq:948012 version:3.2.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2022-01-15 21:45:08.46161 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1938/virt-manager.changes 2022-01-23 12:16:47.900022679 +0100 @@ -1,0 +2,10 @@ +Thu Jan 20 15:46:02 MST 2022 - carn...@suse.com + +- bsc#1194323 - [jsc#SLE-19237][virt-manager] Detected the wrong + win2k22 guest system version from the local install media + virtinst-windows-server-detection.patch +- Upstream bug fixes (bsc#1027942) + 8bb64ad5-console-Dont-block-console-reconnect-for-non-error.patch + Drop virtman-init-viewer-on-reboot.patch + +--- Old: virtman-init-viewer-on-reboot.patch New: 8bb64ad5-console-Dont-block-console-reconnect-for-non-error.patch virtinst-windows-server-detection.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.LUZ7o1/_old 2022-01-23 12:16:48.984015434 +0100 +++ /var/tmp/diff_new_pack.LUZ7o1/_new 2022-01-23 12:16:48.988015407 +0100 @@ -44,6 +44,7 @@ Patch10:f87e96d3-hostdev-use-method-get_mdev_uuid.patch Patch11:9d4002ee-tests-verify-MDEV-support.patch Patch12:0e15cd51-virt-manager-enable-MDEV-support.patch +Patch13: 8bb64ad5-console-Dont-block-console-reconnect-for-non-error.patch # SUSE Only Patch70:virtman-desktop.patch Patch71:virtman-kvm.patch @@ -79,7 +80,6 @@ Patch159: virtman-register-delete-event-for-details-dialog.patch Patch160: virtman-show-no-firmware-for-xenpv.patch Patch161: virtman-legacy-bios-support.patch -Patch162: virtman-init-viewer-on-reboot.patch Patch170: virtinst-xen-drive-type.patch Patch171: virtinst-xenbus-disk-index-fix.patch Patch172: virtinst-refresh_before_fetch_pool.patch @@ -94,6 +94,7 @@ Patch181: virtinst-add-slem-detection-support.patch Patch182: virtinst-add-sle-hpc-support.patch Patch183: virtinst-add-oracle-linux-support.patch +Patch184: virtinst-windows-server-detection.patch BuildArch: noarch BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -184,6 +185,7 @@ %patch10 -p1 %patch11 -p1 %patch12 -p1 +%patch13 -p1 # SUSE Only %patch70 -p1 %patch71 -p1 @@ -219,7 +221,6 @@ %patch159 -p1 %patch160 -p1 %patch161 -p1 -%patch162 -p1 %patch170 -p1 %patch171 -p1 %patch172 -p1 @@ -234,6 +235,7 @@ %patch181 -p1 %patch182 -p1 %patch183 -p1 +%patch184 -p1 %build %if %{default_hvs} ++ 8bb64ad5-console-Dont-block-console-reconnect-for-non-error.patch ++ Subject: console: Don't block console reconnect for non-error From: Cole Robinson crobi...@redhat.com Thu Jan 20 14:14:54 2022 -0500 Date: Fri Jan 21 11:03:23 2022 -0500: Git: 8bb64ad5afd5eb1bb15c25affc5544a3acefe48f https://listman.redhat.com/archives/virt-tools-list/2022-January/msg00012.html On xen, a guest reboot will trigger a non-error viewer-disconnected signal, but we treat it like an error, which makes it difficult to reconnect to the VM console. If there's no error message raised, treat the disconnect like a non-error cases. Signed-off-by: Cole Robinson --- a/virtManager/details/console.py +++ b/virtManager/details/console.py @@ -824,14 +824,23 @@ class vmmConsolePages(vmmGObjectUI): return msg = _("Viewer was disconnected.") +errmsg = "" if errdetails: -msg += "\n" + errdetails +errmsg += "\n" + errdetails if ssherr: log.debug("SSH tunnel error output: %s", ssherr) -msg += "\n\n" -msg += _("SSH tunnel error output: %s") % ssherr +errmsg += "\n\n" +errmsg += _("SSH tunnel error output: %s") % ssherr -self._activate_gfx_unavailable_page(msg) +if errmsg: +self._activate_gfx_unavailable_page(msg + errmsg) +return + +# If no error message was reported, this isn't a clear graphics +# error that should block reconnecting. So use the top level +# 'VM unavailable' page which makes it easier for the user to +# reconnect. +self._activate_vm_unavailable_page(msg) def _viewer_disconnected(self, ignore, errdetails, ssherr): self._activate_gfx_unavailable_page(_("Viewer disconnected.")) ++
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2022-01-15 21:45:06 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1892 (New) Package is "virt-manager" Sat Jan 15 21:45:06 2022 rev:228 rq:946226 version:3.2.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2021-12-08 22:09:13.734870269 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1892/virt-manager.changes 2022-01-15 21:45:08.46161 +0100 @@ -1,0 +2,10 @@ +Thu Jan 13 13:33:50 MST 2022 - carn...@suse.com + +- jsc#SLE-20855 KVM: Enable vfio-ccw and vfio-ap in virt-* tools + 965480e8-virt-install-add-mediated-device.patch + f87e96d3-hostdev-use-method-get_mdev_uuid.patch + 9d4002ee-tests-verify-MDEV-support.patch + 9363e1e6-virt-xml-add-support-for-mediated-devices.patch + 0e15cd51-virt-manager-enable-MDEV-support.patch + +--- New: 0e15cd51-virt-manager-enable-MDEV-support.patch 9363e1e6-virt-xml-add-support-for-mediated-devices.patch 9d4002ee-tests-verify-MDEV-support.patch f87e96d3-hostdev-use-method-get_mdev_uuid.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.f374y1/_old 2022-01-15 21:45:09.489612766 +0100 +++ /var/tmp/diff_new_pack.f374y1/_new 2022-01-15 21:45:09.489612766 +0100 @@ -1,7 +1,7 @@ # # spec file for package virt-manager # -# Copyright (c) 2021 SUSE LLC +# Copyright (c) 2022 SUSE LLC # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -40,6 +40,10 @@ Patch6: fe8722e7-createnet-Remove-some-unnecessary-max_length-annotations.patch Patch7: d9b5090e-Fix-forgetting-password-from-keyring.patch Patch8: 965480e8-virt-install-add-mediated-device.patch +Patch9: 9363e1e6-virt-xml-add-support-for-mediated-devices.patch +Patch10:f87e96d3-hostdev-use-method-get_mdev_uuid.patch +Patch11:9d4002ee-tests-verify-MDEV-support.patch +Patch12:0e15cd51-virt-manager-enable-MDEV-support.patch # SUSE Only Patch70:virtman-desktop.patch Patch71:virtman-kvm.patch @@ -176,6 +180,10 @@ %patch6 -p1 %patch7 -p1 %patch8 -p1 +%patch9 -p1 +%patch10 -p1 +%patch11 -p1 +%patch12 -p1 # SUSE Only %patch70 -p1 %patch71 -p1 ++ 0e15cd51-virt-manager-enable-MDEV-support.patch ++ Subject: virt-manager: enable MDEV support From: Shalini Chellathurai Saroja shal...@linux.ibm.com Mon Jun 7 11:34:21 2021 +0200 Date: Tue Jun 8 09:58:50 2021 -0400: Git: 0e15cd51dfbdaa09f7d34ed1edce2f5416130361 Enable virt-manager GUI to support add, edit, remove, hot-plug and hot-unplug of mediated devices (like DASDs, APQNs and PCIs) in virtual server. It is not possible to edit MDEV when a virtual server is in running state, as this is not supported by libvirt. Reviewed-by: Cole Robinson Signed-off-by: Shalini Chellathurai Saroja diff --git a/tests/data/testdriver/testdriver.xml b/tests/data/testdriver/testdriver.xml index b8d67bac..5875732a 100644 --- a/tests/data/testdriver/testdriver.xml +++ b/tests/data/testdriver/testdriver.xml @@ -3645,6 +3645,27 @@ ba + + css_0_0_0023 + /sys/devices/css0/0.0.0023 + computer + +vfio_ccw + + +0x0 +0x0 +0x0023 + + +I/O subchannel (Non-QDIO) +vfio-ccw +0 + + + + + mdev_8e37ee90_2b51_45e3_9b25_bf8283c03110 /sys/devices/css0/0.0.0023/8e37ee90-2b51-45e3-9b25-bf8283c03110 @@ -3658,6 +3679,24 @@ ba + + ap_matrix + /sys/devices/vfio_ap/matrix + computer + +vfio_ap + + + + +VFIO AP Passthrough Device +vfio-ap +65536 + + + + + mdev_11f92c9d_b0b0_4016_b306_a8071277f8b9 /sys/devices/vfio_ap/matrix/11f92c9d-b0b0-4016-b306-a8071277f8b9 diff --git a/tests/uitests/test_addhardware.py b/tests/uitests/test_addhardware.py index ce3da57c..56acc2fa 100644 --- a/tests/uitests/test_addhardware.py +++ b/tests/uitests/test_addhardware.py @@ -459,6 +459,12 @@ def testAddHosts(app): app.click_alert_button("device is already in use by", "Yes") lib.utils.check(lambda: details.active) +# Add MDEV device +_open_addhw(app, details) +tab = _select_hw(addhw, "MDEV Host Device", "host-tab") +tab.find_fuzzy("mdev_8e37ee90_2b51_45e3_9b25_bf8283c03110", + "table cell").click() +_finish(addhw, check=details) def testAddChars(app): diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py index
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2021-12-08 22:08:44 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.31177 (New) Package is "virt-manager" Wed Dec 8 22:08:44 2021 rev:227 rq:936082 version:3.2.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2021-10-25 15:18:00.381697127 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.31177/virt-manager.changes 2021-12-08 22:09:13.734870269 +0100 @@ -1,0 +2,25 @@ +Tue Nov 23 10:11:44 MST 2021 - carn...@suse.com + +- jsc#SLE-17735 - Support Oracle Linux as a guest VM. See also + bsc#1192238 [Build58.2][KVM] The latest supported OracleLinux as + guest versions are not included anywhere + virtinst-add-oracle-linux-support.patch + +--- +Thu Oct 28 16:09:36 MDT 2021 - carn...@suse.com + +- bsc#1188223 - L3: Sles12sp3 DomU won't boot after adding phys + hard drive + virtinst-xenbus-disk-index-fix.patch + +--- +Tue Oct 26 07:20:07 MDT 2021 - carn...@suse.com + +- jsc#SLE-21540 Dev: Prefer UEFI when creating new virtual machines. + Add a preferences option to allow users to default to UEFI when + creating a new VM. Libvirt decides which firmware file to use. + virtman-add-firmware-preferences.patch +- Renamed patch virtinst-modify-gui-defaults.patch to + virtman-modify-gui-defaults.patch + +--- Old: virtinst-modify-gui-defaults.patch New: virtinst-add-oracle-linux-support.patch virtman-add-firmware-preferences.patch virtman-modify-gui-defaults.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.urbMw1/_old 2021-12-08 22:09:14.906870818 +0100 +++ /var/tmp/diff_new_pack.urbMw1/_new 2021-12-08 22:09:14.910870820 +0100 @@ -51,17 +51,18 @@ # Features or Enhancements Patch103: virtman-load-stored-uris.patch Patch104: virtman-add-tooltip-to-firmware.patch +Patch105: virtman-modify-gui-defaults.patch +Patch106: virtman-add-firmware-preferences.patch Patch120: virtinst-default-xen-to-qcow2-format.patch Patch121: virtinst-detect-oes-distros.patch -Patch122: virtinst-modify-gui-defaults.patch -Patch123: virtinst-vol-default-nocow.patch -Patch124: virtinst-set-cache-mode-unsafe-for-install.patch -Patch125: virtinst-s390x-disable-graphics.patch -Patch126: virtinst-add-caasp-support.patch -Patch127: virtinst-add-sle15-detection-support.patch -Patch128: virtinst-add-pvh-support.patch -Patch129: virtinst-media-detection.patch -Patch130: virtinst-graphics-add-check-for-qemu-modules-in-spice-graphic.patch +Patch122: virtinst-vol-default-nocow.patch +Patch123: virtinst-set-cache-mode-unsafe-for-install.patch +Patch124: virtinst-s390x-disable-graphics.patch +Patch125: virtinst-add-caasp-support.patch +Patch126: virtinst-add-sle15-detection-support.patch +Patch127: virtinst-add-pvh-support.patch +Patch128: virtinst-media-detection.patch +Patch129: virtinst-graphics-add-check-for-qemu-modules-in-spice-graphic.patch # Bug Fixes Patch151: virtman-increase-setKeepAlive-count.patch Patch152: virtman-allow-destroy-from-shutdown-menu-of-crashed-vm.patch @@ -88,6 +89,7 @@ Patch180: virtinst-keep-iso-for-xenpv.patch Patch181: virtinst-add-slem-detection-support.patch Patch182: virtinst-add-sle-hpc-support.patch +Patch183: virtinst-add-oracle-linux-support.patch BuildArch: noarch BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -185,6 +187,8 @@ # Enhancements %patch103 -p1 %patch104 -p1 +%patch105 -p1 +%patch106 -p1 %patch120 -p1 %patch121 -p1 %patch122 -p1 @@ -195,7 +199,6 @@ %patch127 -p1 %patch128 -p1 %patch129 -p1 -%patch130 -p1 # Bug Fixes %patch151 -p1 %patch152 -p1 @@ -222,6 +225,7 @@ %patch180 -p1 %patch181 -p1 %patch182 -p1 +%patch183 -p1 %build %if %{default_hvs} ++ virtinst-add-oracle-linux-support.patch ++ References: bsc#1192238, jsc#SLE-17764 --- virt-manager-3.2.0/virtinst/install/urldetect.py.orig 2021-11-23 15:06:47.451081946 -0700 +++ virt-manager-3.2.0/virtinst/install/urldetect.py2021-11-23 15:07:43.539083283 -0700 @@ -723,6 +723,24 @@ class _OESDistro(_SuseDistro): famregex = ".*Open Enterprise Server.*" +class _OLDistro(_DistroTree): +PRETTY_NAME = "Oracle Linux" +matching_distros = ["ol"] +_variant_prefix =
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2021-10-25 15:17:19 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1890 (New) Package is "virt-manager" Mon Oct 25 15:17:19 2021 rev:226 rq:927021 version:3.2.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2021-10-11 16:48:46.126182326 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1890/virt-manager.changes 2021-10-25 15:18:00.381697127 +0200 @@ -1,0 +2,13 @@ +Fri Oct 22 10:09:51 MDT 2021 - carn...@suse.com + +- Add dependency in spec file for python3-gobject-Gdk (bsc#1191705) + virt-manager.spec + +--- +Tue Oct 12 16:47:47 MDT 2021 - carn...@suse.com + +- bsc#1191358 - The Virtual Machine Manager shows disconnected + after rebooting virtual machine in Xen mode in SLES15 SP3. + virtman-init-viewer-on-reboot.patch + +--- New: virtman-init-viewer-on-reboot.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.SB3XVp/_old 2021-10-25 15:18:01.277697686 +0200 +++ /var/tmp/diff_new_pack.SB3XVp/_new 2021-10-25 15:18:01.281697689 +0200 @@ -74,6 +74,7 @@ Patch159: virtman-register-delete-event-for-details-dialog.patch Patch160: virtman-show-no-firmware-for-xenpv.patch Patch161: virtman-legacy-bios-support.patch +Patch162: virtman-init-viewer-on-reboot.patch Patch170: virtinst-xen-drive-type.patch Patch171: virtinst-xenbus-disk-index-fix.patch Patch172: virtinst-refresh_before_fetch_pool.patch @@ -98,6 +99,7 @@ Requires: python3-gobject # For console widget Requires: python3-cairo +Requires: python3-gobject-Gdk Requires: python3-gobject-cairo Recommends: python3-SpiceClientGtk Requires: virt-install @@ -206,6 +208,7 @@ %patch159 -p1 %patch160 -p1 %patch161 -p1 +%patch162 -p1 %patch170 -p1 %patch171 -p1 %patch172 -p1 ++ virtman-init-viewer-on-reboot.patch ++ References: bsc#1191358 Index: virt-manager-3.2.0/virtManager/details/console.py === --- virt-manager-3.2.0.orig/virtManager/details/console.py +++ virt-manager-3.2.0/virtManager/details/console.py @@ -923,6 +923,8 @@ class vmmConsolePages(vmmGObjectUI): return cpage = self.widget("console-pages").get_current_page() +if cpage == _CONSOLE_PAGE_GRAPHICS: +self._init_viewer() if cpage != _CONSOLE_PAGE_UNAVAILABLE: return
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2021-10-11 16:48:39 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.2443 (New) Package is "virt-manager" Mon Oct 11 16:48:39 2021 rev:225 rq:924117 version:3.2.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2021-09-20 23:32:55.187156277 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.2443/virt-manager.changes 2021-10-11 16:48:46.126182326 +0200 @@ -1,0 +2,15 @@ +Thu Oct 7 14:53:51 MDT 2021 - carn...@suse.com + +- bsc#1191356 - virt-manager should not depend on gtk4 + Modified files: +virt-manager.spec +virtman-dont-specify-gtksource-version.patch +virtman-dont-specify-vte-version.patch + +--- +Mon Oct 4 15:58:01 MDT 2021 - carn...@suse.com + +- jsc#SLE-20856 Dev: KVM: Enable vfio-ccw and vfio-ap in virt-* tools + 965480e8-virt-install-add-mediated-device.patch + +--- New: 965480e8-virt-install-add-mediated-device.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.i4fooy/_old 2021-10-11 16:48:47.138183935 +0200 +++ /var/tmp/diff_new_pack.i4fooy/_new 2021-10-11 16:48:47.138183935 +0200 @@ -39,6 +39,7 @@ Patch5: 143c6bef-virtinst-fix-error-message-format-string.patch Patch6: fe8722e7-createnet-Remove-some-unnecessary-max_length-annotations.patch Patch7: d9b5090e-Fix-forgetting-password-from-keyring.patch +Patch8: 965480e8-virt-install-add-mediated-device.patch # SUSE Only Patch70:virtman-desktop.patch Patch71:virtman-kvm.patch @@ -93,31 +94,23 @@ %define verrel %{version}-%{release} Requires: dbus-1-x11 Requires: dconf -Requires: gtk3 >= 3.22 -Requires: python3-gobject-Gdk +Requires: gtk3 +Requires: python3-gobject # For console widget Requires: python3-cairo Requires: python3-gobject-cairo Recommends: python3-SpiceClientGtk -Requires: gtksourceview >= 3 Requires: virt-install Requires: virt-manager-common = %{verrel} +Requires: typelib(GtkSource) %if %{with_guestfs} Requires: python3-libguestfs %endif -BuildRequires: glib2-devel -BuildRequires: gtk3-tools -BuildRequires: intltool -BuildRequires: perl +BuildRequires: gettext BuildRequires: python3-devel BuildRequires: python3-docutils -BuildRequires: python3-gobject -BuildRequires: python3-libvirt-python >= 0.7.0 -BuildRequires: python3-libxml2-python -BuildRequires: python3-requests -BuildRequires: typelib(Libosinfo) %description Virtual Machine Manager provides a graphical tool for administering virtual @@ -178,6 +171,7 @@ %patch5 -p1 %patch6 -p1 %patch7 -p1 +%patch8 -p1 # SUSE Only %patch70 -p1 %patch71 -p1 ++ 965480e8-virt-install-add-mediated-device.patch ++ Subject: virt-install: add mediated device From: Shalini Chellathurai Saroja shal...@linux.ibm.com Wed Apr 14 17:18:55 2021 +0200 Date: Tue May 18 18:36:03 2021 -0400: Git: 965480e8bc85caf8a4f36b4a2f07963067b63cf6 Add support to install a virtual server with passed-through mediated device. Mediated device can be created using vGPU attached to vfio_pci driver or DASD attached to vfio_ccw driver or APQNs attached to vfio_ap driver. Reviewed-by: Cole Robinson Signed-off-by: Shalini Chellathurai Saroja Index: virt-manager-3.2.0/tests/data/cli/compare/virt-install-many-devices.xml === --- virt-manager-3.2.0.orig/tests/data/cli/compare/virt-install-many-devices.xml +++ virt-manager-3.2.0/tests/data/cli/compare/virt-install-many-devices.xml @@ -592,6 +592,25 @@ /dev/pty7 + + + + + + + + + + + + + + + + + + + Index: virt-manager-3.2.0/tests/data/testdriver/testdriver.xml === --- virt-manager-3.2.0.orig/tests/data/testdriver/testdriver.xml +++ virt-manager-3.2.0/tests/data/testdriver/testdriver.xml @@ -3645,5 +3645,45 @@ ba + + mdev_8e37ee90_2b51_45e3_9b25_bf8283c03110 + /sys/devices/css0/0.0.0023/8e37ee90-2b51-45e3-9b25-bf8283c03110 + css_0_0_0023 + +vfio_mdev + + + + + + + + + mdev_11f92c9d_b0b0_4016_b306_a8071277f8b9 + /sys/devices/vfio_ap/matrix/11f92c9d-b0b0-4016-b306-a8071277f8b9 + ap_matrix + +vfio_mdev + +
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2021-09-20 23:32:13 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.1899 (New) Package is "virt-manager" Mon Sep 20 23:32:13 2021 rev:224 rq:919281 version:3.2.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2021-06-25 15:00:35.700097201 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.1899/virt-manager.changes 2021-09-20 23:32:55.187156277 +0200 @@ -1,0 +2,6 @@ +Wed Sep 8 14:10:59 MDT 2021 - carn...@suse.com + +- bsc#1190215 - [virt-install] No Support for SUSE Product SLE-HPC + virtinst-add-sle-hpc-support.patch + +--- New: virtinst-add-sle-hpc-support.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.1fp35F/_old 2021-09-20 23:32:56.099157403 +0200 +++ /var/tmp/diff_new_pack.1fp35F/_new 2021-09-20 23:32:56.103157408 +0200 @@ -85,6 +85,7 @@ Patch179: virtinst-smbios-unsupported-for-xenpv.patch Patch180: virtinst-keep-iso-for-xenpv.patch Patch181: virtinst-add-slem-detection-support.patch +Patch182: virtinst-add-sle-hpc-support.patch BuildArch: noarch BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -223,6 +224,7 @@ %patch179 -p1 %patch180 -p1 %patch181 -p1 +%patch182 -p1 %build %if %{default_hvs} ++ virtinst-add-sle-hpc-support.patch ++ References: bsc#1190215 Index: virt-manager-3.2.0/virtinst/install/urldetect.py === --- virt-manager-3.2.0.orig/virtinst/install/urldetect.py +++ virt-manager-3.2.0/virtinst/install/urldetect.py @@ -273,12 +273,17 @@ class _SUSEContent(object): if "Enterprise" in self.product_name or "SLES" in self.product_name: if " SAP " in self.product_name: sle_version = self.product_name.strip().rsplit(' ')[7] +if " High Performance " in self.product_name: +sle_version = self.product_name.strip().rsplit(' ')[6] else: sle_version = self.product_name.strip().rsplit(' ')[4] if len(self.product_name.strip().rsplit(' ')) > 5 and not " Micro " in self.product_name: if " SAP " in self.product_name: sle_version = (sle_version + '.' + self.product_name.strip().rsplit(' ')[8][2]) +if " High Performance " in self.product_name: +sle_version = (sle_version + '.' + +self.product_name.strip().rsplit(' ')[7][2]) else: sle_version = (sle_version + '.' + self.product_name.strip().rsplit(' ')[5][2]) @@ -670,6 +675,14 @@ class _SLESDistro(_SuseDistro): famregex = ".*SUSE Linux Enterprise.*" +class _SLEHPCDistro(_SuseDistro): +PRETTY_NAME = "SLE-HPC" +matching_distros = ["sle-hpc"] +_variant_prefix = "sles" +_suse_regex = [".*SUSE Linux Enterprise High Performance Computing*", ".*SUSE SLE-HPC*", ".*SUSE SLE_HPC*"] +famregex = ".*SUSE Linux Enterprise.*" + + class _SLEDDistro(_SuseDistro): PRETTY_NAME = "SLED" matching_distros = ["sled"] @@ -938,6 +951,7 @@ def _build_distro_list(osobj): _CentOSDistro, _SLEDistro, _SLESDistro, +_SLEHPCDistro, _SLEDDistro, _OpensuseDistro, _MICRODistro,
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2021-06-25 15:00:31 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.2625 (New) Package is "virt-manager" Fri Jun 25 15:00:31 2021 rev:223 rq:901224 version:3.2.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2021-04-23 17:49:39.534694446 +0200 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.2625/virt-manager.changes 2021-06-25 15:00:35.700097201 +0200 @@ -1,0 +2,10 @@ +Mon Jun 21 14:30:27 MDT 2021 - carn...@suse.com + +- Upstream bug fixes (bsc#1027942) + d3c627f1-volumeupload-Use-1MiB-read-size.patch + cf93e2db-console-fix-error-with-old-pygobject.patch + 143c6bef-virtinst-fix-error-message-format-string.patch + fe8722e7-createnet-Remove-some-unnecessary-max_length-annotations.patch + d9b5090e-Fix-forgetting-password-from-keyring.patch + +--- New: 143c6bef-virtinst-fix-error-message-format-string.patch cf93e2db-console-fix-error-with-old-pygobject.patch d3c627f1-volumeupload-Use-1MiB-read-size.patch d9b5090e-Fix-forgetting-password-from-keyring.patch fe8722e7-createnet-Remove-some-unnecessary-max_length-annotations.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.adoPbj/_old 2021-06-25 15:00:36.628098333 +0200 +++ /var/tmp/diff_new_pack.adoPbj/_new 2021-06-25 15:00:36.632098338 +0200 @@ -34,6 +34,11 @@ # Upstream Patches Patch1: e7222b50-addstorage-Dont-pass-None-to-widget.set_active.patch Patch2: 4d0e3232-virtinst-Fix-TOCTOU-in-domain-enumeration.patch +Patch3: d3c627f1-volumeupload-Use-1MiB-read-size.patch +Patch4: cf93e2db-console-fix-error-with-old-pygobject.patch +Patch5: 143c6bef-virtinst-fix-error-message-format-string.patch +Patch6: fe8722e7-createnet-Remove-some-unnecessary-max_length-annotations.patch +Patch7: d9b5090e-Fix-forgetting-password-from-keyring.patch # SUSE Only Patch70:virtman-desktop.patch Patch71:virtman-kvm.patch @@ -167,6 +172,11 @@ # Upstream Patches %patch1 -p1 %patch2 -p1 +%patch3 -p1 +%patch4 -p1 +%patch5 -p1 +%patch6 -p1 +%patch7 -p1 # SUSE Only %patch70 -p1 %patch71 -p1 ++ 143c6bef-virtinst-fix-error-message-format-string.patch ++ Subject: virtinst: fix error message format string From: Roman Bogorodskiy bogorods...@gmail.com Wed Feb 10 17:54:10 2021 +0400 Date: Wed Feb 10 10:26:23 2021 -0500: Git: 143c6befc33ee507379fd7eca8cf5e5bd1685799 Fix a regression introduced by commit 71f034d6b where format string expects kwarg "domain", but "vm" is passed instead. Reviewed-by: Cole Robinson Signed-off-by: Roman Bogorodskiy diff --git a/virtinst/virtxml.py b/virtinst/virtxml.py index bd2b4282..0c8da37e 100644 --- a/virtinst/virtxml.py +++ b/virtinst/virtxml.py @@ -251,7 +251,7 @@ def start_domain_transient(conn, xmlobj, devs, action, confirm): dom = conn.createXML(xmlobj.get_xml()) except libvirt.libvirtError as e: fail(_("Failed starting domain '%(domain)s': %(error)s") % { - "vm": xmlobj.name, + "domain": xmlobj.name, "error": e, }) else: ++ cf93e2db-console-fix-error-with-old-pygobject.patch ++ Subject: console: fix error with old pygobject From: Pavel Hrdina phrd...@redhat.com Fri Feb 5 12:15:46 2021 +0100 Date: Fri Feb 5 12:15:46 2021 +0100: Git: cf93e2dbff28fe05d6d45364c579f923b157beb1 The code doesn't work as expected. From python documentation: x and y is the same as x if not x or y so in the code if for some reasone `dev` is None the value stored in `sensitive` will be None as well. No the code itself works with pygobject >= 3.31.3 where they allowed None as a valid boolean value, but with older versions it will fail with this error message: TypeError: Argument 1 does not allow None as a value Resolves: https://github.com/virt-manager/virt-manager/issues/226 Signed-off-by: Pavel Hrdina diff --git a/virtManager/details/console.py b/virtManager/details/console.py index c4ed478e..18f9ddd9 100644 --- a/virtManager/details/console.py +++ b/virtManager/details/console.py @@ -258,7 +258,7 @@ class _ConsoleMenu: cb = toggled_cb cbdata = dev -sensitive = dev and not tooltip +sensitive = bool(dev and not tooltip) active = False if oldlabel is None and sensitive: ++ d3c627f1-volumeupload-Use-1MiB-read-size.patch ++ Subject: volumeupload: Use 1MiB read size From:
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2021-04-23 17:49:37 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.12324 (New) Package is "virt-manager" Fri Apr 23 17:49:37 2021 rev:222 rq:886769 version:3.2.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2021-03-02 12:27:46.251441456 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.12324/virt-manager.changes 2021-04-23 17:49:39.534694446 +0200 @@ -1,0 +2,7 @@ +Mon Apr 12 13:01:27 MDT 2021 - carn...@suse.com + +- Add support for detecting SUSE Linux Enterprise Micro. See also + the osinfo-db package for the SLEM OS description file. + virtinst-add-slem-detection-support.patch + +--- New: virtinst-add-slem-detection-support.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.rZbZIm/_old 2021-04-23 17:49:40.438696001 +0200 +++ /var/tmp/diff_new_pack.rZbZIm/_new 2021-04-23 17:49:40.438696001 +0200 @@ -79,6 +79,7 @@ Patch178: virtinst-sap-detection.patch Patch179: virtinst-smbios-unsupported-for-xenpv.patch Patch180: virtinst-keep-iso-for-xenpv.patch +Patch181: virtinst-add-slem-detection-support.patch BuildArch: noarch BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -211,6 +212,7 @@ %patch178 -p1 %patch179 -p1 %patch180 -p1 +%patch181 -p1 %build %if %{default_hvs} ++ virtinst-add-slem-detection-support.patch ++ Add support for detecting SUSE Linux Enterprise Micro. See also the osinfo-db package for the description file. Index: virt-manager-3.2.0/virtinst/install/urldetect.py === --- virt-manager-3.2.0.orig/virtinst/install/urldetect.py +++ virt-manager-3.2.0/virtinst/install/urldetect.py @@ -275,7 +275,7 @@ class _SUSEContent(object): sle_version = self.product_name.strip().rsplit(' ')[7] else: sle_version = self.product_name.strip().rsplit(' ')[4] -if len(self.product_name.strip().rsplit(' ')) > 5: +if len(self.product_name.strip().rsplit(' ')) > 5 and not " Micro " in self.product_name: if " SAP " in self.product_name: sle_version = (sle_version + '.' + self.product_name.strip().rsplit(' ')[8][2]) @@ -596,6 +596,9 @@ class _SuseDistro(_RHELDistro): version = distro_version.split('.', 1)[0].strip() +if self._variant_prefix.startswith(("slem")): +return self._variant_prefix + distro_version + if self._variant_prefix.startswith(("caasp")): return self._variant_prefix + distro_version @@ -683,6 +686,14 @@ class _OpensuseDistro(_SuseDistro): famregex = ".*openSUSE.*" +class _MICRODistro(_SuseDistro): +PRETTY_NAME = "SLES" +matching_distros = ["slem"] +_variant_prefix = "slem" +_suse_regex = [".*SUSE Linux Enterprise Micro*", ".*SUSE Micro*"] +famregex = ".*SUSE Linux Enterprise Micro.*" + + class _CAASPDistro(_SuseDistro): PRETTY_NAME = "SLES" matching_distros = ["caasp"] @@ -929,6 +940,7 @@ def _build_distro_list(osobj): _SLESDistro, _SLEDDistro, _OpensuseDistro, +_MICRODistro, _CAASPDistro, _OESDistro, _DebianDistro,
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2021-03-02 12:26:19 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.2378 (New) Package is "virt-manager" Tue Mar 2 12:26:19 2021 rev:221 rq:875162 version:3.2.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2021-01-29 14:55:16.753348916 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.2378/virt-manager.changes 2021-03-02 12:27:46.251441456 +0100 @@ -1,0 +2,7 @@ +Wed Feb 24 14:10:01 MST 2021 - a...@suse.com + +- bsc#1178926 - Unable to find any master var for loader + /usr/share/qemu/{bios.bin, bios-256k.bin} + virtman-legacy-bios-support.patch + +--- New: virtman-legacy-bios-support.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.UzbRMN/_old 2021-03-02 12:27:47.723442772 +0100 +++ /var/tmp/diff_new_pack.UzbRMN/_new 2021-03-02 12:27:47.727442776 +0100 @@ -67,6 +67,7 @@ Patch158: virtman-disallow-adding-floppy-disk.patch Patch159: virtman-register-delete-event-for-details-dialog.patch Patch160: virtman-show-no-firmware-for-xenpv.patch +Patch161: virtman-legacy-bios-support.patch Patch170: virtinst-xen-drive-type.patch Patch171: virtinst-xenbus-disk-index-fix.patch Patch172: virtinst-refresh_before_fetch_pool.patch @@ -198,6 +199,7 @@ %patch158 -p1 %patch159 -p1 %patch160 -p1 +%patch161 -p1 %patch170 -p1 %patch171 -p1 %patch172 -p1 ++ virtinst-keep-iso-for-xenpv.patch ++ --- /var/tmp/diff_new_pack.UzbRMN/_old 2021-03-02 12:27:47.831442868 +0100 +++ /var/tmp/diff_new_pack.UzbRMN/_new 2021-03-02 12:27:47.835442873 +0100 @@ -1,3 +1,7 @@ +References: bsc#1180897 +Removing the cdrom iso file from the device prevents booting +with a qemu error. + Index: virt-manager-3.2.0/virtinst/install/installer.py === --- virt-manager-3.2.0.orig/virtinst/install/installer.py ++ virtinst-smbios-unsupported-for-xenpv.patch ++ --- /var/tmp/diff_new_pack.UzbRMN/_old 2021-03-02 12:27:47.859442894 +0100 +++ /var/tmp/diff_new_pack.UzbRMN/_new 2021-03-02 12:27:47.863442897 +0100 @@ -4,7 +4,7 @@ === --- virt-manager-3.2.0.orig/virtinst/guest.py +++ virt-manager-3.2.0/virtinst/guest.py -@@ -691,6 +691,8 @@ class Guest(XMLBuilder): +@@ -704,6 +704,8 @@ class Guest(XMLBuilder): self.type != "kvm"): log.warning( # pragma: no cover "KVM acceleration not available, using '%s'", self.type) ++ virtman-legacy-bios-support.patch ++ References: bsc#1178926 When we choose /usr/share/qemu/bios.bin or /usr/share/qemu/bios-256k.bin in Customize configuration before install, show this error message: Unable to complete install: 'operation failed: unable to find any master var store for loader: /usr/share/qemu/bios.bin' Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/asyncjob.py", line 65, in cb_wrapper callback(asyncjob, *args, **kwargs) File "/usr/share/virt-manager/virtManager/createvm.py", line 2081, in _do_async_install installer.start_install(guest, meter=meter) File "/usr/share/virt-manager/virtinst/install/installer.py", line 721, in start_install domain = self._create_guest( File "/usr/share/virt-manager/virtinst/install/installer.py", line 669, in _create_guest domain = self.conn.createXML(install_xml or final_xml, 0) File "/usr/lib64/python3.8/site-packages/libvirt.py", line 4347, in createXML raise libvirtError('virDomainCreateXML() failed') libvirt.libvirtError: operation failed: unable to find any master var store for loader: /usr/share/qemu/bios.bin This patch check the loader if it is include bios.bin and bios-256k.bin. Signed-off-by: Yu-Chen, Cho -- v2: Fixed tabs vs spaces issues. v1: Check the loader if it is include bios.bin and bios-256k.bin. --- virtManager/object/domain.py | 18 +- virtinst/guest.py| 13 + 2 files changed, 22 insertions(+), 9 deletions(-) Index: virt-manager-3.2.0/virtManager/object/domain.py === --- virt-manager-3.2.0.orig/virtManager/object/domain.py +++ virt-manager-3.2.0/virtManager/object/domain.py @@ -671,16 +671,16 @@ class vmmDomain(vmmLibvirtObject): if loader != _SENTINEL: if loader is None: -# Implies seabios, aka
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2021-01-29 14:55:07 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.28504 (New) Package is "virt-manager" Fri Jan 29 14:55:07 2021 rev:220 rq:866982 version:3.2.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2021-01-19 15:58:49.459074332 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.28504/virt-manager.changes 2021-01-29 14:55:16.753348916 +0100 @@ -1,0 +2,14 @@ +Mon Jan 25 14:32:10 MST 2021 - carn...@suse.com + +- bsc#1180897 - SLES15 SP2: VM does not boot after virt-install + installing from ISO image. + virtinst-keep-iso-for-xenpv.patch + +--- +Mon Jan 25 11:32:34 MST 2021 - carn...@suse.com + +- bsc#1181350 - [Build 20210122] openQA test fails in virt_install + on aarch64 + virtman-show-no-firmware-for-xenpv.patch + +--- New: virtinst-keep-iso-for-xenpv.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.u58vVR/_old 2021-01-29 14:55:20.489354412 +0100 +++ /var/tmp/diff_new_pack.u58vVR/_new 2021-01-29 14:55:20.493354418 +0100 @@ -77,6 +77,7 @@ Patch177: virtinst-set-default-nic.patch Patch178: virtinst-sap-detection.patch Patch179: virtinst-smbios-unsupported-for-xenpv.patch +Patch180: virtinst-keep-iso-for-xenpv.patch BuildArch: noarch BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -207,6 +208,7 @@ %patch177 -p1 %patch178 -p1 %patch179 -p1 +%patch180 -p1 %build %if %{default_hvs} ++ virtinst-keep-iso-for-xenpv.patch ++ Index: virt-manager-3.2.0/virtinst/install/installer.py === --- virt-manager-3.2.0.orig/virtinst/install/installer.py +++ virt-manager-3.2.0/virtinst/install/installer.py @@ -174,8 +174,9 @@ class Installer(object): for disk in guest.devices.disk: if (disk.is_cdrom() and disk.get_source_path() == self._cdrom_path()): -disk.set_source_path(None) -disk.sync_path_props() +if not guest.os.is_xenpv(): +disk.set_source_path(None) +disk.sync_path_props() break def _add_unattended_install_cdrom_device(self, guest, location): ++ virtman-show-no-firmware-for-xenpv.patch ++ --- /var/tmp/diff_new_pack.u58vVR/_old 2021-01-29 14:55:20.725354760 +0100 +++ /var/tmp/diff_new_pack.u58vVR/_new 2021-01-29 14:55:20.725354760 +0100 @@ -1,14 +1,16 @@ References: bsc#1180047 Xen PV doesn't support uefi or BIOS booting virt-manager-3.2.0/virtManager/details/details.py.orig 2021-01-05 13:02:58.040792391 -0700 -+++ virt-manager-3.2.0/virtManager/details/details.py 2021-01-05 13:07:51.212799377 -0700 +Index: virt-manager-3.2.0/virtManager/details/details.py +=== +--- virt-manager-3.2.0.orig/virtManager/details/details.py virt-manager-3.2.0/virtManager/details/details.py @@ -696,7 +696,7 @@ class vmmDetails(vmmGObjectUI): not self.is_customize_dialog) show_firmware = ((self.conn.is_qemu() or self.conn.is_test() or - self.conn.is_xen()) and -+ self.conn.is_xen() and not self.vm.is_xenpv()) and ++ (self.conn.is_xen() and not self.vm.is_xenpv())) and domcaps.arch_can_uefi()) uiutil.set_grid_row_visible( self.widget("overview-firmware-title"), show_firmware)
commit virt-manager for openSUSE:Factory
Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2021-01-19 15:58:44 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.28504 (New) Package is "virt-manager" Tue Jan 19 15:58:44 2021 rev:219 rq:863175 version:3.2.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2021-01-06 19:55:37.324964136 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.28504/virt-manager.changes 2021-01-19 15:58:49.459074332 +0100 @@ -1,0 +2,14 @@ +Thu Jan 7 12:48:11 MST 2021 - carn...@suse.com + +- bsc#1180069 - L3: virsh edit Error: XML document failed to + validate against schema: Unable to validate doc. + virtinst-smbios-unsupported-for-xenpv.patch + +--- +Tue Jan 5 13:10:18 MST 2021 - carn...@suse.com + +- bsc#1180047 - [xen][virt-manger] Libvirt or Hyperisor does not + support UEFI for 15SP3 XENPV Guest + virtman-show-no-firmware-for-xenpv.patch + +--- New: virtinst-smbios-unsupported-for-xenpv.patch virtman-show-no-firmware-for-xenpv.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.CI2zKV/_old 2021-01-19 15:58:50.547075977 +0100 +++ /var/tmp/diff_new_pack.CI2zKV/_new 2021-01-19 15:58:50.551075983 +0100 @@ -66,6 +66,7 @@ Patch157: virtman-fix-restore-vm-menu-selection.patch Patch158: virtman-disallow-adding-floppy-disk.patch Patch159: virtman-register-delete-event-for-details-dialog.patch +Patch160: virtman-show-no-firmware-for-xenpv.patch Patch170: virtinst-xen-drive-type.patch Patch171: virtinst-xenbus-disk-index-fix.patch Patch172: virtinst-refresh_before_fetch_pool.patch @@ -75,6 +76,7 @@ Patch176: virtinst-dont-use-special-copy-cpu-features.patch Patch177: virtinst-set-default-nic.patch Patch178: virtinst-sap-detection.patch +Patch179: virtinst-smbios-unsupported-for-xenpv.patch BuildArch: noarch BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -194,6 +196,7 @@ %patch157 -p1 %patch158 -p1 %patch159 -p1 +%patch160 -p1 %patch170 -p1 %patch171 -p1 %patch172 -p1 @@ -203,6 +206,7 @@ %patch176 -p1 %patch177 -p1 %patch178 -p1 +%patch179 -p1 %build %if %{default_hvs} ++ virtinst-smbios-unsupported-for-xenpv.patch ++ References: bsc#1180069 Index: virt-manager-3.2.0/virtinst/guest.py === --- virt-manager-3.2.0.orig/virtinst/guest.py +++ virt-manager-3.2.0/virtinst/guest.py @@ -691,6 +691,8 @@ class Guest(XMLBuilder): self.type != "kvm"): log.warning( # pragma: no cover "KVM acceleration not available, using '%s'", self.type) +if self.os.is_xenpv() and self.os.smbios_mode is not None: +raise RuntimeError(_("The --sysinfo flag (smbios) is not supported for Xen PV guests.")) def sync_vcpus_topology(self): """ ++ virtman-show-no-firmware-for-xenpv.patch ++ References: bsc#1180047 Xen PV doesn't support uefi or BIOS booting --- virt-manager-3.2.0/virtManager/details/details.py.orig 2021-01-05 13:02:58.040792391 -0700 +++ virt-manager-3.2.0/virtManager/details/details.py 2021-01-05 13:07:51.212799377 -0700 @@ -696,7 +696,7 @@ class vmmDetails(vmmGObjectUI): not self.is_customize_dialog) show_firmware = ((self.conn.is_qemu() or self.conn.is_test() or - self.conn.is_xen()) and + self.conn.is_xen() and not self.vm.is_xenpv()) and domcaps.arch_can_uefi()) uiutil.set_grid_row_visible( self.widget("overview-firmware-title"), show_firmware)
commit virt-manager for openSUSE:Factory
Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2020-12-18 19:52:35 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.5145 (New) Package is "virt-manager" Fri Dec 18 19:52:35 2020 rev:217 rq:856508 version:3.2.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2020-12-01 14:23:09.773617742 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.5145/virt-manager.changes 2020-12-18 19:52:37.645628922 +0100 @@ -1,0 +2,7 @@ +Wed Dec 9 08:32:32 MST 2020 - carn...@suse.com + +- Upstream bug fixes (bsc#1027942) + e7222b50-addstorage-Dont-pass-None-to-widget.set_active.patch + 4d0e3232-virtinst-Fix-TOCTOU-in-domain-enumeration.patch + +--- New: 4d0e3232-virtinst-Fix-TOCTOU-in-domain-enumeration.patch e7222b50-addstorage-Dont-pass-None-to-widget.set_active.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.6UrRJP/_old 2020-12-18 19:52:39.933631367 +0100 +++ /var/tmp/diff_new_pack.6UrRJP/_new 2020-12-18 19:52:39.933631367 +0100 @@ -32,6 +32,8 @@ Source2:virt-install.desktop Source3:virt-manager-supportconfig # Upstream Patches +Patch1: e7222b50-addstorage-Dont-pass-None-to-widget.set_active.patch +Patch2: 4d0e3232-virtinst-Fix-TOCTOU-in-domain-enumeration.patch # SUSE Only Patch70:virtman-desktop.patch Patch71:virtman-kvm.patch @@ -157,6 +159,8 @@ %prep %setup -q # Upstream Patches +%patch1 -p1 +%patch2 -p1 # SUSE Only %patch70 -p1 %patch71 -p1 ++ 4d0e3232-virtinst-Fix-TOCTOU-in-domain-enumeration.patch ++ Subject: virtinst: Fix TOCTOU in domain enumeration From: Martin Pitt mar...@piware.de Tue Nov 24 14:24:06 2020 +0100 Date: Tue Dec 1 13:56:30 2020 -0500: Git: 4d0e323227f18e58283c45be4d240b506faacb22 Similar to commit 49a01b5482, _fetch_all_domains_raw() has a race condition where a domain may disappear (from parallel libvirt operations) in between enumerating and inspecting the objects. Ignore these missing domains instead of crashing. https://bugzilla.redhat.com/show_bug.cgi?id=1901081 diff --git a/virtinst/connection.py b/virtinst/connection.py index fec273b7..06bc60ad 100644 --- a/virtinst/connection.py +++ b/virtinst/connection.py @@ -182,8 +182,16 @@ class VirtinstConnection(object): def _fetch_all_domains_raw(self): dummy1, dummy2, ret = pollhelpers.fetch_vms( self, {}, lambda obj, ignore: obj) -return [Guest(weakref.proxy(self), parsexml=obj.XMLDesc(0)) -for obj in ret] +domains = [] +for obj in ret: +# TOCTOU race: a domain may go away in between enumeration and inspection +try: +xml = obj.XMLDesc(0) +except libvirt.libvirtError as e: # pragma: no cover +log.debug("Fetching domain XML failed: %s", e) +continue +domains.append(Guest(weakref.proxy(self), parsexml=xml)) +return domains def _build_pool_raw(self, poolobj): return StoragePool(weakref.proxy(self), ++ e7222b50-addstorage-Dont-pass-None-to-widget.set_active.patch ++ Subject: addstorage: Don't pass None to widget.set_active() From: Cole Robinson crobi...@redhat.com Sat Nov 21 17:17:33 2020 -0500 Date: Sat Nov 21 17:17:33 2020 -0500: Git: e7222b5058c8874b15fbfd998e5eeb233f571075 Older pygobject can't handle it. Mentioned here: https://github.com/virt-manager/virt-manager/issues/188 Signed-off-by: Cole Robinson diff --git a/virtManager/device/addstorage.py b/virtManager/device/addstorage.py index dee0160c..49d0b693 100644 --- a/virtManager/device/addstorage.py +++ b/virtManager/device/addstorage.py @@ -310,7 +310,7 @@ class vmmAddStorage(vmmGObjectUI): detect_zeroes = disk.driver_detect_zeroes ro = disk.read_only share = disk.shareable -removable = disk.removable +removable = bool(disk.removable) serial = disk.serial self.set_disk_bus(disk.bus) ___ openSUSE Commits mailing list -- commit@lists.opensuse.org To unsubscribe, email commit-le...@lists.opensuse.org List Netiquette: https://en.opensuse.org/openSUSE:Mailing_list_netiquette List Archives: https://lists.opensuse.org/archives/list/commit@lists.opensuse.org
commit virt-manager for openSUSE:Factory
Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2020-12-01 14:22:55 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.5913 (New) Package is "virt-manager" Tue Dec 1 14:22:55 2020 rev:216 rq:851950 version:3.2.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2020-11-17 21:26:11.233431480 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.5913/virt-manager.changes 2020-12-01 14:23:09.773617742 +0100 @@ -1,0 +2,23 @@ +Mon Nov 30 13:39:10 MST 2020 - carn...@suse.com + +- bsc#1179236 - L3: virt-install: "Error validating install + location: invalid literal for int() with base 10" reported by + virt-install ref:_00D1igLOd._5001iTe00n:ref + virtinst-sap-detection.patch + +--- +Wed Nov 25 19:00:46 UTC 2020 - Bruce Rogers + +- boo#1178141 - Accomodate qemu modularization with respect to v5.2 + qemu changes, where 3 additional modular shared objects need to + be present for spice support. This change simply augments what + was done before, adding the additional code to the same patch + +--- +Fri Nov 20 13:52:33 MST 2020 - carn...@suse.com + +- bsc#1172340 - Several YaST modules can be started by typing + "yast2 $module " + virt-install.rb + +--- New: virtinst-sap-detection.patch Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.KxQ9dq/_old 2020-12-01 14:23:10.865618922 +0100 +++ /var/tmp/diff_new_pack.KxQ9dq/_new 2020-12-01 14:23:10.869618927 +0100 @@ -72,6 +72,7 @@ Patch175: virtinst-keep-install-iso-attached.patch Patch176: virtinst-dont-use-special-copy-cpu-features.patch Patch177: virtinst-set-default-nic.patch +Patch178: virtinst-sap-detection.patch BuildArch: noarch BuildRoot: %{_tmppath}/%{name}-%{version}-build @@ -196,6 +197,7 @@ %patch175 -p1 %patch176 -p1 %patch177 -p1 +%patch178 -p1 %build %if %{default_hvs} ++ virt-install.rb ++ --- /var/tmp/diff_new_pack.KxQ9dq/_old 2020-12-01 14:23:11.009619079 +0100 +++ /var/tmp/diff_new_pack.KxQ9dq/_new 2020-12-01 14:23:11.013619083 +0100 @@ -43,6 +43,11 @@ @details = {} Builtins.y2milestone("START HERE.") + if WFM.Args == ["help"] +# Ignore yast help request +return :next + end + if UI.TextMode() Builtins.y2milestone("Running virt-install in text mode is not supported. Running vm-install instead in command line mode.") status = UI.RunInTerminal("/usr/bin/vm-install") ++ virtinst-graphics-add-check-for-qemu-modules-in-spice-graphic.patch ++ --- /var/tmp/diff_new_pack.KxQ9dq/_old 2020-12-01 14:23:11.077619152 +0100 +++ /var/tmp/diff_new_pack.KxQ9dq/_new 2020-12-01 14:23:11.081619156 +0100 @@ -1,6 +1,6 @@ -From 2919f40ac931dce5dedf326f84e83e8c04e1fabe Mon Sep 17 00:00:00 2001 +From dc5e834199e19ad09de17ac13e9834d3f17bd112 Mon Sep 17 00:00:00 2001 From: Bruce Rogers -Date: Sat, 24 Oct 2020 08:10:29 -0600 +Date: Wed, 25 Nov 2020 10:34:56 -0700 Subject: [PATCH] graphics: add check for qemu modules in spice graphics detection @@ -13,30 +13,43 @@ our own detection of whether the qemu modules needed to support the default guest install using spice, usb redirection, and qxl video are present. +With v5.2, some additional qemu modules are also required, so we add +a separate detection for that version, and add corresponding additional +module checks. Signed-off-by: Bruce Rogers --- - virtinst/devices/graphics.py | 9 + - virtinst/support.py | 1 + - 2 files changed, 10 insertions(+) + virtinst/devices/graphics.py | 19 +++ + virtinst/support.py | 2 ++ + 2 files changed, 21 insertions(+) Index: virt-manager-3.1.0/virtinst/devices/graphics.py === --- virt-manager-3.1.0.orig/virtinst/devices/graphics.py +++ virt-manager-3.1.0/virtinst/devices/graphics.py -@@ -135,6 +135,15 @@ class DeviceGraphics(Device): +@@ -135,6 +135,25 @@ class DeviceGraphics(Device): # Spice has issues on some host arches, like ppc, so allow it if self.conn.caps.host.cpu.arch not in ["i686", "x86_64"]: return False -+if self.conn.support.conn_spice_modular(): ++if self.conn.support.conn_spice_modular1(): +if self.conn.caps.host.cpu.arch in ["x86_64"]: +if not (os.path.exists("/usr/lib64/qemu/hw-usb-redirect.so") and +
[opensuse-commit] commit virt-manager for openSUSE:Factory
Hello community, here is the log from the commit of package virt-manager for openSUSE:Factory checked in at 2020-11-17 21:26:09 Comparing /work/SRC/openSUSE:Factory/virt-manager (Old) and /work/SRC/openSUSE:Factory/.virt-manager.new.24930 (New) Package is "virt-manager" Tue Nov 17 21:26:09 2020 rev:215 rq:848981 version:3.2.0 Changes: --- /work/SRC/openSUSE:Factory/virt-manager/virt-manager.changes 2020-11-06 23:46:40.695081627 +0100 +++ /work/SRC/openSUSE:Factory/.virt-manager.new.24930/virt-manager.changes 2020-11-17 21:26:11.233431480 +0100 @@ -1,0 +2,22 @@ +Mon Nov 16 09:57:34 MST 2020 - carn...@suse.com + +- jsc#SLE-16582, Upgrade virt-manager >= 3.x + * Slim down filesystem device editor UI + * Fix TOCTTOU virt-install bugs (Martin Pitt) + * Several other bug fixes + virt-manager-3.2.0.tar.bz2 +- Drop patches contained in new tarball + 1a1e4580-cloner-Explicitly-reject-network-disks-we-dont-know-how-to-clone.patch + 2773bc35-storagepool-cleanup-volumes-on-pool-cleanup.patch + b1328202-devices-disk-Skip-check_path_search-for-path.patch + virtman-append-usr-sbin-to-search-path.patch + +--- +Wed Nov 11 09:06:35 MST 2020 - carn...@suse.com + +- Upstream bug fixes (bsc#1027942) + 1a1e4580-cloner-Explicitly-reject-network-disks-we-dont-know-how-to-clone.patch + 2773bc35-storagepool-cleanup-volumes-on-pool-cleanup.patch + b1328202-devices-disk-Skip-check_path_search-for-path.patch + +--- Old: virt-manager-3.1.0.tar.bz2 virtman-append-usr-sbin-to-search-path.patch New: virt-manager-3.2.0.tar.bz2 Other differences: -- ++ virt-manager.spec ++ --- /var/tmp/diff_new_pack.sM0EFP/_old 2020-11-17 21:26:12.905433139 +0100 +++ /var/tmp/diff_new_pack.sM0EFP/_new 2020-11-17 21:26:12.905433139 +0100 @@ -21,7 +21,7 @@ %global default_hvs"qemu,xen,lxc" Name: virt-manager -Version:3.1.0 +Version:3.2.0 Release:0 Summary:Virtual Machine Manager License:GPL-2.0-or-later @@ -64,7 +64,6 @@ Patch157: virtman-fix-restore-vm-menu-selection.patch Patch158: virtman-disallow-adding-floppy-disk.patch Patch159: virtman-register-delete-event-for-details-dialog.patch -Patch160: virtman-append-usr-sbin-to-search-path.patch Patch170: virtinst-xen-drive-type.patch Patch171: virtinst-xenbus-disk-index-fix.patch Patch172: virtinst-refresh_before_fetch_pool.patch @@ -189,7 +188,6 @@ %patch157 -p1 %patch158 -p1 %patch159 -p1 -%patch160 -p1 %patch170 -p1 %patch171 -p1 %patch172 -p1 ++ virt-manager-3.1.0.tar.bz2 -> virt-manager-3.2.0.tar.bz2 ++ 11438 lines of diff (skipped) ++ virtinst-add-pvh-support.patch ++ --- /var/tmp/diff_new_pack.sM0EFP/_old 2020-11-17 21:26:14.641434861 +0100 +++ /var/tmp/diff_new_pack.sM0EFP/_new 2020-11-17 21:26:14.641434861 +0100 @@ -1,10 +1,10 @@ References: fate#326698 - Add pvh support to virt-manager At this time support is disabled in this patch. -Index: virt-manager-3.1.0/virtManager/createvm.py +Index: virt-manager-3.2.0/virtManager/createvm.py === virt-manager-3.1.0.orig/virtManager/createvm.py -+++ virt-manager-3.1.0/virtManager/createvm.py +--- virt-manager-3.2.0.orig/virtManager/createvm.py virt-manager-3.2.0/virtManager/createvm.py @@ -836,6 +836,9 @@ class vmmCreateVM(vmmGObjectUI): break if label is None: @@ -15,10 +15,10 @@ # Determine if this is the default given by guest_lookup if (gtype == self._capsinfo.os_type and -Index: virt-manager-3.1.0/virtinst/domain/os.py +Index: virt-manager-3.2.0/virtinst/domain/os.py === virt-manager-3.1.0.orig/virtinst/domain/os.py -+++ virt-manager-3.1.0/virtinst/domain/os.py +--- virt-manager-3.2.0.orig/virtinst/domain/os.py virt-manager-3.2.0/virtinst/domain/os.py @@ -32,6 +32,8 @@ class DomainOs(XMLBuilder): return self.os_type == "hvm" def is_xenpv(self): @@ -28,10 +28,10 @@ def is_container(self): return self.os_type == "exe" -Index: virt-manager-3.1.0/virtinst/guest.py +Index: virt-manager-3.2.0/virtinst/guest.py === virt-manager-3.1.0.orig/virtinst/guest.py -+++ virt-manager-3.1.0/virtinst/guest.py +--- virt-manager-3.2.0.orig/virtinst/guest.py virt-manager-3.2.0/virtinst/guest.py @@ -814,7 +814,7 @@ class Guest(XMLBuilder): usb_tablet = False