[accumulo] branch main updated: Remove TODOs and rename PerTableVolumeChooser (#2734)
This is an automated email from the ASF dual-hosted git repository.
ctubbsii pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/accumulo.git
The following commit(s) were added to refs/heads/main by this push:
new 9777a7e789 Remove TODOs and rename PerTableVolumeChooser (#2734)
9777a7e789 is described below
commit 9777a7e789c3668f1d9619a2a7538495f95b7cfc
Author: Luke Foster <84727868+foste...@users.noreply.github.com>
AuthorDate: Wed May 25 23:00:23 2022 -0400
Remove TODOs and rename PerTableVolumeChooser (#2734)
* Remove TODOs and rename PerTableVolumeChooser
* Rename corresponding test and clean up spotbugs suppressions
Co-authored-by: Christopher Tubbs
---
.../fs/{PerTableVolumeChooser.java => DelegatingChooser.java} | 10 --
...TableVolumeChooserTest.java => DelegatingChooserTest.java} | 6 +++---
.../org/apache/accumulo/server/fs/PerTableVolumeChooser.java | 11 +++
.../main/java/org/apache/accumulo/test/VolumeChooserIT.java | 6 +++---
4 files changed, 13 insertions(+), 20 deletions(-)
diff --git
a/core/src/main/java/org/apache/accumulo/core/spi/fs/PerTableVolumeChooser.java
b/core/src/main/java/org/apache/accumulo/core/spi/fs/DelegatingChooser.java
similarity index 94%
rename from
core/src/main/java/org/apache/accumulo/core/spi/fs/PerTableVolumeChooser.java
rename to
core/src/main/java/org/apache/accumulo/core/spi/fs/DelegatingChooser.java
index 39ae0e52fb..0f99c73030 100644
---
a/core/src/main/java/org/apache/accumulo/core/spi/fs/PerTableVolumeChooser.java
+++ b/core/src/main/java/org/apache/accumulo/core/spi/fs/DelegatingChooser.java
@@ -30,16 +30,14 @@ import org.slf4j.LoggerFactory;
/**
* A {@link VolumeChooser} that delegates to another volume chooser based on
other properties:
* table.custom.volume.chooser for tables, and
general.custom.volume.chooser.scoped for scopes.
- * general.custom.volume.chooser.{scope} can override the system wide setting
for
- * general.custom.volume.chooser.scoped. At the this this was written, the
only known scope was
+ * general.custom.volume.chooser.{scope} can override the system-wide setting
for
+ * general.custom.volume.chooser.scoped. At the time this was written, the
only known scope was
* "logger".
*
* @since 2.1.0
*/
-public class PerTableVolumeChooser implements VolumeChooser {
- // TODO rename this class to DelegatingChooser? It delegates for more than
just per-table scope
- private static final Logger log =
LoggerFactory.getLogger(PerTableVolumeChooser.class);
- // TODO Add hint of expected size to construction, see ACCUMULO-3410
+public class DelegatingChooser implements VolumeChooser {
+ private static final Logger log =
LoggerFactory.getLogger(DelegatingChooser.class);
/* Track VolumeChooser instances so they can keep state. */
private final ConcurrentHashMap
tableSpecificChooserCache =
new ConcurrentHashMap<>();
diff --git
a/core/src/test/java/org/apache/accumulo/core/spi/fs/PerTableVolumeChooserTest.java
b/core/src/test/java/org/apache/accumulo/core/spi/fs/DelegatingChooserTest.java
similarity index 98%
rename from
core/src/test/java/org/apache/accumulo/core/spi/fs/PerTableVolumeChooserTest.java
rename to
core/src/test/java/org/apache/accumulo/core/spi/fs/DelegatingChooserTest.java
index 955bb01b01..eaad25c3bf 100644
---
a/core/src/test/java/org/apache/accumulo/core/spi/fs/PerTableVolumeChooserTest.java
+++
b/core/src/test/java/org/apache/accumulo/core/spi/fs/DelegatingChooserTest.java
@@ -37,7 +37,7 @@ import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-public class PerTableVolumeChooserTest {
+public class DelegatingChooserTest {
private static final String TABLE_CUSTOM_SUFFIX = "volume.chooser";
@@ -47,7 +47,7 @@ public class PerTableVolumeChooserTest {
private ServiceEnvironment serviceEnv;
private Configuration tableConf;
- private PerTableVolumeChooser chooser;
+ private DelegatingChooser chooser;
private Configuration systemConf;
public static class MockChooser1 extends RandomVolumeChooser {}
@@ -58,7 +58,7 @@ public class PerTableVolumeChooserTest {
public void before() {
serviceEnv = createStrictMock(ServiceEnvironment.class);
-chooser = new PerTableVolumeChooser();
+chooser = new DelegatingChooser();
tableConf = createStrictMock(Configuration.class);
systemConf = createStrictMock(Configuration.class);
diff --git
a/server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java
b/server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java
index 7b1008465e..888b1d774e 100644
---
a/server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java
+++
b/server/base/src/main/java/org/apache/accumulo/server/fs/PerTableVolumeChooser.java
@@ -18,19 +18,14 @@
*/
package org.apache.accumulo.server.fs;
+import
[accumulo-website] branch asf-staging updated: Automatic Site Publish by Buildbot
This is an automated email from the ASF dual-hosted git repository.
git-site-role pushed a commit to branch asf-staging
in repository https://gitbox.apache.org/repos/asf/accumulo-website.git
The following commit(s) were added to refs/heads/asf-staging by this push:
new 3f4ee2c8 Automatic Site Publish by Buildbot
3f4ee2c8 is described below
commit 3f4ee2c865db2ce0094fe0ca1a63e983d9c1182b
Author: buildbot
AuthorDate: Wed May 25 18:21:00 2022 +
Automatic Site Publish by Buildbot
---
output/feed.xml | 4 ++--
output/release/accumulo-2.1.0/index.html | 3 +++
output/search_data.json | 2 +-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/output/feed.xml b/output/feed.xml
index 8bacebc7..3d52fcf6 100644
--- a/output/feed.xml
+++ b/output/feed.xml
@@ -6,8 +6,8 @@
https://accumulo.apache.org/
https://accumulo.apache.org/feed.xml; rel="self"
type="application/rss+xml"/>
-Mon, 02 May 2022 17:22:25 +
-Mon, 02 May 2022 17:22:25 +
+Wed, 25 May 2022 18:20:53 +
+Wed, 25 May 2022 18:20:53 +
Jekyll v4.2.0
diff --git a/output/release/accumulo-2.1.0/index.html
b/output/release/accumulo-2.1.0/index.html
index dc31d7dc..57b21652 100644
--- a/output/release/accumulo-2.1.0/index.html
+++ b/output/release/accumulo-2.1.0/index.html
@@ -461,7 +461,10 @@ timing out. https://github.com/apache/accumulo/issues/2599;>#2599 <
Other notable changes
+ https://github.com/apache/accumulo/issues/1174;>#1174 https://github.com/apache/accumulo/issues/816;>#816 Abstract metadata
and change root metadata schema
https://github.com/apache/accumulo/issues/1309;>#1309
Prevent cloning metadata table
+ https://github.com/apache/accumulo/issues/1313;>#1313 https://github.com/apache/accumulo/issues/936;>#936 Store Root Tablet
list of files in Zookeeper
+ https://github.com/apache/accumulo/issues/1310;>#1310
Examine WALs used by root tablet during GC
https://github.com/apache/accumulo/issues/1294;>#1294 https://github.com/apache/accumulo/issues/1299;>#1299 Add optional -t
tablename to importdirectory shell command.
https://github.com/apache/accumulo/issues/1332;>#1332
Disable FileSystemMonitor checks by default
https://github.com/apache/accumulo/issues/1345;>#1345 https://github.com/apache/accumulo/issues/1352;>#1352 Allow gc
initiated compaction as option.
diff --git a/output/search_data.json b/output/search_data.json
index e994c0a3..64e16545 100644
--- a/output/search_data.json
+++ b/output/search_data.json
@@ -304,7 +304,7 @@
"release-accumulo-2-1-0": {
"title": "Apache Accumulo 2.1.0",
- "content" : "** DRAFT RELEASE NOTES **AboutTODO high level
description of the releaseTODO summarize contributionsTODO Version Upgrade
guidanceMinimum RequirementsTODO describe requirementsBinary
IncompatibilityThis release is known to be incompatible with prior versions of
the clientlibraries. That is, the 2.0.0 or 2.0.1 version of the client
libraries will notbe able to communicate with a 2.1.0 or later installation of
Accumulo, nor willthe 2.1.0 or later version of the client li [...]
+ "content" : "** DRAFT RELEASE NOTES **AboutTODO high level
description of the releaseTODO summarize contributionsTODO Version Upgrade
guidanceMinimum RequirementsTODO describe requirementsBinary
IncompatibilityThis release is known to be incompatible with prior versions of
the clientlibraries. That is, the 2.0.0 or 2.0.1 version of the client
libraries will notbe able to communicate with a 2.1.0 or later installation of
Accumulo, nor willthe 2.1.0 or later version of the client li [...]
"url": " /release/accumulo-2.1.0/",
"categories": "release"
}
[accumulo-website] branch main updated: Update release notes (#317)
This is an automated email from the ASF dual-hosted git repository.
mmiller pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/accumulo-website.git
The following commit(s) were added to refs/heads/main by this push:
new 7746e11f Update release notes (#317)
7746e11f is described below
commit 7746e11f63c010bbf81ffe97a2bd422b7d0b39f0
Author: Mike Miller
AuthorDate: Wed May 25 18:20:40 2022 +
Update release notes (#317)
---
_posts/release/2022-04-27-accumulo-2.1.0.md | 3 +++
1 file changed, 3 insertions(+)
diff --git a/_posts/release/2022-04-27-accumulo-2.1.0.md
b/_posts/release/2022-04-27-accumulo-2.1.0.md
index 932f1f10..3ac3b44f 100644
--- a/_posts/release/2022-04-27-accumulo-2.1.0.md
+++ b/_posts/release/2022-04-27-accumulo-2.1.0.md
@@ -294,7 +294,10 @@ timing out. {% ghi 2599 %} {% ghi 2598 %}
### Other notable changes
+* {% ghi 1174 %} {% ghi 816 %} Abstract metadata and change root metadata
schema
* {% ghi 1309 %} Prevent cloning metadata table
+* {% ghi 1313 %} {% ghi 936 %} Store Root Tablet list of files in Zookeeper
+* {% ghi 1310 %} Examine WALs used by root tablet during GC
* {% ghi 1294 %} {% ghi 1299 %} Add optional -t tablename to importdirectory
shell command.
* {% ghi 1332 %} Disable FileSystemMonitor checks by default
* {% ghi 1345 %} {% ghi 1352 %} Allow gc initiated compaction as option.
