[jira] [Assigned] (AIRFLOW-5733) Move all AWS components to its own submodule
[
https://issues.apache.org/jira/browse/AIRFLOW-5733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bas Harenslak reassigned AIRFLOW-5733:
--
Assignee: Bas Harenslak
> Move all AWS components to its own submodule
>
>
> Key: AIRFLOW-5733
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5733
> Project: Apache Airflow
> Issue Type: Improvement
> Components: aws
>Affects Versions: 2.0.0
>Reporter: Bas Harenslak
>Assignee: Bas Harenslak
>Priority: Major
>
> As voted for in
> [https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths#AIP-21:Changesinimportpaths-Case#3\{aws/azure/gcp}_*],
> and in similar fashion to all GCP components, which are now stored under
> /airflow/gcp, we should move all AWS components to /airflow/aws.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [airflow] acroos commented on issue #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST reqeust
acroos commented on issue #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST reqeust URL: https://github.com/apache/airflow/pull/6380#issuecomment-545802022 @ashb is it possible to re-run a step in Travis? the test that's failing on only one of the environments now doesn't seem to have anything to do with these changes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] pdambrauskas commented on a change in pull request #6397: [AIRFLOW-5727] Build --connect parameter only if port and schema are defined
pdambrauskas commented on a change in pull request #6397: [AIRFLOW-5727] Build
--connect parameter only if port and schema are defined
URL: https://github.com/apache/airflow/pull/6397#discussion_r338440420
##
File path: airflow/contrib/hooks/sqoop_hook.py
##
@@ -147,11 +147,12 @@ def _prepare_command(self, export=False):
if self.hcatalog_table:
connection_cmd += ["--hcatalog-table", self.hcatalog_table]
-connection_cmd += ["--connect", "{}:{}/{}".format(
-self.conn.host,
-self.conn.port,
-self.conn.schema
-)]
+connect_str = "{}".format(self.conn.host)
Review comment:
Why not just `connect_str = self.conn.host`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] pdambrauskas commented on a change in pull request #6397: [AIRFLOW-5727] Build --connect parameter only if port and schema are defined
pdambrauskas commented on a change in pull request #6397: [AIRFLOW-5727] Build
--connect parameter only if port and schema are defined
URL: https://github.com/apache/airflow/pull/6397#discussion_r338440617
##
File path: airflow/contrib/hooks/sqoop_hook.py
##
@@ -147,11 +147,12 @@ def _prepare_command(self, export=False):
if self.hcatalog_table:
connection_cmd += ["--hcatalog-table", self.hcatalog_table]
-connection_cmd += ["--connect", "{}:{}/{}".format(
-self.conn.host,
-self.conn.port,
-self.conn.schema
-)]
+connect_str = "{}".format(self.conn.host)
+if self.conn.port:
+connect_str += ":{}".format(self.conn.port)
+if self.conn.schema:
+connect_str += "/{}".format(self.conn.schema)
+connection_cmd += ["--connect", "{}".format(connect_str)]
Review comment:
`connection_cmd += ["--connect", connect_str]`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] michalslowikowski00 opened a new pull request #6403: [AIRFLOW-5670] Rename DataFlowHook to DataflowHook
michalslowikowski00 opened a new pull request #6403: [AIRFLOW-5670] Rename
DataFlowHook to DataflowHook
URL: https://github.com/apache/airflow/pull/6403
Part of AIP-21
- renamed DataFlowHook to DataflowHook
- added added to gcp_dataflow_hook.py deprecation warning
--
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] JavierLopezT edited a comment on issue #6396: [AIRFLOW-5726] Delete table as file name in RedshiftToS3Transfer
JavierLopezT edited a comment on issue #6396: [AIRFLOW-5726] Delete table as file name in RedshiftToS3Transfer URL: https://github.com/apache/airflow/pull/6396#issuecomment-545805838 I have a problem here with a part of the documentation, the one defining the param s3_key. If I leave it's definition as a single line ':param s3_key: reference to a specific S3 key. If table_as_file_name is set to False, this param must include the desired file name', it doesn't pass the pylint check due to line length. If I split it in two lines as: 1st line: :param s3_key: reference to a specific S3 key. If table_as_file_name is set 2nd line: to False, this param must include the desired file name It doesn't pass the documentation test. Any idea on how to handle this? Thank you very much This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] JavierLopezT commented on issue #6396: [AIRFLOW-5726] Delete table as file name in RedshiftToS3Transfer
JavierLopezT commented on issue #6396: [AIRFLOW-5726] Delete table as file name in RedshiftToS3Transfer URL: https://github.com/apache/airflow/pull/6396#issuecomment-545805838 I have a problem here with a part of the documentation. If I leave it as a single line ':param s3_key: reference to a specific S3 key. If table_as_file_name is set to False, this param must include the desired file name', it doesn't pass the pylint check due to line length. If I split it in two lines as: 1st line: :param s3_key: reference to a specific S3 key. If table_as_file_name is set 2nd line: to False, this param must include the desired file name It doesn't pass the documentation test. Any idea on how to handle this? Thank you very much This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] michalslowikowski00 closed pull request #6403: [AIRFLOW-5670] Rename DataFlowHook to DataflowHook
michalslowikowski00 closed pull request #6403: [AIRFLOW-5670] Rename DataFlowHook to DataflowHook URL: https://github.com/apache/airflow/pull/6403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (AIRFLOW-5670) [AIRFLOW-5670] Rename DataFlowHook to DataflowHook
[ https://issues.apache.org/jira/browse/AIRFLOW-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958653#comment-16958653 ] ASF GitHub Bot commented on AIRFLOW-5670: - michalslowikowski00 commented on pull request #6403: [AIRFLOW-5670] Rename DataFlowHook to DataflowHook URL: https://github.com/apache/airflow/pull/6403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [AIRFLOW-5670] Rename DataFlowHook to DataflowHook > -- > > Key: AIRFLOW-5670 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5670 > Project: Apache Airflow > Issue Type: Sub-task > Components: gcp >Affects Versions: 1.10.5 >Reporter: Michał Słowikowski >Assignee: Michał Słowikowski >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5670) [AIRFLOW-5670] Rename DataFlowHook to DataflowHook
[
https://issues.apache.org/jira/browse/AIRFLOW-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958650#comment-16958650
]
ASF GitHub Bot commented on AIRFLOW-5670:
-
michalslowikowski00 commented on pull request #6403: [AIRFLOW-5670] Rename
DataFlowHook to DataflowHook
URL: https://github.com/apache/airflow/pull/6403
Part of AIP-21
- renamed DataFlowHook to DataflowHook
- added added to gcp_dataflow_hook.py deprecation warning
--
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [AIRFLOW-5670] Rename DataFlowHook to DataflowHook
> --
>
> Key: AIRFLOW-5670
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5670
> Project: Apache Airflow
> Issue Type: Sub-task
> Components: gcp
>Affects Versions: 1.10.5
>Reporter: Michał Słowikowski
>Assignee: Michał Słowikowski
>Priority: Minor
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5671) [AIRFLOW-5671] rename DataProcHook to DataprocHook
[
https://issues.apache.org/jira/browse/AIRFLOW-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958660#comment-16958660
]
ASF GitHub Bot commented on AIRFLOW-5671:
-
michalslowikowski00 commented on pull request #6404: [AIRFLOW-5671] rename
DataProcHook to DataprocHook
URL: https://github.com/apache/airflow/pull/6404
Part of AIP-21
--
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5671
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [AIRFLOW-5671] rename DataProcHook to DataprocHook
> --
>
> Key: AIRFLOW-5671
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5671
> Project: Apache Airflow
> Issue Type: Sub-task
> Components: gcp
>Affects Versions: 1.10.5
>Reporter: Michał Słowikowski
>Assignee: Michał Słowikowski
>Priority: Minor
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [airflow] michalslowikowski00 opened a new pull request #6404: [AIRFLOW-5671] rename DataProcHook to DataprocHook
michalslowikowski00 opened a new pull request #6404: [AIRFLOW-5671] rename
DataProcHook to DataprocHook
URL: https://github.com/apache/airflow/pull/6404
Part of AIP-21
--
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5671
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on issue #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST reqeust
ashb commented on issue #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST reqeust URL: https://github.com/apache/airflow/pull/6380#issuecomment-545828408 @acroos Re-run that stage. (It needs someone with write access to the repo to hit the button) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST reqeust
ashb commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST reqeust URL: https://github.com/apache/airflow/pull/6380#discussion_r338470212 ## File path: airflow/api/common/experimental/trigger_dag.py ## @@ -107,7 +107,7 @@ def trigger_dag( :param run_id: ID of the dag_run :param conf: configuration :param execution_date: date of execution -:param replace_microseconds: whether microseconds should be zeroed +:param replace_microseconds: whether microseconds should be zeroed (ignored if execution_date is given) Review comment: I'm not sure if it matters, but the view in `airflow/www/api/experimental/endpoints.py` doesn't pass through a replace_microseconds parameter, so there's no way of setting this to anything that the default True from the REST API This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability
ashb commented on a change in pull request #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#discussion_r338474282 ## File path: docs/howto/enable-dag-serialization.rst ## @@ -0,0 +1,109 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + .. http://www.apache.org/licenses/LICENSE-2.0 + + .. Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. + + + + +Enable DAG Serialization + + +Add the following settings in ``airflow.cfg``: + +.. code-block:: ini + +[core] +store_serialized_dags = True +min_serialized_dag_update_interval = 30 + +* ``store_serialized_dags``: This flag decides whether to serialises DAGs and persist them in DB. +If set to True, Webserver reads from DB instead of parsing DAG files +* ``min_serialized_dag_update_interval``: This flag sets the minimum interval (in seconds) after which +the serialized DAG in DB should be updated. This helps in reducing database write rate. + +If you are updating Airflow from <1.10.6, please do not forget to run ``airflow db upgrade``. + + +How it works + + +In order to make Airflow Webserver stateless (almost!), Airflow >=1.10.6 supports +DAG Serialization and DB Persistence. + +.. image:: ../img/dag_serialization.png + +As shown in the image above in Vanilla Airflow, the Webserver and the Scheduler both +needs access to the DAG files. Both the scheduler and webserver parses the DAG files. + +With **DAG Serialization** we aim to decouple the webserver from DAG parsing +which would make the Webserver very light-weight. + +As shown in the image above, when using the dag_serilization feature, +the Scheduler parses the DAG files, serializes them in JSON format and saves them in the Metadata DB. + +The Webserver now instead of having to parse the DAG file again, reads the +serialized DAGs in JSON, de-serializes them and create the DagBag and uses it +to show in the UI. + +One of the key features that is implemented as the part of DAG Serialization is that +instead of loading an entire DagBag when the WebServer starts we only load each DAG on demand from the +Serialized Dag table. This helps reduce Webserver startup time and memory. The reduction is notable +when you have large number of DAGs. + +Below is the screenshot of the ``serialized_dag`` table in Metadata DB: + +.. image:: ../img/serialized_dag_table.png + +Limitations +--- +The Webserver will still need access to DAG files in the following cases, +which is why we said "almost" stateless. + +* **Rendered Template** tab will still have to parse Python file as it needs all the details like +the execution date and even the data passed by the upstream task using Xcom. +* **Code View** will read the DAG File & show it using Pygments. +However, it does not need to Parse the Python file so it is still a small operation. +* :doc:`Extra Operator Links ` would not work out of +the box. They need to be defined in Airflow Plugin. + +**Existing Airflow Operators**: +To make extra operator links work with existing operators like BigQuery, copy all +the classes that are defined in ``operator_extra_links`` property. Review comment: I think for the pre-existing ones that do work we should do what is neccsary to registry them which since it is "internal" doesn't need to be a full plugin. Something like ``` import airflow.plugins_manager airflow.plugins_manager.operator_extra_links.append(BigQueryConsoleLink) ``` sort of thing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] OmerJog commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution
OmerJog commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution URL: https://github.com/apache/airflow/pull/6370#issuecomment-545834039 @Fokko jira still open This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] OmerJog commented on issue #6095: [AIRFLOW-5474] Add Basic auth to Druid hook
OmerJog commented on issue #6095: [AIRFLOW-5474] Add Basic auth to Druid hook URL: https://github.com/apache/airflow/pull/6095#issuecomment-545835716 @Fokko care to review druid hook enhancement? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #6377: [AIRFLOW-5589] monitor pods by labels instead of names
ashb commented on a change in pull request #6377: [AIRFLOW-5589] monitor pods
by labels instead of names
URL: https://github.com/apache/airflow/pull/6377#discussion_r338476326
##
File path: airflow/contrib/operators/kubernetes_pod_operator.py
##
@@ -112,55 +113,61 @@ class KubernetesPodOperator(BaseOperator): # pylint:
disable=too-many-instance-
"""
template_fields = ('cmds', 'arguments', 'env_vars', 'config_file')
+@staticmethod
+def create_labels_for_pod(context):
+"""
+Generate labels for the pod s.t. we can track it in case of Operator
crash
+
+:param context:
+:return:
+"""
+labels = {
+'dag_id': context['dag'].dag_id,
+'task_id': context['task'].task_id,
+'exec_date': context['ts'],
+'try_number': context['ti'].try_number,
Review comment:
Oh I see you've done it else where.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #6377: [AIRFLOW-5589] monitor pods by labels instead of names
ashb commented on a change in pull request #6377: [AIRFLOW-5589] monitor pods
by labels instead of names
URL: https://github.com/apache/airflow/pull/6377#discussion_r338476771
##
File path: airflow/contrib/operators/kubernetes_pod_operator.py
##
@@ -171,6 +178,76 @@ def execute(self, context):
except AirflowException as ex:
raise AirflowException('Pod Launching failed:
{error}'.format(error=ex))
+def _try_numbers_do_not_match(self, context, pod):
+return pod['metadata']['labels']['task_instance']['try_number'] !=
context['ti'].try_number
Review comment:
This is never going to match as the types are different - string vs int
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #6377: [AIRFLOW-5589] monitor pods by labels instead of names
ashb commented on a change in pull request #6377: [AIRFLOW-5589] monitor pods
by labels instead of names
URL: https://github.com/apache/airflow/pull/6377#discussion_r338478137
##
File path: airflow/contrib/operators/kubernetes_pod_operator.py
##
@@ -112,55 +113,60 @@ class KubernetesPodOperator(BaseOperator): # pylint:
disable=too-many-instance-
"""
template_fields = ('cmds', 'arguments', 'env_vars', 'config_file')
+@staticmethod
+def create_labels_for_pod(context):
+"""
+Generate labels for the pod s.t. we can track it in case of Operator
crash
+
+:param context:
+:return:
+"""
+labels = {
+'dag_id': context['dag'].dag_id,
+'task_id': context['task'].task_id,
+'exec_date': context['ts'],
+'try_number': context['ti'].try_number,
Review comment:
I'm now second guessing myself on this.
If we do add this check on try_number in I can't think of a case when we
would re-attach to a running pod. (because if this operator fails/dies/zombies
for it to run again it would be the next try_number.)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin opened a new pull request #6405: [AIRFLOW-XXX] Add resources & links to CONTRIBUTING.rst
nuclearpinguin opened a new pull request #6405: [AIRFLOW-XXX] Add resources &
links to CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/6405
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] Fokko merged pull request #6095: [AIRFLOW-5474] Add Basic auth to Druid hook
Fokko merged pull request #6095: [AIRFLOW-5474] Add Basic auth to Druid hook URL: https://github.com/apache/airflow/pull/6095 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution
Fokko commented on issue #6370: AIRFLOW-5701: Don't clear xcom explicitly before execution URL: https://github.com/apache/airflow/pull/6370#issuecomment-545838956 Thank you @OmerJog This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (AIRFLOW-5474) Add Basic Auth to Druid hook
[ https://issues.apache.org/jira/browse/AIRFLOW-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958718#comment-16958718 ] ASF GitHub Bot commented on AIRFLOW-5474: - Fokko commented on pull request #6095: [AIRFLOW-5474] Add Basic auth to Druid hook URL: https://github.com/apache/airflow/pull/6095 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Basic Auth to Druid hook > > > Key: AIRFLOW-5474 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5474 > Project: Apache Airflow > Issue Type: Improvement > Components: hooks >Affects Versions: 1.10.5 >Reporter: Adam Welsh >Assignee: Adam Welsh >Priority: Minor > Fix For: 2.0.0 > > > Use login and password from druid ingestion connection to add Basic HTTP auth > to druid hook. If login and/or password is None then ensure hook still works. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (AIRFLOW-5701) Don't clear xcom explicitly before execution
[ https://issues.apache.org/jira/browse/AIRFLOW-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AIRFLOW-5701. --- Resolution: Fixed > Don't clear xcom explicitly before execution > > > Key: AIRFLOW-5701 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5701 > Project: Apache Airflow > Issue Type: Bug > Components: xcom >Affects Versions: 1.10.5 >Reporter: Fokko Driesprong >Assignee: Fokko Driesprong >Priority: Major > Fix For: 2.0.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [airflow] ashb merged pull request #6336: [AIRFLOW-5073] Change SQLSensor to optionally treat NULL as keep poking
ashb merged pull request #6336: [AIRFLOW-5073] Change SQLSensor to optionally treat NULL as keep poking URL: https://github.com/apache/airflow/pull/6336 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (AIRFLOW-5073) Change SQLSensor behavior returning 'success' for NULL result
[ https://issues.apache.org/jira/browse/AIRFLOW-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958727#comment-16958727 ] ASF GitHub Bot commented on AIRFLOW-5073: - ashb commented on pull request #6336: [AIRFLOW-5073] Change SQLSensor to optionally treat NULL as keep poking URL: https://github.com/apache/airflow/pull/6336 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Change SQLSensor behavior returning 'success' for NULL result > -- > > Key: AIRFLOW-5073 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5073 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Affects Versions: 1.10.3 >Reporter: Anton Zayniev >Priority: Major > > Change SQLSensor to treat NULL as fail. > Add boolean _allow_null_ parameter to support legacy behavior passing NULL as > success. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5073) Change SQLSensor behavior returning 'success' for NULL result
[ https://issues.apache.org/jira/browse/AIRFLOW-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958728#comment-16958728 ] ASF subversion and git services commented on AIRFLOW-5073: -- Commit 6ba5445a11bcdf165e861ec7a9335ca5485c in airflow's branch refs/heads/master from Anton Zayniev [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=6ba5442 ] [AIRFLOW-5073] Change SQLSensor to optionally treat NULL as keep poking (#6336) > Change SQLSensor behavior returning 'success' for NULL result > -- > > Key: AIRFLOW-5073 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5073 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Affects Versions: 1.10.3 >Reporter: Anton Zayniev >Priority: Major > > Change SQLSensor to treat NULL as fail. > Add boolean _allow_null_ parameter to support legacy behavior passing NULL as > success. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (AIRFLOW-5474) Add Basic Auth to Druid hook
[ https://issues.apache.org/jira/browse/AIRFLOW-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved AIRFLOW-5474. --- Fix Version/s: 2.0.0 Resolution: Fixed > Add Basic Auth to Druid hook > > > Key: AIRFLOW-5474 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5474 > Project: Apache Airflow > Issue Type: Improvement > Components: hooks >Affects Versions: 1.10.5 >Reporter: Adam Welsh >Assignee: Adam Welsh >Priority: Minor > Fix For: 2.0.0 > > > Use login and password from druid ingestion connection to add Basic HTTP auth > to druid hook. If login and/or password is None then ensure hook still works. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5474) Add Basic Auth to Druid hook
[ https://issues.apache.org/jira/browse/AIRFLOW-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958719#comment-16958719 ] ASF subversion and git services commented on AIRFLOW-5474: -- Commit 62675b30c8aa23a7b9780c844b3c067847dd6531 in airflow's branch refs/heads/master from awelsh93 [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=62675b3 ] [AIRFLOW-5474] Add Basic auth to Druid hook (#6095) > Add Basic Auth to Druid hook > > > Key: AIRFLOW-5474 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5474 > Project: Apache Airflow > Issue Type: Improvement > Components: hooks >Affects Versions: 1.10.5 >Reporter: Adam Welsh >Assignee: Adam Welsh >Priority: Minor > Fix For: 2.0.0 > > > Use login and password from druid ingestion connection to add Basic HTTP auth > to druid hook. If login and/or password is None then ensure hook still works. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [airflow] potiuk merged pull request #6405: [AIRFLOW-XXX] Add resources & links to CONTRIBUTING.rst
potiuk merged pull request #6405: [AIRFLOW-XXX] Add resources & links to CONTRIBUTING.rst URL: https://github.com/apache/airflow/pull/6405 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] michalslowikowski00 opened a new pull request #6406: [AIRFLOW-5672] rename CloudDLPHook to CloudDlpHook
michalslowikowski00 opened a new pull request #6406: [AIRFLOW-5672] rename
CloudDLPHook to CloudDlpHook
URL: https://github.com/apache/airflow/pull/6406
Part of AIP-21
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5672
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (AIRFLOW-5735) Move airflow.contrib.operators.s3_to_gcs_operator to core
Tomasz Urbaszek created AIRFLOW-5735: Summary: Move airflow.contrib.operators.s3_to_gcs_operator to core Key: AIRFLOW-5735 URL: https://issues.apache.org/jira/browse/AIRFLOW-5735 Project: Apache Airflow Issue Type: Improvement Components: gcp Affects Versions: 2.0.0 Reporter: Tomasz Urbaszek -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (AIRFLOW-5736) Move airflow.contrib.operators.gcs_to_gdrive_operator to core
Tomasz Urbaszek created AIRFLOW-5736: Summary: Move airflow.contrib.operators.gcs_to_gdrive_operator to core Key: AIRFLOW-5736 URL: https://issues.apache.org/jira/browse/AIRFLOW-5736 Project: Apache Airflow Issue Type: Improvement Components: gcp Affects Versions: 2.0.0 Reporter: Tomasz Urbaszek -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5073) Change SQLSensor behavior returning 'success' for NULL result
[ https://issues.apache.org/jira/browse/AIRFLOW-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958739#comment-16958739 ] ASF subversion and git services commented on AIRFLOW-5073: -- Commit ffe4c3a38a2649b95ddb82cb1a70b8b73d62e474 in airflow's branch refs/heads/v1-10-test from Anton Zayniev [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=ffe4c3a ] [AIRFLOW-5073] Change SQLSensor to optionally treat NULL as keep poking (#6336) (cherry picked from commit 6ba5445a11bcdf165e861ec7a9335ca5485c) > Change SQLSensor behavior returning 'success' for NULL result > -- > > Key: AIRFLOW-5073 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5073 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Affects Versions: 1.10.3 >Reporter: Anton Zayniev >Priority: Major > > Change SQLSensor to treat NULL as fail. > Add boolean _allow_null_ parameter to support legacy behavior passing NULL as > success. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5073) Change SQLSensor behavior returning 'success' for NULL result
[ https://issues.apache.org/jira/browse/AIRFLOW-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958738#comment-16958738 ] ASF subversion and git services commented on AIRFLOW-5073: -- Commit 9a8f042269a4d35b2c3356caded5a2d49f1faef8 in airflow's branch refs/heads/v1-10-test from Anton Zayniev [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=9a8f042 ] [AIRFLOW-5073] Optionally treat NULL as failure and keep poking in SQL sensor (#5688) Change SQLSensor to treat NULL as fail. Add boolean allow_null parameter to support legacy behavior passing NULL as success. (cherry picked from commit 4c9051d6d415ba3773f4a4714d0da8045feef883) > Change SQLSensor behavior returning 'success' for NULL result > -- > > Key: AIRFLOW-5073 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5073 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Affects Versions: 1.10.3 >Reporter: Anton Zayniev >Priority: Major > > Change SQLSensor to treat NULL as fail. > Add boolean _allow_null_ parameter to support legacy behavior passing NULL as > success. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5073) Change SQLSensor behavior returning 'success' for NULL result
[ https://issues.apache.org/jira/browse/AIRFLOW-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958749#comment-16958749 ] ASF subversion and git services commented on AIRFLOW-5073: -- Commit 9a8f042269a4d35b2c3356caded5a2d49f1faef8 in airflow's branch refs/heads/v1-10-test from Anton Zayniev [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=9a8f042 ] [AIRFLOW-5073] Optionally treat NULL as failure and keep poking in SQL sensor (#5688) Change SQLSensor to treat NULL as fail. Add boolean allow_null parameter to support legacy behavior passing NULL as success. (cherry picked from commit 4c9051d6d415ba3773f4a4714d0da8045feef883) > Change SQLSensor behavior returning 'success' for NULL result > -- > > Key: AIRFLOW-5073 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5073 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Affects Versions: 1.10.3 >Reporter: Anton Zayniev >Priority: Major > > Change SQLSensor to treat NULL as fail. > Add boolean _allow_null_ parameter to support legacy behavior passing NULL as > success. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5073) Change SQLSensor behavior returning 'success' for NULL result
[ https://issues.apache.org/jira/browse/AIRFLOW-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958750#comment-16958750 ] ASF subversion and git services commented on AIRFLOW-5073: -- Commit ffe4c3a38a2649b95ddb82cb1a70b8b73d62e474 in airflow's branch refs/heads/v1-10-test from Anton Zayniev [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=ffe4c3a ] [AIRFLOW-5073] Change SQLSensor to optionally treat NULL as keep poking (#6336) (cherry picked from commit 6ba5445a11bcdf165e861ec7a9335ca5485c) > Change SQLSensor behavior returning 'success' for NULL result > -- > > Key: AIRFLOW-5073 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5073 > Project: Apache Airflow > Issue Type: Improvement > Components: core >Affects Versions: 1.10.3 >Reporter: Anton Zayniev >Priority: Major > > Change SQLSensor to treat NULL as fail. > Add boolean _allow_null_ parameter to support legacy behavior passing NULL as > success. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (AIRFLOW-5737) Move example_gcp_dlp_operator.py to example_dlp.py
Jarek Potiuk created AIRFLOW-5737: - Summary: Move example_gcp_dlp_operator.py to example_dlp.py Key: AIRFLOW-5737 URL: https://issues.apache.org/jira/browse/AIRFLOW-5737 Project: Apache Airflow Issue Type: Improvement Components: gcp Affects Versions: 2.0.0 Reporter: Jarek Potiuk Reference [https://wiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths] Move contrib/example_gcp_dlp_operator.py -> providers/google/gcp/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [airflow] acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST reqeust
acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST reqeust URL: https://github.com/apache/airflow/pull/6380#discussion_r338494584 ## File path: airflow/api/common/experimental/trigger_dag.py ## @@ -107,7 +107,7 @@ def trigger_dag( :param run_id: ID of the dag_run :param conf: configuration :param execution_date: date of execution -:param replace_microseconds: whether microseconds should be zeroed +:param replace_microseconds: whether microseconds should be zeroed (ignored if execution_date is given) Review comment: that's true, maybe would be nice to add that as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (AIRFLOW-5735) Move airflow.contrib.operators.s3_to_gcs_operator to core
[ https://issues.apache.org/jira/browse/AIRFLOW-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomasz Urbaszek updated AIRFLOW-5735: - Description: Reference [https://wiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths] Move airflow/contrib/operators/s3_to_gcs_operator -> airflow/operators was: Reference [https://wiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths] Move contrib/example_gcp_dlp_operator.py -> providers/google/gcp/ > Move airflow.contrib.operators.s3_to_gcs_operator to core > - > > Key: AIRFLOW-5735 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5735 > Project: Apache Airflow > Issue Type: Improvement > Components: gcp >Affects Versions: 2.0.0 >Reporter: Tomasz Urbaszek >Priority: Minor > > Reference > [https://wiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths] > Move airflow/contrib/operators/s3_to_gcs_operator -> airflow/operators -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [airflow] danccooper commented on a change in pull request #6377: [AIRFLOW-5589] monitor pods by labels instead of names
danccooper commented on a change in pull request #6377: [AIRFLOW-5589] monitor
pods by labels instead of names
URL: https://github.com/apache/airflow/pull/6377#discussion_r338494904
##
File path: airflow/contrib/operators/kubernetes_pod_operator.py
##
@@ -112,55 +113,60 @@ class KubernetesPodOperator(BaseOperator): # pylint:
disable=too-many-instance-
"""
template_fields = ('cmds', 'arguments', 'env_vars', 'config_file')
+@staticmethod
+def create_labels_for_pod(context):
+"""
+Generate labels for the pod s.t. we can track it in case of Operator
crash
+
+:param context:
+:return:
+"""
+labels = {
+'dag_id': context['dag'].dag_id,
+'task_id': context['task'].task_id,
+'exec_date': context['ts'],
+'try_number': context['ti'].try_number,
Review comment:
I should've realised that. We do indeed monitor a previous try number on
purpose in my original changes.
With the try number changes the main duplicate pod issue will be fixed still
as we force kill it before starting a new one. But I took the view that,
although perhaps confusing in terms of try number, it is far more efficient to
continue monitoring the previous try in the case of worker failure. AFAIK
worker failure/restart is the only situation in which pods remain running and
are not killed. If you fail a task via the UI it triggers a pod kill for
example.
Unless you have another solution that can check & re-use the previous try
number then I think we're better off removing the try_number changes?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6371: [AIRFLOW-5691] Rewrite Dataproc operators to use python library
codecov-io edited a comment on issue #6371: [AIRFLOW-5691] Rewrite Dataproc operators to use python library URL: https://github.com/apache/airflow/pull/6371#issuecomment-54999 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6371?src=pr&el=h1) Report > Merging [#6371](https://codecov.io/gh/apache/airflow/pull/6371?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/47eac794cd0d8646c989f4b55541ff0693438a33?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `90.83%`. [](https://codecov.io/gh/apache/airflow/pull/6371?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master #6371 +/- ## = - Coverage 80.61% 80.6% -0.01% = Files 626 626 Lines 36217 36279 +62 = + Hits29197 29244 +47 - Misses 70207035 +15 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6371?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/operators/dataproc\_operator.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhcHJvY19vcGVyYXRvci5weQ==) | `100% <ø> (ø)` | :arrow_up: | | [airflow/gcp/example\_dags/example\_dataproc.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YXByb2MucHk=) | `0% <0%> (ø)` | :arrow_up: | | [airflow/contrib/hooks/gcp\_dataproc\_hook.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9kYXRhcHJvY19ob29rLnB5) | `100% <100%> (ø)` | :arrow_up: | | [airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5) | `88.21% <93.79%> (+6.52%)` | :arrow_up: | | [airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=) | `98.6% <98.11%> (+43.35%)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/kube\_client.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL2t1YmVfY2xpZW50LnB5) | `33.33% <0%> (-41.67%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `70.14% <0%> (-28.36%)` | :arrow_down: | | ... and [3 more](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6371?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6371?src=pr&el=footer). Last update [47eac79...42bf826](https://codecov.io/gh/apache/airflow/pull/6371?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6371: [AIRFLOW-5691] Rewrite Dataproc operators to use python library
codecov-io edited a comment on issue #6371: [AIRFLOW-5691] Rewrite Dataproc operators to use python library URL: https://github.com/apache/airflow/pull/6371#issuecomment-54999 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6371?src=pr&el=h1) Report > Merging [#6371](https://codecov.io/gh/apache/airflow/pull/6371?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/47eac794cd0d8646c989f4b55541ff0693438a33?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `90.83%`. [](https://codecov.io/gh/apache/airflow/pull/6371?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master #6371 +/- ## = - Coverage 80.61% 80.6% -0.01% = Files 626 626 Lines 36217 36279 +62 = + Hits29197 29244 +47 - Misses 70207035 +15 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6371?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/operators/dataproc\_operator.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhcHJvY19vcGVyYXRvci5weQ==) | `100% <ø> (ø)` | :arrow_up: | | [airflow/gcp/example\_dags/example\_dataproc.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YXByb2MucHk=) | `0% <0%> (ø)` | :arrow_up: | | [airflow/contrib/hooks/gcp\_dataproc\_hook.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9kYXRhcHJvY19ob29rLnB5) | `100% <100%> (ø)` | :arrow_up: | | [airflow/gcp/operators/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2RhdGFwcm9jLnB5) | `88.21% <93.79%> (+6.52%)` | :arrow_up: | | [airflow/gcp/hooks/dataproc.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YXByb2MucHk=) | `98.6% <98.11%> (+43.35%)` | :arrow_up: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/kube\_client.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL2t1YmVfY2xpZW50LnB5) | `33.33% <0%> (-41.67%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `70.14% <0%> (-28.36%)` | :arrow_down: | | ... and [3 more](https://codecov.io/gh/apache/airflow/pull/6371/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6371?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6371?src=pr&el=footer). Last update [47eac79...42bf826](https://codecov.io/gh/apache/airflow/pull/6371?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (AIRFLOW-5736) Move airflow.contrib.operators.gcs_to_gdrive_operator to core
[ https://issues.apache.org/jira/browse/AIRFLOW-5736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomasz Urbaszek updated AIRFLOW-5736: - Description: Reference [https://wiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths] Move airflow/contrib/operators/gcs_to_gdrive_operator -> airflow/operators > Move airflow.contrib.operators.gcs_to_gdrive_operator to core > -- > > Key: AIRFLOW-5736 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5736 > Project: Apache Airflow > Issue Type: Improvement > Components: gcp >Affects Versions: 2.0.0 >Reporter: Tomasz Urbaszek >Priority: Minor > > Reference > [https://wiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths] > Move airflow/contrib/operators/gcs_to_gdrive_operator -> airflow/operators -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (AIRFLOW-5738) Move 'tests/contrib/operators/test_dataproc_operator_system_helper.py' to core
Jarek Potiuk created AIRFLOW-5738: - Summary: Move 'tests/contrib/operators/test_dataproc_operator_system_helper.py' to core Key: AIRFLOW-5738 URL: https://issues.apache.org/jira/browse/AIRFLOW-5738 Project: Apache Airflow Issue Type: Improvement Components: gcp Affects Versions: 2.0.0 Reporter: Jarek Potiuk Move 'tests/contrib/operators/test_dataproc_operator_system_helper.py' to `tests/providers/gcp/operators/test_dataproc_operator_system_helper.py' Reference: [https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (AIRFLOW-5735) Move airflow.contrib.operators.s3_to_gcs_operator to core
[ https://issues.apache.org/jira/browse/AIRFLOW-5735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomasz Urbaszek updated AIRFLOW-5735: - Description: Reference [https://wiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths] Move contrib/example_gcp_dlp_operator.py -> providers/google/gcp/ > Move airflow.contrib.operators.s3_to_gcs_operator to core > - > > Key: AIRFLOW-5735 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5735 > Project: Apache Airflow > Issue Type: Improvement > Components: gcp >Affects Versions: 2.0.0 >Reporter: Tomasz Urbaszek >Priority: Minor > > Reference > [https://wiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths] > Move contrib/example_gcp_dlp_operator.py -> providers/google/gcp/ -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (AIRFLOW-5739) Move Cloud Functions to providers packagae
Tomasz Urbaszek created AIRFLOW-5739: Summary: Move Cloud Functions to providers packagae Key: AIRFLOW-5739 URL: https://issues.apache.org/jira/browse/AIRFLOW-5739 Project: Apache Airflow Issue Type: Improvement Components: gcp Affects Versions: 2.0.0 Reporter: Tomasz Urbaszek Move: airflow.gcp.operators.functions -> airflow.providers.google.cloud.operators.functions airflow.gcp.hooks.functions -> airflow.providers.google.cloud.hooks.functions -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (AIRFLOW-5738) Move 'tests/contrib/operators/test_dataproc_operator_system_helper.py' to core
[ https://issues.apache.org/jira/browse/AIRFLOW-5738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-5738: -- Description: Move 'tests/contrib/operators/test_dataproc_operator_system_helper.py' to `tests/providers/google/cloud/operators/test_dataproc_operator_system_helper.py' Reference: [https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths] was: Move 'tests/contrib/operators/test_dataproc_operator_system_helper.py' to `tests/providers/gcp/operators/test_dataproc_operator_system_helper.py' Reference: [https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths] > Move 'tests/contrib/operators/test_dataproc_operator_system_helper.py' to core > -- > > Key: AIRFLOW-5738 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5738 > Project: Apache Airflow > Issue Type: Improvement > Components: gcp >Affects Versions: 2.0.0 >Reporter: Jarek Potiuk >Priority: Major > > Move 'tests/contrib/operators/test_dataproc_operator_system_helper.py' to > `tests/providers/google/cloud/operators/test_dataproc_operator_system_helper.py' > > Reference: > [https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (AIRFLOW-5741) Move Cloud Natural Language to providers
Tomasz Urbaszek created AIRFLOW-5741: Summary: Move Cloud Natural Language to providers Key: AIRFLOW-5741 URL: https://issues.apache.org/jira/browse/AIRFLOW-5741 Project: Apache Airflow Issue Type: Improvement Components: gcp Affects Versions: 2.0.0 Reporter: Tomasz Urbaszek Move: airflow.gcp.operators.natural_language -> airflow.providers.google.cloud.operators.natural_language airflow.gcp.hooks.natural_language -> airflow.providers.google.cloud.hooks.natural_language and also relevant tests and example DAGs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (AIRFLOW-5740) Fix Transient failure in Slack test
Kaxil Naik created AIRFLOW-5740:
---
Summary: Fix Transient failure in Slack test
Key: AIRFLOW-5740
URL: https://issues.apache.org/jira/browse/AIRFLOW-5740
Project: Apache Airflow
Issue Type: Improvement
Components: tests
Affects Versions: 2.0.0
Reporter: Kaxil Naik
Fix For: 2.0.0
Change Slack test so that it does Equality check regardless of order
{noformat}
7) FAIL: test_build_slack_message
(tests.contrib.hooks.test_slack_webhook_hook.TestSlackWebhookHook)
--
Traceback (most recent call last):
File "/opt/airflow/tests/contrib/hooks/test_slack_webhook_hook.py", line 109,
in test_build_slack_message
self.assertEqual(self.expected_message, message)
AssertionError: '{"ic[188 chars]k", "channel": "#general", "blocks":
[{"type":[109 chars]: 1}' != '{"ic[188 chars]k", "username":
"SlackMcSlackFace", "blocks": [109 chars]: 1}'
- {"icon_emoji": ":hankey:", "icon_url":
"https://airflow.apache.org/_images/pin_large.png";, "attachments":
[{"fallback": "Required plain-text summary"}], "text": "Awesome message to put
on Slack", "channel": "#general", "blocks": [{"type": "section", "text":
{"type": "mrkdwn", "text": "*bold text*"}}], "username": "SlackMcSlackFace",
"link_names": 1}
?
^
+ {"icon_emoji": ":hankey:", "icon_url":
"https://airflow.apache.org/_images/pin_large.png";, "attachments":
[{"fallback": "Required plain-text summary"}], "text": "Awesome message to put
on Slack", "username": "SlackMcSlackFace", "blocks": [{"type": "section",
"text": {"type": "mrkdwn", "text": "*bold text*"}}], "channel": "#general",
"link_names": 1}
?
^^
^^^
{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (AIRFLOW-5737) Move example_gcp_dlp_operator.py to example_dlp.py
[ https://issues.apache.org/jira/browse/AIRFLOW-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk updated AIRFLOW-5737: -- Description: Reference [https://wiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths] Move contrib/example_gcp_dlp_operator.py -> providers/google/cloud/examples/example_gcp_dlp_operator.py was: Reference [https://wiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths] Move contrib/example_gcp_dlp_operator.py -> providers/google/gcp/ > Move example_gcp_dlp_operator.py to example_dlp.py > -- > > Key: AIRFLOW-5737 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5737 > Project: Apache Airflow > Issue Type: Improvement > Components: gcp >Affects Versions: 2.0.0 >Reporter: Jarek Potiuk >Priority: Major > > Reference > [https://wiki.apache.org/confluence/display/AIRFLOW/AIP-21%3A+Changes+in+import+paths] > Move contrib/example_gcp_dlp_operator.py -> > providers/google/cloud/examples/example_gcp_dlp_operator.py -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5740) Fix Transient failure in Slack test
[
https://issues.apache.org/jira/browse/AIRFLOW-5740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958785#comment-16958785
]
ASF subversion and git services commented on AIRFLOW-5740:
--
Commit 2c219f34c6310f4795f9de5bbf8248e0539e4a66 in airflow's branch
refs/heads/AIRFLOW-5740 from Kaxil Naik
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=2c219f3 ]
[AIRFLOW-5740] Fix Transient failure in Slack test
The transient failure is caused by Dict Ordering
> Fix Transient failure in Slack test
> ---
>
> Key: AIRFLOW-5740
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5740
> Project: Apache Airflow
> Issue Type: Improvement
> Components: tests
>Affects Versions: 2.0.0
>Reporter: Kaxil Naik
>Priority: Major
> Fix For: 2.0.0
>
>
> Change Slack test so that it does Equality check regardless of order
> {noformat}
> 7) FAIL: test_build_slack_message
> (tests.contrib.hooks.test_slack_webhook_hook.TestSlackWebhookHook)
> --
> Traceback (most recent call last):
> File "/opt/airflow/tests/contrib/hooks/test_slack_webhook_hook.py", line
> 109, in test_build_slack_message
> self.assertEqual(self.expected_message, message)
> AssertionError: '{"ic[188 chars]k", "channel": "#general", "blocks":
> [{"type":[109 chars]: 1}' != '{"ic[188 chars]k", "username":
> "SlackMcSlackFace", "blocks": [109 chars]: 1}'
> - {"icon_emoji": ":hankey:", "icon_url":
> "https://airflow.apache.org/_images/pin_large.png";, "attachments":
> [{"fallback": "Required plain-text summary"}], "text": "Awesome message to
> put on Slack", "channel": "#general", "blocks": [{"type": "section", "text":
> {"type": "mrkdwn", "text": "*bold text*"}}], "username": "SlackMcSlackFace",
> "link_names": 1}
> ?
>
>^
>
>
> + {"icon_emoji": ":hankey:", "icon_url":
> "https://airflow.apache.org/_images/pin_large.png";, "attachments":
> [{"fallback": "Required plain-text summary"}], "text": "Awesome message to
> put on Slack", "username": "SlackMcSlackFace", "blocks": [{"type": "section",
> "text": {"type": "mrkdwn", "text": "*bold text*"}}], "channel": "#general",
> "link_names": 1}
> ?
>
>^^
>
>^^^
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (AIRFLOW-5742) Move Cloud Vision to providers package
Tomasz Urbaszek created AIRFLOW-5742: Summary: Move Cloud Vision to providers package Key: AIRFLOW-5742 URL: https://issues.apache.org/jira/browse/AIRFLOW-5742 Project: Apache Airflow Issue Type: Improvement Components: gcp Affects Versions: 2.0.0 Reporter: Tomasz Urbaszek Move: airflow.gcp.operators.vision -> airflow.providers.google.cloud.operators.vision airflow.gcp.hooks.vision -> airflow.providers.google.cloud.hooks.vision and also relevant tests and example DAGs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [airflow] kaxil opened a new pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test
kaxil opened a new pull request #6407: [AIRFLOW-5740] Fix Transient failure in
Slack test
URL: https://github.com/apache/airflow/pull/6407
The transient failure is caused by Dict Ordering
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/AIRFLOW-5740
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Change Slack test so that it does Equality check regardless of order
```
7) FAIL: test_build_slack_message
(tests.contrib.hooks.test_slack_webhook_hook.TestSlackWebhookHook)
--
Traceback (most recent call last):
File "/opt/airflow/tests/contrib/hooks/test_slack_webhook_hook.py", line
109, in test_build_slack_message
self.assertEqual(self.expected_message, message)
AssertionError: '{"ic[188 chars]k", "channel": "#general", "blocks":
[{"type":[109 chars]: 1}' != '{"ic[188 chars]k", "username":
"SlackMcSlackFace", "blocks": [109 chars]: 1}'
- {"icon_emoji": ":hankey:", "icon_url":
"https://airflow.apache.org/_images/pin_large.png";, "attachments":
[{"fallback": "Required plain-text summary"}], "text": "Awesome message to put
on Slack", "channel": "#general", "blocks": [{"type": "section", "text":
{"type": "mrkdwn", "text": "*bold text*"}}], "username": "SlackMcSlackFace",
"link_names": 1}
?
^
+ {"icon_emoji": ":hankey:", "icon_url":
"https://airflow.apache.org/_images/pin_large.png";, "attachments":
[{"fallback": "Required plain-text summary"}], "text": "Awesome message to put
on Slack", "username": "SlackMcSlackFace", "blocks": [{"type": "section",
"text": {"type": "mrkdwn", "text": "*bold text*"}}], "channel": "#general",
"link_names": 1}
?
```
Changing from using assertEqual to
[assertCountEqual](https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertCountEqual).
THe backport should contain `assertItemsEqual` (for Py2)
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (AIRFLOW-5740) Fix Transient failure in Slack test
[
https://issues.apache.org/jira/browse/AIRFLOW-5740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958787#comment-16958787
]
ASF GitHub Bot commented on AIRFLOW-5740:
-
kaxil commented on pull request #6407: [AIRFLOW-5740] Fix Transient failure in
Slack test
URL: https://github.com/apache/airflow/pull/6407
The transient failure is caused by Dict Ordering
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/AIRFLOW-5740
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Change Slack test so that it does Equality check regardless of order
```
7) FAIL: test_build_slack_message
(tests.contrib.hooks.test_slack_webhook_hook.TestSlackWebhookHook)
--
Traceback (most recent call last):
File "/opt/airflow/tests/contrib/hooks/test_slack_webhook_hook.py", line
109, in test_build_slack_message
self.assertEqual(self.expected_message, message)
AssertionError: '{"ic[188 chars]k", "channel": "#general", "blocks":
[{"type":[109 chars]: 1}' != '{"ic[188 chars]k", "username":
"SlackMcSlackFace", "blocks": [109 chars]: 1}'
- {"icon_emoji": ":hankey:", "icon_url":
"https://airflow.apache.org/_images/pin_large.png";, "attachments":
[{"fallback": "Required plain-text summary"}], "text": "Awesome message to put
on Slack", "channel": "#general", "blocks": [{"type": "section", "text":
{"type": "mrkdwn", "text": "*bold text*"}}], "username": "SlackMcSlackFace",
"link_names": 1}
?
^
+ {"icon_emoji": ":hankey:", "icon_url":
"https://airflow.apache.org/_images/pin_large.png";, "attachments":
[{"fallback": "Required plain-text summary"}], "text": "Awesome message to put
on Slack", "username": "SlackMcSlackFace", "blocks": [{"type": "section",
"text": {"type": "mrkdwn", "text": "*bold text*"}}], "channel": "#general",
"link_names": 1}
?
```
Changing from using assertEqual to
[assertCountEqual](https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertCountEqual).
THe backport should contain `assertItemsEqual` (for Py2)
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix Transient failure in Slack test
> ---
>
> Key: AIRFLOW-5740
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5740
> Project: Apache Airflow
> Issue Type: Improvement
> Components: tests
>Affects Versions: 2.0.0
>Reporter: Kaxil Naik
>Priority: Major
> Fix For: 2.0.0
>
>
> Change Slack test so that it does Equality check regardless of order
> {noformat}
> 7) FAIL: test_build_slack_message
> (tests.contrib.hooks.test_slack_webhook_hook.TestSlackWebhookHook)
> ---
[jira] [Created] (AIRFLOW-5743) Move Gogle PubSub to providers package
Tomasz Urbaszek created AIRFLOW-5743: Summary: Move Gogle PubSub to providers package Key: AIRFLOW-5743 URL: https://issues.apache.org/jira/browse/AIRFLOW-5743 Project: Apache Airflow Issue Type: Improvement Components: gcp Affects Versions: 2.0.0 Reporter: Tomasz Urbaszek Move: airflow.gcp.operators.pubsub -> airflow.providers.google.cloud.operators.pubsub airflow.gcp.hooks.pubsub -> airflow.providers.google.cloud.hooks.pubsub and also relevant tests and example DAGs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (AIRFLOW-5739) Move Cloud Functions to providers packagae
[ https://issues.apache.org/jira/browse/AIRFLOW-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomasz Urbaszek updated AIRFLOW-5739: - Description: Move: airflow.gcp.operators.functions -> airflow.providers.google.cloud.operators.functions airflow.gcp.hooks.functions -> airflow.providers.google.cloud.hooks.functions and also relevant tests and example DAGs. was: Move: airflow.gcp.operators.functions -> airflow.providers.google.cloud.operators.functions airflow.gcp.hooks.functions -> airflow.providers.google.cloud.hooks.functions > Move Cloud Functions to providers packagae > -- > > Key: AIRFLOW-5739 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5739 > Project: Apache Airflow > Issue Type: Improvement > Components: gcp >Affects Versions: 2.0.0 >Reporter: Tomasz Urbaszek >Priority: Minor > > Move: > airflow.gcp.operators.functions -> > airflow.providers.google.cloud.operators.functions > airflow.gcp.hooks.functions -> airflow.providers.google.cloud.hooks.functions > and also relevant tests and example DAGs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-3333) New features enable transferring of files or data from GCS to a SFTP remote path and SFTP to GCS path.
[ https://issues.apache.org/jira/browse/AIRFLOW-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958794#comment-16958794 ] Aaron Fowles commented on AIRFLOW-: --- Hi Tobiasz, I'm not on the slack but I will try and get round to joining and reach out when I get a chance. Good luck in the meantime! > New features enable transferring of files or data from GCS to a SFTP remote > path and SFTP to GCS path. > --- > > Key: AIRFLOW- > URL: https://issues.apache.org/jira/browse/AIRFLOW- > Project: Apache Airflow > Issue Type: New Feature > Components: contrib, gcp >Reporter: Pulin Pathneja >Priority: Major > > New features enable transferring of files or data from GCS(Google Cloud > Storage) to a SFTP remote path and SFTP to GCS(Google Cloud Storage) path. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [airflow] michalslowikowski00 opened a new pull request #6408: [AIRFLOW-5674] rename GoogleCloudKMSHook to CloudKmsHook
michalslowikowski00 opened a new pull request #6408: [AIRFLOW-5674] rename
GoogleCloudKMSHook to CloudKmsHook
URL: https://github.com/apache/airflow/pull/6408
Part of AIP-21
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5674
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] michalslowikowski00 opened a new pull request #6409: [AIRFLOW-5676] rename CloudSpannerHook to SpannerHook
michalslowikowski00 opened a new pull request #6409: [AIRFLOW-5676] rename
CloudSpannerHook to SpannerHook
URL: https://github.com/apache/airflow/pull/6409
Part of AIP-21
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5676
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (AIRFLOW-5676) [AIRFLOW-5676] rename CloudSpannerHook to SpannerHook
[
https://issues.apache.org/jira/browse/AIRFLOW-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958799#comment-16958799
]
ASF GitHub Bot commented on AIRFLOW-5676:
-
michalslowikowski00 commented on pull request #6409: [AIRFLOW-5676] rename
CloudSpannerHook to SpannerHook
URL: https://github.com/apache/airflow/pull/6409
Part of AIP-21
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5676
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [AIRFLOW-5676] rename CloudSpannerHook to SpannerHook
> -
>
> Key: AIRFLOW-5676
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5676
> Project: Apache Airflow
> Issue Type: Sub-task
> Components: gcp
>Affects Versions: 1.10.5
>Reporter: Michał Słowikowski
>Assignee: Michał Słowikowski
>Priority: Minor
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [airflow] michalslowikowski00 opened a new pull request #6410: [AIRFLOW-5677] rename GCPSpeechToTextHook to CloudSpeechToTextHook
michalslowikowski00 opened a new pull request #6410: [AIRFLOW-5677] rename
GCPSpeechToTextHook to CloudSpeechToTextHook
URL: https://github.com/apache/airflow/pull/6410
Part of AIP-21
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5677
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (AIRFLOW-5677) [AIRFLOW-5677] rename GCPSpeechToTextHook to CloudSpeechToTextHook
[
https://issues.apache.org/jira/browse/AIRFLOW-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958800#comment-16958800
]
ASF GitHub Bot commented on AIRFLOW-5677:
-
michalslowikowski00 commented on pull request #6410: [AIRFLOW-5677] rename
GCPSpeechToTextHook to CloudSpeechToTextHook
URL: https://github.com/apache/airflow/pull/6410
Part of AIP-21
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5677
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [AIRFLOW-5677] rename GCPSpeechToTextHook to CloudSpeechToTextHook
> --
>
> Key: AIRFLOW-5677
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5677
> Project: Apache Airflow
> Issue Type: Sub-task
> Components: gcp
>Affects Versions: 1.10.5
>Reporter: Michał Słowikowski
>Assignee: Michał Słowikowski
>Priority: Minor
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [airflow] michalslowikowski00 opened a new pull request #6411: [AIRFLOW-5678] rename GCPTextToSpeechHook to CloudTextToSpeechHook
michalslowikowski00 opened a new pull request #6411: [AIRFLOW-5678] rename
GCPTextToSpeechHook to CloudTextToSpeechHook
URL: https://github.com/apache/airflow/pull/6411
Part of AIP-21
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5678
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (AIRFLOW-5678) [AIRFLOW-5678] rename GCPTextToSpeechHook to CloudTextToSpeechHook
[
https://issues.apache.org/jira/browse/AIRFLOW-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958803#comment-16958803
]
ASF GitHub Bot commented on AIRFLOW-5678:
-
michalslowikowski00 commented on pull request #6411: [AIRFLOW-5678] rename
GCPTextToSpeechHook to CloudTextToSpeechHook
URL: https://github.com/apache/airflow/pull/6411
Part of AIP-21
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5678
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [AIRFLOW-5678] rename GCPTextToSpeechHook to CloudTextToSpeechHook
> --
>
> Key: AIRFLOW-5678
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5678
> Project: Apache Airflow
> Issue Type: Sub-task
> Components: gcp
>Affects Versions: 1.10.5
>Reporter: Michał Słowikowski
>Assignee: Michał Słowikowski
>Priority: Minor
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5674) [AIRFLOW-5674] rename GoogleCloudKMSHook to CloudKmsHook
[
https://issues.apache.org/jira/browse/AIRFLOW-5674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958798#comment-16958798
]
ASF GitHub Bot commented on AIRFLOW-5674:
-
michalslowikowski00 commented on pull request #6408: [AIRFLOW-5674] rename
GoogleCloudKMSHook to CloudKmsHook
URL: https://github.com/apache/airflow/pull/6408
Part of AIP-21
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5674
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [AIRFLOW-5674] rename GoogleCloudKMSHook to CloudKmsHook
>
>
> Key: AIRFLOW-5674
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5674
> Project: Apache Airflow
> Issue Type: Sub-task
> Components: gcp
>Affects Versions: 1.10.5
>Reporter: Michał Słowikowski
>Assignee: Michał Słowikowski
>Priority: Minor
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [airflow] michalslowikowski00 opened a new pull request #6412: [AIRFLOW-5679] rename GoogleCloudStorageHook to GcsHook
michalslowikowski00 opened a new pull request #6412: [AIRFLOW-5679] rename
GoogleCloudStorageHook to GcsHook
URL: https://github.com/apache/airflow/pull/6412
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5679
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (AIRFLOW-5679) [AIRFLOW-5679] rename GoogleCloudStorageHook to GcsHook
[
https://issues.apache.org/jira/browse/AIRFLOW-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958804#comment-16958804
]
ASF GitHub Bot commented on AIRFLOW-5679:
-
michalslowikowski00 commented on pull request #6412: [AIRFLOW-5679] rename
GoogleCloudStorageHook to GcsHook
URL: https://github.com/apache/airflow/pull/6412
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5679
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [AIRFLOW-5679] rename GoogleCloudStorageHook to GcsHook
> ---
>
> Key: AIRFLOW-5679
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5679
> Project: Apache Airflow
> Issue Type: Sub-task
> Components: gcp
>Affects Versions: 1.10.5
>Reporter: Michał Słowikowski
>Assignee: Michał Słowikowski
>Priority: Minor
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [airflow] JonnyIncognito commented on a change in pull request #6210: [AIRFLOW-5567] BaseAsyncOperator
JonnyIncognito commented on a change in pull request #6210: [AIRFLOW-5567] BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#discussion_r338510991 ## File path: airflow/models/base_async_operator.py ## @@ -0,0 +1,161 @@ +# -*- coding: utf-8 -*- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Base Asynchronous Operator for kicking off a long running +operations and polling for completion with reschedule mode. +""" + +from abc import abstractmethod +from typing import Dict, List, Optional, Union + +from airflow.models import SkipMixin, TaskReschedule +from airflow.models.xcom import XCOM_EXTERNAL_RESOURCE_ID_KEY +from airflow.sensors.base_sensor_operator import BaseSensorOperator +from airflow.utils.decorators import apply_defaults + + Review comment: I agree with trying to put the behaviour into BaseOperator. As it stands, the use-cases are: 1. Only operate (`BaseOperator` <- e.g. `EmrAddStepsOperator`) 1. Only sense (`BaseSensorOperator` <- e.g. `EmrStepSensor`) 1. Do both (to be determined) 1. Do none (`BaseOperator` <- e.g. `DummyOperator`) Currently 1, 2 and 4 are implemented as variations of execute(); 2 is the odd one out in having a special class, as would 3 with the current proposal. If BaseOperator had a default execute() that runs two phases, the other behaviours can be achieved by optionally implementing either of the phases. It's a typical problem using class hierarchies for behaviours, that it's hard to mix and match. I was actually thinking about whether we could use traits to keep the behaviours cleanly separated into their own implementations. But it's probably overkill with so few. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (AIRFLOW-5672) [AIRFLOW-5672] rename CloudDLPHook to CloudDlpHook
[
https://issues.apache.org/jira/browse/AIRFLOW-5672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958733#comment-16958733
]
ASF GitHub Bot commented on AIRFLOW-5672:
-
michalslowikowski00 commented on pull request #6406: [AIRFLOW-5672] rename
CloudDLPHook to CloudDlpHook
URL: https://github.com/apache/airflow/pull/6406
Part of AIP-21
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5672
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [AIRFLOW-5672] rename CloudDLPHook to CloudDlpHook
> --
>
> Key: AIRFLOW-5672
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5672
> Project: Apache Airflow
> Issue Type: Sub-task
> Components: gcp
>Affects Versions: 1.10.5
>Reporter: Michał Słowikowski
>Assignee: Michał Słowikowski
>Priority: Minor
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [airflow] ashb commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test
ashb commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test URL: https://github.com/apache/airflow/pull/6407#discussion_r338515493 ## File path: tests/contrib/hooks/test_slack_webhook_hook.py ## @@ -105,7 +105,7 @@ def test_build_slack_message(self): message = hook._build_slack_message() # Then -self.assertEqual(self.expected_message, message) +self.assertCountEqual(self.expected_message, message) Review comment: Does this compare "deeply"? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test
ashb commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient
failure in Slack test
URL: https://github.com/apache/airflow/pull/6407#discussion_r338516150
##
File path: tests/contrib/hooks/test_slack_webhook_hook.py
##
@@ -105,7 +105,7 @@ def test_build_slack_message(self):
message = hook._build_slack_message()
# Then
-self.assertEqual(self.expected_message, message)
+self.assertCountEqual(self.expected_message, message)
Review comment:
I don't think it does what we want:
```
In [10]: tc = unittest.TestCase(); tc.assertCountEqual({"a":2}, {"b": 3})
---
AssertionErrorTraceback (most recent call last)
in
> 1 tc = unittest.TestCase(); tc.assertCountEqual({"a":2}, {"b": 3})
~/.homebrew/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py
in assertCountEqual(self, first, second, msg)
1198 standardMsg = self._truncateMessage(standardMsg, diffMsg)
1199 msg = self._formatMessage(msg, standardMsg)
-> 1200 self.fail(msg)
1201
1202 def assertMultiLineEqual(self, first, second, msg=None):
~/.homebrew/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/lib/python3.7/unittest/case.py
in fail(self, msg)
678 def fail(self, msg=None):
679 """Fail immediately, with the given message."""
--> 680 raise self.failureException(msg)
681
682 def assertFalse(self, expr, msg=None):
AssertionError: Element counts were not equal:
First has 1, Second has 0: 'a'
First has 0, Second has 1: 'b'
In [11]: tc = unittest.TestCase(); tc.assertCountEqual({"a":2}, {"a": 3})
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test
ashb commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test URL: https://github.com/apache/airflow/pull/6407#discussion_r338517669 ## File path: tests/contrib/hooks/test_slack_webhook_hook.py ## @@ -105,7 +105,7 @@ def test_build_slack_message(self): message = hook._build_slack_message() # Then -self.assertEqual(self.expected_message, message) +self.assertCountEqual(self.expected_message, message) Review comment: (the input 11 there doesn't fail!) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test
kaxil commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test URL: https://github.com/apache/airflow/pull/6407#discussion_r338522450 ## File path: tests/contrib/hooks/test_slack_webhook_hook.py ## @@ -105,7 +105,7 @@ def test_build_slack_message(self): message = hook._build_slack_message() # Then -self.assertEqual(self.expected_message, message) +self.assertCountEqual(self.expected_message, message) Review comment: Yup, you are right !! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] dimberman commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test
dimberman commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test URL: https://github.com/apache/airflow/pull/6407#discussion_r338525297 ## File path: tests/contrib/hooks/test_slack_webhook_hook.py ## @@ -105,7 +105,7 @@ def test_build_slack_message(self): message = hook._build_slack_message() # Then -self.assertEqual(self.expected_message, message) +self.assertCountEqual(self.expected_message, message) Review comment: @kaxil what is the issue here? Is there nesting in the dict that is causing issues? Is there added metadata? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] dimberman commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test
dimberman commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test URL: https://github.com/apache/airflow/pull/6407#discussion_r338525451 ## File path: tests/contrib/hooks/test_slack_webhook_hook.py ## @@ -105,7 +105,7 @@ def test_build_slack_message(self): message = hook._build_slack_message() # Then -self.assertEqual(self.expected_message, message) +self.assertCountEqual(self.expected_message, message) Review comment: I just dealt with some dict comparing issues for the kubepodoperator so maybe something I did could apply here This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test
ashb commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test URL: https://github.com/apache/airflow/pull/6407#discussion_r338526544 ## File path: tests/contrib/hooks/test_slack_webhook_hook.py ## @@ -105,7 +105,7 @@ def test_build_slack_message(self): message = hook._build_slack_message() # Then -self.assertEqual(self.expected_message, message) +self.assertCountEqual(self.expected_message, message) Review comment: Dicts are the same, it's just the order of keys (cos python 3.5 still has random ordering) -- but `d1 == d2` is _meant_ to ignore that from everything we can see and remember. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Work started] (AIRFLOW-4162) Support layout blocks in Slack operators
[ https://issues.apache.org/jira/browse/AIRFLOW-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-4162 started by Bumsoo Kim. --- > Support layout blocks in Slack operators > > > Key: AIRFLOW-4162 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4162 > Project: Apache Airflow > Issue Type: Improvement > Components: operators >Affects Versions: 1.10.2 >Reporter: Bumsoo Kim >Assignee: Bumsoo Kim >Priority: Minor > Labels: features > > Slack introduced a new API called "*layout blocks"* to create rich message > layouts. > [https://api.slack.com/messaging/composing/layouts] > > We can utilize this new feature by simply adding `blocks` array field to the > payload. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [airflow] codecov-io edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability
codecov-io edited a comment on issue #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743#issuecomment-529755241 # [Codecov](https://codecov.io/gh/apache/airflow/pull/5743?src=pr&el=h1) Report > Merging [#5743](https://codecov.io/gh/apache/airflow/pull/5743?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f3c3812908fe6bb802b7a24011fe21e4b46530bf?src=pr&el=desc) will **increase** coverage by `2.72%`. > The diff coverage is `83.71%`. [](https://codecov.io/gh/apache/airflow/pull/5743?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#5743 +/- ## == + Coverage 80.61% 83.33% +2.72% == Files 626 627 +1 Lines 3621736506 +289 == + Hits2919630423+1227 + Misses 7021 6083 -938 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/5743?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [airflow/serialization/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5743/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL19faW5pdF9fLnB5) | `100% <100%> (ø)` | | | [airflow/settings.py](https://codecov.io/gh/apache/airflow/pull/5743/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXR0aW5ncy5weQ==) | `82.01% <100%> (-6.31%)` | :arrow_down: | | [airflow/utils/log/logging\_mixin.py](https://codecov.io/gh/apache/airflow/pull/5743/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvbG9nZ2luZ19taXhpbi5weQ==) | `96.15% <100%> (+0.04%)` | :arrow_up: | | [airflow/www/utils.py](https://codecov.io/gh/apache/airflow/pull/5743/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdXRpbHMucHk=) | `80.19% <100%> (+4.58%)` | :arrow_up: | | [airflow/models/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/5743/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvX19pbml0X18ucHk=) | `100% <100%> (ø)` | :arrow_up: | | [airflow/serialization/enums.py](https://codecov.io/gh/apache/airflow/pull/5743/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL2VudW1zLnB5) | `100% <100%> (ø)` | | | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/5743/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `58.48% <16.66%> (-0.42%)` | :arrow_down: | | [airflow/models/dagbag.py](https://codecov.io/gh/apache/airflow/pull/5743/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnYmFnLnB5) | `84.83% <41.66%> (-7.59%)` | :arrow_down: | | [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/5743/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.87% <80%> (-0.84%)` | :arrow_down: | | [airflow/serialization/serialization.py](https://codecov.io/gh/apache/airflow/pull/5743/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6YXRpb24ucHk=) | `81.06% <81.06%> (ø)` | | | ... and [99 more](https://codecov.io/gh/apache/airflow/pull/5743/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/5743?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/5743?src=pr&el=footer). Last update [f3c3812...162da54](https://codecov.io/gh/apache/airflow/pull/5743?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] dimberman commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test
dimberman commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test URL: https://github.com/apache/airflow/pull/6407#discussion_r338527726 ## File path: tests/contrib/hooks/test_slack_webhook_hook.py ## @@ -105,7 +105,7 @@ def test_build_slack_message(self): message = hook._build_slack_message() # Then -self.assertEqual(self.expected_message, message) +self.assertCountEqual(self.expected_message, message) Review comment: So why not use `assertDictEquals`? I think that ignores ordering. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6388: [AIRFLOW-5669] Rename GoogleCloudBaseHook to CloudBaseHook
codecov-io edited a comment on issue #6388: [AIRFLOW-5669] Rename GoogleCloudBaseHook to CloudBaseHook URL: https://github.com/apache/airflow/pull/6388#issuecomment-545882079 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=h1) Report > Merging [#6388](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/859e1cc79b6c5d79d1ffca70845e1c8ca024314d?src=pr&el=desc) will **decrease** coverage by `0.3%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master #6388 +/- ## = - Coverage 80.61% 80.3% -0.31% = Files 626 626 Lines 36224 36228 +4 = - Hits29203 29094 -109 - Misses 70217134 +113 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [airflow/gcp/hooks/cloud\_build.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvY2xvdWRfYnVpbGQucHk=) | `100% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/cloud\_memorystore.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvY2xvdWRfbWVtb3J5c3RvcmUucHk=) | `73.83% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/cloud\_sql.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvY2xvdWRfc3FsLnB5) | `70.23% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/compute.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvY29tcHV0ZS5weQ==) | `86.86% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/gcs.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZ2NzLnB5) | `84.98% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/tasks.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdGFza3MucHk=) | `92.17% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/video\_intelligence.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdmlkZW9faW50ZWxsaWdlbmNlLnB5) | `89.47% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.18% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/bigquery\_dts.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnlfZHRzLnB5) | `85.96% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/dlp.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGxwLnB5) | `98.69% <100%> (ø)` | :arrow_up: | | ... and [33 more](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=footer). Last update [859e1cc...254e1e8](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6388: [AIRFLOW-5669] Rename GoogleCloudBaseHook to CloudBaseHook
codecov-io edited a comment on issue #6388: [AIRFLOW-5669] Rename GoogleCloudBaseHook to CloudBaseHook URL: https://github.com/apache/airflow/pull/6388#issuecomment-545882079 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=h1) Report > Merging [#6388](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/859e1cc79b6c5d79d1ffca70845e1c8ca024314d?src=pr&el=desc) will **decrease** coverage by `0.3%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master #6388 +/- ## = - Coverage 80.61% 80.3% -0.31% = Files 626 626 Lines 36224 36228 +4 = - Hits29203 29094 -109 - Misses 70217134 +113 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [airflow/gcp/hooks/cloud\_build.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvY2xvdWRfYnVpbGQucHk=) | `100% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/cloud\_memorystore.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvY2xvdWRfbWVtb3J5c3RvcmUucHk=) | `73.83% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/cloud\_sql.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvY2xvdWRfc3FsLnB5) | `70.23% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/compute.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvY29tcHV0ZS5weQ==) | `86.86% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/gcs.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZ2NzLnB5) | `84.98% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/tasks.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdGFza3MucHk=) | `92.17% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/video\_intelligence.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdmlkZW9faW50ZWxsaWdlbmNlLnB5) | `89.47% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.18% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/bigquery\_dts.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnlfZHRzLnB5) | `85.96% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/dlp.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGxwLnB5) | `98.69% <100%> (ø)` | :arrow_up: | | ... and [33 more](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=footer). Last update [859e1cc...254e1e8](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6388: [AIRFLOW-5669] Rename GoogleCloudBaseHook to CloudBaseHook
codecov-io commented on issue #6388: [AIRFLOW-5669] Rename GoogleCloudBaseHook to CloudBaseHook URL: https://github.com/apache/airflow/pull/6388#issuecomment-545882079 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=h1) Report > Merging [#6388](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/859e1cc79b6c5d79d1ffca70845e1c8ca024314d?src=pr&el=desc) will **decrease** coverage by `0.3%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master #6388 +/- ## = - Coverage 80.61% 80.3% -0.31% = Files 626 626 Lines 36224 36228 +4 = - Hits29203 29094 -109 - Misses 70217134 +113 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [airflow/gcp/hooks/cloud\_build.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvY2xvdWRfYnVpbGQucHk=) | `100% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/cloud\_memorystore.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvY2xvdWRfbWVtb3J5c3RvcmUucHk=) | `73.83% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/cloud\_sql.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvY2xvdWRfc3FsLnB5) | `70.23% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/compute.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvY29tcHV0ZS5weQ==) | `86.86% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/gcs.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZ2NzLnB5) | `84.98% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/tasks.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdGFza3MucHk=) | `92.17% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/video\_intelligence.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvdmlkZW9faW50ZWxsaWdlbmNlLnB5) | `89.47% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/bigquery.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnkucHk=) | `70.18% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/bigquery\_dts.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnlfZHRzLnB5) | `85.96% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/dlp.py](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGxwLnB5) | `98.69% <100%> (ø)` | :arrow_up: | | ... and [33 more](https://codecov.io/gh/apache/airflow/pull/6388/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=footer). Last update [859e1cc...254e1e8](https://codecov.io/gh/apache/airflow/pull/6388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] dimberman commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test
dimberman commented on a change in pull request #6407: [AIRFLOW-5740] Fix Transient failure in Slack test URL: https://github.com/apache/airflow/pull/6407#discussion_r338533242 ## File path: tests/contrib/hooks/test_slack_webhook_hook.py ## @@ -105,7 +105,7 @@ def test_build_slack_message(self): message = hook._build_slack_message() # Then -self.assertEqual(self.expected_message, message) +self.assertCountEqual(self.expected_message, message) Review comment: `==` might, but I'm not sure `assertEquals` would. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] kaxil commented on issue #6407: [AIRFLOW-5740] Fix Transient failure in Slack test
kaxil commented on issue #6407: [AIRFLOW-5740] Fix Transient failure in Slack test URL: https://github.com/apache/airflow/pull/6407#issuecomment-545887001 Fixed the test. The actual problem was we were comparing strings. I have changed it to compare dicts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] Khrol opened a new pull request #6413: [AIRFLOW-XXX] Add Automattic to Airflow users
Khrol opened a new pull request #6413: [AIRFLOW-XXX] Add Automattic to Airflow
users
URL: https://github.com/apache/airflow/pull/6413
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability
kaxil merged pull request #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (AIRFLOW-5088) To implement DAG JSON serialization and DB persistence for webserver scalability improvement
[ https://issues.apache.org/jira/browse/AIRFLOW-5088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958850#comment-16958850 ] ASF subversion and git services commented on AIRFLOW-5088: -- Commit 66b2a47d9e6dbef551e31d41d23ee4fc2eae3636 in airflow's branch refs/heads/master from Zhou Fang [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=66b2a47 ] [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability (#5743) Co-Authored-By: Kaxil Naik Co-Authored-By: Ash Berlin-Taylor > To implement DAG JSON serialization and DB persistence for webserver > scalability improvement > > > Key: AIRFLOW-5088 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5088 > Project: Apache Airflow > Issue Type: Improvement > Components: DAG, webserver >Affects Versions: 1.10.5 >Reporter: Zhou Fang >Assignee: Zhou Fang >Priority: Major > > Created this issue for starting to implement DAG serialization using JSON and > persistence in DB. Serialized DAG will be used in webserver for solving the > webserver scalability issue. > > The implementation is based on AIP-24: > [https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-24+DAG+Persistence+in+DB+using+JSON+for+Airflow+Webserver+and+%28optional%29+Scheduler] > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [airflow] kaxil merged pull request #6413: [AIRFLOW-XXX] Add Automattic to Airflow users
kaxil merged pull request #6413: [AIRFLOW-XXX] Add Automattic to Airflow users URL: https://github.com/apache/airflow/pull/6413 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] michalslowikowski00 opened a new pull request #6414: [AIRFLOW-5673] rename GcfHook to CloudFunctionsHook
michalslowikowski00 opened a new pull request #6414: [AIRFLOW-5673] rename
GcfHook to CloudFunctionsHook
URL: https://github.com/apache/airflow/pull/6414
Part of AIP-21
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5673
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (AIRFLOW-5673) [AIRFLOW-5673] rename GcfHook to CloudFunctionsHook
[
https://issues.apache.org/jira/browse/AIRFLOW-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958859#comment-16958859
]
ASF GitHub Bot commented on AIRFLOW-5673:
-
michalslowikowski00 commented on pull request #6414: [AIRFLOW-5673] rename
GcfHook to CloudFunctionsHook
URL: https://github.com/apache/airflow/pull/6414
Part of AIP-21
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-5673
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [AIRFLOW-5673] rename GcfHook to CloudFunctionsHook
> ---
>
> Key: AIRFLOW-5673
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5673
> Project: Apache Airflow
> Issue Type: Sub-task
> Components: gcp
>Affects Versions: 1.10.5
>Reporter: Michał Słowikowski
>Assignee: Michał Słowikowski
>Priority: Minor
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (AIRFLOW-5088) To implement DAG JSON serialization and DB persistence for webserver scalability improvement
[ https://issues.apache.org/jira/browse/AIRFLOW-5088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kaxil Naik resolved AIRFLOW-5088. - Fix Version/s: 1.10.7 Resolution: Fixed > To implement DAG JSON serialization and DB persistence for webserver > scalability improvement > > > Key: AIRFLOW-5088 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5088 > Project: Apache Airflow > Issue Type: Improvement > Components: DAG, webserver >Affects Versions: 1.10.5 >Reporter: Zhou Fang >Assignee: Zhou Fang >Priority: Major > Fix For: 1.10.7 > > > Created this issue for starting to implement DAG serialization using JSON and > persistence in DB. Serialized DAG will be used in webserver for solving the > webserver scalability issue. > > The implementation is based on AIP-24: > [https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-24+DAG+Persistence+in+DB+using+JSON+for+Airflow+Webserver+and+%28optional%29+Scheduler] > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-5088) To implement DAG JSON serialization and DB persistence for webserver scalability improvement
[ https://issues.apache.org/jira/browse/AIRFLOW-5088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958849#comment-16958849 ] ASF GitHub Bot commented on AIRFLOW-5088: - kaxil commented on pull request #5743: [AIRFLOW-5088][AIP-24] Persisting serialized DAG in DB for webserver scalability URL: https://github.com/apache/airflow/pull/5743 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > To implement DAG JSON serialization and DB persistence for webserver > scalability improvement > > > Key: AIRFLOW-5088 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5088 > Project: Apache Airflow > Issue Type: Improvement > Components: DAG, webserver >Affects Versions: 1.10.5 >Reporter: Zhou Fang >Assignee: Zhou Fang >Priority: Major > > Created this issue for starting to implement DAG serialization using JSON and > persistence in DB. Serialized DAG will be used in webserver for solving the > webserver scalability issue. > > The implementation is based on AIP-24: > [https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-24+DAG+Persistence+in+DB+using+JSON+for+Airflow+Webserver+and+%28optional%29+Scheduler] > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [airflow] OmerJog commented on issue #6399: [AIRFLOW-5730] Enable get_pandas_df on Druid and Pinot DbApiHooks
OmerJog commented on issue #6399: [AIRFLOW-5730] Enable get_pandas_df on Druid and Pinot DbApiHooks URL: https://github.com/apache/airflow/pull/6399#issuecomment-545910015 Same issue as https://github.com/apache/airflow/pull/6057 ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] OmerJog commented on issue #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator
OmerJog commented on issue #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator URL: https://github.com/apache/airflow/pull/4530#issuecomment-545914040 @omusavi any progress with this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] OmerJog edited a comment on issue #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator
OmerJog edited a comment on issue #4530: [AIRFLOW-3282] Implement Azure Kubernetes Service Operator URL: https://github.com/apache/airflow/pull/4530#issuecomment-545914040 @omusavi @apraovjr any progress with this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] OmerJog commented on a change in pull request #6332: [AIRFLOW-5710] Optionally raise exception on unused operator arguments.
OmerJog commented on a change in pull request #6332: [AIRFLOW-5710] Optionally raise exception on unused operator arguments. URL: https://github.com/apache/airflow/pull/6332#discussion_r338569836 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -243,6 +243,7 @@ default_cpus = 1 default_ram = 512 default_disk = 512 default_gpus = 0 +allow_illegal_arguments = True Review comment: Shouldn't be here a short note explaining what this setting does? Something like `# When set to False raise exception on unused operator arguments` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6408: [AIRFLOW-5674] rename GoogleCloudKMSHook to CloudKmsHook
codecov-io commented on issue #6408: [AIRFLOW-5674] rename GoogleCloudKMSHook to CloudKmsHook URL: https://github.com/apache/airflow/pull/6408#issuecomment-545921430 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6408?src=pr&el=h1) Report > Merging [#6408](https://codecov.io/gh/apache/airflow/pull/6408?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/859e1cc79b6c5d79d1ffca70845e1c8ca024314d?src=pr&el=desc) will **decrease** coverage by `0.56%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/airflow/pull/6408?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#6408 +/- ## == - Coverage 80.61% 80.05% -0.57% == Files 626 626 Lines 3622436228 +4 == - Hits2920329002 -201 - Misses 7021 7226 +205 ``` | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6408?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [airflow/contrib/hooks/gcp\_kms\_hook.py](https://codecov.io/gh/apache/airflow/pull/6408/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9rbXNfaG9vay5weQ==) | `100% <100%> (ø)` | :arrow_up: | | [airflow/gcp/hooks/kms.py](https://codecov.io/gh/apache/airflow/pull/6408/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3Mva21zLnB5) | `100% <100%> (ø)` | :arrow_up: | | [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/6408/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: | | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/6408/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: | | [airflow/executors/sequential\_executor.py](https://codecov.io/gh/apache/airflow/pull/6408/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvc2VxdWVudGlhbF9leGVjdXRvci5weQ==) | `47.61% <0%> (-52.39%)` | :arrow_down: | | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/6408/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: | | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/6408/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: | | [airflow/kubernetes/kube\_client.py](https://codecov.io/gh/apache/airflow/pull/6408/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL2t1YmVfY2xpZW50LnB5) | `33.33% <0%> (-41.67%)` | :arrow_down: | | [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/6408/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `70.14% <0%> (-28.36%)` | :arrow_down: | | [airflow/utils/log/colored\_log.py](https://codecov.io/gh/apache/airflow/pull/6408/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvY29sb3JlZF9sb2cucHk=) | `72.72% <0%> (-20.46%)` | :arrow_down: | | ... and [9 more](https://codecov.io/gh/apache/airflow/pull/6408/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6408?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6408?src=pr&el=footer). Last update [859e1cc...ba8189b](https://codecov.io/gh/apache/airflow/pull/6408?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (AIRFLOW-5745) Breeze complete has no licence
Jarek Potiuk created AIRFLOW-5745: - Summary: Breeze complete has no licence Key: AIRFLOW-5745 URL: https://issues.apache.org/jira/browse/AIRFLOW-5745 Project: Apache Airflow Issue Type: Improvement Components: ci Affects Versions: 1.10.5, 2.0.0, 1.10.6 Reporter: Jarek Potiuk -- This message was sent by Atlassian Jira (v8.3.4#803005)
