[GitHub] [airflow] potiuk commented on pull request #21546: Allow to switch easily between Bullseye and Buster debian versions

[GitBox]

potiuk commented on pull request #21546:
URL: https://github.com/apache/airflow/pull/21546#issuecomment-1045967707


   We can easily merge that one now. The #21378 will actually make the switch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #21681: Fix Amazon SES emailer signature

[GitBox]

github-actions[bot] commented on pull request #21681:
URL: https://github.com/apache/airflow/pull/21681#issuecomment-1045972311


   The PR is likely OK to be merged with just subset of tests for default 
Python and Database versions without running the full matrix of tests, because 
it does not modify the core of Airflow. If the committers decide that the full 
tests matrix is needed, they will add the label 'full tests needed'. Then you 
should rebase to the latest main or amend the last commit of the PR, and push 
it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] eladkal commented on pull request #21680: Increase timeout for constraints

[GitBox]

eladkal commented on pull request #21680:
URL: https://github.com/apache/airflow/pull/21680#issuecomment-1045972355


   Jed already raised PR for it 
   https://github.com/apache/airflow/pull/21648


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #21680: Increase timeout for constraints

[GitBox]

github-actions[bot] commented on pull request #21680:
URL: https://github.com/apache/airflow/pull/21680#issuecomment-1045972466


   The PR most likely needs to run full matrix of tests because it modifies 
parts of the core of Airflow. However, committers might decide to merge it 
quickly and take the risk. If they don't merge it quickly - please rebase it to 
the latest main at your convenience, or amend the last commit of the PR, and 
push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

[GitBox]

github-actions[bot] commented on pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#issuecomment-1045973405


   The PR is likely OK to be merged with just subset of tests for default 
Python and Database versions without running the full matrix of tests, because 
it does not modify the core of Airflow. If the committers decide that the full 
tests matrix is needed, they will add the label 'full tests needed'. Then you 
should rebase to the latest main or amend the last commit of the PR, and push 
it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #19752: Infinite wait in SparkSubmitOperator kill

[GitBox]

eladkal commented on issue #19752:
URL: https://github.com/apache/airflow/issues/19752#issuecomment-1045973944


   @cb149 you can check the PR that added the functionality 
https://github.com/apache/airflow/pull/9044


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[airflow-site] branch main updated: Add Josh and Malthe announcement (#547)

[eladkal]

This is an automated email from the ASF dual-hosted git repository.

eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow-site.git


The following commit(s) were added to refs/heads/main by this push:
 new 4c4db42  Add Josh and Malthe announcement (#547)
4c4db42 is described below

commit 4c4db42c35cde86971712c5c104935c707c9c6c1
Author: Jarek Potiuk 
AuthorDate: Sat Feb 19 10:13:36 2022 +0100

Add Josh and Malthe announcement (#547)
---
 landing-pages/site/content/en/announcements/_index.md | 9 -
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/landing-pages/site/content/en/announcements/_index.md 
b/landing-pages/site/content/en/announcements/_index.md
index 6b58387..bb4ffe6 100644
--- a/landing-pages/site/content/en/announcements/_index.md
+++ b/landing-pages/site/content/en/announcements/_index.md
@@ -13,6 +13,13 @@ menu:
 
 **Note:** Follow [@ApacheAirflow](https://twitter.com/ApacheAirflow) on 
Twitter for the latest news and announcements!
 
+# February 19, 2022
+
+Airflow PMC welcomes two new Airlow Committers:
+
+* **Malthe Borch** ([@malthe](https://github.com/malthe))
+* **Josh Fell** ([@josh-fell](https://github.com/josh-fell))
+
 # January 10, 2022
 
 We've just released Apache **Airflow Helm chart 1.4.0**.
@@ -137,7 +144,7 @@ We've just released Apache **Airflow 2.1.1**.
 Airflow PMC welcomes 2 new committers:
 
 - **Jed Cunningham** ([@jedcunningham](https://github.com/jedcunningham))
-- **Tzu-ping Chung** ([@uranusjr](https://github.com/uranusjr)
+- **Tzu-ping Chung** ([@uranusjr](https://github.com/uranusjr))
 
 # May 21, 2021
 

[GitHub] [airflow-site] eladkal merged pull request #547: Add Josh and Malthe announcement

[GitBox]

eladkal merged pull request #547:
URL: https://github.com/apache/airflow-site/pull/547


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[airflow-site] branch gh-pages updated: Deploying to gh-pages from @ 4c4db42c35cde86971712c5c104935c707c9c6c1 🚀

[github-bot]

This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a commit to branch gh-pages
in repository https://gitbox.apache.org/repos/asf/airflow-site.git


The following commit(s) were added to refs/heads/gh-pages by this push:
 new 46dea58  Deploying to gh-pages from  @ 
4c4db42c35cde86971712c5c104935c707c9c6c1 🚀
46dea58 is described below

commit 46dea589f1677cd16438007650f91b3de1ebefe9
Author: eladkal <45845474+elad...@users.noreply.github.com>
AuthorDate: Sat Feb 19 09:20:24 2022 +

Deploying to gh-pages from  @ 4c4db42c35cde86971712c5c104935c707c9c6c1 🚀
---
 announcements/index.html   | 11 ++-
 blog/airflow-1.10.10/index.html|  4 +-
 blog/airflow-1.10.12/index.html|  4 +-
 blog/airflow-1.10.8-1.10.9/index.html  |  4 +-
 blog/airflow-2.2.0/index.html  |  4 +-
 blog/airflow-survey-2020/index.html|  4 +-
 blog/airflow-survey/index.html |  4 +-
 blog/airflow-two-point-oh-is-here/index.html   |  4 +-
 blog/airflow_summit_2021/index.html|  4 +-
 blog/announcing-new-website/index.html |  4 +-
 blog/apache-airflow-for-newcomers/index.html   |  4 +-
 .../index.html |  4 +-
 .../index.html |  4 +-
 .../index.html |  4 +-
 .../index.html |  4 +-
 .../index.html |  4 +-
 .../index.html |  4 +-
 index.html | 32 
 search/index.html  |  4 +-
 sitemap.xml| 92 +++---
 use-cases/adobe/index.html |  4 +-
 use-cases/adyen/index.html |  4 +-
 use-cases/big-fish-games/index.html|  4 +-
 use-cases/dish/index.html  |  4 +-
 use-cases/experity/index.html  |  4 +-
 use-cases/onefootball/index.html   |  4 +-
 use-cases/plarium-krasnodar/index.html |  4 +-
 use-cases/seniorlink/index.html|  4 +-
 use-cases/sift/index.html  |  4 +-
 29 files changed, 124 insertions(+), 115 deletions(-)

diff --git a/announcements/index.html b/announcements/index.html
index e67ff67..c1a6b22 100644
--- a/announcements/index.html
+++ b/announcements/index.html
@@ -429,6 +429,15 @@ if (!doNotTrack) {
 
 Note: Follow https://twitter.com/ApacheAirflow"; 
target="_blank">@ApacheAirflow on Twitter for the latest news and 
announcements!
 
+February 19, 2022
+
+Airflow PMC welcomes two new Airlow Committers:
+
+
+Malthe Borch (https://github.com/malthe"; 
target="_blank">@malthe)
+Josh Fell (https://github.com/josh-fell"; 
target="_blank">@josh-fell)
+
+
 January 10, 2022
 
 We’ve just released Apache Airflow Helm chart 
1.4.0.
@@ -555,7 +564,7 @@ if (!doNotTrack) {
 
 
 Jed Cunningham (https://github.com/jedcunningham"; target="_blank">@jedcunningham)
-Tzu-ping Chung (https://github.com/uranusjr"; 
target="_blank">@uranusjr
+Tzu-ping Chung (https://github.com/uranusjr"; 
target="_blank">@uranusjr)
 
 
 May 21, 2021
diff --git a/blog/airflow-1.10.10/index.html b/blog/airflow-1.10.10/index.html
index f9d1d57..3fc6922 100644
--- a/blog/airflow-1.10.10/index.html
+++ b/blog/airflow-1.10.10/index.html
@@ -36,13 +36,13 @@
 
 
 
-
+
 
 
 
 
 
-
+
 
 
 
diff --git a/blog/airflow-1.10.12/index.html b/blog/airflow-1.10.12/index.html
index eaa4156..76169ba 100644
--- a/blog/airflow-1.10.12/index.html
+++ b/blog/airflow-1.10.12/index.html
@@ -36,13 +36,13 @@
 
 
 
-
+
 
 
 
 
 
-
+
 
 
 
diff --git a/blog/airflow-1.10.8-1.10.9/index.html 
b/blog/airflow-1.10.8-1.10.9/index.html
index d1f1aa6..5ddcef1 100644
--- a/blog/airflow-1.10.8-1.10.9/index.html
+++ b/blog/airflow-1.10.8-1.10.9/index.html
@@ -36,13 +36,13 @@
 
 
 
-
+
 
 
 
 
 
-
+
 
 
 
diff --git a/blog/airflow-2.2.0/index.html b/blog/airflow-2.2.0/index.html
index 1c4c7c4..e5eb452 100644
--- a/blog/airflow-2.2.0/index.html
+++ b/blog/airflow-2.2.0/index.html
@@ -36,13 +36,13 @@
 
 
 
-
+
 
 
 
 
 
-
+
 
 
 
diff --git a/blog/airflow-survey-2020/index.html 
b/blog/airflow-survey-2020/index.html
index fbd89ae..a9fe6cb 100644
--- a/blog/airflow-survey-2020/index.html
+++ b/blog/airflow-survey-2020/index.html
@@ -36,13 +36,13 @@
 
 
 
-
+
 
 
 
 
 
-
+
 
 
 
diff --git a/blog/airflow-survey/index.html b/blog/airflow-survey/index.html
index 53251e9..4b56293 100644
--- a/blog/airflow-survey/index.html
+++ b/blog/airflow-survey/index.html
@@ -36,13 +36,13 @@
 
 
 
-
+
 
 
 
 
 
-
+
 
 
 
diff --git a/blog/airflow-two-point-oh-is-here/index.html 
b/blog/airflow-two-point-oh-is-here/index.html
index a532b3d..f985d7e 100644
--- a/blog/airflow-two-point-oh-is-here/index.html
+++ b/blog/airflow

[GitHub] [airflow] eladkal commented on issue #17815: Missing example for Salesforce DAG

[GitBox]

eladkal commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-1045976042


   @rsg17 The goal of examples is to show simple usage of the capabilities. It 
is not for suggesting workaround or how to complete missing functionality (Bulk 
is not yet supported https://github.com/apache/airflow/issues/16921 )
   
   The easiest way to do it is simple go over the provider abilities and add 
example where missing. If you find the examples we have satisfactory we can 
close this issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk closed issue #21671: Amazon Airflow Provider | Broken AWS SES as backend for Email

[GitBox]

potiuk closed issue #21671:
URL: https://github.com/apache/airflow/issues/21671


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #21681: Fix Amazon SES emailer signature

[GitBox]

potiuk merged pull request #21681:
URL: https://github.com/apache/airflow/pull/21681


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #21680: Increase timeout for constraints

[GitBox]

potiuk merged pull request #21680:
URL: https://github.com/apache/airflow/pull/21680


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[airflow] branch main updated (b48dc4d -> b28f4c5)

[potiuk]

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git.


from b48dc4d  Update best-practices.rst (#21679)
 add b28f4c5  Fix Amazon SES emailer signature (#21681)

No new revisions were added by this update.

Summary of changes:
 airflow/providers/amazon/aws/utils/emailer.py|  5 +++--
 docs/apache-airflow/howto/email-config.rst   |  5 +++--
 tests/providers/amazon/aws/utils/test_emailer.py | 11 ++-
 3 files changed, 16 insertions(+), 5 deletions(-)

[GitHub] [airflow] potiuk commented on pull request #21680: Increase timeout for constraints

[GitBox]

potiuk commented on pull request #21680:
URL: https://github.com/apache/airflow/pull/21680#issuecomment-1045977729


   Ah I see. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[airflow] branch main updated (b28f4c5 -> 61e8a5c)

[potiuk]

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git.


from b28f4c5  Fix Amazon SES emailer signature (#21681)
 add 61e8a5c  Increase timeout for constraints (#21680)

No new revisions were added by this update.

Summary of changes:
 .github/workflows/ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[GitHub] [airflow] potiuk commented on pull request #21648: Increase timeout for constraints job

[GitBox]

potiuk commented on pull request #21648:
URL: https://github.com/apache/airflow/pull/21648#issuecomment-1045978044


   Merged it before in #21680 - I set 40 minutes. It could be arbitrary long - 
the constraints job only runs if "setup.py/cfg" changes so we could even set it 
for 2 hours :) if needed :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk closed pull request #21648: Increase timeout for constraints job

[GitBox]

potiuk closed pull request #21648:
URL: https://github.com/apache/airflow/pull/21648


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #21351: Add and use supports_celery attribute for cli celery command validation

[GitBox]

potiuk commented on a change in pull request #21351:
URL: https://github.com/apache/airflow/pull/21351#discussion_r810471560



##
File path: tests/cli/test_cli_parser.py
##
@@ -206,8 +206,9 @@ def 
test_dag_parser_celery_command_require_celery_executor(self):
 stderr = stderr.getvalue()
 assert (
 "airflow command error: argument GROUP_OR_COMMAND: celery 
subcommand "
-"works only with CeleryExecutor, CeleryKubernetesExecutor and 
executors derived from them, "
-"your current executor: SequentialExecutor, subclassed from: 
BaseExecutor, see help above."
+"works only with executors that has 'supports_celery' set to True, 
"

Review comment:
   ```suggestion
   "works only with executors that have 'supports_celery' set to 
True, "
   ```

##
File path: airflow/cli/cli_parser.py
##
@@ -59,31 +59,23 @@ class DefaultHelpParser(argparse.ArgumentParser):
 def _check_value(self, action, value):
 """Override _check_value and check conditionally added command"""
 if action.dest == 'subcommand' and value == 'celery':
+try:
+from airflow.executors.celery_executor import CeleryExecutor  
# noqa
+except ImportError:
+message = (
+"The celery subcommand requires that you pip install the 
celery module. "
+"To do it, run: pip install 'apache-airflow[celery]'"
+)
+raise ArgumentError(action, message)
+
 executor = conf.get('core', 'EXECUTOR')
 if executor not in (CELERY_EXECUTOR, CELERY_KUBERNETES_EXECUTOR):
 executor_cls, _ = ExecutorLoader.import_executor_cls(executor)
-classes = ()
-try:
-from airflow.executors.celery_executor import 
CeleryExecutor
-
-classes += (CeleryExecutor,)
-except ImportError:
-message = (
-"The celery subcommand requires that you pip install 
the celery module. "
-"To do it, run: pip install 'apache-airflow[celery]'"
-)
-raise ArgumentError(action, message)
-try:
-from airflow.executors.celery_kubernetes_executor import 
CeleryKubernetesExecutor
-
-classes += (CeleryKubernetesExecutor,)
-except ImportError:
-pass
-if not issubclass(executor_cls, classes):
+if not getattr(executor_cls, "supports_celery", False):
 message = (
-f'celery subcommand works only with CeleryExecutor, 
CeleryKubernetesExecutor and '
-f'executors derived from them, your current executor: 
{executor}, subclassed from: '
-f'{", ".join([base_cls.__qualname__ for base_cls in 
executor_cls.__bases__])}'
+f"celery subcommand works only with executors that has 
'supports_celery' "

Review comment:
   ```suggestion
   f"celery subcommand works only with executors that 
have 'supports_celery' "
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] Sonins commented on pull request #20508: Fix dates.days_ago to respect localized timezone configuration.

[GitBox]

Sonins commented on pull request #20508:
URL: https://github.com/apache/airflow/pull/20508#issuecomment-1045980255


   @eladkal @dstandish No problem 🍺


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #21351: Add and use supports_celery attribute for cli celery command validation

[GitBox]

potiuk commented on pull request #21351:
URL: https://github.com/apache/airflow/pull/21351#issuecomment-1045980261


   I will need one more committer's approval though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] eladkal commented on pull request #21673: Implement a Sagemaker DeleteModelOperator and Delete model hook.

[GitBox]

eladkal commented on pull request #21673:
URL: https://github.com/apache/airflow/pull/21673#issuecomment-1045980385


   Can you please update docs and add example dag?
   
https://github.com/apache/airflow/tree/main/airflow/providers/amazon/aws/example_dags
   
https://github.com/apache/airflow/tree/main/docs/apache-airflow-providers-amazon/operators


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] eladkal edited a comment on pull request #21673: Implement a Sagemaker DeleteModelOperator and Delete model hook.

[GitBox]

eladkal edited a comment on pull request #21673:
URL: https://github.com/apache/airflow/pull/21673#issuecomment-1045980385


   Can you please add docs and example dag?
   
https://github.com/apache/airflow/tree/main/airflow/providers/amazon/aws/example_dags
   
https://github.com/apache/airflow/tree/main/docs/apache-airflow-providers-amazon/operators


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #21506: Add celery_logging_level

[GitBox]

potiuk merged pull request #21506:
URL: https://github.com/apache/airflow/pull/21506


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[airflow] branch main updated (61e8a5c -> ecd85f8)

[potiuk]

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git.


from 61e8a5c  Increase timeout for constraints (#21680)
 add ecd85f8  Add celery_logging_level (#21506)

No new revisions were added by this update.

Summary of changes:
 airflow/cli/commands/celery_command.py   | 6 +-
 airflow/config_templates/config.yml  | 9 +
 airflow/config_templates/default_airflow.cfg | 5 +
 airflow/config_templates/default_test.cfg| 1 +
 airflow/configuration.py | 2 ++
 tests/cli/commands/test_celery_command.py| 2 +-
 6 files changed, 23 insertions(+), 2 deletions(-)

[GitHub] [airflow] eladkal merged pull request #21523: Update EKS sample DAGs and docs

[GitBox]

eladkal merged pull request #21523:
URL: https://github.com/apache/airflow/pull/21523


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[airflow] branch main updated (ecd85f8 -> dec05fb)

[eladkal]

This is an automated email from the ASF dual-hosted git repository.

eladkal pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git.


from ecd85f8  Add celery_logging_level (#21506)
 add dec05fb  Update EKS sample DAGs and docs (#21523)

No new revisions were added by this update.

Summary of changes:
 .../aws/example_dags/example_eks_templated.py  | 42 +
 .../example_eks_with_fargate_in_one_step.py| 14 --
 .../example_eks_with_fargate_profile.py| 21 +++--
 .../example_eks_with_nodegroup_in_one_step.py  | 16 +--
 .../example_dags/example_eks_with_nodegroups.py| 26 ---
 airflow/providers/amazon/aws/sensors/eks.py| 12 +
 .../operators/eks.rst  | 54 ++
 7 files changed, 145 insertions(+), 40 deletions(-)

[GitHub] [airflow] jayantsande25 commented on issue #17815: Missing example for Salesforce DAG

[GitBox]

jayantsande25 commented on issue #17815:
URL: https://github.com/apache/airflow/issues/17815#issuecomment-1045981977


   Yes Rachana
   You're understanding is correct.
   In case you need more information please let me know, we can discuss
   
   
   On Sat, 19 Feb 2022, 12:35 Rachana Gogate, ***@***.***> wrote:
   
   > I would like to take a pass at this.
   >
   > Can you confirm if my understanding is correct?
   >
   >1. Salesforce Apex example dag
   >

   >has just one example to POST activity data. More example dags are 
possible
   >here given the flexibility of the Operator.
   >2. We don't have a Salesforce Bulk or similar operator. We would like
   >to add that and corresponding examples.
   >
   > —
   > Reply to this email directly, view it on GitHub
   > ,
   > or unsubscribe
   > 

   > .
   > Triage notifications on the go with GitHub Mobile for iOS
   > 

   > or Android
   > 
.
   >
   > You are receiving this because you authored the thread.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #21127: Fail to download task log if there are Chinese characters in dag_id

[GitBox]

eladkal commented on issue #21127:
URL: https://github.com/apache/airflow/issues/21127#issuecomment-1045983659


   I guess this might change in the future there is a good discussion in 
https://github.com/apache/airflow/issues/18010#issuecomment-912820115
   Probably the idea of separating the id from the display name in the UI will 
happen in future releases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] hsrocks commented on pull request #21673: Implement a Sagemaker DeleteModelOperator and Delete model hook.

[GitBox]

hsrocks commented on pull request #21673:
URL: https://github.com/apache/airflow/pull/21673#issuecomment-1045984330


   > Can you please add docs and example dag? 
https://github.com/apache/airflow/tree/main/airflow/providers/amazon/aws/example_dags
 
https://github.com/apache/airflow/tree/main/docs/apache-airflow-providers-amazon/operators
   
   Sure! Valid point @eladkal . Can see its missing for sagemaker altogether. 
Will do it . The failed test '
   Tests / MySQL5.7, Py3.7: Always Integration Providers (pull_request) ' is 
not related to changes. Can you please suggest @eladkal ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] eladkal opened a new issue #21683: Remove all usages of days_ago from test suite

[GitBox]

eladkal opened a new issue #21683:
URL: https://github.com/apache/airflow/issues/21683


   ### Body
   
   `days_ago` is deprecated https://github.com/apache/airflow/pull/21653
   
   We have several references to the function in test suite / example dags.
   
   Task:
   there should be no imports of `airflow.utils.dates import days_ago` in the 
code.
   In most cases we can simple replace with `datetime(2022, 1, 1)`
   
   ### Committer
   
   - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow 
project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] raphaelauv commented on issue #19698: Graceful handle for airflow application pods during K8s API brief interuption

[GitBox]

raphaelauv commented on issue #19698:
URL: https://github.com/apache/airflow/issues/19698#issuecomment-1045997145


   I think we can close this issue , now that the new kubernetesPodOperator is 
retrying.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] utkarsharma2 commented on pull request #21630: Replaced hql references to sql in TrinoHook and PrestoHook #21597

[GitBox]

utkarsharma2 commented on pull request #21630:
URL: https://github.com/apache/airflow/pull/21630#issuecomment-1046006526


   @eladkal, last commit was missing logic to give warning when 'hql' parameter 
is used, fixed it and static check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] hubert-pietron commented on issue #21683: Remove all usages of days_ago from test suite

[GitBox]

hubert-pietron commented on issue #21683:
URL: https://github.com/apache/airflow/issues/21683#issuecomment-1046025246


   Hi, can i take it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #21673: Implement a Sagemaker DeleteModelOperator and Delete model hook.

[GitBox]

potiuk commented on pull request #21673:
URL: https://github.com/apache/airflow/pull/21673#issuecomment-1046035627


   > > Can you please add docs and example dag? 
https://github.com/apache/airflow/tree/main/airflow/providers/amazon/aws/example_dags
 
https://github.com/apache/airflow/tree/main/docs/apache-airflow-providers-amazon/operators
   > 
   > Sure! Valid point @eladkal . Can see its missing for sagemaker altogether. 
Will do it . The failed test ' Tests / MySQL5.7, Py3.7: Always Integration 
Providers (pull_request) ' is not related to changes. Can you please suggest 
@eladkal ?
   
   It could be flaky failure. Try again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk closed issue #19698: Graceful handle for airflow application pods during K8s API brief interuption

[GitBox]

potiuk closed issue #19698:
URL: https://github.com/apache/airflow/issues/19698


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] avkirilishin opened a new pull request #21684: Add dependency to the running_deps

[GitBox]

avkirilishin opened a new pull request #21684:
URL: https://github.com/apache/airflow/pull/21684


   closes: #20461
   
   Problem: Airflow is trying to schedule tasks prior to DAG's start_date.
   Solution: Added ExecDateAfterStartDateDep to the dependencies that need to 
be met for a given task instance to be set to 'RUNNING' state.
   
   
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21434: Task names should be consistent with variable names (drop vs create) in example dags

[GitBox]

boring-cyborg[bot] commented on pull request #21434:
URL: https://github.com/apache/airflow/pull/21434#issuecomment-1046047089


   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[airflow] branch main updated (dec05fb -> 68da4d8)

[eladkal]

This is an automated email from the ASF dual-hosted git repository.

eladkal pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git.


from dec05fb  Update EKS sample DAGs and docs (#21523)
 add 68da4d8  Update MySqlOperator example dag (#21434)

No new revisions were added by this update.

Summary of changes:
 airflow/providers/mysql/example_dags/example_mysql.py | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

[GitHub] [airflow] eladkal merged pull request #21434: Task names should be consistent with variable names (drop vs create) in example dags

[GitBox]

eladkal merged pull request #21434:
URL: https://github.com/apache/airflow/pull/21434


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] avkirilishin commented on issue #20461: Airflow is trying to schedule tasks prior to DAG's start_date

[GitBox]

avkirilishin commented on issue #20461:
URL: https://github.com/apache/airflow/issues/20461#issuecomment-1046051990


   > @avkirilishin runs were created in 2.2.0 or 2.2.1 likely then Airflow was 
upgraded to 2.2.2.
   
   @andreychernih I think there are two different problems:
   
   1) The problem is related to the different logic of the scheduler before and 
after the update. Maybe there are no tasks in the running dags or something 
else. Can you show the rows for this dag run in dag, dag_run and task_instance?
   
   2) I agree with you that it is not the right behavior for the scheduler to 
continue scheduling runs that are earlier than the actual start date of the DAG 
or Task. It can happen, for example, after turning the dag off and back on. So 
I made a PR to fix it: https://github.com/apache/airflow/pull/21684


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] aa3pankaj commented on a change in pull request #21342: Add 'Show record' option for variables

[GitBox]

aa3pankaj commented on a change in pull request #21342:
URL: https://github.com/apache/airflow/pull/21342#discussion_r810511249



##
File path: airflow/www/templates/airflow/variable_show_widget.html
##
@@ -0,0 +1,70 @@
+{#
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements.  See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership.  The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License.  You may obtain a copy of the License at
+
+   http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied.  See the License for the
+ specific language governing permissions and limitations
+ under the License.
+#}
+
+{% import 'appbuilder/general/lib.html' as lib %}
+{% include 'appbuilder/general/confirm.html' %}
+{% include 'appbuilder/general/alert.html' %}
+
+{% block columns %}
+
+{% if fieldsets %}
+
+{% for fieldset_item in fieldsets %}
+{% if fieldset_item[1].get('expanded') == None %}
+{% set expanded = True %}
+{% else %}
+{% set expanded = fieldset_item[1].get('expanded') %}
+{% endif %}
+{% call lib.accordion_tag(loop.index,fieldset_item[0], expanded) %}
+
+
+{% for item in fieldset_item[1].get('fields') %}
+
+{{label_columns.get(item)}}
+{{value_columns[include_columns.index(item)]}}

Review comment:
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] aa3pankaj commented on a change in pull request #21342: Add 'Show record' option for variables

[GitBox]

aa3pankaj commented on a change in pull request #21342:
URL: https://github.com/apache/airflow/pull/21342#discussion_r810511392



##
File path: airflow/www/views.py
##
@@ -3859,6 +3859,9 @@ class VariableModelView(AirflowModelView):
 
 list_template = 'airflow/variable_list.html'
 edit_template = 'airflow/variable_edit.html'
+show_template = 'airflow/variable_show.html'

Review comment:
   overriding _show of BaseCRUDView to mask secret values.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] aa3pankaj commented on a change in pull request #21342: Add 'Show record' option for variables

[GitBox]

aa3pankaj commented on a change in pull request #21342:
URL: https://github.com/apache/airflow/pull/21342#discussion_r810511424



##
File path: airflow/www/views.py
##
@@ -3867,13 +3870,15 @@ class VariableModelView(AirflowModelView):
 'add': 'create',
 'list': 'read',
 'edit': 'edit',
+'show': 'show',

Review comment:
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[airflow] branch constraints-main updated: Updating constraints. Build id:1869261766

[github-bot]

This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a commit to branch constraints-main
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/constraints-main by this push:
 new 5393a3f  Updating constraints. Build id:1869261766
5393a3f is described below

commit 5393a3f88c847a0cda59e842c299265b81b8fd1c
Author: Automated GitHub Actions commit 
AuthorDate: Sat Feb 19 16:30:02 2022 +

Updating constraints. Build id:1869261766

This update in constraints is automatically committed by the CI 
'constraints-push' step based on
HEAD of 'refs/heads/main' in 'apache/airflow'
with commit sha 68da4d84ef3e182916e2ca7ce4909f7f5e22e21f.

All tests passed in this build so we determined we can push the updated 
constraints.

See 
https://github.com/apache/airflow/blob/main/README.md#installing-from-pypi for 
details.
---
 constraints-3.7.txt  | 32 
 constraints-3.8.txt  | 32 
 constraints-3.9.txt  | 32 
 constraints-no-providers-3.7.txt | 10 +-
 constraints-no-providers-3.8.txt | 10 +-
 constraints-no-providers-3.9.txt | 10 +-
 constraints-source-providers-3.7.txt | 26 +-
 constraints-source-providers-3.8.txt | 26 +-
 constraints-source-providers-3.9.txt | 26 +-
 9 files changed, 102 insertions(+), 102 deletions(-)

diff --git a/constraints-3.7.txt b/constraints-3.7.txt
index bd034cf..b431721 100644
--- a/constraints-3.7.txt
+++ b/constraints-3.7.txt
@@ -1,5 +1,5 @@
 #
-# This constraints file was automatically generated on 2022-02-17T19:37:28Z
+# This constraints file was automatically generated on 2022-02-19T16:26:10Z
 # via "eager-upgrade" mechanism of PIP. For the "main" branch of Airflow.
 # This variant of constraints install uses the HEAD of the branch version for 
'apache-airflow' but installs
 # the providers from PIP-released packages at the moment of the constraint 
generation.
@@ -44,7 +44,7 @@ SQLAlchemy-Utils==0.38.2
 SQLAlchemy==1.4.9
 SecretStorage==3.3.1
 Sphinx==4.4.0
-Unidecode==1.3.2
+Unidecode==1.3.3
 WTForms==2.3.3
 Werkzeug==1.0.1
 adal==1.2.7
@@ -82,12 +82,12 @@ apache-airflow-providers-datadog==2.0.1
 apache-airflow-providers-dingding==2.0.1
 apache-airflow-providers-discord==2.0.1
 apache-airflow-providers-docker==2.4.1
-apache-airflow-providers-elasticsearch==2.1.0
+apache-airflow-providers-elasticsearch==2.2.0
 apache-airflow-providers-exasol==2.1.0
 apache-airflow-providers-facebook==2.2.0
 apache-airflow-providers-ftp==2.0.1
 apache-airflow-providers-github==1.0.0
-apache-airflow-providers-google==6.3.0
+apache-airflow-providers-google==6.4.0
 apache-airflow-providers-grpc==2.0.1
 apache-airflow-providers-hashicorp==2.1.1
 apache-airflow-providers-http==2.0.3
@@ -106,7 +106,7 @@ apache-airflow-providers-neo4j==2.1.0
 apache-airflow-providers-odbc==2.0.1
 apache-airflow-providers-openfaas==2.0.0
 apache-airflow-providers-opsgenie==3.0.0
-apache-airflow-providers-oracle==2.1.0
+apache-airflow-providers-oracle==2.2.0
 apache-airflow-providers-pagerduty==2.1.0
 apache-airflow-providers-papermill==2.2.0
 apache-airflow-providers-plexus==2.0.1
@@ -174,9 +174,9 @@ billiard==3.6.4.0
 black==22.1.0
 bleach==4.1.0
 blinker==1.4
-boto3==1.21.1
+boto3==1.21.3
 boto==2.49.0
-botocore==1.24.1
+botocore==1.24.3
 bowler==0.9.0
 cached-property==1.5.2
 cachelib==0.6.0
@@ -192,18 +192,18 @@ charset-normalizer==2.0.12
 click-didyoumean==0.3.0
 click-plugins==1.1.1
 click-repl==0.2.0
-click==8.0.3
+click==8.0.4
 clickclick==20.10.2
 cloudant==2.15.0
 cloudpickle==1.4.1
 colorama==0.4.4
 colorlog==4.8.0
 commonmark==0.9.1
-connexion==2.11.1
+connexion==2.11.2
 coverage==6.3.1
 crcmod==1.7
 cron-descriptor==1.2.24
-croniter==1.3.1
+croniter==1.3.4
 cryptography==3.4.8
 curlify==2.2.1
 cx-Oracle==8.3.0
@@ -255,9 +255,9 @@ google-cloud-audit-log==0.2.0
 google-cloud-automl==2.6.0
 google-cloud-bigquery-datatransfer==3.6.0
 google-cloud-bigquery-storage==2.11.0
-google-cloud-bigquery==2.33.0
+google-cloud-bigquery==2.34.0
 google-cloud-bigtable==1.7.0
-google-cloud-build==3.7.1
+google-cloud-build==3.8.0
 google-cloud-container==1.0.1
 google-cloud-core==1.7.2
 google-cloud-datacatalog==3.6.2
@@ -290,7 +290,7 @@ graphviz==0.19.1
 greenlet==1.1.2
 grpc-google-iam-v1==0.12.3
 grpcio-gcp==0.2.2
-grpcio==1.43.0
+grpcio==1.44.0
 gssapi==1.7.3
 gunicorn==20.1.0
 h11==0.12.0
@@ -308,7 +308,7 @@ imagesize==1.3.0
 importlib-metadata==4.11.1
 importlib-resources==5.4.0
 inflection==0.5.1
-influxdb-client==1.25.0
+influxdb-client==1.26.0
 iniconfig==1.1.1
 ipdb==0.13.9
 ipython-genutils==0.2.0
@@ -388,7 +388,7 @@ pdpyras==4.4.0
 pendulum==2.1.2
 pexpect==4.8.0
 pickleshare==0.7.5
-pinotdb==0.3.8
+pinotdb==0.3.9
 pipdeptree==2.2.1
 pipx==1.0.0
 p

[GitHub] [airflow] eladkal commented on pull request #21673: Implement a Sagemaker DeleteModelOperator and Delete model hook.

[GitBox]

eladkal commented on pull request #21673:
URL: https://github.com/apache/airflow/pull/21673#issuecomment-1046056598


   Yep probably not related. Once you will add the docs and example I'll review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow-site] astrorfox opened a new pull request #548: Updating Astronomer Reference

[GitBox]

astrorfox opened a new pull request #548:
URL: https://github.com/apache/airflow-site/pull/548


   Update Astronomer's product reference to reflect the latest product branding.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] eladkal commented on a change in pull request #20757: Update sftp.rst

[GitBox]

eladkal commented on a change in pull request #20757:
URL: https://github.com/apache/airflow/pull/20757#discussion_r810514063



##
File path: docs/apache-airflow-providers-sftp/connections/sftp.rst
##
@@ -73,17 +73,24 @@ Extra (optional)
 * ``private_key`` Specify the content of the private key, the path to the 
private key file(str) or paramiko.AgentKey
 * ``key_file`` - Full Path of the private SSH Key file that will be used 
to connect to the remote_host.
 
-Example “extras” field:
+Example “extras” field using ``host_key``:
 
-.. code-block:: bash
+.. code-block:: json
 
 {
-   "key_file": "path/to/private_key",
"no_host_key_check": "false",
"allow_host_key_change": "false",
"host_key": "AAAHD...YDWwq=="
 }
 
+Example “extras” field using ``key_file`` or ``private_key``:
+
+.. code-block:: json
+{
+   "key_file": "path/to/private_key",
+   "no_host_key_check": "true"
+}
+

Review comment:
   ```suggestion
   Example “extras” field using ``key_file`` or ``private_key```:
   
   .. code-block:: json
   
   {
  "key_file": "path/to/private_key",
  "no_host_key_check": "true"
   }
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk opened a new pull request #21685: Add extra information about time synchronization needed

[GitBox]

potiuk opened a new pull request #21685:
URL: https://github.com/apache/airflow/pull/21685


   When you have several machines running Airflow and their time
   is not synchronized, you might get very weird behaviour - some of
   the log retrieval actions might randomly return "forbidden" error
   because of expiring token. This is extremely difficult to
   diagnose and figure out (some of our users spent days on
   investigating that). Explicitly stating the requirement in the
   forbidden error and whenever secret_key parameter is
   mentioned, should help our users to diagnose it more easily
   (and save maintainers from unnecessary questions and discussions
   in Slack :))
   
   
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] eladkal commented on a change in pull request #21685: Add extra information about time synchronization needed

[GitBox]

eladkal commented on a change in pull request #21685:
URL: https://github.com/apache/airflow/pull/21685#discussion_r810515314



##
File path: airflow/config_templates/config.yml
##
@@ -1085,6 +1085,10 @@
 Secret key used to run your flask app. It should be as random as 
possible. However, when running
 more than 1 instances of webserver, make sure all of them use the same 
``secret_key`` otherwise
 one of them will error with "CSRF session token is missing".
+The webserver key is also used to authorize requests to Celery workers 
when loga are retrieved.

Review comment:
   ```suggestion
   The webserver key is also used to authorize requests to Celery 
workers when logs are retrieved.
   ```

##
File path: docs/helm-chart/production-guide.rst
##
@@ -111,6 +111,11 @@ Example to create a Kubernetes Secret from ``kubectl``:
 
 kubectl create secret generic my-webserver-secret 
--from-literal="webserver-secret-key=$(python3 -c 'import secrets; 
print(secrets.token_hex(16))')"
 
+The webserver key is also used to authorize requests to Celery workers when 
loga are retrieved. The token

Review comment:
   ```suggestion
   The webserver key is also used to authorize requests to Celery workers when 
logs are retrieved. The token
   ```

##
File path: docs/apache-airflow/howto/set-config.rst
##
@@ -121,3 +121,8 @@ the example below.
 does not require all, some configurations need to be same otherwise they 
would not
 work as expected. A good example for that is 
:ref:`secret_key` which
 should be same on the Webserver and Worker to allow Webserver to fetch 
logs from Worker.
+
+The webserver key is also used to authorize requests to Celery workers 
when loga are retrieved. The token

Review comment:
   ```suggestion
   The webserver key is also used to authorize requests to Celery workers 
when logs are retrieved. The token
   ```

##
File path: docs/apache-airflow/upgrading-from-1-10/index.rst
##
@@ -339,6 +339,11 @@ the only supported UI.
 this via any configuration mechanism. The 1.10.15 bridge-release modifies 
this feature
 to use randomly generated secret keys instead of an insecure default and 
may break existing
 deployments that rely on the default.
+The webserver key is also used to authorize requests to Celery workers 
when loga are retrieved. The token

Review comment:
   ```suggestion
   The webserver key is also used to authorize requests to Celery workers 
when logs are retrieved. The token
   ```

##
File path: airflow/config_templates/default_airflow.cfg
##
@@ -559,6 +559,10 @@ reload_on_plugin_change = False
 # Secret key used to run your flask app. It should be as random as possible. 
However, when running
 # more than 1 instances of webserver, make sure all of them use the same 
``secret_key`` otherwise
 # one of them will error with "CSRF session token is missing".
+# The webserver key is also used to authorize requests to Celery workers when 
loga are retrieved.

Review comment:
   ```suggestion
   # The webserver key is also used to authorize requests to Celery workers 
when logs are retrieved.
   ```

##
File path: docs/apache-airflow/configurations-ref.rst
##
@@ -27,6 +27,11 @@ does not require all, some configurations need to be same 
otherwise they would n
 work as expected. A good example for that is 
:ref:`secret_key` which
 should be same on the Webserver and Worker to allow Webserver to fetch logs 
from Worker.
 
+The webserver key is also used to authorize requests to Celery workers when 
loga are retrieved. The token

Review comment:
   ```suggestion
   The webserver key is also used to authorize requests to Celery workers when 
logs are retrieved. The token
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #21685: Add extra information about time synchronization needed

[GitBox]

github-actions[bot] commented on pull request #21685:
URL: https://github.com/apache/airflow/pull/21685#issuecomment-1046063591






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #21685: Add extra information about time synchronization needed

[GitBox]

potiuk commented on pull request #21685:
URL: https://github.com/apache/airflow/pull/21685#issuecomment-1046064722


   I deliberetely put repeated content in this case. The problem with content 
that is "linked" from many places is that most users will not follow "see also" 
or "look for details". I believe some level of redundancy in "watch outs" and 
warnings like this is not only good but necessary - especially that (unlike 
code) those warnings will not get refactored or updated after they are merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #21685: Add extra information about time synchronization needed

[GitBox]

potiuk commented on pull request #21685:
URL: https://github.com/apache/airflow/pull/21685#issuecomment-1046064875


   And when you see mistakes like that, it's also super easy to do 
search-replace if the content is the same :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] schirag1993 closed pull request #21090: Implement AWS Lambda invoke operator

[GitBox]

schirag1993 closed pull request #21090:
URL: https://github.com/apache/airflow/pull/21090


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] schirag1993 opened a new pull request #21686: add invoke lambda function operator

[GitBox]

schirag1993 opened a new pull request #21686:
URL: https://github.com/apache/airflow/pull/21686


   
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] dstandish commented on issue #19346: Sensors no longer respecting `retries` with timeouts.

[GitBox]

dstandish commented on issue #19346:
URL: https://github.com/apache/airflow/issues/19346#issuecomment-1046065769


   > @yuqian90 What if I don't want to or I cannot increase the timeout period? 
In my case I need to retry for a period of 24 hours so if I increase the 
timeout to 24 hours then the task will not release the slot in my environment 
for 24 hours (its basically a running task that takes 24 hours to complete). As 
other similar tasks come in, they also take some slots and my environment 
finally ends up with too many running tasks and causing other issues.
   
   This is a very obvious case for deferrable operators: 
https://airflow.apache.org/docs/apache-airflow/stable/concepts/deferring.html#:~:text=A%20deferrable%20operator%20is%20one,to%20something%20called%20a%20Trigger.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] dstandish edited a comment on issue #19346: Sensors no longer respecting `retries` with timeouts.

[GitBox]

dstandish edited a comment on issue #19346:
URL: https://github.com/apache/airflow/issues/19346#issuecomment-1046065769


   @hojatbay
   
   > What if I don't want to or I cannot increase the timeout period? In my 
case I need to retry for a period of 24 hours so if I increase the timeout to 
24 hours then the task will not release the slot in my environment for 24 hours 
(its basically a running task that takes 24 hours to complete). As other 
similar tasks come in, they also take some slots and my environment finally 
ends up with too many running tasks and causing other issues.
   
   This is a very obvious case for deferrable operators: 
https://airflow.apache.org/docs/apache-airflow/stable/concepts/deferring.html#:~:text=A%20deferrable%20operator%20is%20one,to%20something%20called%20a%20Trigger.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #21685: Add extra information about time synchronization needed

[GitBox]

potiuk commented on pull request #21685:
URL: https://github.com/apache/airflow/pull/21685#issuecomment-1046066143


   Just one comment - tt's actually very similar reasoning why Tests shoudl be 
DAMP not DRY: 
https://testing.googleblog.com/2019/12/testing-on-toilet-tests-too-dry-make.html
 
   
   I agree that also in docs  DRY is important but when faced with the dillema 
DRY or IMMEDIATELY HELPFUL WITHOUT FOLLOWING MORE LINKS (when you see warnings 
and watchouts) I favour the other. 
   
   BTW.  That gave me an idea - I need to come up with some catchy phrase like 
DAMP. I think this might be the next content of my blog post and presentation 
for the summit even :D.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk edited a comment on pull request #21685: Add extra information about time synchronization needed

[GitBox]

potiuk edited a comment on pull request #21685:
URL: https://github.com/apache/airflow/pull/21685#issuecomment-1046066143


   Just one comment - tt's actually very similar reasoning why Tests shoudl be 
DAMP rather than DRY (DAMP should be favoured): 
https://testing.googleblog.com/2019/12/testing-on-toilet-tests-too-dry-make.html
 
   
   I agree that also in docs  DRY is important but when faced with the dillema 
DRY or IMMEDIATELY HELPFUL WITHOUT FOLLOWING MORE LINKS (when you see warnings 
and watchouts) I favour the other. 
   
   BTW.  That gave me an idea - I need to come up with some catchy phrase like 
DAMP. I think this might be the next content of my blog post and presentation 
for the summit even :D.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #21685: Add extra information about time synchronization needed

[GitBox]

potiuk commented on pull request #21685:
URL: https://github.com/apache/airflow/pull/21685#issuecomment-1046066935


   Actually - thanks @eladkal ! I was thinking for a while about a new idea for 
talk / blog post and your comment gave me fantastic idea. I am going to do it 
:) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] uranusjr commented on issue #20461: Airflow is trying to schedule tasks prior to DAG's start_date

[GitBox]

uranusjr commented on issue #20461:
URL: https://github.com/apache/airflow/issues/20461#issuecomment-1046077336


   (Sorry I missed this) I think #21011 is different. That one schedules the 
task (incorrectly) _at_ `start_date` even if that time does not lie on the 
schedule, and the fix is to delay the first run to a time after `start_date` 
that matches the schedule. The problem description here says however the tun is 
scheduled _before_ `start_date`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] pateash opened a new pull request #21687: [WIP]: openapi java client for airflow

[GitBox]

pateash opened a new pull request #21687:
URL: https://github.com/apache/airflow/pull/21687


   closes #17362 
   
   ---
   This PR adds a generation script for generating OpenAPI Airflow JDK client.
   
   related PR - https://github.com/apache/airflow-client-java/pull/1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[airflow-site] branch main updated: Updating Astronomer Reference (#548)

[potiuk]

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow-site.git


The following commit(s) were added to refs/heads/main by this push:
 new b715054  Updating Astronomer Reference (#548)
b715054 is described below

commit b715054b26be0a787a9585955aea002792bb209d
Author: Ryan Fox <68031732+astror...@users.noreply.github.com>
AuthorDate: Sat Feb 19 13:31:56 2022 -0500

Updating Astronomer Reference (#548)

Update Astronomer's product reference to reflect the latest product 
branding.
---
 landing-pages/site/content/en/ecosystem/_index.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/landing-pages/site/content/en/ecosystem/_index.md 
b/landing-pages/site/content/en/ecosystem/_index.md
index 6c2cb76..50c6e2f 100644
--- a/landing-pages/site/content/en/ecosystem/_index.md
+++ b/landing-pages/site/content/en/ecosystem/_index.md
@@ -33,7 +33,7 @@ If you would you like to be included on this page, please 
reach out to the [Apac
 
 ## Airflow as a Service
 
-[Astronomer](https://www.astronomer.io/) - Managed Apache Airflow in 
Astronomer Cloud, or self-hosted within your environment
+[Astro](https://www.astronomer.io/product) - Provided by Astronomer, Astro is 
the modern data orchestration platform, powered by Apache Airflow. Astro 
enables data engineers, data scientists, and data analysts to build, run, and 
observe pipelines-as-code.
 
 [Google Cloud Composer](https://cloud.google.com/composer) - Managed Apache 
Airflow service on Google Cloud Platform
 

[GitHub] [airflow-site] potiuk merged pull request #548: Updating Astronomer Reference

[GitBox]

potiuk merged pull request #548:
URL: https://github.com/apache/airflow-site/pull/548


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] chenglongyan opened a new pull request #21688: Simplify check_cycle() implement

[GitBox]

chenglongyan opened a new pull request #21688:
URL: https://github.com/apache/airflow/pull/21688


   DAG.topological_sort() seems did the same thing?
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[airflow-site] branch gh-pages updated: Deploying to gh-pages from @ b715054b26be0a787a9585955aea002792bb209d 🚀

[github-bot]

This is an automated email from the ASF dual-hosted git repository.

github-bot pushed a commit to branch gh-pages
in repository https://gitbox.apache.org/repos/asf/airflow-site.git


The following commit(s) were added to refs/heads/gh-pages by this push:
 new 9e52a98  Deploying to gh-pages from  @ 
b715054b26be0a787a9585955aea002792bb209d 🚀
9e52a98 is described below

commit 9e52a98eddc4b6aa8251e300403b4f914faf4ea7
Author: potiuk 
AuthorDate: Sat Feb 19 18:39:29 2022 +

Deploying to gh-pages from  @ b715054b26be0a787a9585955aea002792bb209d 🚀
---
 blog/airflow-1.10.10/index.html|  4 +-
 blog/airflow-1.10.12/index.html|  4 +-
 blog/airflow-1.10.8-1.10.9/index.html  |  4 +-
 blog/airflow-2.2.0/index.html  |  4 +-
 blog/airflow-survey-2020/index.html|  4 +-
 blog/airflow-survey/index.html |  4 +-
 blog/airflow-two-point-oh-is-here/index.html   |  4 +-
 blog/airflow_summit_2021/index.html|  4 +-
 blog/announcing-new-website/index.html |  4 +-
 blog/apache-airflow-for-newcomers/index.html   |  4 +-
 .../index.html |  4 +-
 .../index.html |  4 +-
 .../index.html |  4 +-
 .../index.html |  4 +-
 .../index.html |  4 +-
 .../index.html |  4 +-
 ecosystem/index.html   |  2 +-
 index.html | 32 
 search/index.html  |  4 +-
 sitemap.xml| 92 +++---
 use-cases/adobe/index.html |  4 +-
 use-cases/adyen/index.html |  4 +-
 use-cases/big-fish-games/index.html|  4 +-
 use-cases/dish/index.html  |  4 +-
 use-cases/experity/index.html  |  4 +-
 use-cases/onefootball/index.html   |  4 +-
 use-cases/plarium-krasnodar/index.html |  4 +-
 use-cases/seniorlink/index.html|  4 +-
 use-cases/sift/index.html  |  4 +-
 29 files changed, 115 insertions(+), 115 deletions(-)

diff --git a/blog/airflow-1.10.10/index.html b/blog/airflow-1.10.10/index.html
index 3fc6922..e5e67be 100644
--- a/blog/airflow-1.10.10/index.html
+++ b/blog/airflow-1.10.10/index.html
@@ -36,13 +36,13 @@
 
 
 
-
+
 
 
 
 
 
-
+
 
 
 
diff --git a/blog/airflow-1.10.12/index.html b/blog/airflow-1.10.12/index.html
index 76169ba..03ff426 100644
--- a/blog/airflow-1.10.12/index.html
+++ b/blog/airflow-1.10.12/index.html
@@ -36,13 +36,13 @@
 
 
 
-
+
 
 
 
 
 
-
+
 
 
 
diff --git a/blog/airflow-1.10.8-1.10.9/index.html 
b/blog/airflow-1.10.8-1.10.9/index.html
index 5ddcef1..d473c77 100644
--- a/blog/airflow-1.10.8-1.10.9/index.html
+++ b/blog/airflow-1.10.8-1.10.9/index.html
@@ -36,13 +36,13 @@
 
 
 
-
+
 
 
 
 
 
-
+
 
 
 
diff --git a/blog/airflow-2.2.0/index.html b/blog/airflow-2.2.0/index.html
index e5eb452..131e646 100644
--- a/blog/airflow-2.2.0/index.html
+++ b/blog/airflow-2.2.0/index.html
@@ -36,13 +36,13 @@
 
 
 
-
+
 
 
 
 
 
-
+
 
 
 
diff --git a/blog/airflow-survey-2020/index.html 
b/blog/airflow-survey-2020/index.html
index a9fe6cb..d82ea67 100644
--- a/blog/airflow-survey-2020/index.html
+++ b/blog/airflow-survey-2020/index.html
@@ -36,13 +36,13 @@
 
 
 
-
+
 
 
 
 
 
-
+
 
 
 
diff --git a/blog/airflow-survey/index.html b/blog/airflow-survey/index.html
index 4b56293..711bdfc 100644
--- a/blog/airflow-survey/index.html
+++ b/blog/airflow-survey/index.html
@@ -36,13 +36,13 @@
 
 
 
-
+
 
 
 
 
 
-
+
 
 
 
diff --git a/blog/airflow-two-point-oh-is-here/index.html 
b/blog/airflow-two-point-oh-is-here/index.html
index f985d7e..531783f 100644
--- a/blog/airflow-two-point-oh-is-here/index.html
+++ b/blog/airflow-two-point-oh-is-here/index.html
@@ -36,13 +36,13 @@
 
 
 
-
+
 
 
 
 
 
-
+
 
 
 
diff --git a/blog/airflow_summit_2021/index.html 
b/blog/airflow_summit_2021/index.html
index 522289d..5eee030 100644
--- a/blog/airflow_summit_2021/index.html
+++ b/blog/airflow_summit_2021/index.html
@@ -36,13 +36,13 @@
 
 
 
-
+
 
 
 
 
 
-
+
 
 
 
diff --git a/blog/announcing-new-website/index.html 
b/blog/announcing-new-website/index.html
index 4614455..94848f1 100644
--- a/blog/announcing-new-website/index.html
+++ b/blog/announcing-new-website/index.html
@@ -36,13 +36,13 @@
 
 
 
-
+
 
 
 
 
 
-
+
 
 
 
diff --git a/blog/apache-airflow-for-newcomers/index.html 
b/blog/apache-airflow-for-newcomers/index.html
index b941a9c..c3cac49 100644
--- a/blog/apache-airflow-for-newcomers/index.html
+++ b/blog/apache-airflow-for-newcomers/index.html
@@ -37,14 +37,14 @@ Authoring Workflow in Apache Airflow. Airflow makes it easy 
to author workflows
 
 
 
-
+
 
 
 
 
 
-
+
 
 
 

[GitHub] [airflow] ac1997 commented on pull request #21351: Add and use supports_celery attribute for cli celery command validation

[GitBox]

ac1997 commented on pull request #21351:
URL: https://github.com/apache/airflow/pull/21351#issuecomment-1046082824


   My apologies, just noticed that my initial commit was done using company 
email address. Had to rebase/force push to use personal email.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] omoumniabdou commented on issue #10790: Copy of [AIRFLOW-5071] JIRA: Thousands of Executor reports task instance X finished (success) although the task says its queued. Was the task

[GitBox]

omoumniabdou commented on issue #10790:
URL: https://github.com/apache/airflow/issues/10790#issuecomment-1046086644


   The problem for us was that we had one dag that reach 32 parallelize 
runnable task ( 32 leaf tasks) which was the value of parameter `parallelism`. 
After this, the scheduler was not able to run (or queue) any task.
   Increasing this parameter solve the problem for us.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (AIRFLOW-5071) Thousand os Executor reports task instance X finished (success) although the task says its queued. Was the task killed externally?

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/AIRFLOW-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17495037#comment-17495037
 ] 

ASF GitHub Bot commented on AIRFLOW-5071:
-

omoumniabdou commented on issue #10790:
URL: https://github.com/apache/airflow/issues/10790#issuecomment-1046086644


   The problem for us was that we had one dag that reach 32 parallelize 
runnable task ( 32 leaf tasks) which was the value of parameter `parallelism`. 
After this, the scheduler was not able to run (or queue) any task.
   Increasing this parameter solve the problem for us.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Thousand os Executor reports task instance X finished (success) although the 
> task says its queued. Was the task killed externally?
> --
>
> Key: AIRFLOW-5071
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5071
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: DAG, scheduler
>Affects Versions: 1.10.3
>Reporter: msempere
>Priority: Critical
> Fix For: 1.10.12
>
> Attachments: image-2020-01-27-18-10-29-124.png, 
> image-2020-07-08-07-58-42-972.png
>
>
> I'm opening this issue because since I update to 1.10.3 I'm seeing thousands 
> of daily messages like the following in the logs:
>  
> ```
>  {{__init__.py:1580}} ERROR - Executor reports task instance  2019-07-29 00:00:00+00:00 [queued]> finished (success) although the task says 
> its queued. Was the task killed externally?
> {{jobs.py:1484}} ERROR - Executor reports task instance  2019-07-29 00:00:00+00:00 [queued]> finished (success) although the task says 
> its queued. Was the task killed externally?
> ```
> -And looks like this is triggering also thousand of daily emails because the 
> flag to send email in case of failure is set to True.-
> I have Airflow setup to use Celery and Redis as a backend queue service.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[GitHub] [airflow] mik-laj commented on a change in pull request #21688: Simplify check_cycle() implement

[GitBox]

mik-laj commented on a change in pull request #21688:
URL: https://github.com/apache/airflow/pull/21688#discussion_r810529468



##
File path: airflow/utils/dag_cycle_tester.py
##
@@ -49,33 +42,4 @@ def check_cycle(dag: 'DAG') -> None:
 
 :raises AirflowDagCycleException: If cycle is found in the DAG.
 """
-# default of int is 0 which corresponds to CYCLE_NEW
-visited: Dict[str, int] = defaultdict(int)
-path_stack: Deque[str] = deque()
-task_dict = dag.task_dict
-
-def _check_adjacent_tasks(task_id, current_task):
-"""Returns first untraversed child task, else None if all tasks 
traversed."""
-for adjacent_task in current_task.get_direct_relative_ids():
-if visited[adjacent_task] == CYCLE_IN_PROGRESS:
-msg = f"Cycle detected in DAG. Faulty task: {task_id}"
-raise AirflowDagCycleException(msg)
-elif visited[adjacent_task] == CYCLE_NEW:
-return adjacent_task
-return None
-
-for dag_task_id in dag.task_dict.keys():
-if visited[dag_task_id] == CYCLE_DONE:
-continue
-path_stack.append(dag_task_id)
-while path_stack:
-current_task_id = path_stack[-1]
-if visited[current_task_id] == CYCLE_NEW:
-visited[current_task_id] = CYCLE_IN_PROGRESS
-task = task_dict[current_task_id]
-child_to_check = _check_adjacent_tasks(current_task_id, task)
-if not child_to_check:
-visited[current_task_id] = CYCLE_DONE
-path_stack.pop()
-else:
-path_stack.append(child_to_check)
+dag.topological_sort(include_subdag_tasks=False)

Review comment:
   Is the sort implementation recursive or not?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk opened a new pull request #21689: Convert our internal tools to use rich_click

[GitBox]

potiuk opened a new pull request #21689:
URL: https://github.com/apache/airflow/pull/21689


   Rich_click provides out-of-the-box beautifying of the click command
   line tools to provide 'rich' help output.
   
   This PR changes our internal tools (including the new Breeze2
   in-progress effort to use rich click to make our help nicer.
   
   
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #21689: Convert our internal tools to use rich_click

[GitBox]

potiuk commented on pull request #21689:
URL: https://github.com/apache/airflow/pull/21689#issuecomment-1046092585


   cc: @Bowrna @edithturn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #21689: Convert our internal tools to use rich_click

[GitBox]

potiuk commented on pull request #21689:
URL: https://github.com/apache/airflow/pull/21689#issuecomment-1046092675


   Some screenshots :) 
   
   https://user-images.githubusercontent.com/595491/154817014-4c13c9e1-ae0c-4cda-8442-37e3fc82428d.png";>
   https://user-images.githubusercontent.com/595491/154817018-69fd8ec4-4d27-40fb-8c89-636d07bc3f64.png";>
   https://user-images.githubusercontent.com/595491/154817020-7b6437b7-7901-4657-9c60-27b3f827841e.png";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #21689: Convert our internal tools to use rich_click

[GitBox]

potiuk commented on pull request #21689:
URL: https://github.com/apache/airflow/pull/21689#issuecomment-1046092878


   BTW. Should we convert Airflow to use click ? Seems more and more worth it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #21689: Convert our internal tools to use rich_click

[GitBox]

github-actions[bot] commented on pull request #21689:
URL: https://github.com/apache/airflow/pull/21689#issuecomment-1046096056


   The PR most likely needs to run full matrix of tests because it modifies 
parts of the core of Airflow. However, committers might decide to merge it 
quickly and take the risk. If they don't merge it quickly - please rebase it to 
the latest main at your convenience, or amend the last commit of the PR, and 
push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #21689: Convert our internal tools to use rich_click

[GitBox]

potiuk merged pull request #21689:
URL: https://github.com/apache/airflow/pull/21689


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[airflow] branch main updated (68da4d8 -> 066ba15)

[potiuk]

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git.


from 68da4d8  Update MySqlOperator example dag (#21434)
 add 066ba15  Convert our internal tools to use rich_click (#21689)

No new revisions were added by this update.

Summary of changes:
 dev/airflow-github| 2 +-
 dev/assign_cherry_picked_prs_with_milestone.py| 2 +-
 dev/breeze/setup.cfg  | 1 +
 dev/breeze/src/airflow_breeze/breeze.py   | 5 ++---
 dev/breeze/src/airflow_ci/freespace.py| 2 +-
 dev/check_files.py| 2 +-
 dev/prepare_release_issue.py  | 2 +-
 dev/provider_packages/prepare_provider_packages.py| 2 +-
 dev/requirements.txt  | 5 +++--
 dev/retag_docker_images.py| 2 +-
 dev/send_email.py | 2 +-
 dev/stats/calculate_statistics_provider_testing_issues.py | 2 +-
 docs/exts/operators_and_hooks_ref.py  | 2 +-
 setup.py  | 5 +++--
 tests/test_utils/perf/scheduler_dag_execution_timing.py   | 2 +-
 15 files changed, 20 insertions(+), 18 deletions(-)

[GitHub] [airflow] potiuk merged pull request #21685: Add extra information about time synchronization needed

[GitBox]

potiuk merged pull request #21685:
URL: https://github.com/apache/airflow/pull/21685


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[airflow] branch main updated: Add extra information about time synchronization needed (#21685)

[potiuk]

This is an automated email from the ASF dual-hosted git repository.

potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/main by this push:
 new d8ae7df  Add extra information about time synchronization needed 
(#21685)
d8ae7df is described below

commit d8ae7df08168fd3ab92ed0d917f9b5dd34d1354d
Author: Jarek Potiuk 
AuthorDate: Sat Feb 19 21:47:14 2022 +0100

Add extra information about time synchronization needed (#21685)

When you have several machines running Airflow and their time
is not synchronized, you might get very weird behaviour - some of
the log retrieval actions might randomly return "forbidden" error
because of expiring token. This is extremely difficult to
diagnose and figure out (some of our users spent days on
investigating that). Explicitly stating the requirement in the
forbidden error and whenever secret_key parameter is
mentioned, should help our users to diagnose it more easily
(and save maintainers from unnecessary questions and discussions
in Slack :))
---
 airflow/config_templates/config.yml   | 4 
 airflow/config_templates/default_airflow.cfg  | 4 
 airflow/utils/log/file_task_handler.py| 5 +++--
 docs/apache-airflow/configurations-ref.rst| 5 +
 docs/apache-airflow/howto/set-config.rst  | 5 +
 docs/apache-airflow/upgrading-from-1-10/index.rst | 5 +
 docs/helm-chart/production-guide.rst  | 5 +
 docs/spelling_wordlist.txt| 1 +
 8 files changed, 32 insertions(+), 2 deletions(-)

diff --git a/airflow/config_templates/config.yml 
b/airflow/config_templates/config.yml
index 63da2c2..0eb771e 100644
--- a/airflow/config_templates/config.yml
+++ b/airflow/config_templates/config.yml
@@ -1085,6 +1085,10 @@
 Secret key used to run your flask app. It should be as random as 
possible. However, when running
 more than 1 instances of webserver, make sure all of them use the same 
``secret_key`` otherwise
 one of them will error with "CSRF session token is missing".
+The webserver key is also used to authorize requests to Celery workers 
when logs are retrieved.
+The token generated using the secret key has a short expiry time 
though - make sure that time on
+ALL the machines that you run airflow components on is synchronized 
(for example using ntpd)
+otherwise you might get "forbidden" errors when the logs are accessed.
   version_added: ~
   type: string
   sensitive: true
diff --git a/airflow/config_templates/default_airflow.cfg 
b/airflow/config_templates/default_airflow.cfg
index 1b27d9b..6d69578 100644
--- a/airflow/config_templates/default_airflow.cfg
+++ b/airflow/config_templates/default_airflow.cfg
@@ -559,6 +559,10 @@ reload_on_plugin_change = False
 # Secret key used to run your flask app. It should be as random as possible. 
However, when running
 # more than 1 instances of webserver, make sure all of them use the same 
``secret_key`` otherwise
 # one of them will error with "CSRF session token is missing".
+# The webserver key is also used to authorize requests to Celery workers when 
logs are retrieved.
+# The token generated using the secret key has a short expiry time though - 
make sure that time on
+# ALL the machines that you run airflow components on is synchronized (for 
example using ntpd)
+# otherwise you might get "forbidden" errors when the logs are accessed.
 secret_key = {SECRET_KEY}
 
 # Number of workers to run the Gunicorn web server
diff --git a/airflow/utils/log/file_task_handler.py 
b/airflow/utils/log/file_task_handler.py
index 08755bb..e056199 100644
--- a/airflow/utils/log/file_task_handler.py
+++ b/airflow/utils/log/file_task_handler.py
@@ -207,8 +207,9 @@ class FileTaskHandler(logging.Handler):
 if response.status_code == 403:
 log += (
 "***  Please make sure that all your Airflow 
components (e.g. "
-"schedulers, webservers and workers) have"
-" the same 'secret_key' configured in 'webserver' 
section !\n***"
+"schedulers, webservers and workers) have "
+"the same 'secret_key' configured in 'webserver' 
section and "
+"time is synchronized on all your machines (for 
example with ntpd) !\n***"
 )
 log += (
 "*** See more at 
https://airflow.apache.org/docs/apache-airflow/";
diff --git a/docs/apache-airflow/configurations-ref.rst 
b/docs/apache-airflow/configurations-ref.rst
index 63c5c96..c77a33c 100644
--- a/docs/apache-airflow/configurations-ref.rst
+++ b/docs/apache-airflow/configurations-ref.rst
@@ -27,6 +27,11 @@ does not require all, some configurations need to be same 
otherwise t

[GitHub] [airflow] eladkal closed issue #12120: Old libraries in setup.py causing dependency resolution to pull old transitive constraints (3 years+)

[GitBox]

eladkal closed issue #12120:
URL: https://github.com/apache/airflow/issues/12120


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #12120: Old libraries in setup.py causing dependency resolution to pull old transitive constraints (3 years+)

[GitBox]

eladkal commented on issue #12120:
URL: https://github.com/apache/airflow/issues/12120#issuecomment-1046102122


   I agree with you Jarek and since the months passed without further comments 
I'm closing the issue.
   If needed lets open new issues with defined scope


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #9321: Add Signal Based Scheduling To Airflow

[GitBox]

eladkal commented on issue #9321:
URL: https://github.com/apache/airflow/issues/9321#issuecomment-1046103101


   I'm closing this issue as it already has a [draft 
AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-35+Add+Signal+Based+Scheduling+To+Airflow).
   There is a discussion thread in the mailing list about it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] eladkal closed issue #9321: Add Signal Based Scheduling To Airflow

[GitBox]

eladkal closed issue #9321:
URL: https://github.com/apache/airflow/issues/9321


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #16480: gitpodify Apache Airflow - online development workspace

[GitBox]

eladkal commented on issue #16480:
URL: https://github.com/apache/airflow/issues/16480#issuecomment-1046103769


   @j143 are you still working on this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] ashb commented on a change in pull request #21640: Change the default auth backend to session

[GitBox]

ashb commented on a change in pull request #21640:
URL: https://github.com/apache/airflow/pull/21640#discussion_r810538825



##
File path: chart/values.yaml
##
@@ -1384,7 +1384,7 @@ config:
 remote_logging: '{{- ternary "True" "False" .Values.elasticsearch.enabled 
}}'
   # Authentication backend used for the experimental API
   api:
-auth_backends: airflow.api.auth.backend.deny_all
+auth_backends: airflow.api.auth.backend.session

Review comment:
   Yeah, lets just remove this in the chart values entirely




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] eladkal commented on pull request #21685: Add extra information about time synchronization needed

[GitBox]

eladkal commented on pull request #21685:
URL: https://github.com/apache/airflow/pull/21685#issuecomment-1046106835


   For me documentation is not different that managing DWH. You need one source 
of truth otherwise more often people will consume wrong/non update information 
but I also agree with what you said. Duplication can sometimes be OK (for 
example in intro/quick guide <-> full extensive guide). Ideally we should have 
the ability to embed text snippets so the content is written only once and the 
reader doesn't have to click a link nor is even aware that the content is taken 
from somewhere else. Something to inspire to...
   
   > Actually - thanks @eladkal ! I was thinking for a while about a new idea 
for talk / blog post and your comment gave me fantastic idea. I am going to do 
it :)
   
   Waiting to read it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #12120: Old libraries in setup.py causing dependency resolution to pull old transitive constraints (3 years+)

[GitBox]

potiuk commented on issue #12120:
URL: https://github.com/apache/airflow/issues/12120#issuecomment-1046107075


   Actually - we already agreed, merged and achieved lazy consensus to try the 
approach that addresses that issue: 
   
   https://github.com/apache/airflow/pull/21356
   
   We removed upper limits from most of the libraries and only really left 
those that we know why we are limiting them and what is the condition to remove 
those, which allows us to periodicallly (at minor relase time) to review 
whether the reasons for limiting are gone . 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #12120: Old libraries in setup.py causing dependency resolution to pull old transitive constraints (3 years+)

[GitBox]

potiuk commented on issue #12120:
URL: https://github.com/apache/airflow/issues/12120#issuecomment-1046107496


   So it's more than 'month passed' :) . We actually implemented actions to 
address it :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #19949: Only update label when adopting to prevent new pods

[GitBox]

github-actions[bot] commented on pull request #19949:
URL: https://github.com/apache/airflow/pull/19949#issuecomment-1046128953


   This pull request has been automatically marked as stale because it has not 
had recent activity. It will be closed in 5 days if no further activity occurs. 
Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] jon-fearer commented on issue #21669: Status of testing of Apache Airflow 2.2.4rc1

[GitBox]

jon-fearer commented on issue #21669:
URL: https://github.com/apache/airflow/issues/21669#issuecomment-1046131215


   #20303 Looks good in the RC version


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] hubert-pietron commented on issue #18967: DbApiHook.test_connection() does not work with Oracle db

[GitBox]

hubert-pietron commented on issue #18967:
URL: https://github.com/apache/airflow/issues/18967#issuecomment-1046162817


   Hi, can i finish it @gbonazzoli ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] gbonazzoli commented on issue #18967: DbApiHook.test_connection() does not work with Oracle db

[GitBox]

gbonazzoli commented on issue #18967:
URL: https://github.com/apache/airflow/issues/18967#issuecomment-1046166350


   Yes, you are welcome, very welcome !!!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] changxiaoju commented on issue #13692: task failed with a null hostname

[GitBox]

changxiaoju commented on issue #13692:
URL: https://github.com/apache/airflow/issues/13692#issuecomment-1046167057


   happens on Airflow2.2.4rc1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] uranusjr commented on a change in pull request #21640: Change the default auth backend to session

[GitBox]

uranusjr commented on a change in pull request #21640:
URL: https://github.com/apache/airflow/pull/21640#discussion_r810577276



##
File path: airflow/configuration.py
##
@@ -350,10 +350,11 @@ def _using_old_value(self, old, current_value):
 return old.search(current_value) is not None
 
 def _update_env_var(self, section, name, new_value):
-# Make sure the env var option is removed, otherwise it
-# would be read and used instead of the value we set
 env_var = self._env_var_name(section, name)
-os.environ.pop(env_var, None)
+# If the config comes from environment, set it there so that any 
subprocesses keep the same override!
+if os.environ.get(env_var):

Review comment:
   ```suggestion
   if env_var in os.environ:
   ```
   
   This matters because it is possible to set an environment variable to an 
empty string.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] kurtqq commented on pull request #20656: Update base sensor operator to support XCOM return value

[GitBox]

kurtqq commented on pull request #20656:
URL: https://github.com/apache/airflow/pull/20656#issuecomment-1046174972


   that would be nice


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] kadai0308 commented on issue #21599: Explore the possibility of generic `SqlToGcsOperator`

[GitBox]

kadai0308 commented on issue #21599:
URL: https://github.com/apache/airflow/issues/21599#issuecomment-1046180277


   Hi eladkal, Can I take this one as my first issue? I already went through 
the PR [#20807](https://github.com/apache/airflow/pull/20807)
   and later I will check each implementation of XXXToGCSOperator to see is it 
possible to implement a generic `SqlToGCSOperator` to replace all of them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #21599: Explore the possibility of generic `SqlToGcsOperator`

[GitBox]

eladkal commented on issue #21599:
URL: https://github.com/apache/airflow/issues/21599#issuecomment-1046181651


   sure assigned to you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #21683: Remove all usages of days_ago from test suite

[GitBox]

eladkal commented on issue #21683:
URL: https://github.com/apache/airflow/issues/21683#issuecomment-1046183139


   @hubert-pietron sure, assigned to you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org