[GitHub] [airflow] swapz-z commented on issue #28289: Add AWS Neptune hook and operators
swapz-z commented on issue #28289: URL: https://github.com/apache/airflow/issues/28289#issuecomment-1368357895 Yes @eladkal. Will raise a PR this week -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a diff in pull request #28521: Update doc for API clients release policy
XD-DENG commented on code in PR #28521: URL: https://github.com/apache/airflow/pull/28521#discussion_r1059696134 ## README.md: ## @@ -259,8 +259,12 @@ packages: Chart to depend on minimal Airflow version. * **Airflow API clients**: SemVer MAJOR and MINOR versions follow MAJOR and MINOR versions of Airflow. The first MAJOR or MINOR X.Y.0 release of Airflow should always be followed by X.Y.0 release of - all clients. The clients then can release their own PATCH releases with bugfixes, - independently of Airflow PATCH releases. + all clients. An airflow PATCH X.Y.Z release can be followed by a PATCH release of API clients, only + if this PATCH is relevant to the clients. + The clients then can release their own PATCH releases with bugfixes, independently of Airflow PATCH releases. + As a consequence, each API clients will have its own PATCH version that may or may not be in sync with the Airflow Review Comment: ```suggestion As a consequence, each API client will have its own PATCH version that may or may not be in sync with the Airflow ``` nit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] robbiebusinessacc commented on pull request #28660: Very minor changes
robbiebusinessacc commented on PR #28660: URL: https://github.com/apache/airflow/pull/28660#issuecomment-1368317278 I believe pre-commit removed one ')' but I'm not entirely sure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on issue #25297: on_failure_callback is not called when task is terminated externally
github-actions[bot] commented on issue #25297: URL: https://github.com/apache/airflow/issues/25297#issuecomment-1368301607 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #26739: Added Istio support to KubernetesPodOperator
github-actions[bot] closed pull request #26739: Added Istio support to KubernetesPodOperator URL: https://github.com/apache/airflow/pull/26739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed issue #25297: on_failure_callback is not called when task is terminated externally
github-actions[bot] closed issue #25297: on_failure_callback is not called when task is terminated externally URL: https://github.com/apache/airflow/issues/25297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #27108: Create path for downloaded dbt artefact (#27107)
github-actions[bot] closed pull request #27108: Create path for downloaded dbt artefact (#27107) URL: https://github.com/apache/airflow/pull/27108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #27689: Add option to add arguments to PSRP hook and operator
github-actions[bot] commented on PR #27689: URL: https://github.com/apache/airflow/pull/27689#issuecomment-1368301536 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on issue #27589: Scheduler pods memory leak on airflow 2.3.2
github-actions[bot] commented on issue #27589: URL: https://github.com/apache/airflow/issues/27589#issuecomment-1368301547 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further activity occurs from the issue author. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #27480: fix flower_url_prefix
github-actions[bot] commented on PR #27480: URL: https://github.com/apache/airflow/pull/27480#issuecomment-1368301560 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #28580: Update Task Life Cycle Diagram to include flow for Deferred Operators
eladkal commented on issue #28580: URL: https://github.com/apache/airflow/issues/28580#issuecomment-1368284441 Probably best to also handle https://github.com/apache/airflow/issues/21071 on the way -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #28651: Prepare docs for Jan 2023 wave of Providers
eladkal commented on code in PR #28651: URL: https://github.com/apache/airflow/pull/28651#discussion_r1059677961 ## docs/apache-airflow-providers-ftp/index.rst: ## @@ -35,6 +35,12 @@ Content Operators +.. toctree:: +:hidden: +:caption: System tests + +System Tests <_api/tests/system/providers/ftp/index> + Review Comment: so something is odd with the automation as it should have not been removed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #28481: dagwarning, add retry to purge_inactive_dag_warnings
ephraimbuddy commented on code in PR #28481: URL: https://github.com/apache/airflow/pull/28481#discussion_r1059675857 ## tests/models/test_dagwarning.py: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +import unittest +from unittest.mock import MagicMock + +from sqlalchemy.exc import OperationalError + +from airflow.models.dagwarning import DagWarning + + +class TestDagWarning(unittest.TestCase): Review Comment: Check this: https://github.com/apache/airflow/blob/378c8faba19d21b29abfff1705a8e7624aeabdc4/tests/models/test_taskinstance.py#L507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] tnyz commented on pull request #28659: check jenkins result state
tnyz commented on PR #28659: URL: https://github.com/apache/airflow/pull/28659#issuecomment-1368268755 No, I think what was described in that ticket is about scheme instead of schema `scheme://user:password@host%2Flocation:1234/schema?__extra__=%7B%22my_val%22%3A+%5B%22list%22%2C+%22of%22%2C+%22values%22%5D%2` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28660: Very minor changes
boring-cyborg[bot] commented on PR #28660: URL: https://github.com/apache/airflow/pull/28660#issuecomment-1368268187 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst) Here are some useful points: - Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that. - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it. - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations. - Be patient and persistent. It might take some time to get a review or get the final approval from Committers. - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack. - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices). Apache Airflow is a community-driven project and together we are making it better 🚀. In case of doubts contact the developers at: Mailing List: d...@airflow.apache.org Slack: https://s.apache.org/airflow-slack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] robbiebusinessacc opened a new pull request, #28660: Very minor changes
robbiebusinessacc opened a new pull request, #28660:
URL: https://github.com/apache/airflow/pull/28660
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #23858: Main constraints for Airflow downgrade cncf.kubernetes provider to 3.1.2
potiuk commented on issue #23858: URL: https://github.com/apache/airflow/issues/23858#issuecomment-1368267862 Yeah. It was some strange issue with dependencies. Solved long time ago. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] potiuk closed issue #23858: Main constraints for Airflow downgrade cncf.kubernetes provider to 3.1.2
potiuk closed issue #23858: Main constraints for Airflow downgrade cncf.kubernetes provider to 3.1.2 URL: https://github.com/apache/airflow/issues/23858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #28651: Prepare docs for Jan 2023 wave of Providers
potiuk commented on code in PR #28651: URL: https://github.com/apache/airflow/pull/28651#discussion_r1059672879 ## docs/apache-airflow-providers-ftp/index.rst: ## @@ -35,6 +35,12 @@ Content Operators +.. toctree:: +:hidden: +:caption: System tests + +System Tests <_api/tests/system/providers/ftp/index> + Review Comment: Ok. I know the reason. https://github.com/apache/airflow/commit/39f501d4f4e87635c80d97bb599daf61096d23b8 added the TOC entry BUT in the section that is automatically generated and when you regenerated it, it was removed in your PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #28651: Prepare docs for Jan 2023 wave of Providers
potiuk commented on code in PR #28651: URL: https://github.com/apache/airflow/pull/28651#discussion_r1059671922 ## docs/apache-airflow-providers-ftp/index.rst: ## @@ -35,6 +35,12 @@ Content Operators +.. toctree:: +:hidden: +:caption: System tests + +System Tests <_api/tests/system/providers/ftp/index> + Review Comment: Found it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #28651: Prepare docs for Jan 2023 wave of Providers
potiuk commented on code in PR #28651: URL: https://github.com/apache/airflow/pull/28651#discussion_r1059671814 ## docs/apache-airflow-providers-ftp/index.rst: ## @@ -35,6 +35,12 @@ Content Operators +.. toctree:: +:hidden: +:caption: System tests + +System Tests <_api/tests/system/providers/ftp/index> + Review Comment: Do you happen to have a link to the job where it failed (it's green now)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #28659: check jenkins result state
eladkal commented on PR #28659: URL: https://github.com/apache/airflow/pull/28659#issuecomment-1368264493 Is this related to https://github.com/apache/airflow/issues/28465 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] tnyz opened a new pull request, #28659: check jenkins result state
tnyz opened a new pull request, #28659:
URL: https://github.com/apache/airflow/pull/28659
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #22253: Add SparkKubernetesOperator crd implementation
dstandish commented on PR #22253: URL: https://github.com/apache/airflow/pull/22253#issuecomment-1368259732 My apologies -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #23858: Main constraints for Airflow downgrade cncf.kubernetes provider to 3.1.2
eladkal commented on issue #23858: URL: https://github.com/apache/airflow/issues/23858#issuecomment-1368247151 @potiuk was this task completed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #11439: [QUARANTINE] test failing TestImpersonationWithCustomPythonPath.test_impersonation_custom
eladkal commented on issue #11439: URL: https://github.com/apache/airflow/issues/11439#issuecomment-1368243741 closed in favor of https://github.com/apache/airflow/issues/28658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal closed issue #11439: [QUARANTINE] test failing TestImpersonationWithCustomPythonPath.test_impersonation_custom
eladkal closed issue #11439: [QUARANTINE] test failing TestImpersonationWithCustomPythonPath.test_impersonation_custom URL: https://github.com/apache/airflow/issues/11439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #11932: [QUARANTINE] test_exception_propagation fails in TestCeleryExecutor on mysql 5.7
eladkal commented on issue #11932: URL: https://github.com/apache/airflow/issues/11932#issuecomment-1368243736 closed in favor of https://github.com/apache/airflow/issues/28658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal closed issue #11932: [QUARANTINE] test_exception_propagation fails in TestCeleryExecutor on mysql 5.7
eladkal closed issue #11932: [QUARANTINE] test_exception_propagation fails in TestCeleryExecutor on mysql 5.7 URL: https://github.com/apache/airflow/issues/11932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal closed issue #14937: [QUARANTINED] tests/cli/commands/test_task_command.py::TestLogsfromTaskRunCommand
eladkal closed issue #14937: [QUARANTINED] tests/cli/commands/test_task_command.py::TestLogsfromTaskRunCommand URL: https://github.com/apache/airflow/issues/14937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #14937: [QUARANTINED] tests/cli/commands/test_task_command.py::TestLogsfromTaskRunCommand
eladkal commented on issue #14937: URL: https://github.com/apache/airflow/issues/14937#issuecomment-1368243727 closed in favor of https://github.com/apache/airflow/issues/28658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal closed issue #17439: Quarantine TestLocalTaskJob.test_process_sigterm_works_with_retries
eladkal closed issue #17439: Quarantine TestLocalTaskJob.test_process_sigterm_works_with_retries URL: https://github.com/apache/airflow/issues/17439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #17439: Quarantine TestLocalTaskJob.test_process_sigterm_works_with_retries
eladkal commented on issue #17439: URL: https://github.com/apache/airflow/issues/17439#issuecomment-1368243719 closed in favor of https://github.com/apache/airflow/issues/28658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal closed issue #16168: [QUARANTINE] `test_send_tasks_to_celery_hang` hangs on self-hosted runners
eladkal closed issue #16168: [QUARANTINE] `test_send_tasks_to_celery_hang` hangs on self-hosted runners URL: https://github.com/apache/airflow/issues/16168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #16168: [QUARANTINE] `test_send_tasks_to_celery_hang` hangs on self-hosted runners
eladkal commented on issue #16168: URL: https://github.com/apache/airflow/issues/16168#issuecomment-1368243257 closing as test isn't marked as quarantined anymore -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal opened a new issue, #28658: Fix Quarantine tests
eladkal opened a new issue, #28658: URL: https://github.com/apache/airflow/issues/28658 ### Body We have several tests marked in the code base with `@pytest.mark.quarantined` It means that the tests are flaky and if fail in CI it does not fail the build. The goal is to fix the tests and make them stable. This task is to gather all of them under the same issue instead of dedicated issue per test. - [ ] [TestImpersonation](https://github.com/apache/airflow/blob/bfcae349b88fd959e32bfacd027a5be976fe2132/tests/core/test_impersonation_tests.py#L117) - [ ] [TestImpersonationWithCustomPythonPath](https://github.com/apache/airflow/blob/bfcae349b88fd959e32bfacd027a5be976fe2132/tests/core/test_impersonation_tests.py#L181) - [ ] [test_exception_propagation](https://github.com/apache/airflow/blob/4d0fd8ef6adc35f683c7561f05688a65fd7451f4/tests/executors/test_celery_executor.py#L103) - [ ] [test_localtaskjob_maintain_heart_rate](https://github.com/apache/airflow/blob/76f81cd4a7433b7eeddb863b2ae6ee59176cf816/tests/jobs/test_local_task_job.py#L402) - [ ] [test_exception_propagation](https://github.com/apache/airflow/blob/4d0fd8ef6adc35f683c7561f05688a65fd7451f4/tests/executors/test_celery_executor.py#L103) ### Committer - [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #27341: Move db check command to run inside task process.
eladkal commented on issue #27341: URL: https://github.com/apache/airflow/issues/27341#issuecomment-1368239643 @hterik are you working on this task? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal closed issue #16487: Expose ability to set blob metadata in GCSHook
eladkal closed issue #16487: Expose ability to set blob metadata in GCSHook URL: https://github.com/apache/airflow/issues/16487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #16487: Expose ability to set blob metadata in GCSHook
eladkal commented on issue #16487: URL: https://github.com/apache/airflow/issues/16487#issuecomment-1368232838 Thanks @shahar1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #28651: Prepare docs for Jan 2023 wave of Providers
eladkal commented on code in PR #28651: URL: https://github.com/apache/airflow/pull/28651#discussion_r1059654006 ## docs/apache-airflow-providers-ftp/index.rst: ## @@ -35,6 +35,12 @@ Content Operators +.. toctree:: +:hidden: +:caption: System tests + +System Tests <_api/tests/system/providers/ftp/index> + Review Comment: I'm not sure why the static tests fails on ``` Checking docs/apache-airflow-providers-ftp/index.rst The docs/apache-airflow-providers-ftp/index.rst does not contain System Tests TOC. Make sure to add those lines to docs/apache-airflow-providers-ftp/index.rst: .. toctree:: :hidden: :caption: System tests System Tests <_api/tests/system/providers/ftp/index> ``` In this PR. I would expect this to present failure on the PR that added the system tests for the provider https://github.com/apache/airflow/pull/26974? @potiuk is this expected? in any case this commit should solve the problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #28651: Prepare docs for Jan 2023 wave of Providers
eladkal commented on code in PR #28651: URL: https://github.com/apache/airflow/pull/28651#discussion_r1059654006 ## docs/apache-airflow-providers-ftp/index.rst: ## @@ -35,6 +35,12 @@ Content Operators +.. toctree:: +:hidden: +:caption: System tests + +System Tests <_api/tests/system/providers/ftp/index> + Review Comment: I'm not sure why the static tests fails on ``` Checking docs/apache-airflow-providers-ftp/index.rst The docs/apache-airflow-providers-ftp/index.rst does not contain System Tests TOC. Make sure to add those lines to docs/apache-airflow-providers-ftp/index.rst: .. toctree:: :hidden: :caption: System tests System Tests <_api/tests/system/providers/ftp/index> ``` In this PR. I would expect this to present failure on the PR that added the system tests for the provider https://github.com/apache/airflow/pull/26974? @potiuk is this expected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] hamedhsn commented on pull request #22253: Add SparkKubernetesOperator crd implementation
hamedhsn commented on PR #22253: URL: https://github.com/apache/airflow/pull/22253#issuecomment-1368225263 > Are you still going to work on it @hamedhsn ? @potiuk yes, it is in progress. I am waiting for @dstandish to review last changes and reply -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] stamixthereal commented on pull request #28619: Fix code readability, add docstrings to json_client
stamixthereal commented on PR #28619: URL: https://github.com/apache/airflow/pull/28619#issuecomment-1368204696 Will we have a chance to review that PR? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #28440: Propagate logs to stdout when in k8s executor pod
dstandish commented on PR #28440: URL: https://github.com/apache/airflow/pull/28440#issuecomment-1368185546 Ok @malthe i have simplified the code, if you would like to have another look: https://github.com/apache/airflow/blob/0ade033eaa9feb52aecbe12d1b91131a27a80b4b/airflow/cli/commands/task_command.py#L322-L326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
