[jira] [Created] (AIRFLOW-6650) Google Cloud Platform Connection key json documentation or code is wrong

2020-01-27 Thread Evgeniy Sokolov (Jira) 
Evgeniy Sokolov created AIRFLOW-6650:


 Summary: Google Cloud Platform Connection key json documentation 
or code is wrong
 Key: AIRFLOW-6650
 URL: https://issues.apache.org/jira/browse/AIRFLOW-6650
 Project: Apache Airflow
  Issue Type: Bug
  Components: gcp
Affects Versions: 1.10.7, 1.10.6, 1.10.5, 1.10.4
Reporter: Evgeniy Sokolov


According to the documentation: 

[https://airflow.readthedocs.io/en/stable/howto/connection/gcp.html] 

The name of the external configuration for Keyfile JSON is: 
 * {{extra__google_cloud_platform__key_dict}} - Keyfile JSON

Excluding the prefix ({{extra__google_cloud_platform__) the name of the 
variable is *key_dict*. 
}}
However, '*keyfile_dict*' is expected in the source code: 

[https://github.com/apache/airflow/blob/master/airflow/gcp/hooks/base.py]
{code:java}
146: keyfile_dict = self._get_field('keyfile_dict', None)  # type: 
Optional[str]{code}

[https://github.com/apache/airflow/blob/v1-10-stable/airflow/contrib/hooks/gcp_api_base_hook.py]
{code:java}
138: keyfile_dict = self._get_field('keyfile_dict', False){code}
 

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6650) Google Cloud Platform Connection key json documentation or code is wrong

2020-01-27 Thread Evgeniy Sokolov (Jira) 


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024434#comment-17024434
 ] 

Evgeniy Sokolov commented on AIRFLOW-6650:
--

Either documentation or the code should be fixed. 

I suppose that documentation is easier. 

> Google Cloud Platform Connection key json documentation or code is wrong
> 
>
> Key: AIRFLOW-6650
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6650
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: gcp
>Affects Versions: 1.10.4, 1.10.5, 1.10.6, 1.10.7
>Reporter: Evgeniy Sokolov
>Priority: Minor
>
> According to the documentation: 
> [https://airflow.readthedocs.io/en/stable/howto/connection/gcp.html] 
> The name of the external configuration for Keyfile JSON is: 
>  * {{extra__google_cloud_platform__key_dict}} - Keyfile JSON
> Excluding the prefix ({{extra__google_cloud_platform__) the name of the 
> variable is *key_dict*. 
> }}
> However, '*keyfile_dict*' is expected in the source code: 
> [https://github.com/apache/airflow/blob/master/airflow/gcp/hooks/base.py]
> {code:java}
> 146: keyfile_dict = self._get_field('keyfile_dict', None)  # type: 
> Optional[str]{code}
> [https://github.com/apache/airflow/blob/v1-10-stable/airflow/contrib/hooks/gcp_api_base_hook.py]
> {code:java}
> 138: keyfile_dict = self._get_field('keyfile_dict', False){code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (AIRFLOW-6650) Google Cloud Platform Connection key json documentation or code is wrong

2020-01-28 Thread Evgeniy Sokolov (Jira) 


[ 
https://issues.apache.org/jira/browse/AIRFLOW-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024933#comment-17024933
 ] 

Evgeniy Sokolov commented on AIRFLOW-6650:
--

[https://airflow.readthedocs.io/en/latest/howto/connection/gcp.html] 
You are right, it's fixed in the latest version. 

> Google Cloud Platform Connection key json documentation or code is wrong
> 
>
> Key: AIRFLOW-6650
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6650
> Project: Apache Airflow
>  Issue Type: Bug
>  Components: gcp
>Affects Versions: 1.10.4, 1.10.5, 1.10.6, 1.10.7
>Reporter: Evgeniy Sokolov
>Priority: Minor
>
> According to the documentation: 
> [https://airflow.readthedocs.io/en/stable/howto/connection/gcp.html] 
> The name of the external configuration for Keyfile JSON is: 
>  * {{extra__google_cloud_platform__key_dict}} - Keyfile JSON
> Excluding the prefix ({{extra__google_cloud_platform__) the name of the 
> variable is *key_dict*. 
> }}
> However, '*keyfile_dict*' is expected in the source code: 
> [https://github.com/apache/airflow/blob/master/airflow/gcp/hooks/base.py]
> {code:java}
> 146: keyfile_dict = self._get_field('keyfile_dict', None)  # type: 
> Optional[str]{code}
> [https://github.com/apache/airflow/blob/v1-10-stable/airflow/contrib/hooks/gcp_api_base_hook.py]
> {code:java}
> 138: keyfile_dict = self._get_field('keyfile_dict', False){code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)