[GitHub] [airflow] Acehaidrey commented on pull request #20733: Add Audit Log View to Dag View
Acehaidrey commented on pull request #20733: URL: https://github.com/apache/airflow/pull/20733#issuecomment-1037384199 Thank you so much! Glad can help and had a lot of help from Sam + Brent here. I'll start the discussion in the slack about the improvements discussed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on pull request #20733: Add Audit Log View to Dag View
Acehaidrey commented on pull request #20733: URL: https://github.com/apache/airflow/pull/20733#issuecomment-1037384199 Thank you so much! Glad can help and had a lot of help from Sam + Brent here. I'll start the discussion in the slack about the improvements discussed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on pull request #20733: Add Audit Log View to Dag View
Acehaidrey commented on pull request #20733: URL: https://github.com/apache/airflow/pull/20733#issuecomment-1037056388 Finally thank you @potiuk it is good :) Do I need to do anything else for this to be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on pull request #20733: Add Audit Log View to Dag View
Acehaidrey commented on pull request #20733: URL: https://github.com/apache/airflow/pull/20733#issuecomment-1033345864 thank you @potiuk ! Let me know if I can help too. Would be interested but need to learn about git actions a bit more to help here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on pull request #20733: Add Audit Log View to Dag View
Acehaidrey commented on pull request #20733: URL: https://github.com/apache/airflow/pull/20733#issuecomment-1032262412 I have tried everything I can to get the docker-compose quick start test to complete successfully. I see other PRs also failing similarly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on pull request #20733: Add Audit Log View to Dag View
Acehaidrey commented on pull request #20733: URL: https://github.com/apache/airflow/pull/20733#issuecomment-1029795390 Hey @SamWheating @bbovenzi I think this PR is officially complete for what it set out to complete. If you don't mind taking a look I fixed the tests/checks. I added new screenshot too. Next steps will be described in followup. Is slack or email best to do that conversation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on pull request #20733: Add Audit Log View to Dag View
Acehaidrey commented on pull request #20733: URL: https://github.com/apache/airflow/pull/20733#issuecomment-1023750321 > I was thinking, should we even have any of this in the config? I think a better UX would be to show all possible events on the page and allow a user to check/uncheck each as they wish. Therefore on the page, a user immediately knows which types of events they can see instead of having to look at the config. Hi @bbovenzi on this end, I see what you are alluding to. So for the audit log I actually do not have a good idea of how to incorporate that here. To add a new filter selection or check/uncheck records. Are you open to discussing this further as a downstream action item. I think we can iterate on that. I can work on it right after this one too, if can have some of your help planning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on pull request #20733: Add Audit Log View to Dag View
Acehaidrey commented on pull request #20733: URL: https://github.com/apache/airflow/pull/20733#issuecomment-1023748689 > I wonder if something like the `All Instances` button in the task instance modal can be added as well. The button would link to the audit log browse view with pre-applied filters for the dag / task. > >  Hey @wolfier ! Hope you're well! The case with this button. Right now the sentence links to the audit log view with the filters applied in the tags. I am wondering do you feel there should be multiple buttons here? Because if it is just the single All Instances button, I may say it doesn't seem so great to add just single button for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on pull request #20733: Add Audit Log View to Dag View
Acehaidrey commented on pull request #20733: URL: https://github.com/apache/airflow/pull/20733#issuecomment-1023747908 sorry all - I been dealing with more covid complications but now I am back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] Acehaidrey commented on pull request #20733: Add Audit Log View to Dag View
Acehaidrey commented on pull request #20733: URL: https://github.com/apache/airflow/pull/20733#issuecomment-1012831545 Thank you both for your review @SamWheating and @bbovenzi . Addressed the comments . Waiting on the build to run, testing to see and will reach out again after for a last review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
