[GitHub] [airflow] Acehaidrey commented on pull request #9472: Add drop_partition functionality for HiveMetastoreHook

2020-06-25 Thread GitBox 


Acehaidrey commented on pull request #9472:
URL: https://github.com/apache/airflow/pull/9472#issuecomment-649713645


   @vanka56 can you rebase and try the static tests again



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] Acehaidrey commented on pull request #9472: Add drop_partition functionality for HiveMetastoreHook

2020-06-27 Thread GitBox 


Acehaidrey commented on pull request #9472:
URL: https://github.com/apache/airflow/pull/9472#issuecomment-650518730


   @vanka56 loook at the error logs
   ```
   There were some pylint errors. Exiting
   
   
###
  EXITING 
/opt/airflow/scripts/ci/in_container/run_pylint_tests.sh WITH STATUS CODE 1
   
###
   * Module tests.providers.apache.hive.hooks.test_hive
   tests/providers/apache/hive/hooks/test_hive.py:561:0: C0301: Line too long 
(115/110) (line-too-long)
   tests/providers/apache/hive/hooks/test_hive.py:561:8: W1503: Redundant use 
of assertTrue with constant value True (redundant-unittest-assert)
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] Acehaidrey commented on pull request #9472: Add drop_partition functionality for HiveMetastoreHook

2020-06-28 Thread GitBox 


Acehaidrey commented on pull request #9472:
URL: https://github.com/apache/airflow/pull/9472#issuecomment-650947153


   @vanka56 ```airflow/providers/apache/hive/hooks/hive.py:789:30: W1202: Use 
lazy % formatting in logging functions (logging-format-interpolation)
   airflow/providers/apache/hive/hooks/hive.py:793:26: W1202: Use lazy % 
formatting in logging functions (logging-format-interpolation)
   ``` still



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] Acehaidrey commented on pull request #9472: Add drop_partition functionality for HiveMetastoreHook

2020-07-01 Thread GitBox 


Acehaidrey commented on pull request #9472:
URL: https://github.com/apache/airflow/pull/9472#issuecomment-652627140


   @vanka56 
   ```
   Trim Trailing 
Whitespace..Failed
   - hook id: trailing-whitespace
   - exit code: 1
   - files were modified by this hook
   ```
   can you fix that



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org