[GitHub] [airflow] Fokko commented on a change in pull request #7532: [AIRFLOW-XXXX] Fix outdated doc on settings.policy
Fokko commented on a change in pull request #7532: [AIRFLOW-] Fix outdated doc on settings.policy URL: https://github.com/apache/airflow/pull/7532#discussion_r383924936 ## File path: airflow/settings.py ## @@ -79,28 +79,26 @@ json = json -def policy(task_instance): +def policy(task): Review comment: Much better, sorry for the fuzz. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] Fokko commented on a change in pull request #7532: [AIRFLOW-XXXX] Fix outdated doc on settings.policy
Fokko commented on a change in pull request #7532: [AIRFLOW-] Fix outdated doc on settings.policy URL: https://github.com/apache/airflow/pull/7532#discussion_r383905306 ## File path: airflow/settings.py ## @@ -79,28 +79,26 @@ json = json -def policy(task_instance): +def policy(task): Review comment: I prefer 2, but if there is any chance of having cyclic dependencies we should just leave it out. The first one is a bit awkward. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] Fokko commented on a change in pull request #7532: [AIRFLOW-XXXX] Fix outdated doc on settings.policy
Fokko commented on a change in pull request #7532: [AIRFLOW-] Fix outdated doc on settings.policy URL: https://github.com/apache/airflow/pull/7532#discussion_r383895918 ## File path: airflow/settings.py ## @@ -79,28 +79,26 @@ json = json -def policy(task_instance): +def policy(task): Review comment: When the user copies the function, they'll also copy the annotation, makes the code more robust :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] Fokko commented on a change in pull request #7532: [AIRFLOW-XXXX] Fix outdated doc on settings.policy
Fokko commented on a change in pull request #7532: [AIRFLOW-] Fix outdated doc on settings.policy URL: https://github.com/apache/airflow/pull/7532#discussion_r383884871 ## File path: airflow/settings.py ## @@ -79,28 +79,26 @@ json = json -def policy(task_instance): +def policy(task): Review comment: Maybe add a type annotation here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
