[GitHub] [airflow] MaiHoangViet1809 commented on issue #27952: can not use output of task decorator as input for external_task_ids of ExternalTaskSensor

2022-12-09 Thread GitBox 


MaiHoangViet1809 commented on issue #27952:
URL: https://github.com/apache/airflow/issues/27952#issuecomment-1344420984

   the log from v2.5.0 is below:
   ```
   Broken DAG: [//airflow/dags/reproduce_error_for_27952.py] Traceback 
(most recent call last):
 File 
"//env3.10.5/lib/python3.10/site-packages/airflow/models/baseoperator.py",
 line 411, in apply_defaults
   result = func(self, **kwargs, default_args=default_args)
 File 
"//env3.10.5/lib/python3.10/site-packages/airflow/sensors/external_task.py",
 line 165, in __init__
   if external_task_ids and len(external_task_ids) > 
len(set(external_task_ids)):
   TypeError: object of type 'PlainXComArg' has no len()
   ```
   note: masked path with 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] MaiHoangViet1809 commented on issue #27952: can not use output of task decorator as input for external_task_ids of ExternalTaskSensor

2022-12-09 Thread GitBox 


MaiHoangViet1809 commented on issue #27952:
URL: https://github.com/apache/airflow/issues/27952#issuecomment-1344387121

   > But did you actually reproduce it ? @MaiHoangViet1809 ?
   > 
   > I belive the problem has been solved in the way that 
len(external_task_ids) will not raise the exception in the first place (this 
was the fix in #27251). Please double-check if you can reproduce it there and 
post logs in case it is not.
   
   oh, #27251 resolved another issues I reported before this, #27209.
   
   this one is still error in v2.5.0 after I upgraded airflow from 2.4.3 to 
2.5.0
   error log is the same with v2.4.3.
   
   I did try to move that 2 lines in "airflow/airflow/sensors/external_task.py" 
to the poke method of class and it work, but I am not sure which other line 
need to move so I fired this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] MaiHoangViet1809 commented on issue #27952: can not use output of task decorator as input for external_task_ids of ExternalTaskSensor

2022-12-09 Thread GitBox 


MaiHoangViet1809 commented on issue #27952:
URL: https://github.com/apache/airflow/issues/27952#issuecomment-1343983433

   > 
   
   yes, I've checked in source code of v2.5.0:
   
https://github.com/apache/airflow/blob/5fad8a4a450de8388e4488523670d5f10f4f35b1/airflow/sensors/external_task.py#L165-L166
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] MaiHoangViet1809 commented on issue #27952: can not use output of task decorator as input for external_task_ids of ExternalTaskSensor

2022-12-07 Thread GitBox 


MaiHoangViet1809 commented on issue #27952:
URL: https://github.com/apache/airflow/issues/27952#issuecomment-1341946866

   it was not fixed yet @potiuk, I believe the code still unchanged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org