[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function
Sonins commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-898763140 > @Sonins, congrats on your first commit! Thanks for the fix Thanks for your help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function
Sonins commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-898034985 Thanks for your suggest, @jedcunningham. Static-check failure is because of formatting problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function
Sonins commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-896918356 I think CI has an issue right now. All `Build image` phases are now pending, including other PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function
Sonins commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-896394743 I added simple username and password. Here's test result.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function
Sonins commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-895740341 > Yeah, we should change it to 9200. Cool. I think new issue for that will be necessary later. Or is there any necessary change for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function
Sonins commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-894885972 OK. I wrote new test coverage. Here's my local test result. with original template ``` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function
Sonins commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-894733668 OK. I misunderstood badly. I will commit new test function as soon as i finished. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] Sonins commented on pull request #17428: Fix elasticsearch-secret template port default function
Sonins commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-893932430 Thank you for your review @jedcunningham . I did the unit test using pytest in breeze environment, but I don't know how to attach the result to this PR in fancy style. So, I just paste the result of pytest. ``` = test session starts == platform linux -- Python 3.6.14, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 -- /usr/local/bin/python cachedir: .pytest_cache rootdir: /opt/airflow, configfile: pytest.ini plugins: requests-mock-1.9.3, flaky-3.7.0, timeouts-1.2.1, anyio-3.3.0, forked-1.3.0, httpx-0.12.0, instafail-0.4.2, cov-2.12.1, xdist-2.3.0, rerunfailures-9.1.1, celery-4.4.7 setup timeout: 0.0s, execution timeout: 0.0s, teardown timeout: 0.0s collected 400 items tests/test_airflow_common.py::AirflowCommon::test_annotations PASSED [ 0%] tests/test_airflow_common.py::AirflowCommon::test_dags_mount_0 PASSED[ 0%] tests/test_airflow_common.py::AirflowCommon::test_dags_mount_1 PASSED[ 0%] tests/test_airflow_common.py::AirflowCommon::test_dags_mount_2 PASSED[ 1%] tests/test_annotations.py::AnnotationsTest::test_service_account_annotations PASSED [ 1%] tests/test_basic_helm_chart.py::TestBaseChartTest::test_annotations_on_airflow_pods_in_deployment PASSED [ 1%] tests/test_basic_helm_chart.py::TestBaseChartTest::test_basic_deployment_without_default_users PASSED [ 1%] tests/test_basic_helm_chart.py::TestBaseChartTest::test_basic_deployments PASSED [ 2%] tests/test_basic_helm_chart.py::TestBaseChartTest::test_chart_is_consistent_with_official_airflow_image PASSED [ 2%] tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_dags_access_mode PASSED [ 2%] tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_0_airflow PASSED [ 2%] tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_1_pod_template PASSED [ 3%] tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_2_flower PASSED [ 3%] tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_3_statsd PASSED [ 3%] tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_4_redis PASSED [ 3%] tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_5_pgbouncer PASSED [ 4%] tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_6_pgbouncerExporter PASSED [ 4%] tests/test_basic_helm_chart.py::TestBaseChartTest::test_invalid_pull_policy_7_gitSync PASSED [ 4%] tests/test_basic_helm_chart.py::TestBaseChartTest::test_labels_are_valid PASSED [ 4%] tests/test_basic_helm_chart.py::TestBaseChartTest::test_network_policies_are_valid PASSED [ 5%] tests/test_basic_helm_chart.py::TestBaseChartTest::test_unsupported_executor PASSED [ 5%] tests/test_celery_kubernetes_executor.py::CeleryKubernetesExecutorTest::test_should_create_a_worker_deployment_with_the_celery_executor PASSED [ 5%] tests/test_celery_kubernetes_executor.py::CeleryKubernetesExecutorTest::test_should_create_a_worker_deployment_with_the_celery_kubernetes_executor PASSED [ 5%] tests/test_chart_quality.py::ChartQualityTest::test_values_validate_schema PASSED [ 6%] tests/test_cleanup_pods.py::CleanupPodsTest::test_should_change_image_when_set_airflow_image PASSED [ 6%] tests/test_cleanup_pods.py::CleanupPodsTest::test_should_create_cronjob_for_enabled_cleanup PASSED [ 6%] tests/test_cleanup_pods.py::CleanupPodsTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 6%] tests/test_configmap.py::ConfigmapTest::test_airflow_local_settings PASSED [ 7%] tests/test_configmap.py::ConfigmapTest::test_kerberos_config_available_with_celery_executor PASSED [ 7%] tests/test_configmap.py::ConfigmapTest::test_multiple_annotations PASSED [ 7%] tests/test_configmap.py::ConfigmapTest::test_no_airflow_local_settings_by_default PASSED [ 7%] tests/test_configmap.py::ConfigmapTest::test_single_annotation PASSED[ 8%] tests/test_create_user_job.py::CreateUserJobTest::test_should_create_valid_affinity_tolerations_and_node_selector PASSED [ 8%] tests/test_create_user_job.py::CreateUserJobTest::test_should_run_by_default PASSED [ 8%] tests/test_create_user_job.py::CreateUserJobTest::test_should_support_annotations PASSED [ 8%] tests/test_dags_persistent_volume_claim.py::DagsPersistentVolumeClaimTest::test_should_generate_a_document_if_persistence_is_enabled_and_not_using_an_existing_claim PASSED [ 9%] tests/test_dags_persistent_volume_claim.py::DagsPersistentVolumeClaimTest::test_should_not_generate_a_document_if_persistence_is_disabled PASSED [ 9%] tests/test_dags_persistent_volume_claim.py::DagsPersistentVolumeClaimTest::test_should_
