[GitHub] [airflow] Taragolis commented on a diff in pull request #28180: Add link for EMR Steps Sensor logs

2022-12-19 Thread GitBox 


Taragolis commented on code in PR #28180:
URL: https://github.com/apache/airflow/pull/28180#discussion_r1052679855


##
airflow/providers/amazon/aws/links/emr_logs.py:
##
@@ -0,0 +1,27 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+from airflow.providers.amazon.aws.links.base_aws import BASE_AWS_CONSOLE_LINK, 
BaseAwsLink
+
+
+class EmrLogsLink(BaseAwsLink):
+"""Helper class for constructing AWS EMR Logs Link"""
+
+name = "EMR Cluster Logs"
+key = "emr_logs"
+format_str = BASE_AWS_CONSOLE_LINK + 
"/s3/buckets/{log_uri}?region={region_name}={job_flow_id}/"

Review Comment:
   I thought one of link for Batch is actually to CloudWatch service.
   In theory it also could use into another Operators/Sensors.
   
   I also try to improve some communications with links but unfortunetly it 
still some local poc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] Taragolis commented on a diff in pull request #28180: Add link for EMR Steps Sensor logs

2022-12-15 Thread GitBox 


Taragolis commented on code in PR #28180:
URL: https://github.com/apache/airflow/pull/28180#discussion_r1050097931


##
airflow/providers/amazon/aws/links/emr_logs.py:
##
@@ -0,0 +1,27 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from __future__ import annotations
+
+from airflow.providers.amazon.aws.links.base_aws import BASE_AWS_CONSOLE_LINK, 
BaseAwsLink
+
+
+class EmrLogsLink(BaseAwsLink):
+"""Helper class for constructing AWS EMR Logs Link"""
+
+name = "EMR Cluster Logs"
+key = "emr_logs"
+format_str = BASE_AWS_CONSOLE_LINK + 
"/s3/buckets/{log_uri}?region={region_name}={job_flow_id}/"

Review Comment:
   One concern. I think better keep it into 
`airflow.providers.amazon.aws.links.emr` rather than 
`airflow.providers.amazon.aws.links.emr_links`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org