Taragolis commented on code in PR #28282:
URL: https://github.com/apache/airflow/pull/28282#discussion_r1046817833
##
airflow/providers/amazon/aws/operators/emr.py:
##
@@ -71,6 +71,9 @@ def __init__(
aws_conn_id: str = "aws_default",
steps: list[dict] | str | None = None,
wait_for_completion: bool = False,
+cancel_existing_steps: bool = True,
+steps_states: list[str],
Review Comment:
This parameter is mandatory right now, which also might broke someone
pipeline
##
airflow/providers/amazon/aws/operators/emr.py:
##
@@ -71,6 +71,9 @@ def __init__(
aws_conn_id: str = "aws_default",
steps: list[dict] | str | None = None,
wait_for_completion: bool = False,
+cancel_existing_steps: bool = True,
Review Comment:
Set default for `cancel_existing_steps` to True might broke someone pipeline.
```suggestion
cancel_existing_steps: bool = False,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
