[GitHub] [airflow] Taragolis commented on pull request #29144: rewrite invoke lamba operator tests

2023-01-25 Thread via GitHub


Taragolis commented on PR #29144:
URL: https://github.com/apache/airflow/pull/29144#issuecomment-1404142990

   I think more time spending for create Lambda environment. Potentially we 
could move this kind of tests which required a lot of time for execution to the 
[integration](https://github.com/apache/airflow/tree/main/tests/integration/providers)
 and run [`moto`](https://docs.getmoto.org/en/latest/docs/server_mode.html) 
(docker image) or [`localstack`](https://github.com/localstack/localstack) in 
separate container


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] Taragolis commented on pull request #29144: rewrite invoke lamba operator tests

2023-01-24 Thread via GitHub


Taragolis commented on PR #29144:
URL: https://github.com/apache/airflow/pull/29144#issuecomment-1402930439

   I don't know about removal `moto` in this test, because it is a good 
framework for testing something more close to AWS implementation. Basically it 
just wrapper around 
[botocore.stub.Stubber](https://botocore.amazonaws.com/v1/documentation/api/latest/reference/stubber.html)
 with some helpers.
   
   Side effect with mock you really need to sure that you didn't do any mistake 
with mocking otherwise you easily could pass something that regular AWS 
environment and botocore/boto won't allow


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org