[GitHub] [airflow] Taragolis commented on pull request #29761: Use waiters in ECS Operators instead of inner sensors

2023-03-02 Thread via GitHub 


Taragolis commented on PR #29761:
URL: https://github.com/apache/airflow/pull/29761#issuecomment-1451639773

   Yep locally it also checked forever `¯\_(ツ)_/¯`
   
   I guess it is combination of airflow serializer, templated fields and multi 
inheritance (which I add for enums)
   
   
![image](https://user-images.githubusercontent.com/3998685/222401603-280a2298-b0c5-4266-b624-df1ae5c702d6.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] Taragolis commented on pull request #29761: Use waiters in ECS Operators instead of inner sensors

2023-03-02 Thread via GitHub 


Taragolis commented on PR #29761:
URL: https://github.com/apache/airflow/pull/29761#issuecomment-1451513993

   > [ECS System 
test](https://github.com/apache/airflow/blob/main/tests/system/providers/amazon/aws/example_ecs.py)
 is failing after this merge, the 
[`await_cluster`](https://github.com/apache/airflow/blob/main/tests/system/providers/amazon/aws/example_ecs.py#L100)
 task (which calls 
[`EcsClusterStateSensor`](https://github.com/apache/airflow/blob/181a8252597e314e5675e2b9655cb44da412eeb2/airflow/providers/amazon/aws/sensors/ecs.py#L65))
 is timing out after logging `INFO airflow.task.operators:ecs.py:98 Cluster 
state: EcsClusterStates.ACTIVE, waiting for: EcsClusterStates.ACTIVE`. I'll try 
to take a look at it tomorrow
   
   And this a bit strange, because after this logger record, as I could see 
there is no external calls (to AWS) and only simple validation which should 
finished in a milliseconds


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org