[GitHub] [airflow] TeddyHartanto commented on issue #5308: [AIRFLOW-4549] skipped tasks should be ok for wait_for_downstream

2020-03-12 Thread GitBox 
TeddyHartanto commented on issue #5308: [AIRFLOW-4549] skipped tasks should be 
ok for wait_for_downstream
URL: https://github.com/apache/airflow/pull/5308#issuecomment-598518360
 
 
   @kaxil Sure. On it!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] TeddyHartanto commented on issue #5308: [AIRFLOW-4549] skipped tasks should be ok for wait_for_downstream

2020-02-06 Thread GitBox 
TeddyHartanto commented on issue #5308: [AIRFLOW-4549] skipped tasks should be 
ok for wait_for_downstream
URL: https://github.com/apache/airflow/pull/5308#issuecomment-583214567
 
 
   @kaxil the build is still failing. Do you mind taking a look at it? It's 
coming from `tests/models/test_dagrun.py`:
   ```from tests.executors.test_executor import TestExecutor```
   
   There's no package `tests.executors.test_executor` nor the class 
`TestExecutor`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] TeddyHartanto commented on issue #5308: [AIRFLOW-4549] skipped tasks should be ok for wait_for_downstream

2020-01-23 Thread GitBox 
TeddyHartanto commented on issue #5308: [AIRFLOW-4549] skipped tasks should be 
ok for wait_for_downstream
URL: https://github.com/apache/airflow/pull/5308#issuecomment-577974864
 
 
   @kaxil no objection too. Just the static checks failure as mentioned by 
@potiuk 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] TeddyHartanto commented on issue #5308: [AIRFLOW-4549] skipped tasks should be ok for wait_for_downstream

2020-01-20 Thread GitBox 
TeddyHartanto commented on issue #5308: [AIRFLOW-4549] skipped tasks should be 
ok for wait_for_downstream
URL: https://github.com/apache/airflow/pull/5308#issuecomment-576505675
 
 
   Hi, any update on this? This is desperately needed. It doesn't make sense 
that we regard `Status.SKIPPED` and `Status.SUCCESS` as "successful" state in 
the `depends_on_past` check, but for `wait_for_downstream`, only 
`Status.SUCCESS` is regarded as "successful" state. This needs a fix.
   
   And because it seems that @dima-asana has gone missing, should we start a 
new PR? I can help.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services