[GitHub] [airflow] amoghrajesh commented on pull request #28325: Adding an example dag for dynamic task mapping

2022-12-15 Thread GitBox


amoghrajesh commented on PR #28325:
URL: https://github.com/apache/airflow/pull/28325#issuecomment-1352855806

   @potiuk @uranusjr Finally we have a green build! Can you help in merging 
this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] amoghrajesh commented on pull request #28325: Adding an example dag for dynamic task mapping

2022-12-14 Thread GitBox


amoghrajesh commented on PR #28325:
URL: https://github.com/apache/airflow/pull/28325#issuecomment-1352574929

   @uranusjr looks like the previous build was "cancelled". Rebasing the PR 
again. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] amoghrajesh commented on pull request #28325: Adding an example dag for dynamic task mapping

2022-12-14 Thread GitBox


amoghrajesh commented on PR #28325:
URL: https://github.com/apache/airflow/pull/28325#issuecomment-1351261078

   Haha okay @uranusjr 
   We will have to wait on merging this PR i guess then? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] amoghrajesh commented on pull request #28325: Adding an example dag for dynamic task mapping

2022-12-14 Thread GitBox


amoghrajesh commented on PR #28325:
URL: https://github.com/apache/airflow/pull/28325#issuecomment-1350685933

   Thanks for the pointers @potiuk 
   Trying a rebase. If it does not fix it, I will try running it locally and 
fixing it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] amoghrajesh commented on pull request #28325: Adding an example dag for dynamic task mapping

2022-12-13 Thread GitBox


amoghrajesh commented on PR #28325:
URL: https://github.com/apache/airflow/pull/28325#issuecomment-1350508583

   @potiuk @uranusjr The UTs are failing in the `validate_deserialized_task`, I 
am not sure how to debug it. Can someone guide me here? 
https://github.com/apache/airflow/actions/runs/3692197454/jobs/6251170704


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] amoghrajesh commented on pull request #28325: Adding an example dag for dynamic task mapping

2022-12-13 Thread GitBox


amoghrajesh commented on PR #28325:
URL: https://github.com/apache/airflow/pull/28325#issuecomment-1350435244

   @potiuk @uranusjr I am running into this doc build error:
   ```
   ## Start docs build errors summary 
##
   
   == apache-airflow ==
   -- Error   1 
ERROR: Unexpected indentation.
   
   File path: apache-airflow/concepts/dynamic-task-mapping.rst (35)
   
 30 | 
 31 | In its simplest form you can map over a list defined directly in your 
DAG file using the ``expand()`` function instead of calling your task directly.
 32 | 
 33 | If you want to see a simple usage of Dynamic Task Mapping, you can 
look below:
 34 | .. exampleinclude:: 
/../../airflow/example_dags/example_dynamic_task_mapping.py
   > 35 | :language: python
 36 | :dedent: 4
 37 | 
 38 | This will show ``Total was 9`` in the task logs when executed.
 39 | 
 40 | This is the resulting DAG structure:
   
   ```
   
   I am not really able to figure out whats wrong here. The indent looks about 
right to me. Can i get some hint?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] amoghrajesh commented on pull request #28325: Adding an example dag for dynamic task mapping

2022-12-13 Thread GitBox


amoghrajesh commented on PR #28325:
URL: https://github.com/apache/airflow/pull/28325#issuecomment-1348812558

   @uranusjr the build seems to fail. I need some guidance on what's failing 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] amoghrajesh commented on pull request #28325: Adding an example dag for dynamic task mapping

2022-12-13 Thread GitBox


amoghrajesh commented on PR #28325:
URL: https://github.com/apache/airflow/pull/28325#issuecomment-1348102663

   @uranusjr working on fixing the build failures. Might need some help around 
it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org