[GitHub] [airflow] ashb commented on a change in pull request #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name

2019-09-24 Thread GitBox 
ashb commented on a change in pull request #5879: [AIRFLOW-5280] conn: Remove 
aws_default's default region name
URL: https://github.com/apache/airflow/pull/5879#discussion_r327647300
 
 

 ##
 File path: UPDATING.md
 ##
 @@ -39,28 +39,36 @@ assists users migrating to a new version.
 
 ## Airflow Master
 
+### Changes to `aws_default` Connection's default region
+
+The region of Airflow's default connection to AWS (`aws_default`) has
+previously been set to `us-east-1` during installation.
+
+The region now needs to be set manually either in the connection screens in
+Airflow, or via the `AWS_DEFAULT_REGION` environment variable.
+
 ### Changes to FileSensor
 FileSensor is now takes a glob pattern, not just a filename. If the filename 
you are looking for has `*`, `?`, or `[` in it then you should replace these 
with `[*]`, `[?]`, and `[[]`.
 
 ### Change dag loading duration metric name
-Change DAG file loading duration metric from 
 
 Review comment:
   These changes still are here - can you remove them please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name

2019-09-17 Thread GitBox 
ashb commented on a change in pull request #5879: [AIRFLOW-5280] conn: Remove 
aws_default's default region name
URL: https://github.com/apache/airflow/pull/5879#discussion_r325112886
 
 

 ##
 File path: scripts/ci/in_container/entrypoint_ci.sh
 ##
 @@ -121,6 +121,10 @@ export 
PYTHONPATH=${PYTHONPATH:-${AIRFLOW_SOURCES}/tests/test_utils}
 export PATH=${PATH}:${AIRFLOW_SOURCES}
 
 export AIRFLOW__CORE__UNIT_TEST_MODE=True
+export HADOOP_DISTRO
 
 Review comment:
   Unrelated/old change?
   ```suggestion
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name

2019-09-17 Thread GitBox 
ashb commented on a change in pull request #5879: [AIRFLOW-5280] conn: Remove 
aws_default's default region name
URL: https://github.com/apache/airflow/pull/5879#discussion_r325112605
 
 

 ##
 File path: UPDATING.md
 ##
 @@ -39,28 +39,36 @@ assists users migrating to a new version.
 
 ## Airflow Master
 
+### Changes to `aws_default` Connection's default region
+
+The region of Airflow's default connection to AWS (`aws_default`) has
+previously been set to `us-east-1` during installation.
+
+The region now needs to be set manually either in the connection screens in
+Airflow, or via the `AWS_DEFAULT_REGION` environment variable.
+
 ### Changes to FileSensor
 FileSensor is now takes a glob pattern, not just a filename. If the filename 
you are looking for has `*`, `?`, or `[` in it then you should replace these 
with `[*]`, `[?]`, and `[[]`.
 
 ### Change dag loading duration metric name
-Change DAG file loading duration metric from 
 
 Review comment:
   Could you avoid making white-space only changes to the rest of this file? 
(This will make this change harder to cherry-pick back to the release branch)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #5879: [AIRFLOW-5280] conn: Remove aws_default's default region name

2019-09-03 Thread GitBox 
ashb commented on a change in pull request #5879: [AIRFLOW-5280] conn: Remove 
aws_default's default region name
URL: https://github.com/apache/airflow/pull/5879#discussion_r320338999
 
 

 ##
 File path: docs/howto/connection/aws.rst
 ##
 @@ -35,6 +35,8 @@ Default Connection IDs
 
 The default connection ID is ``aws_default``.
 
+.. note:: Previously, the ``aws_default`` connection had the "extras" field 
set to ``{"region_name": "us-east-1"}`` on install. This means that by default 
the ``aws_default`` connection used the ``us-east-1`` region. This is no longer 
the case and the region needs to be set manually.
 
 Review comment:
   ```suggestion
   .. note:: Previously, the ``aws_default`` connection had the "extras" field 
set to ``{"region_name": "us-east-1"}`` on install. This means that by default 
the ``aws_default`` connection used the ``us-east-1`` region. This is no longer 
the case and the region needs to be set manually, either in the connection 
screens in Airflow, or via the ``AWS_DEFAULT_REGION`` environment variable.
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services