[GitHub] [airflow] ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module
ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module URL: https://github.com/apache/airflow/pull/6938#issuecomment-591098934 https://github.com/apache/airflow/pull/7538 will I think solve my issue/brain fart. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module
ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module URL: https://github.com/apache/airflow/pull/6938#issuecomment-591096260 It's probably fine as it is. Def not worth changing all the files again anyway. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module
ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module URL: https://github.com/apache/airflow/pull/6938#issuecomment-591091381 :man_facepalming: oh yeah. Sorry, long day. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module
ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module URL: https://github.com/apache/airflow/pull/6938#issuecomment-591084955 (excuse the grump, but this change, and the pre commit rule we put in place meant I had to work around it have code live in the repo but work on master and in 1.10.) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module
ashb commented on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module URL: https://github.com/apache/airflow/pull/6938#issuecomment-591081255 Why did we make this change? Neither the PR nor the linked Jira give _any_ justification for the change. It doesn't reduce any imports, and personally, I found the previous name _clearer_. Now seeing that code for the first time my question would be "what is it session?" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
