[GitHub] [airflow] ashb edited a comment on issue #4335: [AIRFLOW-3458] Move models.Connection into separate file
ashb edited a comment on issue #4335: [AIRFLOW-3458] Move models.Connection
into separate file
URL: https://github.com/apache/airflow/pull/4335#issuecomment-474851078
@BasPH @Fokko I'd like to cherry-pick this in to 1.10.3, but do do that we
need a deprecation shim.
I can do this with a few lines at the _end_ of models/__init__.py:
```python
# To avoid circular import on Python2.7 we need to define this at the
_bottom_
from zope.deprecation import deprecated
from airflow.models.connection import Connection # noqa
deprecated('Connection', 'has been moved to airflow.models.connection
package. Please update your code before Airflow 2.0')
```
Are you happy for me to "just" do that on the release branch?
Trying that
https://github.com/ashb/airflow/commit/f6d200876c9ab41aa68e8d51bb1e56aa38720393
- tests running https://travis-ci.org/ashb/airflow/builds/509059430
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb edited a comment on issue #4335: [AIRFLOW-3458] Move models.Connection into separate file
ashb edited a comment on issue #4335: [AIRFLOW-3458] Move models.Connection
into separate file
URL: https://github.com/apache/airflow/pull/4335#issuecomment-474851078
@BasPH @Fokko I'd like to cherry-pick this in to 1.10.3, but do do that we
need a deprecation shim.
I can do this with a few lines at the _end_ of models/__init__.py:
```python
# To avoid circular import on Python2.7 we need to define this at the
_bottom_
from zope.deprecation import deprecated
from airflow.models.connection import Connection # noqa
deprecated('Connection', 'has been moved to airflow.models.connection
package. Please update your code before Airflow 2.0')
```
Are you happy for me to "just" do that on the release branch?
Trying that
https://github.com/ashb/airflow/commit/ae414097f46b9c4eef5e41907112b328fb13203d
- tests running https://travis-ci.org/ashb/airflow/builds/508974769
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
