[GitHub] [airflow] blag commented on pull request #21167: Add a session backend to store session data in the database

2022-02-07 Thread GitBox 


blag commented on pull request #21167:
URL: https://github.com/apache/airflow/pull/21167#issuecomment-1031870760


   @dstandish That's a good call, but it's looking less and less likely that 
our changes are going to be palatable to the maintainer of Flask-Session. If 
the changes we need won't ever be merged into Flask-Session, then our modified 
vendored code just becomes...our code, with an additional copyright line/header.
   
   A "middle path" of this would be to start maintaining our own fork of 
Flask-Session, merge in the changes that we need, maybe merge in a few more 
unmerged PRs from Flask-Session, and have our fork become the friendlier (than 
Flask-Session) session package for Flask. But I don't want to sign the company 
up for that responsibility without some consensus and blessing, and I don't 
really want to maintain my own personal fork of Flask-Session specifically for 
Airflow.
   
   I'm happy to do whatever it takes to get this merged, but I will need some 
guidance on how to get there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] blag commented on pull request #21167: Add a session backend to store session data in the database

2022-02-01 Thread GitBox 


blag commented on pull request #21167:
URL: https://github.com/apache/airflow/pull/21167#issuecomment-1027637286


   @jedcunningham Some of the code your wanted changes to is the vendored in 
code. I intentionally made as minimal modifications to that code as I needed, 
with the intent to possibly make a PR to upstream Flask-Session, get that 
merged, and migrate to using that (and removing our vendored code). The more 
and more in-depth modifications we make to the vendored code, the more 
difficult it will be to switch in the future.
   
   I'm happy to make the changes you noted if you'd still like me to (please 
let me know), I just wanted to bring that to your attention first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org