[GitHub] [airflow] christophlingg commented on a change in pull request #9535: boolean values in environment variables
christophlingg commented on a change in pull request #9535: URL: https://github.com/apache/airflow/pull/9535#discussion_r446802187 ## File path: docs/howto/set-config.rst ## @@ -37,6 +37,12 @@ or by creating a corresponding environment variable: .. code-block:: bash export AIRFLOW__CORE__SQL_ALCHEMY_CONN=my_conn_string + +For setting boolean configuration values use ``true``/``false``: + +.. code-block:: bask + +export AIRFLOW__CORE__REMOTE_LOGGING=true Review comment: thanks @kaxil for getting into that. When I set the environmental variables I was not aware that airflow parses booleans that gracefully and supports many variants (`1`, `TRUE`, `true`, `t`, `True`, ...). One could avoid concerns by giving an example in the documentation, like I did above. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] christophlingg commented on a change in pull request #9535: boolean values in environment variables
christophlingg commented on a change in pull request #9535: URL: https://github.com/apache/airflow/pull/9535#discussion_r448213603 ## File path: docs/howto/set-config.rst ## @@ -37,6 +37,12 @@ or by creating a corresponding environment variable: .. code-block:: bash export AIRFLOW__CORE__SQL_ALCHEMY_CONN=my_conn_string + +For setting boolean configuration values use ``true``/``false``: + +.. code-block:: bask + +export AIRFLOW__CORE__REMOTE_LOGGING=true Review comment: Maybe I was thinking too much like a software developer here. And as the parsing is so clever, people won't have issues. I will close the PR, thanks for your feedback. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
