[GitHub] [airflow] ddelange commented on issue #6523: [AIRFLOW-5873] KubernetesPodOperator fixes and test
ddelange commented on issue #6523: [AIRFLOW-5873] KubernetesPodOperator fixes and test URL: https://github.com/apache/airflow/pull/6523#issuecomment-552190688 On my local machine I get the same error as Travis, so I added `origin/` to the command. ```sh $ git diff --name-only v1-10-test...HEAD fatal: ambiguous argument 'v1-10-test...HEAD': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git [...] -- [...]' $ git diff --name-only origin/v1-10-test...HEAD .pre-commit-config.yaml .travis.yml BREEZE.rst Dockerfile Dockerfile-checklicence airflow/contrib/kubernetes/pod.py airflow/contrib/operators/kubernetes_pod_operator.py airflow/models/baseoperator.py airflow/utils/helpers.py breeze common/_files_for_rebuild_check.sh docs/howto/custom-operator.rst hooks/build scripts/ci/_utils.sh scripts/ci/ci_check_license.sh scripts/ci/ci_docs.sh scripts/ci/ci_flake8.sh scripts/ci/ci_mypy.sh scripts/ci/ci_refresh_pylint_todo.sh scripts/ci/ci_run_all_static_tests.sh scripts/ci/ci_run_all_static_tests_except_licence.sh scripts/ci/docker-compose.yml scripts/ci/docker_build/ci_build_install_deps.sh scripts/ci/in_container/entrypoint_ci.sh scripts/ci/local_ci_build_ci_slim_image.sh scripts/ci/local_ci_cleanup.sh scripts/ci/pre_commit_check_license.sh scripts/ci/pre_commit_ci_build.sh scripts/ci/pre_commit_flake8.sh scripts/ci/pre_commit_lint_dockerfile.sh scripts/ci/pre_commit_mypy.sh scripts/ci/pre_commit_pylint_main.sh scripts/ci/pre_commit_pylint_tests.sh tests/contrib/operators/test_kubernetes_pod_operator.py tests/test_impersonation.py``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ddelange commented on issue #6523: [AIRFLOW-5873] KubernetesPodOperator fixes and test
ddelange commented on issue #6523: [AIRFLOW-5873] KubernetesPodOperator fixes and test URL: https://github.com/apache/airflow/pull/6523#issuecomment-551809654 Opened up #6524 @potiuk :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ddelange commented on issue #6523: [AIRFLOW-5873] KubernetesPodOperator fixes and test
ddelange commented on issue #6523: [AIRFLOW-5873] KubernetesPodOperator fixes and test URL: https://github.com/apache/airflow/pull/6523#issuecomment-551736922 Hi @potiuk, thanks for the swift reply. I can open a new PR based on master, but master is too different from this branch to test my v1.10 setup with these changes on our cluster (e.g. my pods won't even start because https://github.com/apache/airflow/blob/v1-10-test/airflow/models/user.py doesn't exist anymore in master) [?] To me it seems they have already diverged (master `__version__` is v2.0 after all) and I'm not sure how those cherry picks would turn out. E.g. I also added a fix (base_operator `**resources`) in this PR which is already on `master`, but should definitely be in v1.10.7 I could alternatively make two PR's, one main one based on `master` and merged separately, and make this PR a patch that keeps changes to a minimum (with compatibility in mind). Please advise :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] ddelange commented on issue #6523: [AIRFLOW-5873] KubernetesPodOperator fixes and test
ddelange commented on issue #6523: [AIRFLOW-5873] KubernetesPodOperator fixes and test URL: https://github.com/apache/airflow/pull/6523#issuecomment-551694985 @ashb how should I cherry pick the relevant changes made to kubernetes in `master` onto `v1-10-test`? how/where is your branch structure documented (flow to pick commits for releases etc)? cc https://github.com/apache/airflow/pull/6506#issuecomment-550051457 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
