[GitHub] [airflow] dimberman commented on a change in pull request #8904: Move k8s files out of contrib
dimberman commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427588906
##
File path: airflow/contrib/operators/file_to_wasb.py
##
@@ -57,8 +57,8 @@ def execute(self, context):
"""Upload a file to Azure Blob Storage."""
hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
self.log.info(
-'Uploading %s to wasb://%s '
-'as %s'.format(self.file_path, self.container_name, self.blob_name)
+'Uploading {} to wasb://{} '
+'as {}'.format(self.file_path, self.container_name, self.blob_name)
Review comment:
@ashb If possible I'd like to avoid making changes unrelated to the
commit on this PR (especially since it's going straight to 1-10). Should we
make a separate PR for fixing these logs/flake8 tests?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [airflow] dimberman commented on a change in pull request #8904: Move k8s files out of contrib
dimberman commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427588906
##
File path: airflow/contrib/operators/file_to_wasb.py
##
@@ -57,8 +57,8 @@ def execute(self, context):
"""Upload a file to Azure Blob Storage."""
hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
self.log.info(
-'Uploading %s to wasb://%s '
-'as %s'.format(self.file_path, self.container_name, self.blob_name)
+'Uploading {} to wasb://{} '
+'as {}'.format(self.file_path, self.container_name, self.blob_name)
Review comment:
@ashb If possible I'd like to avoid making changes unrelated to the
commit on this PR (especially since it's going straight to 1-10). Should we
make a separate PR for fixing these logs?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [airflow] dimberman commented on a change in pull request #8904: Move k8s files out of contrib
dimberman commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427555106
##
File path: airflow/contrib/operators/file_to_wasb.py
##
@@ -57,8 +57,8 @@ def execute(self, context):
"""Upload a file to Azure Blob Storage."""
hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
self.log.info(
-'Uploading %s to wasb://%s '
-'as %s'.format(self.file_path, self.container_name, self.blob_name)
+'Uploading {} to wasb://{} '
+'as {}'.format(self.file_path, self.container_name, self.blob_name)
Review comment:
@kaxil fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [airflow] dimberman commented on a change in pull request #8904: Move k8s files out of contrib
dimberman commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427490782
##
File path: airflow/contrib/operators/file_to_wasb.py
##
@@ -57,8 +57,8 @@ def execute(self, context):
"""Upload a file to Azure Blob Storage."""
hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
self.log.info(
-'Uploading %s to wasb://%s '
-'as %s'.format(self.file_path, self.container_name, self.blob_name)
+'Uploading {} to wasb://{} '
+'as {}'.format(self.file_path, self.container_name, self.blob_name)
Review comment:
also if you're running .format on the string before it's even parsed
does it even matter?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [airflow] dimberman commented on a change in pull request #8904: Move k8s files out of contrib
dimberman commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427490378
##
File path: airflow/contrib/operators/file_to_wasb.py
##
@@ -57,8 +57,8 @@ def execute(self, context):
"""Upload a file to Azure Blob Storage."""
hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
self.log.info(
-'Uploading %s to wasb://%s '
-'as %s'.format(self.file_path, self.container_name, self.blob_name)
+'Uploading {} to wasb://{} '
+'as {}'.format(self.file_path, self.container_name, self.blob_name)
Review comment:
@kaxil any thoughts on what to do here? change them or set ignore flags?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [airflow] dimberman commented on a change in pull request #8904: Move k8s files out of contrib
dimberman commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427481728
##
File path: airflow/contrib/operators/file_to_wasb.py
##
@@ -57,8 +57,8 @@ def execute(self, context):
"""Upload a file to Azure Blob Storage."""
hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
self.log.info(
-'Uploading %s to wasb://%s '
-'as %s'.format(self.file_path, self.container_name, self.blob_name)
+'Uploading {} to wasb://{} '
+'as {}'.format(self.file_path, self.container_name, self.blob_name)
Review comment:
Yes. This was because of flake8 errors.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [airflow] dimberman commented on a change in pull request #8904: Move k8s files out of contrib
dimberman commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r426895969
##
File path: .github/workflows/ci.yml
##
@@ -123,7 +123,7 @@ jobs:
run: ./scripts/ci/ci_free_space_on_ci.sh
- name: "Build CI image ${{ matrix.python-version }}"
run: ./scripts/ci/ci_prepare_image_on_ci.sh
- - name: "Tests"
+ - ame: "Tests"
Review comment:
and it's only Monday lol
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
