[GitHub] [airflow] ephraimbuddy commented on pull request #27829: Improving the release process
ephraimbuddy commented on PR #27829: URL: https://github.com/apache/airflow/pull/27829#issuecomment-1400675244 > Feel free to merge if you think it's GOOD and useful :). Been thinking about the useful side of it :) let @jedcunningham decide -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #27829: Improving the release process
ephraimbuddy commented on PR #27829: URL: https://github.com/apache/airflow/pull/27829#issuecomment-1400284160 Previously, some of the commands used to check out branches were being executed in the CI. However, because this change was not in the checked-out branch, the codes could not be found and the process failed. To resolve this issue, the solution was to run the branch check-out commands in dry-run mode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #27829: Improving the release process
ephraimbuddy commented on PR #27829: URL: https://github.com/apache/airflow/pull/27829#issuecomment-1399875924 > I think you might wan to re-install breeze (via the composite action we use elsewhere) just before "Fix ownership" job. This should fix the last problem @ephraimbuddy Re-installing breeze didn't work. I will come back to debug it again, I believe it's from what now runs within the code in the CI unlike before when I skipped them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #27829: Improving the release process
ephraimbuddy commented on PR #27829: URL: https://github.com/apache/airflow/pull/27829#issuecomment-1386921743 > Please fix those - and if it still does not help - I might take a closer look. On it. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #27829: Improving the release process
ephraimbuddy commented on PR #27829: URL: https://github.com/apache/airflow/pull/27829#issuecomment-1386750234 Hi @potiuk, It seems like there's something wrong with the breeze build on this PR. For example, here: https://github.com/apache/airflow/actions/runs/3947115412/jobs/6755756155#step:8:33 it's saying that the command does not exist. Also, I have been having issues with post-breeze step -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #27829: Improving the release process
ephraimbuddy commented on PR #27829: URL: https://github.com/apache/airflow/pull/27829#issuecomment-1346094951 > Which pre-commit ? This does not seem like it is run in image (it would be /opt/airflow path then). Each pre-commit has their own dependencies and you need to make sure they are installed when they are run - they heave their dependencies declrated in .pre-commit-config.yml file.. ``` Update output of breeze commands in BREEZE.rst.Failed - hook id: update-breeze-cmd-output - exit code: 1 OK. The setup_autocomplete screenshot is embedded in BREEZE.rst. OK. The testing_helm-tests screenshot is embedded in BREEZE.rst. OK. The release-management_generate-constraints screenshot is embedded in BREEZE.rst. OK. The static-checks screenshot is embedded in BREEZE.rst. OK. The exec screenshot is embedded in BREEZE.rst. OK. The setup screenshot is embedded in BREEZE.rst. OK. The prod-image_pull screenshot is embedded in BREEZE.rst. OK. The ci-image_build screenshot is embedded in BREEZE.rst. OK. The release-management_verify-provider-packages screenshot is embedded in BREEZE.rst. OK. The ci screenshot is embedded in BREEZE.rst. OK. The prod-image_build screenshot is embedded in BREEZE.rst. OK. The k8s_build-k8s-image screenshot is embedded in BREEZE.rst. OK. The ci-image screenshot is embedded in BREEZE.rst. OK. The k8s screenshot is embedded in BREEZE.rst. OK. The release-management_prepare-airflow-package screenshot is embedded in BREEZE.rst. OK. The k8s_run-complete-tests screenshot is embedded in BREEZE.rst. OK. The ci_free-space screenshot is embedded in BREEZE.rst. OK. The release-management_prepare-provider-packages screenshot is embedded in BREEZE.rst. OK. The testing_tests screenshot is embedded in BREEZE.rst. OK. The k8s_upload-k8s-image screenshot is embedded in BREEZE.rst. OK. The ci-image_pull screenshot is embedded in BREEZE.rst. OK. The setup_self-upgrade screenshot is embedded in BREEZE.rst. OK. The release-management_release-prod-images screenshot is embedded in BREEZE.rst. OK. The ci_resource-check screenshot is embedded in BREEZE.rst. OK. The compile-www-assets screenshot is embedded in BREEZE.rst. OK. The ci_get-workflow-info screenshot is embedded in BREEZE.rst. OK. The prod-image screenshot is embedded in BREEZE.rst. OK. The k8s_configure-cluster screenshot is embedded in BREEZE.rst. OK. The k8s_tests screenshot is embedded in BREEZE.rst. OK. The ci_selective-check screenshot is embedded in BREEZE.rst. OK. The k8s_deploy-airflow screenshot is embedded in BREEZE.rst. OK. The k8s_setup-env screenshot is embedded in BREEZE.rst. OK. The stop screenshot is embedded in BREEZE.rst. OK. The shell screenshot is embedded in BREEZE.rst. OK. The ci-image_verify screenshot is embedded in BREEZE.rst. OK. The testing screenshot is embedded in BREEZE.rst. OK. The release-management screenshot is embedded in BREEZE.rst. OK. The k8s_logs screenshot is embedded in BREEZE.rst. OK. The ci_fix-ownership screenshot is embedded in BREEZE.rst. OK. The ci_find-newer-dependencies screenshot is embedded in BREEZE.rst. OK. The k8s_shell screenshot is embedded in BREEZE.rst. OK. The k8s_status screenshot is embedded in BREEZE.rst. OK. The release-management_prepare-provider-documentation screenshot is embedded in BREEZE.rst. OK. The prod-image_verify screenshot is embedded in BREEZE.rst. OK. The k8s_k9s screenshot is embedded in BREEZE.rst. OK. The setup_config screenshot is embedded in BREEZE.rst. OK. The k8s_delete-cluster screenshot is embedded in BREEZE.rst. OK. The testing_docker-compose-tests screenshot is embedded in BREEZE.rst. OK. The setup_regenerate-command-images screenshot is embedded in BREEZE.rst. OK. The k8s_create-cluster screenshot is embedded in BREEZE.rst. OK. The start-airflow screenshot is embedded in BREEZE.rst. OK. The cleanup screenshot is embedded in BREEZE.rst. OK. The build-docs screenshot is embedded in BREEZE.rst. OK. The setup_version screenshot is embedded in BREEZE.rst. OK. The testing_integration-tests screenshot is embedded in BREEZE.rst. Traceback (most recent call last): File "/Users/ephraimbuddy/Documents/astronomer/airflow/dev/breeze/src/airflow_breeze/breeze.py", line 49, in main() File "/Users/ephraimbuddy/.cache/pre-commit/repofp_wavck/py_env-python3/lib/python3.10/site-packages/click/core.py", line 1130, in __call__ return self.main(*args, **kwargs) File "/Users/ephraimbuddy/.cache/pre-commit/repofp_wavck/py_env-python3/lib/python3.10/site-packages/rich_click/rich_group.py", line 21, in main rv = super().main(*args, standalone_mode=False, **kwargs) File "/Users/ephraimbuddy/.cache/pre-commit/repofp_wavck/py_env-python3/lib/python3.10/site-packages/click/core.py", line 1055, in main
[GitHub] [airflow] ephraimbuddy commented on pull request #27829: Improving the release process
ephraimbuddy commented on PR #27829: URL: https://github.com/apache/airflow/pull/27829#issuecomment-1345934132 > cc: @ephraimbuddy Thanks. Have updated it. It seems like `inputimeout` is not installed in the image because it errors out during pre-commit run: ``` File "/Users/ephraimbuddy/Documents/astronomer/airflow/dev/breeze/src/airflow_breeze/commands/main_command.py", line 159, in check_for_rosetta_environment from inputimeout import TimeoutOccurred, inputimeout ModuleNotFoundError: No module named 'inputimeout' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #27829: Improving the release process
ephraimbuddy commented on PR #27829: URL: https://github.com/apache/airflow/pull/27829#issuecomment-1338728668 > I think you need to rebase @ephraimbuddy :) Seems there's something I did wrong because the build info has always failed recently after each rebase. Any ideas? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #27829: Improving the release process
ephraimbuddy commented on PR #27829: URL: https://github.com/apache/airflow/pull/27829#issuecomment-1327111335 I added a new function `user_confirm_bools` that returns a bool using `user_confirm` under the hood. This helped me reduce a lot of `if else` statements. Also added `console_print` that uses `get_console().print` to print messages to the screen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #27829: Improving the release process
ephraimbuddy commented on PR #27829: URL: https://github.com/apache/airflow/pull/27829#issuecomment-1323934130 Nice. Thanks once more! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #27829: Improving the release process
ephraimbuddy commented on PR #27829: URL: https://github.com/apache/airflow/pull/27829#issuecomment-1323886749 @potiuk, Concerning running this on the CI with `dry_option` and `--answer yes`, I think we should not. It looks risky and doesn't seem to give us information on whether the command is still ok. Like it just lists the commands that it should run without running them. I don't think it's useful considering that if there's any mistake on the `dry_option` or CI, we risk running the commands for real. The risk seems to outweigh the testing on CI The thought of a mistake makes me want to exclude it from what we should test on the CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #27829: Improving the release process
ephraimbuddy commented on PR #27829: URL: https://github.com/apache/airflow/pull/27829#issuecomment-1323635269 > @ephraimbuddy - the "prepare-provider-documenation" step is added here #27832 - let's see if it works fine. `ANSWER="yes"` is passed from the job environments (see the top of the file) so it should simulate the user answering "yes" to all questions. > > I think it will not work, I will have to add some other "bypass" there - becasue there is a question about the type of change as well, but I will add it when I see it (not)working. Something similar you will have to do in your PR, likely for some of the operations. i think it is entirely worthy of the effort - this way you do not have to worry during release if the tool still works or not. In my case, I wouldn't want to run some commands if the environment is CI, so I'm looking at sorting the commands that would run if `--answer yes` is passed. Or just check if we are on CI and use dry run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
