houqp opened a new pull request #9042:
URL: https://github.com/apache/airflow/pull/9042


   Without this detection code, breeze just fails with the following error:
   
   ```
   
===============================================================================================
                Checking backend: mysql
   
===============================================================================================
   
   Checking if MySQL is ready for connections (double restarts in the logs)
   
   ............................................................
   ERROR! Maximum number of retries while waiting for MySQL. Exiting
   
   Last check: 0 connection ready messages (expected >=2)
   ```
   
   With the change, it will fail with a more actionable error:
   
   ```
   Starting docker-compose_mysql_1 ... done
   Client: Docker Engine - Community
    Version:           19.03.9
    API version:       1.40
    Go version:        go1.13.10
    Git commit:        9d988398e7
    Built:             Fri May 15 00:24:16 2020
    OS/Arch:           linux/amd64
    Experimental:      false
   Error response from daemon: client version 1.40 is too new. Maximum 
supported API version is 1.39
   ```
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Target Github ISSUE in description if exists
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to