[GitHub] [airflow] hussein-awala commented on pull request #29498: add missing read for K8S config file from conn in deferred `KubernetesPodOperator`
hussein-awala commented on PR #29498: URL: https://github.com/apache/airflow/pull/29498#issuecomment-1437703231 > Hi! May i ask in which format you will pass the config file to trigger? So it will be just a file passed as a parameter to trigger? Or how? @VladaZakharova - Yes, I pass the file path and let the triggerer loads it. Can you check my last commit? BTW, I am not sure if loading the config file from the env var `KUBECONFIG` is a good idea or not, because it's difficult to decide when we need to load it and when we don't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] hussein-awala commented on pull request #29498: add missing read for K8S config file from conn in deferred `KubernetesPodOperator`
hussein-awala commented on PR #29498: URL: https://github.com/apache/airflow/pull/29498#issuecomment-1436659985 > I guess you will be still changing the config access pattern on that one ? Do I understand correctly? Yes, I'm testing loading the config file in the triggerer instead of loading it in the worker and pass it as a dict. I convert the PR to draft until I finish testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
