[GitHub] [airflow] jedcunningham commented on pull request #17428: Fix elasticsearch-secret template port default function
jedcunningham commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-898724877 @Sonins, congrats on your first commit! Thanks for the fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17428: Fix elasticsearch-secret template port default function
jedcunningham commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-897026685 @Sonins, looks like there is a static check failure in `chart/tests/test_elasticsearch_secret.py`. I'd suggest that you [set up the pre-commit hooks](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks), they help catch these issues early . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17428: Fix elasticsearch-secret template port default function
jedcunningham commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-896858088 (I closed/reopened to try and get CI to run) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17428: Fix elasticsearch-secret template port default function
jedcunningham commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-896230424 > Cool. I think new issue for that will be necessary later. Yep, we can do this as a follow up . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17428: Fix elasticsearch-secret template port default function
jedcunningham commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-895341826 > And also, Should default port be 80? As far as i know, Elasticsearch uses port 9200 as default. Yeah, we should change it to 9200. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17428: Fix elasticsearch-secret template port default function
jedcunningham commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-894562815 Hey @Sonins, what I meant was we need to write new tests to cover this change (well, and the whole elasticsearch secret). The tests in `test_metadata_connection_secret.py` are very similar so they are a good example of how it is done. If you get stuck, I (and I'm sure others) wouldn't mind helping get you moving again, just post in the #airflow-how-to-pr channel on slack. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
