[GitHub] [airflow] josh-fell commented on a diff in pull request #29816: Move ref anchor for env var link in Connection how-to doc

2023-02-28 Thread via GitHub


josh-fell commented on code in PR #29816:
URL: https://github.com/apache/airflow/pull/29816#discussion_r1120779955


##
docs/apache-airflow-providers-dbt-cloud/connections.rst:
##
@@ -102,5 +102,5 @@ For example, to add a connection with the connection ID of 
"dbt_cloud_default":
 export 
AIRFLOW_CONN_DBT_CLOUD_DEFAULT='dbt-cloud://:api_to...@my-tenant.getdbt.com'
 
 You can refer to the documentation on
-:ref:`creating connections via environment variables 
` for more
+:ref:`creating connections via environment variables 
` for more

Review Comment:
   The same reference anchor was used in the dbt Cloud connection docs too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [airflow] josh-fell commented on a diff in pull request #29816: Move ref anchor for env var link in Connection how-to doc

2023-02-28 Thread via GitHub


josh-fell commented on code in PR #29816:
URL: https://github.com/apache/airflow/pull/29816#discussion_r1120710255


##
docs/apache-airflow/howto/connection.rst:
##
@@ -31,6 +31,8 @@ Connections may be defined in the following ways:
   - in the :ref:`Airflow metadata database `
 (using the :ref:`CLI ` or :ref:`web UI 
`)
 
+.. _environment_variables_secrets_backend:

Review Comment:
   Oh, rename it? That's a better name for sure.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org