[GitHub] [airflow] kaxil commented on a change in pull request #12704: Refactor list rendering in commands
kaxil commented on a change in pull request #12704: URL: https://github.com/apache/airflow/pull/12704#discussion_r533746027 ## File path: UPDATING.md ## @@ -52,6 +52,41 @@ assists users migrating to a new version. ## Master +### Changes to output argument in commands + +Instead of using [tabulate](https://pypi.org/project/tabulate/) to render commands output +we use [rich](https://github.com/willmcgugan/rich). Due to this change the `--output` argument +will no longer accept formats of tabulate tables. Instead it accepts: Review comment: ```suggestion From Airflow 2.0, We are replacing [tabulate](https://pypi.org/project/tabulate/) with [rich](https://github.com/willmcgugan/rich) to render commands output. Due to this change, the `--output` argument will no longer accept formats of tabulate tables. Instead, it now accepts: ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #12704: Refactor list rendering in commands
kaxil commented on a change in pull request #12704: URL: https://github.com/apache/airflow/pull/12704#discussion_r533748403 ## File path: tests/cli/commands/test_task_command.py ## @@ -55,6 +55,7 @@ def reset(dag_id): runs.delete() +# TODO: Check if tests needs side effects - locally there's missing DAG Review comment: Can this be removed, looks like tests are passing ## File path: tests/cli/commands/test_dag_command.py ## @@ -47,6 +47,7 @@ ) +# TODO: Check if tests needs side effects - locally there's missing DAG Review comment: Can this be removed, looks like tests are passing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #12704: Refactor list rendering in commands
kaxil commented on a change in pull request #12704: URL: https://github.com/apache/airflow/pull/12704#discussion_r533795846 ## File path: tests/cli/commands/test_task_command.py ## @@ -55,6 +55,7 @@ def reset(dag_id): runs.delete() +# TODO: Check if tests needs side effects - locally there's missing DAG Review comment: I can test that and fix it if that is the case in a separate PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #12704: Refactor list rendering in commands
kaxil commented on a change in pull request #12704: URL: https://github.com/apache/airflow/pull/12704#discussion_r533827933 ## File path: tests/cli/commands/test_task_command.py ## @@ -55,6 +55,7 @@ def reset(dag_id): runs.delete() +# TODO: Check if tests needs side effects - locally there's missing DAG Review comment: Weird: ``` ❯ ./breeze --python 3.6 --backend postgres --db-reset root@34129b165f1a:/opt/airflow# pytest tests/cli/commands/test_task_command.py::TestCliTasks test session starts = platform linux -- Python 3.6.12, pytest-6.1.2, py-1.9.0, pluggy-0.13.1 -- /usr/local/bin/python cachedir: .pytest_cache rootdir: /opt/airflow, configfile: pytest.ini plugins: forked-1.3.0, timeouts-1.2.1, cov-2.10.1, celery-4.4.7, flaky-3.7.0, xdist-2.1.0, instafail-0.4.2, requests-mock-1.8.0, rerunfailures-9.1.1 setup timeout: 0.0s, execution timeout: 0.0s, teardown timeout: 0.0s collected 17 items tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_list_tasks PASSED [ 5%] tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run PASSED [ 11%] tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run_invalid_raw_option_0__ignore_all_dependencies PASSED [ 17%] tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run_invalid_raw_option_1__ignore_depends_on_past PASSED [ 23%] tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run_invalid_raw_option_2__ignore_dependencies PASSED [ 29%] tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run_invalid_raw_option_3__force PASSED [ 35%] tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_run_mutually_exclusive PASSED [ 41%] tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_test PASSED [ 47%] tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_test_with_env_vars PASSED [ 52%] tests/cli/commands/test_task_command.py::TestCliTasks::test_cli_test_with_params PASSED [ 58%] tests/cli/commands/test_task_command.py::TestCliTasks::test_local_run SKIPPED [ 64%] tests/cli/commands/test_task_command.py::TestCliTasks::test_parentdag_downstream_clear PASSED [ 70%] tests/cli/commands/test_task_command.py::TestCliTasks::test_run_naive_taskinstance PASSED [ 76%] tests/cli/commands/test_task_command.py::TestCliTasks::test_subdag_clear PASSED [ 82%] tests/cli/commands/test_task_command.py::TestCliTasks::test_task_state PASSED
[GitHub] [airflow] kaxil commented on a change in pull request #12704: Refactor list rendering in commands
kaxil commented on a change in pull request #12704:
URL: https://github.com/apache/airflow/pull/12704#discussion_r533827933
##
File path: tests/cli/commands/test_task_command.py
##
@@ -55,6 +55,7 @@ def reset(dag_id):
runs.delete()
+# TODO: Check if tests needs side effects - locally there's missing DAG
Review comment:
Weird:
```
❯ ./breeze --python 3.6 --backend postgres --db-reset
===
Checking integrations and backends
===
PostgreSQL: OK.
---
---
Resetting the DB
DB: postgresql+psycopg2://postgres:***@postgres/airflow
[2020-12-02 01:05:00,245] {db.py:619} INFO - Dropping tables that exist
[2020-12-02 01:05:00,553] {migration.py:155} INFO - Context impl
PostgresqlImpl.
[2020-12-02 01:05:00,554] {migration.py:162} INFO - Will assume
transactional DDL.
[2020-12-02 01:05:00,968] {db.py:609} INFO - Creating tables
INFO [alembic.runtime.migration] Context impl PostgresqlImpl.
INFO [alembic.runtime.migration] Will assume transactional DDL.
INFO [alembic.runtime.migration] Running upgrade -> e3a246e0dc1, current
schema
INFO [alembic.runtime.migration] Running upgrade e3a246e0dc1 ->
1507a7289a2f, create is_encrypted
INFO [alembic.runtime.migration] Running upgrade 1507a7289a2f ->
13eb55f81627, maintain history for compatibility with earlier migrations
INFO [alembic.runtime.migration] Running upgrade 13eb55f81627 ->
338e90f54d61, More logging into task_instance
INFO [alembic.runtime.migration] Running upgrade 338e90f54d61 ->
52d714495f0, job_id indices
INFO [alembic.runtime.migration] Running upgrade 52d714495f0 ->
502898887f84, Adding extra to Log
INFO [alembic.runtime.migration] Running upgrade 502898887f84 ->
1b38cef5b76e, add dagrun
INFO [alembic.runtime.migration] Running upgrade 1b38cef5b76e ->
2e541a1dcfed, task_duration
INFO [alembic.runtime.migration] Running upgrade 2e541a1dcfed ->
40e67319e3a9, dagrun_config
INFO [alembic.runtime.migration] Running upgrade 40e67319e3a9 ->
561833c1c74b, add password column to user
INFO [alembic.runtime.migration] Running upgrade 561833c1c74b ->
4446e08588, dagrun start end
INFO [alembic.runtime.migration] Running upgrade 4446e08588 ->
bbc73705a13e, Add notification_sent column to sla_miss
INFO [alembic.runtime.migration] Running upgrade bbc73705a13e ->
bba5a7cfc896, Add a column to track the encryption state of the 'Extra' field
in connection
INFO [alembic.runtime.migration] Running upgrade bba5a7cfc896 ->
1968acfc09e3, add is_encrypted column to variable table
INFO [alembic.runtime.migration] Running upgrade 1968acfc09e3 ->
2e82aab8ef20, rename user table
INFO [alembic.runtime.migration] Running upgrade 2e82aab8ef20 ->
211e584da130, add TI state index
INFO [alembic.runtime.migration] Running upgrade 211e584da130 ->
64de9cddf6c9, add task fails journal table
INFO [alembic.runtime.migration] Running upgrade 64de9cddf6c9 ->
f2ca10b85618, add dag_stats table
INFO [alembic.runtime.migration] Running upgrade f2ca10b85618 ->
4addfa1236f1, Add fractional seconds to mysql tables
INFO [alembic.runtime.migration] Running upgrade 4addfa1236f1 ->
8504051e801b, xcom dag task indices
INFO [alembic.runtime.migration] Running upgrade 8504051e801b ->
5e7d17757c7a, add pid field to TaskInstance
INFO [alembic.runtime.migration] Running upgrade 5e7d17757c7a ->
127d2bf2dfa7, Add dag_id/state index on dag_run table
INFO [alembic.runtime.migration] Running upgrade 127d2bf2dfa7 ->
cc1e65623dc7, add max tries column to task instance
INFO [alembic.runtime.migration] Running upgrade cc1e65623dc7 ->
bdaa763e6c56, Make xcom value column a large binary
INFO [alembic.runtime.migration] Running upgrade bdaa763e6c56 ->
947454bf1dff, add ti job_id index
INFO [alembic.runtime.migration] Running upgrade 947454bf1dff ->
d2ae31099d61, Increase text size for MySQL (not relevant for other DBs' text
types)
INFO [alembic.runtime.migration] Running upgrade d2ae31099d61 ->
0e2a74e0fc9f, Add time zone awareness
INFO [alembic.runtime.migration] Running upgrade d2ae31099d61 ->
33ae817a1ff4, kubernetes_resource_checkpointing
INFO [alembic.runtime.migration] Running upgrade 33ae817a1ff4 ->
27c6a30d7c24, kubernetes_resource_checkpointing
INFO [alembic.runtime.migration] Running upgrade 27c6a30d7c24 ->
86770d1215c0, add kubernetes scheduler uniqueness
INFO [alembic.runtime.migration] Running upgrade 86770d1215c0, 0e2a74e0fc9f
-> 05f30312d566, merge heads
INFO [alembic.runtime.migr
