[GitHub] [airflow] kaxil commented on a change in pull request #8299: Clarify docs for on delete_worker_pods_on_success
kaxil commented on a change in pull request #8299: Clarify docs for on delete_worker_pods_on_success URL: https://github.com/apache/airflow/pull/8299#discussion_r408429470 ## File path: airflow/config_templates/config.yml ## @@ -1754,7 +1754,9 @@ default: "True" - name: delete_worker_pods_on_success description: | -If True (default), worker pods will be deleted only on task success +If True (default), worker pods will be deleted only on task success. +Note that this feature overrides `delete_worker_pods`, so failed pods Review comment: ```suggestion Note that this feature overrides ``delete_worker_pods``, so failed pods ``` As it will be rendered in an RST This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #8299: Clarify docs for on delete_worker_pods_on_success
kaxil commented on a change in pull request #8299: Clarify docs for on delete_worker_pods_on_success URL: https://github.com/apache/airflow/pull/8299#discussion_r408429552 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -815,7 +815,9 @@ worker_container_image_pull_policy = IfNotPresent # If True, all worker pods will be deleted upon termination delete_worker_pods = True -# If True (default), worker pods will be deleted only on task success +# If True (default), worker pods will be deleted only on task success. +# Note that this feature overrides `delete_worker_pods`, so failed pods Review comment: ```suggestion # Note that this feature overrides ``delete_worker_pods``, so failed pods ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
