[GitHub] [airflow] kaxil commented on pull request #8992: [AIRFLOW-5391] Do not re-run skipped tasks when they are cleared (#7276)

2020-06-23 Thread GitBox 


kaxil commented on pull request #8992:
URL: https://github.com/apache/airflow/pull/8992#issuecomment-648282668


   Doc tests are failing 🤔 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #8992: [AIRFLOW-5391] Do not re-run skipped tasks when they are cleared (#7276)

2020-06-26 Thread GitBox 


kaxil commented on pull request #8992:
URL: https://github.com/apache/airflow/pull/8992#issuecomment-650443760


   @yuqian90 tests are failing, can you take a look please



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #8992: [AIRFLOW-5391] Do not re-run skipped tasks when they are cleared (#7276)

2020-06-27 Thread GitBox 


kaxil commented on pull request #8992:
URL: https://github.com/apache/airflow/pull/8992#issuecomment-650620677


   > > @yuqian90 tests are failing, can you take a look please
   > 
   > Hi @kaxil thank you. I looked into it. I think 
`tests/operators/test_latest_only_operator.py:test_run` is the only one related 
to my change.
   > 
   > The reason `test_latest_only_operator.py:test_run` fails in this PR but 
not in master is that master has another commit #5970. So I cherry-picked #5970 
into my PR as well. `test_latest_only_operator.py:test_run` should now pass.
   > 
   > ```
   > XCom.set(
   > key=XCOM_SKIPMIXIN_KEY,
   > value={XCOM_SKIPMIXIN_SKIPPED: [d.task_id for d in tasks]},
   > task_id=task_id,
   > >   dag_id=dag_run.dag_id,
   > execution_date=dag_run.execution_date,
   > session=session
   > )
   > E   AttributeError: 'NoneType' object has no attribute 'dag_id'
   > ```
   
   Thanks. Currently, the CI is failing on v1-10-test too because of k8s tests. 
Will take a look tomorrow and re-runs the tests



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #8992: [AIRFLOW-5391] Do not re-run skipped tasks when they are cleared (#7276)

2020-07-02 Thread GitBox 


kaxil commented on pull request #8992:
URL: https://github.com/apache/airflow/pull/8992#issuecomment-653022789


   Hi @yuqian90, apologies this won't make it to 1.10.11 as the 
LatestOnlyOperator causes a change in behaviour. Is it possible for you to 
achieve this without changing the behaviour (talking about the note in 
Updating.md) or adding a flag to have old behavior vs new behaviour (default 
would be old behaviour).
   
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #8992: [AIRFLOW-5391] Do not re-run skipped tasks when they are cleared (#7276)

2020-07-22 Thread GitBox 


kaxil commented on pull request #8992:
URL: https://github.com/apache/airflow/pull/8992#issuecomment-662427191


   Thanks @yuqian90 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org