[GitHub] [airflow] loulsb commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789
loulsb commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1407462128 * Wait until we approve the tests (as you are first time contributor) and somoene reviews it/merges it. I am sorry I wasn't clear. I meant what should I do about the test that failed last time it ran. I thank you for your guidance. I asked because your comment earlier (the SSM test errors will likely go away after rebase) helped me understand why I had a failing test before and I don't know how to run a test manually (now I understand that I can't because I am a first time contributor). Thanks again for your help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] loulsb commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789
loulsb commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1407445003 @potiuk what should I do next? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] loulsb commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789
loulsb commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1404166547 I finally figured out the type error and fixed it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] loulsb commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789
loulsb commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1404081234 I needed to change the method _format_action to _rich_format_action to work with rich_argparse. Now I get an output format similar to before  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [airflow] loulsb commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789
loulsb commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1402667103 I don't know if there is a specific tool that you use for performance testing, I ran "time airflow cheat-sheet" a bunch of times without the change and with the change and I got this: Without the change: real0m0.381s user0m0.351s sys 0m0.030s real0m0.367s user0m0.307s sys 0m0.060s real0m0.373s user0m0.312s sys 0m0.061s real0m0.369s user0m0.329s sys 0m0.040s real0m0.375s user0m0.355s sys 0m0.020s real0m0.372s user0m0.342s sys 0m0.030s real0m0.373s user0m0.363s sys 0m0.010s real0m0.372s user0m0.372s sys 0m0.000s With the change: real0m0.391s user0m0.370s sys 0m0.020s real0m0.391s user0m0.341s sys 0m0.050s real0m0.391s user0m0.351s sys 0m0.040s real0m0.392s user0m0.362s sys 0m0.030s real0m0.389s user0m0.369s sys 0m0.020s real0m0.394s user0m0.383s sys 0m0.010s real0m0.399s user0m0.379s sys 0m0.020s real0m0.392s user0m0.352s sys 0m0.041s -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
