[GitHub] [airflow] mik-laj commented on a change in pull request #6105: [AIRFLOW-5495] Remove unneeded parens in dataproc.py
mik-laj commented on a change in pull request #6105: [AIRFLOW-5495] Remove unneeded parens in dataproc.py URL: https://github.com/apache/airflow/pull/6105#discussion_r324481153 ## File path: airflow/gcp/operators/dataproc.py ## @@ -407,7 +407,7 @@ def _build_cluster_data(self): cluster_data['config']['softwareConfig']['imageVersion'] = self.image_version elif self.custom_image: -project_id = self.custom_image_project_id if (self.custom_image_project_id) else self.project_id +project_id = self.custom_image_project_id if self.custom_image_project_id else self.project_id Review comment: Hello from Warsaw, Poland. I wish you lots of fun. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #6105: [AIRFLOW-5495] Remove unneeded parens in dataproc.py
mik-laj commented on a change in pull request #6105: [AIRFLOW-5495] Remove unneeded parens in dataproc.py URL: https://github.com/apache/airflow/pull/6105#discussion_r324480808 ## File path: airflow/gcp/operators/dataproc.py ## @@ -407,7 +407,7 @@ def _build_cluster_data(self): cluster_data['config']['softwareConfig']['imageVersion'] = self.image_version elif self.custom_image: -project_id = self.custom_image_project_id if (self.custom_image_project_id) else self.project_id +project_id = self.custom_image_project_id if self.custom_image_project_id else self.project_id Review comment: ```suggestion project_id = self.custom_image_project_id or self.project_id ``` This is the equivalent code, but simpler. WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
