[GitHub] [airflow] mik-laj commented on a change in pull request #6912: [AIRFLOW-6352] security - ui - add login timeout

2019-12-30 Thread GitBox
mik-laj commented on a change in pull request #6912: [AIRFLOW-6352] security - 
ui - add login timeout
URL: https://github.com/apache/airflow/pull/6912#discussion_r362112340
 
 

 ##
 File path: airflow/config_templates/default_airflow.cfg
 ##
 @@ -370,10 +370,13 @@ default_wrap = False
 # on webserver startup
 update_fab_perms = True
 
+# Minutes of non-activity before logged out from UI
+# 0 means never get forcibly logged out
 
 Review comment:
   Related discussion: 
https://github.com/apache/airflow/pull/6952#discussion_r362102402
   
   I think, we can add short description in 'security.rst' file or a new file 
in `howto` directory. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [airflow] mik-laj commented on a change in pull request #6912: [AIRFLOW-6352] security - ui - add login timeout

2019-12-30 Thread GitBox
mik-laj commented on a change in pull request #6912: [AIRFLOW-6352] security - 
ui - add login timeout
URL: https://github.com/apache/airflow/pull/6912#discussion_r362102039
 
 

 ##
 File path: airflow/config_templates/default_airflow.cfg
 ##
 @@ -370,10 +370,13 @@ default_wrap = False
 # on webserver startup
 update_fab_perms = True
 
+# Minutes of non-activity before logged out from UI
+# 0 means never get forcibly logged out
 
 Review comment:
   Can you add some documentation about this option?   If there is no 
information about this feature in the documentation, very few people will be 
able to use it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services