[GitHub] [airflow] mik-laj commented on a change in pull request #6923: [AIRFLOW-5149] - skip SLA checks config
mik-laj commented on a change in pull request #6923: [AIRFLOW-5149] - skip SLA checks config URL: https://github.com/apache/airflow/pull/6923#discussion_r362115161 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -176,6 +176,9 @@ store_serialized_dags = False # Updating serialized DAG can not be faster than a minimum interval to reduce database write rate. min_serialized_dag_update_interval = 30 +# On each dagrun check against defined SLAs Review comment: @kaxil Fantastic! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #6923: [AIRFLOW-5149] - skip SLA checks config
mik-laj commented on a change in pull request #6923: [AIRFLOW-5149] - skip SLA checks config URL: https://github.com/apache/airflow/pull/6923#discussion_r362110552 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -176,6 +176,9 @@ store_serialized_dags = False # Updating serialized DAG can not be faster than a minimum interval to reduce database write rate. min_serialized_dag_update_interval = 30 +# On each dagrun check against defined SLAs Review comment: > and where all the previous options are documented? We have documentation gaps, but we try to develop documentation all the time. There is no precise documentation for the SLA mechanism, but this does not mean that it is impossible to write a few sentences and put them in the documentation. Another person who wants to describe the wider documentation will have less work. I think that these two sentences describing this parameter may be placed in a new document in the howto directory. I will give an example of documentation that describes the configuration parameter. https://github.com/apache/airflow/pull/5850/files This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #6923: [AIRFLOW-5149] - skip SLA checks config
mik-laj commented on a change in pull request #6923: [AIRFLOW-5149] - skip SLA checks config URL: https://github.com/apache/airflow/pull/6923#discussion_r362110552 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -176,6 +176,9 @@ store_serialized_dags = False # Updating serialized DAG can not be faster than a minimum interval to reduce database write rate. min_serialized_dag_update_interval = 30 +# On each dagrun check against defined SLAs Review comment: > and where all the previous options are documented? We have documentation gaps, but we try to develop documentation all the time. There is no precise documentation for the SLA mechanism, but this does not mean that it is impossible to write a few sentences and put them in the documentation. Another person who wants to describe the wider documentation will have less work. I think that these two sentences describing this parameter may be placed in a new document in the howto directory. I will give an example of documentation that describes the configuration parameter. https://github.com/apache/airflow/pull/5850/files This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #6923: [AIRFLOW-5149] - skip SLA checks config
mik-laj commented on a change in pull request #6923: [AIRFLOW-5149] - skip SLA checks config URL: https://github.com/apache/airflow/pull/6923#discussion_r362102159 ## File path: airflow/config_templates/default_airflow.cfg ## @@ -176,6 +176,9 @@ store_serialized_dags = False # Updating serialized DAG can not be faster than a minimum interval to reduce database write rate. min_serialized_dag_update_interval = 30 +# On each dagrun check against defined SLAs Review comment: Can you add some documentation about this option? If there is no information about this feature in the documentation, very few people will be able to use it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
